1. 23 Nov, 2007 3 commits
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B32400-5.0-opt · 7596cbfd
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B32400-5.1-opt
      
      
      BitKeeper/deleted/.del-ps_6bdb.result:
        Auto merged
      mysql-test/r/ps_2myisam.result:
        Auto merged
      mysql-test/r/ps_3innodb.result:
        Auto merged
      mysql-test/r/ps_4heap.result:
        Auto merged
      mysql-test/r/ps_5merge.result:
        Auto merged
      mysql-test/suite/ndb/r/ps_7ndb.result:
        Auto merged
      sql/item.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/t/subselect.test:
        merge of bug 32400 to 5.1-opt
      7596cbfd
    • unknown's avatar
      merge 5.0-opt -> 5.1-opt · abad0dee
      unknown authored
      abad0dee
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/mysql-5.0-opt · 11a0d0d4
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/merge-5.1-opt
      
      
      mysql-test/r/gis.result:
        Auto merged
      mysql-test/r/type_bit.result:
        Auto merged
      mysql-test/r/type_blob.result:
        Auto merged
      mysql-test/t/gis.test:
        Auto merged
      mysql-test/t/type_bit.test:
        Auto merged
      mysql-test/t/type_blob.test:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_string.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/subselect.result:
        null merge. resolve latete.
      mysql-test/t/subselect.test:
        merge 5.0-opt -> 5.1-opt
      sql/key.cc:
        merge 5.0-opt -> 5.1-opt
      sql/sql_class.h:
        merge 5.0-opt -> 5.1-opt
      sql/sql_insert.cc:
        merge 5.0-opt -> 5.1-opt
      sql/sql_table.cc:
        merge 5.0-opt -> 5.1-opt
      11a0d0d4
  2. 22 Nov, 2007 12 commits
  3. 21 Nov, 2007 6 commits
    • unknown's avatar
      Fixed bug #32556: assert in "using index for group-by" : · d408a401
      unknown authored
                        is_last_prefix <= 0, file .\opt_range.cc.
      
      SELECT ... GROUP BY bit field failed with an assertion if the
      bit length of that field was not divisible by 8.
      
      
      
      sql/key.cc:
        Fixed bug #32556.
        Copying of "uneven" bits of a bit field was duplicated in the
        key_copy() and in the Field_bit::get_key_image().
        So, instead of copying of the rest of a bit field, 
        Field_bit::get_key_image() copied "uneven" bits to key image again,
        and the lowest field byte was not copied to key at all.
        
        Duplicated code has been removed from the key_copy function.
      mysql-test/t/type_bit.test:
        Added test case for bug #32556.
      mysql-test/r/type_bit.result:
        Added test case for bug #32556.
      d408a401
    • unknown's avatar
      Bug #31171: test alter_table, fulltext2, ps, sp fail, · a58cafa5
      unknown authored
       "Table is already up to date" vs. "OK"
      
      On MacOSX 10.5 when you cast something to "bool"
      (the built in C type) it takes values 0 or 1 
      instead of 0-255 as it seems to be on older compilers.
      Fixed by removing the typecast (not needed).
      No test case needed : there are tests that test it.
      
      
      storage/myisam/mi_open.c:
        Bug #31171: don't typecast when not needed
      a58cafa5
    • unknown's avatar
      merge of bug 30788 to 5.1-opt · 1d3df515
      unknown authored
      1d3df515
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B30788-5.0-opt · 0fdbcc32
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B30788-5.1-opt
      
      
      mysql-test/r/subselect3.result:
        Auto merged
      sql/item.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        merge of bug 30788 to 5.1-opt
      mysql-test/t/subselect.test:
        merge of bug 30788 to 5.1-opt
      0fdbcc32
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 3fdc12ca
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B30788-5.0-opt
      
      
      sql/item.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        merge of 5.0-opt
      mysql-test/t/subselect.test:
        merge of 5.0-opt
      3fdc12ca
    • unknown's avatar
      Bug #30788: Inconsistent retrieval of char/varchar · f3637af4
      unknown authored
      Index lookup does not always guarantee that we can
      simply remove the relevant conditions from the WHERE
      clause. Reasons can be e.g. conversion errors, 
      partial indexes etc. 
      The optimizer was removing these parts of the WHERE 
      condition without any further checking.
      This leads to "false positives" when using indexes.
      Fixed by checking the index reference conditions
      (using WHERE) when using indexes with sub-queries.
      
      
      mysql-test/r/subselect.result:
        Bug #30788: 
         - using where
         - test case
      mysql-test/r/subselect3.result:
        Bug #30788: using where
      mysql-test/t/subselect.test:
        Bug #30788: test case
      sql/item.h:
        Bug #30788: 
         - Declare eq() method of Item_cache descendants : this is used in
         test_if_ref()
         - preserve the field that is being cached for type comparisions
      sql/sql_select.cc:
        Bug #30788: Don't remove the WHERE when using index lookup 
        with subqueries.
      f3637af4
  4. 20 Nov, 2007 15 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · f339b1d3
      unknown authored
      into  moonbone.local:/work/31048-bug-5.0-opt-mysql
      
      f339b1d3
    • unknown's avatar
      sql_select.cc: · 9ec0b739
      unknown authored
        Additional stack check for the bug#31048.
      
      
      sql/sql_select.cc:
        Additional stack check for the bug#31048.
      9ec0b739
    • unknown's avatar
      Bug #32400: Complex SELECT query returns correct result · 5a49b5f0
      unknown authored
       only on some occasions
      
      Referencing an element from the SELECT list in a WHERE 
      clause is not permitted. The namespace of the WHERE
      clause is the table columns only. This was not enforced
      correctly when resolving outer references in sub-queries.
      
      Fixed by not allowing references to aliases in a 
      sub-query in WHERE.
      
      
      mysql-test/include/ps_query.inc:
        Bug #32400: fixed old test queries
      mysql-test/r/ps_2myisam.result:
        Bug #32400: fixed old test queries
      mysql-test/r/ps_3innodb.result:
        Bug #32400: fixed old test queries
      mysql-test/r/ps_4heap.result:
        Bug #32400: fixed old test queries
      mysql-test/r/ps_5merge.result:
        Bug #32400: fixed old test queries
      mysql-test/r/ps_6bdb.result:
        Bug #32400: fixed old test queries
      mysql-test/r/ps_7ndb.result:
        Bug #32400: fixed old test queries
      mysql-test/r/subselect.result:
        Bug #32400: test case
      mysql-test/t/subselect.test:
        Bug #32400: test case
      sql/item.cc:
        Bug #32400: don't allow references to aliases in WHERE
      tests/mysql_client_test.c:
        Bug #32400: fixed old test queries
      5a49b5f0
    • unknown's avatar
      Merge gleb.loc:/work/bk/5.0-opt-32533 · 80077e9b
      unknown authored
      into  gleb.loc:/work/bk/5.0-opt
      
      80077e9b
    • unknown's avatar
      Fixed bug #32533. · 61e5a65b
      unknown authored
      8bit escape characters, termination and enclosed characters
      were silently ignored by SELECT INTO query, but LOAD DATA INFILE
      algorithm is 8bit-clean, so data was corrupted during 
      encoding.
      
      
      sql/sql_class.cc:
        Fixed bug #32533.
        SELECT INTO OUTFILE encoding was not 8bit clear, it
        has been fixed for a symmetry with the LOAD DATA INFILE
        decoding algorithm.
      mysql-test/t/outfile_loaddata.test:
        Added test case for bug #32533.
      mysql-test/r/outfile_loaddata.result:
        Added test case for bug #32533.
      61e5a65b
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · cf6ba9fc
      unknown authored
      into  mysql.com:/home/psergey/mysql-5.1-bug30573
      
      cf6ba9fc
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 44b4a799
      unknown authored
      into  mysql.com:/home/hf/work/mysql-5.0-opt
      
      44b4a799
    • unknown's avatar
      test case added for the bug #31155 · 2a525960
      unknown authored
      
      mysql-test/r/gis.result:
        test result complete
      mysql-test/t/gis.test:
        test case added for the bug
      2a525960
    • unknown's avatar
      merging · bbc5db3a
      unknown authored
      bbc5db3a
    • unknown's avatar
      Merge mysql.com:/home/hf/work/31868/my41-31868 · fa2185df
      unknown authored
      into  mysql.com:/home/hf/work/31868/my50-31868
      
      
      sql/sql_table.cc:
        merging
      fa2185df
    • unknown's avatar
      Merge mysql.com:/home/hf/work/32211/my51-32211 · 6b064134
      unknown authored
      into  mysql.com:/home/hf/work/31868/my51-31868
      
      6b064134
    • unknown's avatar
      Merge mysql.com:/home/hf/work/32063/my41-32063 · 3ad728e6
      unknown authored
      into  mysql.com:/home/hf/work/31868/my41-31868
      
      3ad728e6
    • unknown's avatar
      Merge mysql.com:/home/hf/work/31960/my51-31960 · 22cd8833
      unknown authored
      into  mysql.com:/home/hf/work/31868/my51-31868
      
      
      sql/sql_parse.cc:
        Auto merged
      sql/mysql_priv.h:
        merging
      22cd8833
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · 048d3ec0
      unknown authored
      into  mysql.com:/home/hf/work/31868/my51-31868
      
      
      BitKeeper/etc/ignore:
        auto-union
      libmysqld/lib_sql.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      048d3ec0
    • unknown's avatar
      BUG#30573: Ordered range scan over partitioned tables returns some rows twice · 861a18b9
      unknown authored
      The problem: ha_partition::read_range_first() could return a record that is 
      outside of the scanned range. If that record happened to be in the next 
      subsequent range, it would satisfy the WHERE and appear in the output twice.
      (we would get it the second time when scanning the next subsequent range)
      
      Fix: 
      Made ha_partition::read_range_first() check if the returned recod is within
      the scanned range, like other read_range_first() implementations do.
      
      
      mysql-test/r/partition_range.result:
        BUG#30573: Ordered range scan over partitioned tables returns some rows twice
         - Testcase
      mysql-test/t/partition_range.test:
        BUG#30573: Ordered range scan over partitioned tables returns some rows twice
         - Testcase
      sql/ha_partition.cc:
        BUG#30573: Ordered range scan over partitioned tables returns some rows twice
        - Make ha_partition::read_range_first() check if the returned record is 
          within the range.
      861a18b9
  5. 19 Nov, 2007 4 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e424e732
      unknown authored
      into  moonbone.local:/work/31048-bug-5.0-opt-mysql
      
      e424e732
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 0438da39
      unknown authored
      into  moonbone.local:/work/31048-bug-5.0-opt-mysql
      
      
      sql/item_subselect.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge
      mysql-test/t/subselect.test:
        Manual merge
      0438da39
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 4efdde4f
      unknown authored
      into  moonbone.local:/work/30384-bug-5.0-opt-mysql
      
      
      sql/sql_class.h:
        Auto merged
      4efdde4f
    • unknown's avatar
      Bug#30384: Having SQL_BUFFER_RESULT option in the CREATE .. KEY(..) .. SELECT · c3bbe760
      unknown authored
      led to creating corrupted index.
      
      Corrected fix. The new method called prepare2 is added to the select_create
      class. As all preparations are done by the select_create::prepare function
      it doesn't do anything. Slightly changed algorithm of calling the 
      start_bulk_insert function. Now it's called from the select_insert::prepare2
      function when the SQL_BUFFER_RESULT flags is set.
      The is_bulk_insert_mode flag is removed as it is not needed anymore.
      
      
      sql/sql_class.h:
        Bug#30384: Having SQL_BUFFER_RESULT option in the CREATE .. KEY(..) .. SELECT
        led to creating corrupted index.
        Corrected fix. The new method called prepare2 is added to the select_create
        class. As all preparetions are done by the select_create::prepare function
        it doesn't do anything.
        The is_bulk_insert_mode flag is removed as it is not needed anymore.
      sql/sql_insert.cc:
        Bug#30384: Having SQL_BUFFER_RESULT option in the CREATE .. KEY(..) .. SELECT
        led to creating corrupted index. Slightly changed algorithm of calling the
        start_bulk_insert function. Now it's called from the select_insert::prepare2
        function when the SQL_BUFFER_RESULT flags is set.
        Corrected fix. The is_bulk_insert_mode flag is removed as it is not needed
        anymore.
      c3bbe760