1. 12 Feb, 2008 4 commits
    • unknown's avatar
      Merge mbp:src/opt/bug33389/my51-bug25162 · 7634d74c
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      7634d74c
    • unknown's avatar
      Merge ssh://bk-internal.mysql.com//home/bk/mysql-5.1-opt · f16d93ad
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      f16d93ad
    • unknown's avatar
      Merge mbp.:/Users/kaa/src/opt/bug33389/my50-bug25162 · d4e1a377
      unknown authored
      into  mbp.:/Users/kaa/src/opt/bug33389/my51-bug25162
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Manual merge.
      sql/item.cc:
        Manual merge.
      d4e1a377
    • unknown's avatar
      Fix for bug #33389: Selecting from a view into a table from within SP · eee4d8cc
      unknown authored
                          or trigger crashes server
      
      Under some circumstances a combination of VIEWs, subselects with outer
      references and PS/SP/triggers could lead to use of uninitialized memory
      and server crash as a result.
      
      Fixed by changing the code in Item_field::fix_fields() so that in cases
      when the field is a VIEW reference, we first check whether the field
      is also an outer reference, and mark it appropriately before returning.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #33389.
      mysql-test/t/view.test:
        Added a test case for bug #33389.
      sql/item.cc:
        In cases when in Item_field::fix_fields() from_field is a view reference,
        do not return too early, i.e. before marking the reference as an outer
        one when needed.
      eee4d8cc
  2. 11 Feb, 2008 1 commit
  3. 10 Feb, 2008 7 commits
  4. 05 Feb, 2008 1 commit
  5. 01 Feb, 2008 3 commits
    • unknown's avatar
      Merge mbp.local:/Users/kaa/src/opt/bug25162/my51-bug25162 · 925ab750
      unknown authored
      into  mbp.local:/Users/kaa/src/opt/mysql-5.1-opt
      
      925ab750
    • unknown's avatar
      Merge mbp.local:/Users/kaa/src/opt/bug25162/my50-bug25162 · 3d87df86
      unknown authored
      into  mbp.local:/Users/kaa/src/opt/bug25162/my51-bug25162
      
      
      mysql-test/t/create.test:
        Auto merged
      sql/sql_yacc.yy:
        Null merge.
      mysql-test/r/create.result:
        Manual merge.
      3d87df86
    • unknown's avatar
      Fix for bug #25162: Backing up DB from 5.1 adds 'USING BTREE' to KEYs · 653ab4ee
      unknown authored
                          on table creates
      
      The problem was in incompatible syntax for key definition in CREATE
      TABLE.
      
      5.0 supports only the following syntax for key definition (see "CREATE
      TABLE syntax" in the manual):
      
      {INDEX|KEY} [index_name] [index_type] (index_col_name,...)
      
      While 5.1 parser supports the above syntax, the "preferred" syntax was
      changed to:
      
      {INDEX|KEY} [index_name] (index_col_name,...) [index_type]
      
      The above syntax is used in 5.1 for the SHOW CREATE TABLE output, which
      led to dumps generated by 5.1 being incompatible with 5.0.
      
      Fixed by changing the parser in 5.0 to support both 5.0 and 5.1 syntax
      for key definition.
      
      
      mysql-test/r/create.result:
        Added a test case for bug #25162.
      mysql-test/t/create.test:
        Added a test case for bug #25162.
      sql/sql_yacc.yy:
        Changed the parser to support both 5.0 and 5.1 syntax for index type
        specification in CREATE TABLE.
      653ab4ee
  6. 31 Jan, 2008 2 commits
  7. 30 Jan, 2008 1 commit
  8. 25 Jan, 2008 1 commit
    • unknown's avatar
      Bug #31524: One table one row select on NDB cause optimizer to · fd09742a
      unknown authored
        require SQL_BIG_SELECTS=1
      
      There was a previous test that leaves a non-default (small) max_join_size.
      Fixed by re-setting the max_join_size to default when the test is over.
      
      
      mysql-test/extra/rpl_tests/rpl_row_charset.test:
        Bug #31524: side effects of previous testsuites fixed
      mysql-test/suite/rpl/r/rpl_row_charset.result:
        Bug #31524: side effects of previous testsuites fixed
      mysql-test/suite/rpl/r/rpl_row_charset_innodb.result:
        Bug #31524: side effects of previous testsuites fixed
      mysql-test/suite/rpl_ndb/r/rpl_ndb_charset.result:
        Bug #31524: side effects of previous testsuites fixed
      fd09742a
  9. 24 Jan, 2008 1 commit
  10. 20 Jan, 2008 2 commits
  11. 19 Jan, 2008 3 commits
    • unknown's avatar
      Post-merge fixes. · 72f9fc48
      unknown authored
      
      mysql-test/r/group_by.result:
        Post-merge fix after merging 5.0-opt to 5.1-opt.
      mysql-test/t/disabled.def:
        Disabled innodb_mysql back, bug #32724 is still not fixed.
      72f9fc48
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 8243bdf1
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/type_decimal.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/type_decimal.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge.
      mysql-test/t/group_by.test:
        Manual merge.
      mysql-test/t/subselect.test:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      8243bdf1
    • unknown's avatar
      Raise version number after cloning 5.1.23-rc · c477db1b
      unknown authored
      c477db1b
  12. 18 Jan, 2008 2 commits
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 5a82c60b
      unknown authored
      into  lamia.dupka:/home/mhansson/my50-bug33143-again-pushee
      
      5a82c60b
    • unknown's avatar
      BUG#33794 "MySQL crashes executing specific query": · c726f011
      unknown authored
      The problem occurred when one had a subquery that had an equality X=Y where 
      Y referred to a named select list expression from the parent select. MySQL 
      crashed when trying to use the X=Y equality for ref-based access. 
      
      Fixed by allowing non-Item_field items in the described case.
      
      
      mysql-test/r/subselect.result:
        BUG#33794 "MySQL crashes executing specific query"
        - Testcase
      mysql-test/t/subselect.test:
        BUG#33794 "MySQL crashes executing specific query"
        - Testcase
      sql/sql_select.cc:
        BUG#33794 "MySQL crashes executing specific query"
        get_store_key() assumed that if it got a reference
          t.key=Item_outer_ref(Item_direct_ref(x)) 
        then x was an Item_field object, which is not the case when one refers to a
        named select list expression out ot subquery.
      c726f011
  13. 17 Jan, 2008 3 commits
  14. 14 Jan, 2008 1 commit
    • unknown's avatar
      Bug#33143: Incorrect ORDER BY for ROUND()/TRUNCATE() result · 01557dde
      unknown authored
      The ROUND(X, D) function would change the Item::decimals field during
      execution to achieve the effect of a dynamic number of decimal digits.
      This caused a series of bugs:
      Bug #30617:Round() function not working under some circumstances in InnoDB
      Bug #33402:ROUND with decimal and non-constant cannot round to 0 decimal places
      Bug #30889:filesort and order by with float/numeric crashes server
      Fixed by never changing the number of shown digits for DECIMAL when
      used with a nonconstant number of decimal digits.
      
      
      mysql-test/r/type_decimal.result:
        Bug#33143: Test result
      mysql-test/t/type_decimal.test:
        Bug#33143: Test case
      sql/item_func.cc:
        Bug#33143: 
        - Moved the DECIMAL_MAX_SCALE limitation to fix_length_and_dec.
        - Removed resetting of Item::decimals field.
        - set the frac field of the output value to current scale.
      strings/decimal.c:
        Bug#33143: It is necessary to set all digits in the buffer following the 
        rounded one to zero, as they may now be displayed.
      01557dde
  15. 12 Jan, 2008 1 commit
  16. 11 Jan, 2008 7 commits
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 4d2e8a69
      unknown authored
      into  lamia.dupka:/home/mhansson/my51-bug31797-pushee
      
      4d2e8a69
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.1-opt · c4e2b6f5
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug31797/my51-bug31797-pushee
      
      
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/t/group_by.test:
        Auto merged
      sql/item.cc:
        Auto merged
      c4e2b6f5
    • unknown's avatar
      Merge linux-st28.site:/home/martin/mysql/src/bug31797/my50-bug31797 · 12c7f4c5
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug31797/my51-bug31797
      
      
      sql/item.cc:
        Auto merged
      mysql-test/r/group_by.result:
        Bug#31797: Manual merge
      mysql-test/t/group_by.test:
        Bug#31797: Manual merge
      12c7f4c5
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.1-opt · f15bd806
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.1-opt-bug33697
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      f15bd806
    • unknown's avatar
      Fixed bug #33697. · 7a690444
      unknown authored
      When the function test_if_skip_sort_order prefers index backward scan 
      to ref access the corresponding access functions must be set accordingly.
      
      
      mysql-test/include/mix1.inc:
        Added a test case for bug #33697.
        Corrected one previous bad merge.
      mysql-test/r/innodb_mysql.result:
        Added a test case for bug #33697.
      mysql-test/t/disabled.def:
        Turned innodb_mysql test on.
      7a690444
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.0-opt · de17151f
      unknown authored
      into  linux-st28.site:/home/martin/mysql/src/bug31797/my50-bug31797-pushee
      
      
      sql/item.cc:
        Auto merged
      mysql-test/r/group_by.result:
        Bug#31797: Manual merge
      mysql-test/t/group_by.test:
        Bug#31797: Manual merge
      de17151f
    • unknown's avatar
      Bug#31797: error while parsing subqueries -- WHERE is parsed as HAVING · 2771cf8b
      unknown authored
      The name resolution for correlated subqueries and HAVING clauses
      failed to distinguish which of two was being performed when there 
      was a reference to an outer aliased field.
      Fixed by adding the condition that HAVING clause name resulotion
      is being performed.
      
      
      mysql-test/r/group_by.result:
        Bug#31797: Test result
      mysql-test/t/group_by.test:
        Bug#31797: Test case
      sql/item.cc:
        Bug#31797: 
        Corrected function comment.
        The fix, raising the error is restricted to HAVING name resolution.
      2771cf8b