1. 06 Oct, 2009 1 commit
    • Michael Widenius's avatar
      Don't call _ma_decrement_open_count() for ma_extra(HA_EXTRA_PREPARE_FOR_DROP). · 77750fd2
      Michael Widenius authored
      Don't call _mi_decrement_open_count() for mi_extra(HA_EXTRA_PREPARE_FOR_DROP).
      This ensures that if we empty the key cache and a drop table fails later, the index will be automaticly rebuilt
      
      storage/maria/ma_extra.c:
        Don't call _ma_decrement_open_count() for ma_extra(HA_EXTRA_PREPARE_FOR_DROP).
        This ensures that if we empty the key cache and a drop table fails later, the index will be automaticly rebuilt
      storage/maria/ma_locking.c:
        Simple optimization: Don't call maria_lock_database() if locking is disabled
      storage/myisam/mi_extra.c:
        Don't call _mi_decrement_open_count() for mi_extra(HA_EXTRA_PREPARE_FOR_DROP).
        Simplify code to remove if
      77750fd2
  2. 02 Oct, 2009 3 commits
    • Michael Widenius's avatar
      Fixed typo · df26a7a5
      Michael Widenius authored
      df26a7a5
    • Michael Widenius's avatar
      When using --help --verbose give error and abort if there are any unknown options · 1f7cc235
      Michael Widenius authored
      mysql-test/r/mysqld_option_err.result:
        Test that mysqld --not-known-option --help --verbose gives error
      mysql-test/t/mysqld_option_err.test:
        Test that mysqld --not-known-option --help --verbose gives error
      1f7cc235
    • Michael Widenius's avatar
      Added client functions: · d2b9b326
      Michael Widenius authored
      - mysql_get_server_name()
        This returns MySQL or MariaDB depending on the server type
      - mariadb_connection()
        This returns 1 if you are connected to a MariaDB server
      
      Modifed the MySQL command line client to print out if you are connected to MariaDB or MySQL
      Better default prompt (shows server you are connected to and base directory)
      
      client/mysql.cc:
        Print out if you are connected to MariaDB or MySQL
        Better default prompt (shows server you are connected to and base directory)
        Added option \N to prompt to print server name.
      configure.in:
        Changed maria to MariaDB in version string
      include/mysql.h:
        Added mysql_get_server_name() and mariadb_connection()
      include/mysql.h.pp:
        Update for new API functions
      libmysql/libmysql.c:
        Added client functions:
        - mysql_get_server_name()
          This returns MySQL or MariaDB depending on the server type
        - mariadb_connection()
          This returns 1 if you are connected to a MariaDB server
      d2b9b326
  3. 26 Sep, 2009 1 commit
  4. 25 Sep, 2009 4 commits
    • unknown's avatar
      Fix some test failures found during RPM package building: · e3bfc4d7
      unknown authored
       - mysqlslap result file update after merge.
       - Fix skipping certain tests when running test suite as root, got broken somehow.
      
      mysql-test/mysql-test-run.pl:
        Somehow skipping tests when running as root got broken. The mysqltest if() no longer seems
        to accept YES as a true value, so use 1 for true value instead.
      mysql-test/r/mysqlslap.result:
        Result file update after change in engine behaviour of mysqlslap.
      mysql-test/t/mysqld_option_err.test:
        This test does not work when run as root.
      e3bfc4d7
    • unknown's avatar
      Merge MySQL-5.1.38 and XtraDB-7 into MariaDB. · 9e7940ac
      unknown authored
      Merge Percona microsec_process patch.
      Includes lots of after-merge fixes, Windows fixes, and other misc. small fixes.
      9e7940ac
    • Igor Babaev's avatar
      Merge · 79298071
      Igor Babaev authored
      79298071
    • Igor Babaev's avatar
      Took care of mysql test suite failures on Windows. · fb817543
      Igor Babaev authored
      mysql-test/suite/rpl/t/rpl_binlog_corruption.test:
        Disabled the test for Windows (see bug #47639)
      mysql-test/suite/rpl/t/rpl_killed_ddl.test:
        Disabled the test for Windows (see bug #47638)
      vio/viosocket.c:
        Added an implementation of vio_poll_read for Windows.
        Winsock does not support the poll function.
        So the existing generic implementation of vio_poll_read
        could not be used for Windows.
      fb817543
  5. 24 Sep, 2009 2 commits
  6. 23 Sep, 2009 1 commit
    • unknown's avatar
      Merge Percona microsec_process patch into MariaDB. · 48807b1a
      unknown authored
      This adds a TIME_MS column to SHOW FULL PROCESSLIST and
      INFORMATION_SCHEMA.PROCESSLIST that works like the TIME column, but
      in units of milliseconds with microsecond precision.
      
      Note that this also changes behaviour of the existing TIME column. In
      the MySQL server, the TIME column changes when a thread sets @TIMESTAMP.
      This is contrary to documentation and also potentially confusing, so
      could in any case be considered a bug. With this patch, to ensure
      consistency between TIME and TIME_MS, setting @TIMESTAMP has no effect
      on either value.
      
      Add a test case for the TIME and TIME_MS columns.
      Update existing test cases for changed behaviour.
      
      Author: Percona
      Signed-off-by: default avatarKristian Nielsen <knielsen@knielsen-hq.org>
      
      
      mysql-test/r/create.result:
        Result file update.
      mysql-test/r/information_schema.result:
        Add test case.
        Result file update (changed behaviour).
      mysql-test/t/information_schema.test:
        Add test case.
        Adjust test case for changed behaviour.
      mysql-test/t/not_embedded_server.test:
        Update (commented-out) test case for newly added column.
      sql/sql_show.cc:
        Merge Percona microsec_process patch into MariaDB.
      48807b1a
  7. 20 Sep, 2009 1 commit
  8. 19 Sep, 2009 2 commits
  9. 18 Sep, 2009 8 commits
    • Hakan Kuecuekyilmaz's avatar
      Merge. · b3646de1
      Hakan Kuecuekyilmaz authored
      b3646de1
    • Igor Babaev's avatar
      Made innodb_xtradb_bug317074.test to be a 'big' test · 702f1484
      Igor Babaev authored
      to avoid a timeout failure of it on Windows. 
      702f1484
    • Igor Babaev's avatar
      Applied the fix for bug #46931 from mysql-5.1 main trunk · b35d8650
      Igor Babaev authored
      to fix a failure in rpl_get_master_version_and_clock.test
      b35d8650
    • Hakan Kuecuekyilmaz's avatar
      Merge. · 2ff94b40
      Hakan Kuecuekyilmaz authored
      2ff94b40
    • Hakan Kuecuekyilmaz's avatar
      Fix for · 4d014dee
      Hakan Kuecuekyilmaz authored
          mysqlslap: setting --engine does not get replicated
          http://bugs.mysql.com/bug.php?id=46967
      
      and
          mysqlslap: specifying --engine and --create does not
          work with --engine=<storage_engine>:<option>
          https://bugs.launchpad.net/maria/+bug/429773
      
      Problems were that an --engine=<storage_engine> was translated
      to a "set storage_engine = <storage_engine>", wich is _not_
      replicated. A --engine=<storage_engine>:<option> was not always
      properly parsed and in some cases crashed.
      
      Fixed by eliminating "set storage_engine = ..." and adding
      proper DDL generation. Initialized an unitialized buffer to
      prevent crashes and fixed to use proper pointer for in
      case of --engine=<storage_engine>:<option> being the last
      element in list of --engines.
      
      Also cleaned up code for better readability.
      
      Q: Should MySQL's replication actually replicate a
         "set storage_engine = ..." command or not?
      A: No it should not. It is documented here:
         http://dev.mysql.com/doc/refman/5.1/en/replication-features-variables.html
         ...
         "The storage_engine system variable is not replicated, which is a
         good thing for replication between different storage engines." ...
      
      Before the patch, mysqlslap was behaving this way:
      
      +-------------------------------+--------+-------------+
      |                               | single | replication |
      +-------------------------------+--------+-------------+
      | Before patch                                         | 
      +-------------------------------+--------+-------------+
      | --engine[1]                                          |
      +-----+-------------------------+--------+-------------+
      | 1.1 | eng1                    |  OK    |   Not OK    |
      | 1.2 | eng1,eng2               |  OK    |   Not OK    |
      | 1.3 | eng1,eng2,eng3          |  OK    |   Not OK    |
      | 1.4 | memory:option           |  OK    |   Not OK    |
      | 1.5 | memory:option,eng1      |  OK    |   Not OK    |
      | 1.6 | eng1,memory:option      | Not OK |   Not OK    |
      | 1.7 | memory:option,eng1,eng2 | Crash  |   Not OK    |
      | 1.8 | eng1,memory:option,eng2 |  OK    |   Not OK    |
      | 1.9 | eng1,eng2,memory:option | Not OK |   Not OK    |
      +-----+-------------------------+--------+-------------+
      +-------------------------------+--------+-------------+
      | --create --engine[2]                                 |
      +-----+-------------------------+--------+-------------+
      | 2.1 | eng1                    |  OK    |   Not OK    |
      | 2.2 | eng1,eng2               |  OK    |   Not OK    |
      | 2.3 | eng1,eng2,eng3          |  OK    |   Not OK    |
      | 2.4 | memory:option           | Not OK |   Not OK    |
      | 2.5 | memory:option,eng1      | Not OK |   Not OK    |
      | 2.6 | eng1,memory:option      | Not OK |   Not OK    |
      | 2.7 | memory:option,eng1,eng2 | Crash  |   Not OK    |
      | 2.8 | eng1,memory:option,eng2 | Not OK |   Not OK    |
      | 2.9 | eng1,eng2,memory:option | Not OK |   Not OK    |
      +-----+-------------------------+--------+-------------+
      
      After my final patch, mysqlslap now runs like this:
      
      +-------------------------------+--------+-------------+
      |                               | single | replication |
      +-------------------------------+--------+-------------+
      | After third patch                                    | 
      +-------------------------------+--------+-------------+
      | --engine[1]                                          |
      +-----+-------------------------+--------+-------------+
      | 1.1 | eng1                    |  OK    |  OK         |
      | 1.2 | eng1,eng2               |  OK    |  OK         |
      | 1.3 | eng1,eng2,eng3          |  OK    |  OK         |
      | 1.4 | memory:option           |  OK    |  OK         |
      | 1.5 | memory:option,eng1      |  OK    |  OK         |
      | 1.6 | eng1,memory:option      |  OK    |  OK         |
      | 1.7 | memory:option,eng1,eng2 |  OK    |  OK         |
      | 1.8 | eng1,memory:option,eng2 |  OK    |  OK         |
      | 1.9 | eng1,eng2,memory:option |  OK    |  OK         |
      +-----+-------------------------+--------+-------------+
      +-------------------------------+--------+-------------+
      | --create --engine[2]                                 |
      +-----+-------------------------+--------+-------------+
      | 2.1 | eng1                    |  OK    |  OK         |
      | 2.2 | eng1,eng2               |  OK    |  OK         |
      | 2.3 | eng1,eng2,eng3          |  OK    |  OK         |
      | 2.4 | memory:option           |  OK    |  OK         |
      | 2.5 | memory:option,eng1      |  OK    |  OK         |
      | 2.6 | eng1,memory:option      |  OK    |  OK         |
      | 2.7 | memory:option,eng1,eng2 |  OK    |  OK         |
      | 2.8 | eng1,memory:option,eng2 |  OK    |  OK         |
      | 2.9 | eng1,eng2,memory:option |  OK    |  OK         |
      +-----+-------------------------+--------+-------------+
      4d014dee
    • Sergey Petrunya's avatar
      Gcov support improvements · 879c7f17
      Sergey Petrunya authored
      - address review feedback (cleaner perl code)
      879c7f17
    • Sergey Petrunya's avatar
      A change of direction for fix 10 csets ago: · 02c5bb04
      Sergey Petrunya authored
      - When the table is created with an attribute that is not supported by
        the storage engine, the attribute ought to be still kept.
      02c5bb04
    • Sergey Petrunya's avatar
      Fix mysql-test-run on windows: · d62f6280
      Sergey Petrunya authored
      Make it not to add '--console' when '--log-error' option is present
      - Review feedback
      d62f6280
  10. 17 Sep, 2009 3 commits
  11. 16 Sep, 2009 8 commits
  12. 15 Sep, 2009 6 commits