An error occurred fetching the project authors.
  1. 31 Dec, 2004 1 commit
  2. 18 Dec, 2004 1 commit
  3. 14 Dec, 2004 1 commit
  4. 13 Dec, 2004 1 commit
  5. 11 Dec, 2004 1 commit
  6. 30 Nov, 2004 1 commit
  7. 22 Nov, 2004 1 commit
  8. 16 Nov, 2004 1 commit
  9. 15 Nov, 2004 1 commit
  10. 07 Nov, 2004 1 commit
    • monty@mysql.com's avatar
      Simpler arena swapping code · b903a129
      monty@mysql.com authored
      Now thd->mem_root is a pointer to thd->main_mem_root and THR_MALLOC is a pointer to thd->mem_root.
      This gives us the following benefits:
      - Allow us to easily detect if arena has already been swapped before (this fixes a bug in setup_conds() where arena was swaped twice in some cases)
      - Faster swaps of arenas (as we don't have to copy the whole MEM_ROOT)
      - We don't anymore have to call my_pthread_setspecific_ptr(THR_MALLOC,...) to change where memory is alloced. Now it's enough to set thd->mem_root
      b903a129
  11. 06 Nov, 2004 1 commit
    • igor@rurik.mysql.com's avatar
      join_outer.result, join_outer.test: · ca355c8a
      igor@rurik.mysql.com authored
        Added cases for bugs #6307 and #6460.
      sql_select.cc:
        Fixed the problem of bug reports #6307 and #6460.
        The reported wrong result sets were due to the fact that
        the added call of the fix_fields method for the built
        AND condition that joined WHERE and ON conditions
        broke ON expression, as it removed extra AND levels
        in the built condition. 
        It looks like that no attributes of the built condition
        are needed, so we don't have to call fix_fields here.
      ca355c8a
  12. 19 Oct, 2004 1 commit
    • monty@mishka.local's avatar
      Review of all code pushed since last review · 04c23808
      monty@mishka.local authored
      Simple optimzations and cleanups
      Removed compiler warnings and fixed portability issues
      Added client functions 'mysql_embedded()' to allow client to check if we are using embedded server
      Fixes for purify
      04c23808
  13. 10 Oct, 2004 1 commit
  14. 09 Oct, 2004 2 commits
    • konstantin@mysql.com's avatar
      A small simplification: perform two actions at once, register a · 703e396b
      konstantin@mysql.com authored
      change, and perform it (the new Item changes registry).
      703e396b
    • konstantin@mysql.com's avatar
      A fix and test case for Bug#5987 "subselect in bool function · daa4c249
      konstantin@mysql.com authored
      crashes server (prepared statements)": the bug was that all boolean
      items always recovered its original arguments at statement cleanup 
      stage.
      This collided with Item_subselect::select_transformer, which tries to 
      permanently change the item tree to use a transformed subselect instead of
      original one.
      So we had this call sequence for prepare:
      mysql_stmt_prepare -> JOIN::prepare -> 
      Item_subselect::fix_fields -> the item tree gets transformed ->
      Item_bool_rowready_func2::cleanup, item tree is recovered to original
      state, while it shouldn't have been;
      mysql_stmt_execute -> attempts to execute a broken tree -> crash.
      Now instead of bluntly recovering all arguments of bool functions in 
      Item_bool_rowready_func2::cleanup, we recover only those
      which were changed, and do it in one place.
      There still would exist a possibility for a collision with subselect
      tranformation, if permanent and temporary changes were performed at the 
      same stage.
      But fortunately subselect transformation is always done first, so it 
      doesn't conflict with the optimization done by propogate_cond_constants.
      Now we have: 
      mysql_stmt_prepare -> JOIN::prepare -> subselect transformation 
      permanently changes the tree -> cleanup doesn't recover anything, 
      because nothing was registered for recovery.
      mysql_stmt_execute -> JOIN::prepare (the tree is already transformed, 
      so it doesn't change), JOIN::optimize -> 
      propogate_cond_constants -> temporary changes the item tree 
      with constants -> JOIN::execute -> cleanup -> 
      the changes done by propogate_cond_constants are recovered, as
      they were registered for recovery.
      daa4c249
  15. 08 Oct, 2004 2 commits
  16. 07 Oct, 2004 1 commit
    • monty@mysql.com's avatar
      After merge fixes · 6239edc1
      monty@mysql.com authored
      Some bigger code changes was necessary becasue of the multi-table-update and the new HANDLER code
      6239edc1
  17. 01 Oct, 2004 1 commit
  18. 30 Sep, 2004 2 commits
  19. 13 Sep, 2004 2 commits
  20. 06 Sep, 2004 1 commit
  21. 03 Sep, 2004 1 commit
    • igor@rurik.mysql.com's avatar
      select.result, select.test: · f888026f
      igor@rurik.mysql.com authored
        Added a test case for bug #5333.
      null_key.result, key_primary.result:
        Made covering index usable for const tables.
      sql_select.cc:
        Made covering index usable for const tables:
        downported the corresponding code from 4.1.
        Simultaneously fixed bug #5333 reported for 4.1.
        The bug was due to the fact that field index in join
        structures was always set to 0 for const tables.
      f888026f
  22. 31 Aug, 2004 2 commits
  23. 29 Aug, 2004 1 commit
  24. 26 Aug, 2004 1 commit
  25. 24 Aug, 2004 2 commits
  26. 23 Aug, 2004 5 commits
  27. 20 Aug, 2004 3 commits
    • konstantin@mysql.com's avatar
      Fix for bug#4912 "mysqld crashs in case a statement is executed · 568c6e85
      konstantin@mysql.com authored
       a second time". The bug was caused by incompatibility of
      negations elimination algorithm and PS: during first statement 
      execute a subtree with negation was replaced with equivalent 
      subtree without NOTs.
      The problem was that although this transformation was permanent, 
      items of the new subtree were created in execute-local memory.
      The patch adds means to check if it is the first execute of a
      prepared statement, and if this is the case, to allocate items
      in memory of the prepared statement.
      The implementation:
      - backports Item_arena from 5.0
      - adds Item_arena::is_stmt_prepare(), 
        Item_arena::is_first_stmt_execute().
      - deletes THD::allocate_temporary_pool_for_ps_preparing(),
        THD::free_temporary_pool_for_ps_preparing(); they
        were redundant.
      and adds a few invariants:
      - thd->free_list never contains junk (= freed items)
      - thd->current_arena is never null. If there is no
        prepared statement, it points at the thd. 
      The rest of the patch contains mainly mechanical changes and
      cleanups.
      568c6e85
    • serg@serg.mylan's avatar
      sql_select.cc: compilation failure fixed · b267ce4b
      serg@serg.mylan authored
      b267ce4b
    • dlenev@brandersnatch.localdomain's avatar
      Fix for bug#4302 "ambiguos order by when renamed column is identical to another in result" · c8882165
      dlenev@brandersnatch.localdomain authored
      When in find_item_in_list() we are looking for item we should take into account unaliased 
      names of the fields but only if item with such aliased name is not found.
      Also we should ignore aliases when looking for fully specified field.
      c8882165
  28. 19 Aug, 2004 1 commit