1. 29 Sep, 2017 1 commit
    • Monty's avatar
      Fix index scan cleanup in the partition engine. · 7c554e1f
      Monty authored
      Spiral Patch 057: 057_mariadb-10.2.0.partition_index_end.diff MDEV-12999
      
      Original author: Kentoku SHIBA
      First reviewer:  Jacob Mathew
      Second reviewer: Michael Widenius
      7c554e1f
  2. 28 Sep, 2017 5 commits
    • Monty's avatar
      Adding option to tell that cmp_ref handler call is expensive · 04ef45cb
      Monty authored
      - In Spider, calling cmp_ref() can be very expensive. In ha_partition.cc
        we don't anymore sort rows according to position for the Spider
        engine.
      - Removed Spider specific call info(HA_EXTRA_STARTING_ORDERED_INDEX_SCAN)
        from handle_ordered_index_scan(). It's caused performance issues and
        does not change results for queries with ORDER BY.
      - The visible effect of this patch is that for some storage engines,
        rows may be returned in a different order if there is no ORDER BY clause.
      
      - Based in Spiral Patch 052:
        052_mariadb-10.2.0.add_partition_skip_pk_sort_for_non_clustered_index.diff
        MDEV-7748
      - The major difference from original patch is that there is no variable to
        get the old behaviour.
      
      - Other things:
        - Optimized ha_partition::cmp_ref() and cmp_part_ids() to make them
          simpler and faster.
        - Changed arguments to cmp_key_part_id() to be same as cmp_key_rowid_part_id
          to simplify code.
      
      Original author: Kentoku SHIBA
      First reviewer:  Jacob Mathew
      Second reviewer: Michael Widenius
      04ef45cb
    • Monty's avatar
      Adding support for auto_increment in the partition engine. · 611b1c76
      Monty authored
      Contains Spiral patches:
      - Spiral Patch 022: 022_mariadb-10.2.0.auto_increment.diff          MDEV-7720
      - Spiral Patch 030: 030_mariadb-10.2.0.partition_auto_inc_init.diff MDEV-7726
      
      These patches have the following differences compared to the original
      patches:
      - Added the new #defines for the feature in spd_environ.h instead of in
        handler.h because these #defines are needed by Spider and are not needed by
        the server.
      - Cleaned up code related to the removed variable m_need_info_for_auto_inc
      . Changed variable assignment in lock_auto_increment() and
        unlock_auto_increment() so that the assignments are done under locks.
      - Added a test case.
      - Added test result changes resulting from a bug that was fixed by these
        patches.
      
      Original author: Kentoku SHIBA
      First reviewer:  Jacob Mathew
      Second reviewer: Michael Widenius
      611b1c76
    • Monty's avatar
      Adding Full Text Search support to partitions · 4ed3b913
      Monty authored
      Contains Spiral patches:
      - Spiral Patch 007: 007_mariadb-10.2.0.partition_fulltext.diff  MDEV-7705
      - Spiral Patch 038: 038_mariadb-10.2.0.partition_fulltext2.diff MDEV-7734
      
      - This commit has the following differences compared to the original patches:
        - Added necessary full text search cleanup at the storage engine layer
          that was omitted in the original patch.
        - Added test case.
      - A lot of code cleanups to make the code notable smaller.
      - Changed SQL code to use ha_ft_end() instead of ft_end()
      
      Original author: Kentoku SHIBA
      First reviewer:  Jacob Mathew
      Second reviewer: Michael Widenius
      4ed3b913
    • Monty's avatar
      052e57be
    • Monty's avatar
      Add direct aggregates · f595ce1e
      Monty authored
      Spider patches 026 (MDEV-7723), 031 (MDEV-7727) and 058 (MDEV-12532)
      
      This allows the storage engine to internally compute sum and count
      operations.
      
      - Enhance sum items to be able to store the sum value directly.
      - return_record_by_parent() is enabled in spider as
        HANDLER_HAS_DIRECT_AGGREGATE is defined
      - Added spd_environ.h to spider. This is loaded first to ensure that all
        MariaDB specific defines that are used by include files are properly
        defined.
      - This code is tested by the existing spider tests direct_aggregate.test
        and direct_aggregate_part.test and also partition.test
      f595ce1e
  3. 09 Sep, 2017 7 commits
    • Monty's avatar
      Added more DBUG information · 74adf882
      Monty authored
      Done to simplify spider patch for direct aggregates
      74adf882
    • Monty's avatar
      Adding multi_range_read support to partitions · 64ef56fd
      Monty authored
      Other things:
      - Cleanup of allocated bitmaps done in open(), which
        simplifies init_partition_bitmaps()
      - Add needed defines in ha_spider.cc to enable new spider code
      - Fixed some DBUG_PRINT() to be consistent with normal code
      - Removed end space
      - The changes in test cases partition_innodb, partition_range,
        partition_pruning etc are becasue partitions can now more exactly calculate
        the number of rows in a range.
      
      Contains spider patches:
      014,015,023,033,035,037,040,042,044,045,049,050,051,053,059
      64ef56fd
    • Monty's avatar
      MDEV-7700 Spiral patch 002_mariadb-10.0.15.spider.diff, part 2 · a8fe3f52
      Monty authored
      Allow partition engines to access table->s->connect_string for engines
      that uses HTON_CAN_READ_CONNECT_STRING_IN_PARTITION
      Don't reset table->s->connect_string in ha_partition::open
      a8fe3f52
    • Monty's avatar
      MDEV 7701 Apply Spider patch 003_mariadb-10.0.15.vp.diff · b7223575
      Monty authored
      - Support HA_EXTRA_ADD_CHILDREN_LIST,HA_EXTRA_ATTACH_CHILDREN,
        HA_EXTRA_IS_ATTACHED_CHILDREN and HA_EXTRA_DETACH_CHILDREN
        in partition handler for handlers that has HA_CAN_MULTISTEPL_MERGE flag
      - Added HA_CAN_MULTISTEPL_MERGE to MERGE handler.
      - Added handler::get_child_handlers()
      - Change m_num_lock to contain total number of locks. This was needed as we
        now adjust number of locks when extra(HA_EXTRA_ATTACH_CHILDREN) is called.
      b7223575
    • Monty's avatar
      MDEV-7700 Spiral patch 002_mariadb-10.0.15.spider.diff · 50a2eb55
      Monty authored
      - Enable HA_EXTRA_WRITE_CAN_REPLACE and HA_EXTRA_WRITE_CANNOT_REPLACE for
        partition engine.
      50a2eb55
    • Monty's avatar
      Applied patch 001_mariadb-10.0.15.partition_cond_push.diff · d2b2ea86
      Monty authored
      - Added cond_push() and cond_pop() to ha_partition.cc
      d2b2ea86
    • Monty's avatar
      Added spider patches for adding HANDLER support for the partition engine · 42c8b68b
      Monty authored
      013_mariadb-10.0.15.vp_handler.diff
      034_mariadb-10.0.15.vp_handler2.diff
      005_mariadb-10.0.15.hs.diff
      041_mariadb-10.0.15.vp_handler2.diff
      + Fixes from Kentoku
      + Added handler/suite.pm and handler/suite.opt to be able to run test cases
        in spider/handler
      42c8b68b
  4. 08 Sep, 2017 5 commits
  5. 07 Sep, 2017 6 commits
  6. 06 Sep, 2017 9 commits
  7. 05 Sep, 2017 2 commits
  8. 04 Sep, 2017 4 commits
    • andrelkin's avatar
      MDEV-12731 · 8592ff9e
      andrelkin authored
      Was reported as 'rpl.rpl_gtid_stop_start fails with Valgrind in buildbot and outside'.
      The 'Conditional jump or move depends on uninitialized value' valgrind complaint is valid
      and means THD::m_current_stage_key that is not initialized indeed by constructor.
      
      Fixed with its initialization added to the initializer list of
      THD::THD.  Double checked with mysql to have found a similar fixes for
      the very same issue which was discovered after P_S merge to Maria
      (60589aee where the member is introduced) had been done.
      8592ff9e
    • Andrei Elkin's avatar
      Post-push for MDEV-13437 · 641baa5d
      Andrei Elkin authored
      A new $MYSQLD_LAST_CMD evaluation was too late in case --manual-gdb.
      Now it is done before the server restart type branches which is safe
      and the args value has been fully computed by the new point of
      evaluation.
      641baa5d
    • Oleksandr Byelkin's avatar
      MDEV-10972: Insert from select / view / union -- repeatable crash in 10.1, 10.2 Linux/Mac/Windows · 17589989
      Oleksandr Byelkin authored
      save thd->select_number between parsing and executions (in case it was not complete executed due to errors (for example epsent table))
      17589989
    • Marko Mäkelä's avatar
      MDEV-13705 10.0.32 does not compile on architectures without 64-bit atomics · 05008999
      Marko Mäkelä authored
      This is a backport of the following:
      
      MDEV-13009 10.1.24 does not compile on architectures without 64-bit atomics
      
      Add a missing #include "sync0types.h" that was removed in MDEV-12674.
      05008999
  9. 03 Sep, 2017 1 commit