An error occurred fetching the project authors.
  1. 29 Mar, 2005 1 commit
    • unknown's avatar
      Shift skipping of some tests with embedded server from within · ff9a1bd2
      unknown authored
      mysql-test-run to the tests themselves.
      
      
      mysql-test/t/bdb-deadlock.test:
        Don't run this test with embedded server
      mysql-test/mysql-test-run.sh:
        Remove tests from being skipped with embedded server
      mysql-test/t/connect.test:
        Skip test under embedded server
      mysql-test/t/flush_block_commit.test:
        Skip test under embedded server
      mysql-test/t/grant.test:
        Skip test under embedded server
      mysql-test/t/grant2.test:
        Skip test under embedded server
      mysql-test/t/grant_cache.test:
        Skip test under embedded server
      ff9a1bd2
  2. 17 Dec, 2004 1 commit
    • unknown's avatar
      Fix for BUG#7358: removing warning reporting of mysqldump 4.1.8 when calling... · 9a202517
      unknown authored
      Fix for BUG#7358: removing warning reporting of mysqldump 4.1.8 when calling SHOW CREATE DATABASE, as we deal almost gracefully with it
      (back to behaviour of 4.1.7). Warning was not fatal: mysqldump continued. And the good thing is that it helped spot that starting from 4.1.7,
      SHOW CREATE DATABASE failed (if --single-transaction and first db has non-empty InnoDB table and there is a second db) and thus mysqldump
      produced CREATE DATABASE statements missing the CHARACTER SET clause. Removing the bug which was in the server, and the warning reporting in
      mysqldump (compatibility with old servers).
      
      
      client/mysqldump.c:
        don't report errors as we deal almost gracefully with them (back to code of 4.1.7)
      mysql-test/r/flush_block_commit.result:
        result update
      mysql-test/t/flush_block_commit.test:
        let's verify that SHOW CREATE DATABASE succeeds even if connection has open transaction.
      sql/sql_parse.cc:
        There is no reason to forbid SHOW CREATE DATABASE if connection has an open transaction
      9a202517
  3. 30 Nov, 2004 1 commit
    • unknown's avatar
      two-line fix for BUG#6732 "FLUSH TABLES WITH READ LOCK + COMMIT makes next... · 352ad815
      unknown authored
      two-line fix for BUG#6732 "FLUSH TABLES WITH READ LOCK + COMMIT makes next FLUSH...LOCK hang forever"
      (originally reported as "second run of innobackup hangs forever and can even hang server").
      Plus testcase for the bugfix and comments about global read locks.
      
      
      mysql-test/r/flush_block_commit.result:
        result update
      mysql-test/t/flush_block_commit.test:
        testing bugfix (originally: second run of innobackup hangs)
      sql/lock.cc:
        When we are in start_waiting_global_read_lock(), if we ourselves have
        the global read lock, there is nothing to start. This makes a pair with how 
        wait_if_global_read_lock() behaves when we ourselves have the global read lock.
        Previously, start_waiting_global_read_lock() decremented protect... whereas wait_if_global_read_lock()
        hadn't incremented it => very wrong => hangs.
        Descriptive comments on how global read lock works.
      352ad815
  4. 20 Aug, 2004 2 commits
    • unknown's avatar
      after merge fix · 0745a2b7
      unknown authored
      myisam/Makefile.am:
        put zlib at the end (libtool adds the whole bunch of dependencies right after that)
      sql/Makefile.am:
        put zlib at the end (libtool adds the whole bunch of dependencies right after that)
      0745a2b7
    • unknown's avatar
      Making FLUSH TABLES WITH READ LOCK block COMMITs of existing transactions, · cd8054d4
      unknown authored
      in a deadlock-free manner. This splits locking the global read lock in two steps.
      This fixes a consequence of this bug, known as:
      BUG#4953 'mysqldump --master-data may report incorrect binlog position if using InnoDB'
      And a test.
      
      
      sql/handler.cc:
        making COMMIT wait if FLUSH TABLES WITH READ LOCK happened.
      sql/lock.cc:
        an additional stage so that FLUSH TABLES WITH READ LOCK blocks COMMIT:
        make_global_read_lock_block_commit():
        taking the global read lock is TWO steps (2nd step is optional; without
        it, COMMIT of existing transactions will be allowed):
        lock_global_read_lock() THEN make_global_read_lock_block_commit().
      sql/mysql_priv.h:
        new argument to wait_if_global_read_lock()
      sql/sql_class.h:
        THD::global_read_lock now an uint to reflect the 2 steps of global read lock (does not block COMMIT / does)
      sql/sql_db.cc:
        update for new prototype
      sql/sql_parse.cc:
        implementing the two steps of global read lock so that FLUSH TABLES WITH READ LOCK can block COMMIT without deadlocking with COMMITs.
      cd8054d4