Commits · 7e8cc90a8b3ca552c4a81047becb439bad475e96 · nexedi / MariaDB

21 Oct, 2003 2 commits

Bugfix of previous WL#1265 commit. · 7e8cc90a

unknown authored Oct 21, 2003

Need a sp_cache_remove() function with implicit name lookup to make the WL task
to work. It's a cleaner and more convenient interface anyway...


sql/sp.cc:
  Modified sp_cache_remove() function calls; just remove by name.
sql/sp_cache.cc:
  Modified sp_cache_remove() function. Get name and lookup/remove, return the
  removed entry, if any.
sql/sp_cache.h:
  Modified sp_cache_remove() function. Get name and lookup/remove, return the
  removed entry, if any.

7e8cc90a

WL#1265: Fix proper ALTER/DROP support in the SP cache. · 562a04d5

unknown authored Oct 21, 2003

New sp_cache C API. When an SP is dropped, old caches (in other threads)
become invalid and are cleared.
Also, the caches in THD are only created on demand.


Docs/sp-imp-spec.txt:
  Brough the SP cache docs up-to-date.
sql/mysqld.cc:
  Initialize SP cache.
sql/sp.cc:
  New C API for SP cache.
sql/sp_cache.cc:
  New C API for sp_cache.
  The class sp_cache is still used, but not directly. The C functions makes takes
  care of updating caches when SPs are dropped. (This is done in the simplest
  possible way, by simply detecting drops and then clear all old caches.)
  The API is also designed so that the sp_cache is created on demand.
sql/sp_cache.h:
  New C API for sp_cache.
  The class sp_cache is still used, but not directly. The C functions makes takes
  care of updating caches when SPs are dropped.
  The API is also designed so that the sp_cache is created on demand.
sql/sql_class.cc:
  The new sp_cache API creates the caches on demand, to avoid allocating it
  when it's not needed.

562a04d5

20 Oct, 2003 1 commit

Bugfix; added another method to Item_splocal, updated tests, and added previous · 2b1dc5f3

unknown authored Oct 20, 2003

fix to functions as well.


mysql-test/r/sp.result:
  Modified test to trap yet another bug (now fixed).
mysql-test/t/sp.test:
  Modified test to trap yet another bug (now fixed).
sql/item.h:
  Another bugfix; need to override yet another method in Item_splocal.
sql/sp_head.cc:
  Completed previous initialization bug; now for FUNCTIONs. too.

2b1dc5f3

17 Oct, 2003 1 commit

Bugfix. Local variables are now initialized to null. · 82e5115a

unknown authored Oct 17, 2003


mysql-test/r/sp.result:
  New test case for bugfix (when a variable is not set due to an exception).
mysql-test/t/sp.test:
  New test case for bugfix (when a variable is not set due to an exception).
sql/item.h:
  Local variables are initialized to null.
sql/sp_head.cc:
  Local variables are initialized to null.

82e5115a

16 Oct, 2003 1 commit

Handle user variables (@-vars) as OUT and INOUT parameters in SPs. · 12a0546d

unknown authored Oct 16, 2003


mysql-test/r/sp.result:
  Test cases for user variables (@-vars) as OUT and INOUT parameters.
mysql-test/t/sp.test:
  Test cases for user variables (@-vars) as OUT and INOUT parameters.
sql/item_func.h:
  We need to be able to detect Item_func_get_user_vars when used as arguments to SPs.
sql/sp_head.cc:
  Handle user variables (@-vars) as OUT and INOUT parameters.
  But we still just ignore it, if it's anything else.

12a0546d

15 Oct, 2003 1 commit

Fix for BUG#1547: "SELECT ... WHERE field = var" sometimes give the wrong result in SPs · 9aa680a0

unknown authored Oct 15, 2003

Two missing methods added to Item_splocal + test case.


mysql-test/r/sp.result:
  Test case for BUG#1547
mysql-test/t/sp.test:
  Test case for BUG#1547
sql/item.h:
  Fix for BUG#1547: "SELECT ... WHERE field = var" sometimes give the wrong result in SPs
  
  Added missing methods to Item_splocal to get the correct compare function
  and make the optimizer do the right thing.

9aa680a0

14 Oct, 2003 1 commit

Fix for BUG#1495: Evaluate items before setting a local variable with SELECT INTO. · 776784b8

unknown authored Oct 14, 2003

Also copy and restore order_list and group_list for selects in SPs.


mysql-test/r/sp.result:
  Test for BUG#1495, and an additional cursor test.
mysql-test/t/sp.test:
  Test for BUG#1495, and an additional cursor test.
sql/sp_head.cc:
  Fix BUG#1495: renamed eval_func_item() into sp_eval_func_item() and made it
  non-static.
  Also need to copy and restore order_list and group_list pointers before and
  after execution of a substatement. (Which means these must always be properly
  initialized for all queries.)
sql/sp_rcontext.cc:
  Fix BUG#1495: Evaluate and set a local variable (for SELECT INTO).
sql/sp_rcontext.h:
  Fix BUG#1495: Evaluate and set a local variable (for SELECT INTO).
sql/sql_class.cc:
  Fix BUG#1495: Evaluate and set a local variable (for SELECT INTO).
sql/sql_class.h:
  Fix BUG#1495: Evaluate and set a local variable (for SELECT INTO); need type for this.
sql/sql_parse.cc:
  order_list and group_list must be initialized in select_lex for all queries,
  to make SP sub statement execution work.
sql/sql_yacc.yy:
  Type needed for setting local variables.
sql/table.h:
  Need a copy of the Item* pointer when executing sub-statements in SPs. (Since
  it's modified and must be restored afterwards.)

776784b8

10 Oct, 2003 2 commits

Merge mysql.com:/usr/local/bk/mysql-5.0 · 569e72af
unknown authored Oct 10, 2003
```
into mysql.com:/home/pem/work/mysql-5.0


sql/sql_yacc.yy:
  Auto merged
```
569e72af

WL#962: Added simple, read-only, non-scrolling, asensitive cursors in SPs, using the · 04c6b9b8

unknown authored Oct 10, 2003

(updated) Protocol_cursor class.
Also did some bug fixes.


Docs/sp-imp-spec.txt:
  Added CURSOR docs (and fixed typos)
Docs/sp-implemented.txt:
  Updated for CURSORs
include/mysqld_error.h:
  New error codes/messages for CURSORs
libmysqld/Makefile.am:
  SP cursors now needs this.
mysql-test/r/sp-error.result:
  New tests for cursors.
mysql-test/r/sp.result:
  New tests for cursors.
mysql-test/t/sp-error.test:
  New tests for cursors.
mysql-test/t/sp.test:
  New tests for cursors.
sql/protocol.cc:
  We now always have Protocol_cursor (SPs use it)
sql/protocol.h:
  Fixed bugs in Protocol_cursor (for SPs)
sql/protocol_cursor.cc:
  Fixed bugs in Protocol_cursor (for SPs)
sql/share/czech/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/danish/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/dutch/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/english/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/estonian/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/french/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/german/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/greek/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/hungarian/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/italian/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/japanese/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/korean/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/norwegian-ny/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/norwegian/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/polish/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/portuguese/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/romanian/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/russian/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/serbian/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/slovak/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/spanish/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/swedish/errmsg.txt:
  New error codes/messages for CURSORs
sql/share/ukrainian/errmsg.txt:
  New error codes/messages for CURSORs
sql/sp_head.cc:
  Added cursor support.
  Also fixed problems with item_lists, where pointers and ref_pointer_arrays.
sql/sp_head.h:
  Added cursor support
sql/sp_pcontext.cc:
  Added cursor support
sql/sp_pcontext.h:
  Added cursor support
sql/sp_rcontext.cc:
  Added cursor support, in particular the new sp_cursor class.
sql/sp_rcontext.h:
  Added cursor support, in particular the new sp_cursor class.
sql/sql_lex.h:
  We sometimes need to copy item_lists in LEX when executing substatements in SPs
sql/sql_yacc.yy:
  Added minimal cursor support (not the full syntax yet).

04c6b9b8

06 Oct, 2003 2 commits

Merge laptop.sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 84285351

unknown authored Oct 06, 2003

into laptop.sanja.is.com.ua:/home/bell/mysql/bk/work-udf-5.0


sql/sql_parse.cc:
  Auto merged
sql/sql_yacc.yy:
  Auto merged

84285351

after review patch (SCRUM) · d2574b92

unknown authored Oct 06, 2003


sql/sql_parse.cc:
  already fixed in right way
sql/udf_example.cc:
  not used function
tests/udf_test.res:
  added test of AS
tests/udf_test:
  added test of AS

d2574b92

03 Oct, 2003 2 commits

Check that a FUNCTION contains RETURN and that we actually get a return value. · 4379cbcf

unknown authored Oct 03, 2003


include/mysqld_error.h:
  New error codes/messages for missing RETURNs in FUNCTIONs.
mysql-test/r/sp-error.result:
  New error tests for missing RETURNs in FUNCTIONs.
mysql-test/t/sp-error.test:
  New error tests for missing RETURNs in FUNCTIONs.
sql/share/czech/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/danish/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/dutch/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/english/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/estonian/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/french/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/german/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/greek/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/hungarian/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/italian/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/japanese/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/korean/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/norwegian-ny/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/norwegian/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/polish/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/portuguese/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/romanian/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/russian/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/serbian/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/slovak/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/spanish/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/swedish/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/share/ukrainian/errmsg.txt:
  New error codes/messages for missing RETURNs in FUNCTIONs.
sql/sp_head.h:
  Check that a FUNCTION contains RETURN.
sql/sql_parse.cc:
  Check that a FUNCTION contains RETURN.
sql/sql_yacc.yy:
  Check that a FUNCTION contains RETURN.

4379cbcf

Fixed BUG#822: Copying and clearing some things in thd/lex when · 869b49ef

unknown authored Oct 03, 2003

executing sub-statements (selects) prevents crashes intermittent
crashes.
Also fixed bug in sql_yacc.yy (generated a hpop instruction when
not needed).


mysql-test/r/sp.result:
  Test-case for BUG#822.
mysql-test/t/sp.test:
  Test-case for BUG#822.
sql/sp_head.cc:
  Fixed BUG#822; needed to copy and clear some stuff when calling sub-statements.
sql/sql_yacc.yy:
  Only generate hpop instruction when we actually have handlers.

869b49ef

02 Oct, 2003 1 commit
- Merge laptop.sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 39fe2f6a
  unknown authored Oct 02, 2003
```
into laptop.sanja.is.com.ua:/home/bell/mysql/bk/work-udf-5.0
```
  39fe2f6a
01 Oct, 2003 2 commits
- Made SELECT INTO variable-list re-entrant, which fixes bug in stored procedures (#822) · 2f468db7
  unknown authored Oct 01, 2003
  
  2f468db7
- Add proc table if not exists · 422bb4fc
  unknown authored Oct 01, 2003
```
BitKeeper/etc/logging_ok:
  Logging to logging@openlogging.org accepted
```
  422bb4fc
28 Sep, 2003 1 commit

Merge laptop.sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · bb9a92cc

unknown authored Sep 28, 2003

into laptop.sanja.is.com.ua:/home/bell/mysql/bk/work-udf-5.0


include/mysql_com.h:
  Auto merged
sql/item.cc:
  Auto merged
sql/item.h:
  Auto merged
sql/item_func.cc:
  Auto merged
sql/sql_parse.cc:
  Auto merged
sql/sql_yacc.yy:
  Auto merged
sql/udf_example.cc:
  Auto merged

bb9a92cc

24 Sep, 2003 4 commits

Post-merge fixes. · 03042c7d
unknown authored Sep 24, 2003

03042c7d

Merging 4.1 -> 5.0 · cd8508d3

unknown authored Sep 24, 2003


BitKeeper/etc/ignore:
  auto-union
BitKeeper/etc/logging_ok:
  auto-union
client/mysql.cc:
  Auto merged
configure.in:
  Auto merged
include/my_pthread.h:
  Auto merged
include/mysql_com.h:
  Auto merged
libmysql/libmysql.c:
  Auto merged
BitKeeper/deleted/.del-sel000100.result~84ed46856cb3a69f:
  Auto merged
BitKeeper/deleted/.del-sel000100.test~548501cad19a1a59:
  Auto merged
myisam/mi_check.c:
  Auto merged
myisam/myisamchk.c:
  Auto merged
mysql-test/r/connect.result:
  Auto merged
mysql-test/r/show_check.result:
  Auto merged
mysql-test/r/subselect.result:
  Auto merged
mysql-test/r/symlink.result:
  Auto merged
mysql-test/t/subselect.test:
  Auto merged
mysys/my_pthread.c:
  Auto merged
scripts/mysql_create_system_tables.sh:
  Auto merged
scripts/mysql_install_db.sh:
  Auto merged
sql/filesort.cc:
  Auto merged
sql/ha_berkeley.cc:
  Auto merged
sql/ha_innodb.cc:
  Auto merged
sql/ha_myisam.cc:
  Auto merged
sql/item_cmpfunc.cc:
  Auto merged
sql/item_create.cc:
  Auto merged
sql/item_func.cc:
  Auto merged
sql/item_func.h:
  Auto merged
sql/item_subselect.cc:
  Auto merged
sql/item_sum.cc:
  Auto merged
sql/lex.h:
  Auto merged
sql/lock.cc:
  Auto merged
sql/log.cc:
  Auto merged
sql/log_event.cc:
  Auto merged
sql/mysql_priv.h:
  Auto merged
sql/mysqld.cc:
  Auto merged
sql/protocol.cc:
  Auto merged
sql/records.cc:
  Auto merged
sql/repl_failsafe.cc:
  Auto merged
sql/set_var.cc:
  Auto merged
sql/slave.cc:
  Auto merged
sql/sql_acl.cc:
  Auto merged
sql/sql_base.cc:
  Auto merged
sql/sql_cache.cc:
  Auto merged
sql/sql_class.cc:
  Auto merged
sql/sql_class.h:
  Auto merged
sql/sql_db.cc:
  Auto merged
sql/sql_derived.cc:
  Auto merged
sql/sql_insert.cc:
  Auto merged
sql/sql_lex.cc:
  Auto merged
sql/sql_load.cc:
  Auto merged
sql/sql_repl.cc:
  Auto merged
sql/sql_repl.h:
  Auto merged
sql/sql_select.cc:
  Auto merged
sql/sql_show.cc:
  Auto merged
sql/sql_table.cc:
  Auto merged
sql/sql_update.cc:
  Auto merged
sql/sql_yacc.yy:
  Auto merged

cd8508d3

Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 4e09f14b
unknown authored Sep 24, 2003
```
into narttu.mysql.fi:/my/mysql-4.1


sql/sql_parse.cc:
  Auto merged
```
4e09f14b

- Code cleanup: replaced C++-style comments with the proper syntax for · 07001f78

unknown authored Sep 24, 2003

   .c files (the IBM Visual Age C compiler aborts with a syntax error
   on these)


libmysql/dll.c:
   - replaced C++-style comment with the proper syntax for .c files
     (the IBM Visual Age C compiler aborts with a syntax error on these)
libmysql/libmysql.c:
   - replaced C++-style comment with the proper syntax for .c files
     (the IBM Visual Age C compiler aborts with a syntax error on these)
mysys/my_getopt.c:
   - replaced C++-style comment with the proper syntax for .c files
     (the IBM Visual Age C compiler aborts with a syntax error on these)
sql/net_serv.cc:
   - replaced C++-style comment with the proper syntax for .c files
     (the IBM Visual Age C compiler aborts with a syntax error on these)
strings/ctype-bin.c:
   - replaced C++-style comment with the proper syntax for .c files
     (the IBM Visual Age C compiler aborts with a syntax error on these)
tests/client_test.c:
   - replaced C++-style comment with the proper syntax for .c files
     (the IBM Visual Age C compiler aborts with a syntax error on these)

07001f78

23 Sep, 2003 6 commits

- added option "--readline" to enable linking against libreadline · 51f7838a
unknown authored Sep 23, 2003
```
   (instead of libedit, which is the default for 4.1)
 - brushed up the usage help text a bit
```
51f7838a
Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 32652464
unknown authored Sep 23, 2003
```
into mysql.com:/home/dlenev/src/mysql-4.1-868
```
32652464

derror.cc: · 7bf99d12

unknown authored Sep 23, 2003

  Typo fix: redundant "in"


sql/derror.cc:
  Typo fix: redundant "in"

7bf99d12

Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · c3a58133
unknown authored Sep 23, 2003
```
into mysql.com:/home/dlenev/src/mysql-4.1-868
```
c3a58133

charset.c: · 2d7beead

unknown authored Sep 23, 2003

  comp_err failed to compile error message file when a
  character set was not incompiled.


mysys/charset.c:
  comp_err failed to compile error message file when a
  character set was not incompiled.

2d7beead

derror.cc: · cdd3acc7

unknown authored Sep 23, 2003

  Better English message


sql/derror.cc:
  Better English message

cdd3acc7

22 Sep, 2003 8 commits

Merge mysql.com:/space/my/mysql-4.1 · af7cb104
unknown authored Sep 23, 2003
```
into mysql.com:/space/my/mysql-4.1-build
```
af7cb104

- Polished mysql-copyright a bit and added call to remove · a448d769

unknown authored Sep 23, 2003

   cmd-line-utils/readline from the commercial distribution
 - fixed some copyright headers so mysql-copyright can process them


Build-tools/mysql-copyright:
   - remove the cmd-line-utils/readline directory from the commercial
     distribution
   - make use of more builtin Perl functions instead of forking 
     subprocesses
include/my_pthread.h:
   - fixed copyright header
sql/filesort.cc:
   - fixed copyright header
sql/gen_lex_hash.cc:
   - fixed copyright header
sql/item.h:
   - fixed copyright header
sql/item_cmpfunc.cc:
   - fixed copyright header
sql/records.cc:
   - fixed copyright header

a448d769

Merge abarkov@build.mysql.com:/home/bk/mysql-4.1 · c4d9dc7d
unknown authored Sep 22, 2003
```
into bar.mysql.r18.ru:/usr/home/bar/mysql-4.1
```
c4d9dc7d
Bug 1181 fix. LIKE didn't work with UCS2 character set. · de826fdb
unknown authored Sep 22, 2003

de826fdb
Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · bc26c1ff
unknown authored Sep 22, 2003
```
into mysql.com:/home/dlenev/src/mysql-4.1-868
```
bc26c1ff
Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · dc11b113
unknown authored Sep 22, 2003
```
into gw.mysql.r18.ru:/usr/home/ram/work/4.1


sql/item_strfunc.cc:
  Auto merged
```
dc11b113
xml.c: · 96eb8197
unknown authored Sep 22, 2003
```
  Bug fix


strings/xml.c:
  Bug fix
```
96eb8197
Bug 1350 fix · c8cf1e4e
unknown authored Sep 22, 2003

c8cf1e4e

20 Sep, 2003 1 commit
- Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · aa4b5cda
  unknown authored Sep 20, 2003
```
into mysql.com:/home/dlenev/src/mysql-4.1-868
```
  aa4b5cda
19 Sep, 2003 4 commits

comp_err.c: · d2989680

unknown authored Sep 19, 2003

  There are some problems compiling with pure "configure"
  I need to fix it first.


extra/comp_err.c:
  There are some problems compiling with pure "configure"
  I need to fix it first.

d2989680

New test for UTF8 functionality · 4935e67c
unknown authored Sep 19, 2003

4935e67c
Merge abarkov@build.mysql.com:/home/bk/mysql-4.1 · 127d402e
unknown authored Sep 19, 2003
```
into bar.mysql.r18.ru:/usr/home/bar/mysql-4.1


sql/item_func.cc:
  Auto merged
```
127d402e

Fixed that multibyte charsets didn't honor multibyte · 44bffa0b

unknown authored Sep 19, 2003

sequence boundaries in functions LIKE and LOCATE in
the case of "binary" collation. Comparison was done
like if the strings were just a binary strings without
character set assumption.

44bffa0b