1. 29 Sep, 2006 6 commits
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 7ecc1ac2
      unknown authored
      into  mysql.com:/home/psergey/mysql-5.1-bug14940-r10a
      
      
      sql/sql_select.cc:
        Auto merged
      7ecc1ac2
    • unknown's avatar
      Remove empty line · 9481cd80
      unknown authored
      9481cd80
    • unknown's avatar
      merge fixes · b38d9982
      unknown authored
      
      mysql-test/t/view.test:
        moved the new error message last
      sql/share/errmsg.txt:
        moved the new error message last
      b38d9982
    • unknown's avatar
      BUG#14940: Slow join order is chosen: [2nd commit with post-review fixes] · 5df80677
      unknown authored
      - Re-worked the prev_record_reads() function to return the lower bound of
        number of different table access scans that will be performed.
      
      
      mysql-test/r/join.result:
        BUG#14940: testcase
      mysql-test/t/join.test:
        BUG#14940: testcase
      sql/sql_select.cc:
        BUG#14940: Slow join order is chosen: 
        - Re-worked the prev_record_reads() function to return the lower bound of
          number of different table access scans that will be performed.
      sql/sql_select.h:
        BUG#14940: Slow join order is chosen:
        - Added comments in struct POSITION
        - Added POSITION::ref_depend_map: bitmap of tables that the table access
          method depends on.
      5df80677
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt · 08f6fca4
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      08f6fca4
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · f02715ff
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      f02715ff
  2. 28 Sep, 2006 14 commits
    • unknown's avatar
      view.test: · 04bf9cc7
      unknown authored
        After merge fix
      
      
      mysql-test/t/view.test:
        After merge fix
      04bf9cc7
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 09542617
      unknown authored
      into  moonbone.local:/work/5505-bug-5.0-opt-mysql
      
      
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      mysql-test/r/view.result:
        Manual merge
      mysql-test/t/view.test:
        Manual merge
      09542617
    • unknown's avatar
      Fixed bug#5505: Wrong error message on INSERT into a view · d332c37c
      unknown authored
      On an INSERT into an updatable but non-insertable view an error message was
      issued stating the view being not updatable. This can lead to a confusion of a
      user.
      
      A new error message is introduced. Is is showed when a user tries to insert
      into a non-insertable view.
      
      
      sql/sql_base.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        The update_non_unique_table_error() function now issues proper
        error for an INSERT.
      sql/sql_insert.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Issue the ER_NON_INSERTABLE_TABLE error instead of the 
        ER_NON_UPDATABLE_TABLE on insert into a view.
      sql/sql_view.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Issue the ER_NON_INSERTABLE_TABLE error instead of the
        ER_NON_UPDATABLE_TABLE on insert into a view.
      mysql-test/r/view.result:
        Added the test case for bug#5505: Wrong error message on INSERT into a view
        Corrected a few test cases after fixing bug#5505
      mysql-test/t/view.test:
        Added the test case for bug#5505: Wrong error message on INSERT into a view
        Corrected a few test cases after fixing bug#5505
      sql/share/errmsg.txt:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Added the ER_NON_INSERTABLE_TABLE error definition.
      d332c37c
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1 · 1ec1fc44
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      1ec1fc44
    • unknown's avatar
      after merge fix · 1e641502
      unknown authored
      1e641502
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · ef5b6b19
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/mysql_priv.h:
        Auto merged
      ef5b6b19
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · f6493451
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      f6493451
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 00f0f920
      unknown authored
      into  moonbone.local:/work/18360-bug-5.1-opt-mysql
      
      
      mysql-test/t/view.test:
        Auto merged
      sql/item.cc:
        Auto merged
      00f0f920
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · 5f10ffd0
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1
      
      
      include/mysql_com.h:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_repl.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/sp.cc:
        manual merge
      sql/sp_head.cc:
        manual merge
      sql/sql_class.h:
        manual merge
      sql/table.cc:
        manual merge
      5f10ffd0
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-5.1 · 802800b6
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.1-opt
      
      
      sql/field.h:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      802800b6
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt · d30536dc
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      d30536dc
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-5.0 · 70255e85
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      70255e85
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-4.1 · b8fe6206
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      b8fe6206
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.1 · 2d48a1f2
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/5.1-runtime-new
      
      
      sql/handler.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      mysql-test/r/sp.result:
        manual merge
      mysql-test/t/sp.test:
        manual merge
      storage/csv/ha_tina.cc:
        manual merge
      storage/myisam/ha_myisam.cc:
        manual merge
      2d48a1f2
  3. 27 Sep, 2006 12 commits
    • unknown's avatar
      additional 'after merge' fix · c316933e
      unknown authored
      c316933e
    • unknown's avatar
      merge fixes 5.0-opt -> 5.1-opt · b828758a
      unknown authored
      b828758a
    • unknown's avatar
      after merge fix · c1e264a5
      unknown authored
      c1e264a5
    • unknown's avatar
      Remove unused error messages (no release contains them · ac4b6623
      unknown authored
      at the moment, so we can safely do that). Update an error
      mesage to make it translateable.
      
      
      mysql-test/r/log_tables.result:
        update result file
      sql/share/errmsg.txt:
        remove unused error messages
      sql/sql_table.cc:
        Use name of the statements rather then English words.
        This way error message is translateable.
      ac4b6623
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/4.1 · 6d77ba47
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0
      
      
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/table.cc:
        Auto merged
      include/mysql_com.h:
        manual merge
      mysql-test/r/ctype_utf8.result:
        manual merge
      mysql-test/t/ctype_utf8.test:
        manual merge
      sql/sql_acl.cc:
        manual merge
      6d77ba47
    • unknown's avatar
      Patch for bug#21432 is reverted · abd883f4
      unknown authored
      abd883f4
    • unknown's avatar
      b2b69607
    • unknown's avatar
      Merge macbook.gmz:/Users/kgeorge/mysql/work/B21174-5.0-opt · c689d424
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B21174-5.1-opt
      
      
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/group_by.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      mysql-test/t/ps.test:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/myisam/mi_check.c:
        Auto merged
      mysql-test/r/ps.result:
        merge 5.0-opt -> 5.1-opt
      sql/unireg.cc:
        merge 5.0-opt -> 5.1-opt
      c689d424
    • unknown's avatar
      Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX · ca5e2947
      unknown authored
       - reversed the patch for 5.0 and moved to 5.1
      
      
      mysql-test/r/group_by.result:
        Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX
         - reversed the patch for 5.0
      mysql-test/t/group_by.test:
        Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX
         - reversed the patch for 5.0
      sql/sql_select.cc:
        Bug #21174: Index degrades sort performance and optimizer does not honor IGNORE INDEX
         - reversed the patch for 5.0
      ca5e2947
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1 · 7c59445a
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug21414
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      mysql-test/r/sp.result:
        Manual merge.
      mysql-test/t/sp.test:
        Manual merge.
      7c59445a
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · c6af7ee1
      unknown authored
      into  mysql.com:/home/hf/work/mysql-5.0-mrg
      
      
      c6af7ee1
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1-opt · 2b59a97b
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.15428
      
      
      2b59a97b
  4. 26 Sep, 2006 5 commits
    • unknown's avatar
      Fixed bug #18360: Type aggregation for IN and CASE may lead to a wrong · c1bbfb2b
      unknown authored
      result
      
      The IN function aggregates result types of all expressions. It uses that 
      type in comparison of left expression and expressions in right part. 
      This approach works in most cases. But let's consider the case when the
      right part contains both strings and integers. In that case this approach may
      cause wrong results because all strings which do not start with a digit are
      evaluated as 0.
      CASE uses the same approach when a CASE expression is given thus it's also
      affected.
      
      The idea behind this fix is to make IN function to compare expressions with
      different result types differently. For example a string in the left
      part will be compared as string with strings specified in right part and
      will be converted to real for comparison to int or real items in the right
      part.
      
      A new function called collect_cmp_types() is added. It collects different
      result types for comparison of first item in the provided list with each 
      other item in the list. 
      
      The Item_func_in class now can refer up to 5 cmp_item objects: 1 for each
      result type for comparison purposes. cmp_item objects are allocated according
      to found result types. The comparison of the left expression with any
      right part expression is now based only on result types of these expressions.
      
      The Item_func_case class is modified in the similar way when a CASE
      expression is specified. Now it can allocate up to 5 cmp_item objects
      to compare CASE expression with WHEN expressions of different types.
      The comparison of the CASE expression with any WHEN expression now based only 
      on result types of these expressions.
      
      
      
      sql/item.cc:
        Cleaned up an outdated comment.
      sql/item_cmpfunc.cc:
            Fixed bug #18360: Type aggregation for IN and CASE may lead to a wrong result
            A new function called collect_cmp_types() is added. It collects different
            result types for comparison of first item in the provided list with each 
            other item in the list. 
            The Item_func_in class now can refer up to 5 cmp_item objects: 1 for each
            result type for comparison purposes. cmp_item objects are allocated according
            to found result types. The comparison of the left expression with any
            right part expression is now based only on result types of these expressions.
            The Item_func_case class is modified in the similar way when a CASE
            expression is specified. Now it can allocate up to 5 cmp_item objects
            to compare CASE expression with WHEN expressions of different types.
            The comparison of the CASE expression with any WHEN expression now based only 
            on result types of these expressions.
      sql/item_cmpfunc.h:
            Fixed bug#18360: Type aggregation for IN and CASE may lead to a wrong result
            The Item_func_in class now can refer up to 5 cmp_item objects.
            The Item_func_case class is modified in the similar way.
      sql/opt_range.cc:
            Fixed bug #18360: Type aggregation for IN and CASE may lead to a wrong
            resultSmall code changes due to changes in Item_func_in class.
      mysql-test/t/view.test:
        Added a test comment
      mysql-test/t/func_in.test:
        Added a test case for bug#18360: Type aggregation for IN and CASE may lead to a wrong
        result
      mysql-test/r/func_in.result:
        Added a test case for bug#18360: Type aggregation for IN and CASE may lead to a wrong
        result
      c1bbfb2b
    • unknown's avatar
      Added more tests of field conversions. · 5529b7fb
      unknown authored
      5529b7fb
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-runtime · 4e5b560d
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-runtime
      
      
      4e5b560d
    • unknown's avatar
      Fix for bug#20208 · 770e9b4b
      unknown authored
      A better fix for bug#10025.
      
      Fixed test case plus added new tests.
      
      After fixing Bug#20208 "Blobs greater than 8K are being truncated to 8K"
      the fix to bug#10025 "Misleading error with COLLATE mediumtext and UNION"
      became more accurate. Earlier mediumtext got converted to longtext,
      although mediumtext was enough to contain the results. Now it converts
      correctly to mediumtext, if the length does not exceed that and if none
      of the original fields were type longtext.
      
      Type longtext still converts correctly to type longtext, as the extra
      tests prove.
      
      
      mysql-test/r/union.result:
        Fixed an earlier test case plus added two new tests.
      mysql-test/t/union.test:
        Fixed an earlier test case plus added two new tests.
      770e9b4b
    • unknown's avatar
      Merge trift2.:/MySQL/M50/clone-5.0 · 3436f0ac
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      mysql-test/r/func_time.result:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/view.result:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/t/func_time.test:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/t/type_date.test:
        Auto merged
      mysql-test/t/view.test:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      sql/item_cmpfunc.cc:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      3436f0ac
  5. 25 Sep, 2006 3 commits
    • unknown's avatar
      Fix for bug#22662 Inconsistent values displayed for event_scheduler · 070c8e74
      unknown authored
      when set to DISABLED
        
      It was a silly ordering number error.
      
      
      
      sql/events.h:
        fix ordinal number, the cause for bug #22662
        Inconsistent values displayed for event_scheduler when set to DISABLED
      mysql-test/r/events_restart_phase0.result:
        New BitKeeper file ``mysql-test/r/events_restart_phase0.result''
      mysql-test/t/events_restart_phase0.log:
        New BitKeeper file ``mysql-test/t/events_restart_phase0.log''
      mysql-test/t/events_restart_phase0.result:
        New BitKeeper file ``mysql-test/t/events_restart_phase0.result''
      070c8e74
    • unknown's avatar
      Fix for bug#22397 Events: crash with procedure which alters events · 6c9400b9
      unknown authored
        
      ALTER EVENT in stored procedure body led to a crash during the
      procedure call. Affected was only ALTER EVENT which changed the
      interval of the event. No problems with AT, STARTS, ENDS and so on.
      
      
      
      mysql-test/r/events_bugs.result:
        fix result
      mysql-test/t/events_bugs.test:
        add test case for bug 22397 : Events, crash with procedure which alters body
      sql/event_data_objects.cc:
        fix copy&paste error in code, which resulted in bug#22397
        Events: crash with procedure which alters body
      6c9400b9
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0-opt · 78bf0287
      unknown authored
      into  rurik.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug21646
      
      
      78bf0287