1. 25 Jun, 2007 2 commits
  2. 23 Jun, 2007 1 commit
    • unknown's avatar
      Fix for BUG#29318 "Statements prepared with PREPARE and with one · 36320e71
      unknown authored
      parameter don't use query cache"
      Thanks to the fix of BUG#26842, statements prepared with SQL PREPARE
      and having parameters can now use the query cache.
      
      
      mysql-test/include/query_cache_sql_prepare.inc:
        now, statements prepared with SQL PREPARE use the query cache even
        when they have parameters.
      mysql-test/r/query_cache_ps_no_prot.result:
        updated result: we see caching happened.
      mysql-test/r/query_cache_ps_ps_prot.result:
        updated result: we see caching happened
      sql/sql_prepare.cc:
        query expansion does not insert user variables' references anymore,
        it now inserts parameters' values (BUG#26842's fix did this);
        so we can use the query cache.
      36320e71
  3. 22 Jun, 2007 19 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · e4fd17d1
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      e4fd17d1
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · 69755041
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      69755041
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 77825106
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      77825106
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · d77cd439
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      Makefile.am:
        Manual merge.
      d77cd439
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/50 · 828dddf1
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      828dddf1
    • unknown's avatar
      Add the "nist" suite to the "test-bt" target, · 21905996
      unknown authored
      to be run only if it is available on the machine.
      
      21905996
    • unknown's avatar
      Fix broken automatic dependency tracking of Automake in sql/: · 5aeca2ef
      unknown authored
      The embedded library is still broken, but there the situation
      with dependencies is even more broken.
      
      
      sql/Makefile.am:
        Fix broken automatic dependency tracking of Automake in sql/:
        use a convenience library to specify additional includes that
        are required to compile files ha_ndbcluster_*, and then
        add this convenience library to the main project.
        The embedded library is still broken, but there the situation
        with dependencies is even more broken.
      5aeca2ef
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug28846/my51-bug28846 · 77d7a92e
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      mysql-test/t/sp-error.test:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      77d7a92e
    • unknown's avatar
      Bug #28846 Use of undocumented Prepared Statements crashes server · 0f3f32d1
      unknown authored
      - Manual merge patch.
      
      
      sql/sql_yacc.yy:
        Corrected merge error. ALTER VIEW rules has been split in two and both
        rules need to be checked for SP-context.
      0f3f32d1
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug28846/my50-bug28846 · 05ef7ddb
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug28846/my51-bug28846
      
      
      mysql-test/r/ps_1general.result:
        Auto merged
      mysql-test/r/sp-dynamic.result:
        Auto merged
      mysql-test/r/sp-error.result:
        Auto merged
      mysql-test/t/ps_1general.test:
        Auto merged
      mysql-test/t/sp-error.test:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Manual merge 5.0->5.1
      05ef7ddb
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · dbcba7ce
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      dbcba7ce
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · 724baa97
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      724baa97
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 49dcd6ec
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      49dcd6ec
    • unknown's avatar
      Bug#28846 Use of undocumented Prepared Statements crashes server · 295803a1
      unknown authored
      ALTER VIEW is currently not supported as a prepared statement
      and should be disabled as such as they otherwise could cause server crashes.
      
      ALTER VIEW is currently not supported when called from stored
      procedures or functions for related reasons and should also be disabled.
      
      This patch disables these DDL statements and adjusts the appropriate test
      cases accordingly.
      
      Additional tests has been added to reflect on the fact that we do support
      CREATE/ALTER/DROP TABLE for Prepared Statements (PS), Stored Procedures (SP)
      and PS within SP.
      
      
      mysql-test/r/ps_1general.result:
        - Updated test to reflect on the new policy to disallow ALTER VIEW within SP.
      mysql-test/r/sp-dynamic.result:
        - Added PS ALTER TABLE test from within SP-context to demonstrate that CREATE/ALTER/DROP
        TABLE statements is working.
        - Added PS CREATE/ALTER/DROP VIEW tests from within SP-context to show that
        ALTER VIEW is not supported, CREATE VIEW/DROP VIEW are supported.
      mysql-test/r/sp-error.result:
        - Updated test to reflect on the new policy to disallow VIEW DDL within SP.
      mysql-test/t/ps_1general.test:
        - Updated test to reflect on the new policy to disallow VIEW DDL within SP.
      mysql-test/t/sp-dynamic.test:
        - Add PS ALTER TABLE test from within SP to demonstrate that CREATE/ALTER/DROP
        TABLE statements are supported.
      mysql-test/t/sp-error.test:
        - Updated test to reflect on the new policy to disallow ALTER VIEW
        within SP-context.
        - Changed error code 1314 to the more abstract ER_SP_BADSTATEMENT.
      sql/sql_class.h:
        - Added comment for clarity
      sql/sql_parse.cc:
        - Added comment for clarity
      sql/sql_prepare.cc:
        - Disallow ALTER VIEW as prepared statements until they are
          properly supported. Note that SQLCOM_CREATE_VIEW also handles ALTER VIEW
          statements.
      sql/sql_view.cc:
        - converted to doxygen comments
        - Added comment for clarity
      sql/sql_yacc.yy:
        - Disallow ALTER VIEW statements within a SP.
        If the parser is operating within the SP context, this is shown
        on the sp->sphead pointer. If this flag is set for view DDL operations
        we stop parsing with the error 'ER_SP_BAD_STATEMENT'.
      295803a1
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1-maint · 7382aa01
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      7382aa01
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 3300b8eb
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      3300b8eb
    • unknown's avatar
      binlog_innodb.result: · c6683f4e
      unknown authored
        post-merge fix
      
      
      mysql-test/r/binlog_innodb.result:
        post-merge fix
      c6683f4e
    • unknown's avatar
      Merge damien-katzs-computer.local:/Users/dkatz/50_kill · 310f44dd
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/mysql51
      
      
      mysql-test/r/kill.result:
        Auto merged
      mysql-test/t/kill.test:
        Auto merged
      storage/myisam/sort.c:
        Auto merged
      310f44dd
    • unknown's avatar
      Bug #29138 'kill' fails in pushbuild · 86ae7940
      unknown authored
      The reason the "reap;" succeeds unexpectedly is because the query was completing(almost always) and the network buffer was big enough to store the query result (sometimes) on Windows, meaning the response was completely sent before the server thread could be killed.
      
      Therefore we use a much longer running query that doesn't have a chance to fully complete before the reap happens, testing the kill properly.
      
      
      mysql-test/r/kill.result:
        We use a much longer running query that doesn't have a chance to fully complete before the reap happens.
      mysql-test/t/kill.test:
        We use a much longer running query that doesn't have a chance to fully complete before the reap happens.
      86ae7940
  4. 21 Jun, 2007 18 commits
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1 · 2326576b
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      2326576b
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1-rpl · a76e188e
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      include/m_ctype.h:
        Auto merged
      mysql-test/Makefile.am:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/r/rpl_ssl.result:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/t/multi_update.test:
        Auto merged
      mysql-test/t/rpl_row_until.test:
        Auto merged
      mysql-test/t/rpl_ssl.test:
        Auto merged
      mysql-test/t/rpl_stm_until.test:
        Auto merged
      mysys/charset-def.c:
        Auto merged
      mysys/charset.c:
        Auto merged
      sql/item_create.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      strings/ctype-big5.c:
        Auto merged
      strings/ctype-gbk.c:
        Auto merged
      strings/ctype-sjis.c:
        Auto merged
      strings/ctype-uca.c:
        Auto merged
      strings/ctype.c:
        Auto merged
      BitKeeper/deleted/.del-binlog_innodb.result:
        Delete: mysql-test/r/binlog_innodb.result
      BitKeeper/deleted/.del-binlog_innodb.test:
        Delete: mysql-test/t/binlog_innodb.test
      mysql-test/r/binlog_innodb.result:
        Fix merge of two independent binlog_innodb tests (from -rpl and -maint)
      mysql-test/t/binlog_innodb.test:
        Fix merge of two independent binlog_innodb tests (from -rpl and -maint)
      mysql-test/r/innodb.result:
        Use local (manual merge)
      mysql-test/r/multi_update.result:
        Use remote (manual merge)
      mysql-test/t/rpl_log_pos.test:
        Manual merge
      mysql-test/r/rpl_log_pos.result:
        Manual merge, part 2
      a76e188e
    • unknown's avatar
      58faadd6
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/50 · 709b1b59
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      configure.in:
        Auto merged
      include/m_ctype.h:
        Auto merged
      mysql-test/Makefile.am:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysys/charset-def.c:
        Auto merged
      mysys/charset.c:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      strings/ctype-big5.c:
        Auto merged
      strings/ctype-gbk.c:
        Auto merged
      strings/ctype-sjis.c:
        Auto merged
      strings/ctype-uca.c:
        Auto merged
      strings/ctype.c:
        Auto merged
      mysql-test/r/innodb.result:
        Manual merge
      mysql-test/r/multi_update.result:
        Manual merge
      mysql-test/t/multi_update.test:
        Manual merge
      sql/sql_update.cc:
        SCCS merged
      709b1b59
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/41 · 839c07db
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      839c07db
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 6367bd2a
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/r/innodb.result:
        Manual merge
      6367bd2a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1-rpl · 42247162
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/41
      
      42247162
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/51 · b3b9ea8a
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      configure.in:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/query_cache.result:
        SCCS merged
      b3b9ea8a
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-maint · f763728b
      unknown authored
      into  amd64.(none):/src/bug27029/my51-bug27029
      
      
      storage/myisam/sort.c:
        Auto merged
      f763728b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · d3662296
      unknown authored
      into  amd64.(none):/src/bug27029/my50-bug27029
      
      
      myisam/sort.c:
        Auto merged
      d3662296
    • unknown's avatar
      Merge amd64.(none):/src/bug27029/my50-bug27029 · 14c0e451
      unknown authored
      into  amd64.(none):/src/bug27029/my51-bug27029
      
      
      storage/myisam/sort.c:
        Auto merged
      14c0e451
    • unknown's avatar
      Bug#27029 alter table ... enable keys crashes mysqld on large table · 8d27f335
      unknown authored
      - When creating an index for the sort, the number of rows plus 1 is used 
      to allocate a buffer.  In this test case, the number of rows 4294967295 
      is the max value of an unsigned integer, so when 1 was added to it, a 
      buffer of size 0 was allocated causing the crash.
      - Create new test suite for this bug's test suite as per QA.
      
      
      myisam/sort.c:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - Check to make sure the value of records is < UINT_MAX32 to avoid a 
        false positive on the remaining condition.
      mysql-test/suite/large_tests/README.TXT:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - New testsuite for large tests.
        - Added mtr hint for potential testers.
      mysql-test/suite/large_tests/r/alter_table.result:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - New testsuite for large tests.
        - Added results for bug.
      mysql-test/suite/large_tests/t/alter_table.test:
        Bug#27029 alter table ... enable keys crashes mysqld on large table
        - New testsuite for large tests.
        - Added test for bug.
      8d27f335
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 6c70aa11
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      configure.in:
        Auto merged
      6c70aa11
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bk/mysql-5.0-rpl · 0d5196ce
      unknown authored
      into  mysql.com:/nfsdisk1/lars/bk/mysql-5.1-new-rpl
      
      0d5196ce
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bk/mysql-5.1 · a24060d7
      unknown authored
      into  mysql.com:/nfsdisk1/lars/bk/mysql-5.1-new-rpl
      
      
      mysql-test/t/disabled.def:
        Auto merged
      mysql-test/t/ndb_index_ordered.test:
        Auto merged
      mysys/charset.c:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      a24060d7
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bk/mysql-5.0 · 9dfd4335
      unknown authored
      into  mysql.com:/nfsdisk1/lars/bk/mysql-5.0-rpl
      
      9dfd4335
    • unknown's avatar
      merge rpl 5.0->5.1 · e7848c84
      unknown authored
      e7848c84
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bk/mysql-5.0-rpl · 80e7ffde
      unknown authored
      into  mysql.com:/nfsdisk1/lars/bk/mysql-5.1-new-rpl
      
      
      sql/sql_acl.cc:
        Auto merged
      80e7ffde