1. 25 Nov, 2009 7 commits
  2. 24 Nov, 2009 6 commits
  3. 23 Nov, 2009 7 commits
  4. 22 Nov, 2009 1 commit
    • unknown's avatar
      Bug #48350 truncate temporary table crashes replication · a2ed6829
      unknown authored
      In RBR, All statements operating on temporary tables should not be binlogged.
      Despite this fact, after executing 'TRUNCATE... ' on a temporary table, 
      the command is still logged, even if in row-based mode. Consequently, this raises
      problems in the slave as the table may not exist, resulting in an
      execution failure. Ultimately, this causes the slave to report
      an error and abort.
      
      After this patch, 'TRUNCATE ...' statement on a temporary table will not be
      binlogged in RBR.
      a2ed6829
  5. 21 Nov, 2009 3 commits
    • Alfranio Correia's avatar
      897d87f6
    • Davi Arnaut's avatar
      64f097dc
    • Davi Arnaut's avatar
      Bug#41726: upgrade from 5.0 to 5.1.30 crashes if you didn't run mysql_upgrade · c70a9fa1
      Davi Arnaut authored
      The problem is that the server could crash when attempting
      to access a non-conformant proc system table. One such case
      was a crash when invoking stored procedure related statements
      on a 5.1 server with a proc system table in the 5.0 format.
      
      The solution is to validate the proc system table format
      before attempts to access it are made. If the table is not
      in the format that the server expects, a message is written
      to the error log and the statement that caused the table to
      be accessed fails.
      
      mysql-test/r/sp-destruct.result:
        Add test case result for Bug#41726
      mysql-test/t/sp-destruct.test:
        Add test case for Bug#41726
      sql/event_db_repository.cc:
        Update code to use new structures.
      sql/sp.cc:
        Describe the proc table format and use it to validate when
        opening a instance of the table.
        Add a check to insure that a error message is written to
        the error log only once.
      sql/sql_acl.cc:
        Remove unused variable and use new structure.
      sql/sql_acl.h:
        Export field definition.
      sql/table.cc:
        Accept the field count and definition in a single structure.
      sql/table.h:
        Combine the field count and definition in a single structure.
        Transform function into a class in order to support different
        ways of reporting a error.
        Add a pointer cache to TABLE_SHARE.
      c70a9fa1
  6. 20 Nov, 2009 13 commits
    • Kristofer Pettersson's avatar
      merge · f9af124e
      Kristofer Pettersson authored
      f9af124e
    • Kristofer Pettersson's avatar
      automerge · 3596983d
      Kristofer Pettersson authored
      3596983d
    • Kristofer Pettersson's avatar
      Bug#45613 handle failures from my_hash_insert · 0a686030
      Kristofer Pettersson authored
      Not all my_hash_insert() calls are checked for return value.
      
      This patch adds appropriate checks and failure responses
      where needed.
      
      
      mysys/hash.c:
        * Debug hook for testing failures in my_hash_insert()
      0a686030
    • Georgi Kodinov's avatar
      merge · 5bf2a5c3
      Georgi Kodinov authored
      5bf2a5c3
    • Georgi Kodinov's avatar
      merge · 2961cf67
      Georgi Kodinov authored
      2961cf67
    • Georgi Kodinov's avatar
      merge · 02938963
      Georgi Kodinov authored
      02938963
    • Vladislav Vaintroub's avatar
      merge · ff3b4245
      Vladislav Vaintroub authored
      ff3b4245
    • Kristofer Pettersson's avatar
      automerge · 5181325c
      Kristofer Pettersson authored
      5181325c
    • Kristofer Pettersson's avatar
      Bug#39253 Large query cache still freezes server after fix for bug #21074 · 41085809
      Kristofer Pettersson authored
      This patch introduce a limit on the time the query cache can
      block with a lock on SELECTs.
      
      Other operations which causes a change in the table
      data will still be blocked.
      
      
      sql/sql_cache.cc:
        * Introduced a timeout value for the qc lock when entering send_result_to_client()
        and store_query() methods.
      sql/sql_cache.h:
        * New signature for Query_cache::try_lock()
      41085809
    • Georgi Kodinov's avatar
      merge · 0927bb74
      Georgi Kodinov authored
      0927bb74
    • Vladislav Vaintroub's avatar
      Bug#47571 : idle named pipe connection is unkillable · 26a37b36
      Vladislav Vaintroub authored
      implement Davi's review suggestions (post-push fixes)
      
      
      include/violite.h:
        Use official abbreviation for milliseconds (ms)
      sql/mysqld.cc:
        Fix formatting
        Add error handling for the case of CreateEvent error
      vio/vio.c:
        Use official abbreviation for milliseconds(ms)
        Remove superfluous memset
        Fix formatting
      vio/viosocket.c:
        Use official abbreviation for milliseconds (ms)
        Use size_t  datatype instead of int in pipe_complete_io
      26a37b36
    • Georgi Kodinov's avatar
      merge · a889a833
      Georgi Kodinov authored
      a889a833
    • Georgi Kodinov's avatar
      Bug #45261 : Crash, stored procedure + decimal · a21cd97c
      Georgi Kodinov authored
      Bug #48370  Absolutely wrong calculations with GROUP BY and
        decimal fields when using IF
      
      Added the test cases in the above two bugs for regression
      testing.
      Added additional tests that demonstrate a incomplete fix.
      Added a new factory method for Field_new_decimal to 
      create a field from an (decimal returning) Item.
      In the new method made sure that all the precision and 
      length variables are capped in a proper way. 
      This is required because Item's can have larger precision
      than the decimal fields and thus need to be capped when
      creating a field based on an Item type.
      Fixed the wrong typecast to Item_decimal.
      a21cd97c
  7. 19 Nov, 2009 2 commits
    • Christopher Powers's avatar
      Bug #48739 MySQL crashes on specific INTERVAL in select query · c74609b1
      Christopher Powers authored
      Fixed crash caused by x64 int/long incompatibility introduced
      in Bug #29125.
      
      sql/item_timefunc.cc:
        Fixed crash caused by int/long incompatibility on x64 systems.
        
        Changed two "uint" casts and a "long" declartion to "int" in order to
        ensure that the integer sign is preserved.
        
        See Bug #48739 for details.
      c74609b1
    • Georgi Kodinov's avatar
      Bug #48665: sql-bench's insert test fails due to wrong result · 405c9310
      Georgi Kodinov authored
      When merging ranges during calculation of the result of OR
      to two range sets the current range may be obsoleted by the 
      resulting merged range.
      The first overlapping range can be obsoleted as well.
      
      Fixed by moving the pointer to the first overlapping range to the
      pointer of the resulting union range.
      Added few comments at key places in key_or().
      405c9310
  8. 18 Nov, 2009 1 commit
    • Georgi Kodinov's avatar
      Bug#48864: MySQL fails to compile on 64 bit Fedora 12 · ed9e3409
      Georgi Kodinov authored
      Fixed 2 errors in comp_err executable : 
      1. Wrong (off by 1) length passed to my_checksum()
      2. strmov() was used on overlapping strings. This is
       not legal according to the docs in stpcpy(). Used 
      the overlap safe memmove() instead.
      ed9e3409