1. 29 Aug, 2004 1 commit
    • unknown's avatar
      Fix for BUG#4500 "set character set replicates incorrectly" · 804238d3
      unknown authored
      We must not reset the charset in slave after each statement, otherwise the SET CHARACTER SET is cancelled immediately.
      Instead, we write a SET CHARACTER SET DEFAULT to the master's binlog when needed (like we already do for SET FOREIGN_KEY_CHECKS);
      such writing is not necessary in 4.1 (in 4.1 the bug does not exist, as the SET ONE_SHOT syntax is used).
      I have written a test and it works, but I'm not pushing the test as it requires building with all charsets.
      I have noticed differences between what is inserted in the master's table in 4.0 and 4.1, and alerted Bar.
      
      
      sql/log.cc:
        When SET CHARACTER SET has been used, we must reset the charset after the writing the statement, in the binlog.
        In 4.1, this resetting is already achieved by the SET ONE_SHOT syntax.
      sql/log_event.cc:
        In slave, we must not simply reset the charset after each statement: if we do this, the charset gets
        immediately after executing the SET CHARACTER SET! (BUG#4500).
      804238d3
  2. 27 Aug, 2004 3 commits
    • unknown's avatar
      Compile all charset conversion tables if --with-extra-charsets=all · 2fddfe2f
      unknown authored
      or --with-extra-charsets=complex is given.
      
      2fddfe2f
    • unknown's avatar
      table.cc: · 4b5953b9
      unknown authored
        Bug #4558 Escape handling error for ENUM values in SJIS encoding
      
      
      sql/table.cc:
        Bug #4558 Escape handling error for ENUM values in SJIS encoding
      4b5953b9
    • unknown's avatar
      win1251.conf: · 33b9755d
      unknown authored
        Wrong UPPER/LOWER translation for Cyrillic letter tse was fixed.
        bug#5110
      
      
      sql/share/charsets/win1251.conf:
        Wrong UPPER/LOWER translation for Cyrillic letter tse was fixed.
        bug#5110
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      33b9755d
  3. 26 Aug, 2004 9 commits
  4. 25 Aug, 2004 6 commits
    • unknown's avatar
      merge · 7c0a7b2d
      unknown authored
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      mysql-test/mysql-test-run.sh:
        merge (use new code)
      7c0a7b2d
    • unknown's avatar
      Remove default argument to mysql_truncate() · 7586eae8
      unknown authored
      Update to new valgrind
      
      
      mysql-test/mysql-test-run.sh:
        Update for new valgrind
      sql/mysql_priv.h:
        Remove default argument to mysql_truncate()
      sql/sql_parse.cc:
        Remove default argument to mysql_truncate()
      7586eae8
    • unknown's avatar
      Test case for Bug #4792 lower_case_table_names does not resolve db.tbl.column in SELECT list · 81798982
      unknown authored
      lowercase_table.result:
        New results for modified lowercase_table test
      lowercase_table.test:
        Added test case for all uppercase database when running under lower_case_table_names.  This really only failed under Windows.  Bug# 4792
      
      
      mysql-test/t/lowercase_table.test:
        Added test case for all uppercase database when running under lower_case_table_names.  This really only failed under Windows.  Bug# 4792
      mysql-test/r/lowercase_table.result:
        New results for modified lowercase_table test
      81798982
    • unknown's avatar
      Bug #4792 lower_case_table_names does not resolve db.tbl.column in SELECT list · 32fd1ca1
      unknown authored
      sql_base.cc:
        Added code to lowercase database name in insert_fields when lower_case_table_names=1. This fixes bug# 4792
      
      
      sql/sql_base.cc:
        Added code to lowercase database name in insert_fields when lower_case_table_names=1. This fixes bug# 4792
      32fd1ca1
    • unknown's avatar
      Adding binary version information for debug/release version of libmysqld.dll · 83d20542
      unknown authored
      This was a customer request for to get the XP Logo Certification.
      
      Note for LenZ:
      Adding to the project libmysqld.dsp the file libmysqld.rc at compilation time will be created
      the libmysqld.res and this linked. For every release edit the libmysqld.rc
      version number.
      
      83d20542
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · cc54eba4
      unknown authored
      into build.mysql.com:/users/rburnett/mysql-4.0
      
      
      BitKeeper/etc/logging_ok:
        auto-union
      client/mysql.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      cc54eba4
  5. 24 Aug, 2004 6 commits
    • unknown's avatar
      buf0rea.c: · abfdace0
      unknown authored
        Fix bug: if there was little file I/O in InnoDB, but the insert buffer was used, it could happen that 'Pending normal aio reads' was bigger than 0, but the I/O handler thread did not get waken up in 600 seconds. This resulted in a hang, and crashing of InnoDB.
      
      
      innobase/buf/buf0rea.c:
        Fix bug: if there was little file I/O in InnoDB, but the insert buffer was used, it could happen that 'Pending normal aio reads' was bigger than 0, but the I/O handler thread did not get waken up in 600 seconds. This resulted in a hang, and crashing of InnoDB.
      abfdace0
    • unknown's avatar
      All 'Makefile's must use '$(AR)' (not just 'ar') because the variable may contain options. · f3f69563
      unknown authored
      
      libmysqld/Makefile.am:
        Always use 'make' variable '$(AR)' so that options (AIX 64 bit!) are included.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      f3f69563
    • unknown's avatar
      Fix warning VC++ and fix applied fisrt to source 4.1 · 009fcf12
      unknown authored
      
      mysys/my_lib.c:
        Same fix for bug #4737 that wrongly I did first on tree 4.1
      mysys/my_vsnprintf.c:
        Fix VC++ warning assuming that my_vsnprintf() is external
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      009fcf12
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-4.0 · 51f3953a
      unknown authored
      into gluh.mysql.r18.ru:/home/gluh/MySQL-BUGS/mysql-4.0
      
      51f3953a
    • unknown's avatar
      Fix for bug #4340: find_in_set is case insensitive even on binary operators(2nd version) · 1868a53d
      unknown authored
      
      mysql-test/r/func_set.result:
        Fix for bug #4340: find_in_set is case insensitive even on binary operators
      mysql-test/t/func_set.test:
        Fix for bug #4340: find_in_set is case insensitive even on binary operators
      sql/item_func.cc:
        Fix for bug #4340: find_in_set is case insensitive even on binary operators
      1868a53d
    • unknown's avatar
      - make sure to recreate all autoconf/automake-related files after · 4fa7f9c2
      unknown authored
         modifying configure.in for the commercial tarballs
       - added my-innodb-heavy-4G.cnf to the distribution
      
      
      Build-tools/mysql-copyright:
         - make sure to recreate all autoconf/automake-related files after
           modifying configure.in
      support-files/Makefile.am:
         - added my-innodb-heavy-4G.cnf to the distribution
      4fa7f9c2
  6. 23 Aug, 2004 7 commits
  7. 22 Aug, 2004 3 commits
  8. 21 Aug, 2004 1 commit
    • unknown's avatar
      null.test, null.result: · b33b4c27
      unknown authored
        Added test case for bug #4256.
      join_outer.result:
        Fixed bug #4256.
      item_cmpfunc.h:
        Fixed inconsistency of values of used_tables_cache and
        const_item_cache for Item_func_isnull objects.
        This inconsistency caused bug #4256.
      
      
      sql/item_cmpfunc.h:
        Fixed inconsistency of values of used_tables_cache and
        const_item_cache for Item_func_isnull objects.
        This inconsistency caused bug #4256.
      mysql-test/r/join_outer.result:
        Fixed bug #4256.
      mysql-test/r/null.result:
        Added test case for bug #4256.
      mysql-test/t/null.test:
        Added test case for bug #4256.
      b33b4c27
  9. 20 Aug, 2004 3 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 8003fee8
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      8003fee8
    • unknown's avatar
      Making FLUSH TABLES WITH READ LOCK block COMMITs of existing transactions, · 79b2593f
      unknown authored
      in a deadlock-free manner. This splits locking the global read lock in two steps.
      This fixes a consequence of this bug, known as:
      BUG#4953 'mysqldump --master-data may report incorrect binlog position if using InnoDB'
      And a test.
      
      
      sql/handler.cc:
        making COMMIT wait if FLUSH TABLES WITH READ LOCK happened.
      sql/lock.cc:
        an additional stage so that FLUSH TABLES WITH READ LOCK blocks COMMIT:
        make_global_read_lock_block_commit():
        taking the global read lock is TWO steps (2nd step is optional; without
        it, COMMIT of existing transactions will be allowed):
        lock_global_read_lock() THEN make_global_read_lock_block_commit().
      sql/mysql_priv.h:
        new argument to wait_if_global_read_lock()
      sql/sql_class.h:
        THD::global_read_lock now an uint to reflect the 2 steps of global read lock (does not block COMMIT / does)
      sql/sql_db.cc:
        update for new prototype
      sql/sql_parse.cc:
        implementing the two steps of global read lock so that FLUSH TABLES WITH READ LOCK can block COMMIT without deadlocking with COMMITs.
      79b2593f
    • unknown's avatar
      A fix (bug #5115: Erronious Syntax Error when comment placed inside of "create table") · 80ef38c7
      unknown authored
      
      client/mysql.cc:
        in_comment is now outside the add_line().
      80ef38c7
  10. 19 Aug, 2004 1 commit