1. 06 Jul, 2006 1 commit
    • unknown's avatar
      Behaviour change of mysql-test-run.pl: · 81bb604c
      unknown authored
      by default we never run disabled tests (even if they're
      explicitely listed on the command-line). We add an option --enable-disabled
      which will run tests even though they are disabled, and will print, for each
      such test, the comment explaining why it was disabled.
      The reason for the change is when you want to run "all tests which are about
      NDB" for example: mysql-test-run.pl t/*ndb*.test used to run some disabled
      NDB tests, causing failures, causing investigations.
      Code amended and approved by Kent.
      
      
      mysql-test/lib/mtr_cases.pl:
        always detect if a test is listed as disabled, and read the comment why is is.
        If it is listed, don't run the test, except if
        --enable-disabled was given, then mark the test as to-run-even-
        though-it-is-listed-as-disabled.
      mysql-test/lib/mtr_report.pl:
        Report tests which will run though they are listed as disabled
        (does something only if --enable-disabled).
      mysql-test/mysql-test-run.pl:
        New behaviour: by default we never run disabled tests (even if they're
        explicitely listed on the command-line). We add an option --enable-disabled
        which will run tests even though they are disabled, and will print, for each
        such test, the comment explaining why it was disabled.
      81bb604c
  2. 20 Jun, 2006 1 commit
    • unknown's avatar
      Fix for BUG#20522 "RBR: CREATE TEMPORARY TABLE SELECT writes to binlog · 339deb0c
      unknown authored
      though unneeded". It's indeed unneeded, as slave is only interested in
      permanent tables, and permanent tables don't depend on temporary tables
      when in row-based binlogging mode. And other CREATE TEMPORARY TABLE
      (referring no table or with LIKE) already don't write the CREATE to
      binlog in row-based mode. 
      
      
      mysql-test/r/rpl_row_create_table.result:
        result update (note that no lines appear in SHOW BINLOG EVENTS further below, which is how we
        see the bug is fixed)
      mysql-test/t/rpl_row_create_table.test:
        testing if a CREATE TEMPORARY TABLE SELECT goes to binlog (it should not)
        when in row-based binlogging mode. A few lines after, there is a SHOW
        BINLOG EVENTS; before the bugfix it showed the CREATE TEMPORARY TABLE.
      sql/sql_class.h:
        a method to access select_create::create_info from outside of select_create
        ("read-only" access). Making get_thd() "read-only" too.
      sql/sql_insert.cc:
        The function (hook) which writes CREATE TABLE to binlog when in row-based
        binlogging mode, for CREATE TABLE SELECT, now does nothing if the table
        is temporary (as in row-based mode, temp tables are not replicated).
        This is consistent with CREATE TEMPORARY TABLE LIKE and
        CREATE TEMPORARY TABLE, which don't write any CREATE to binlog in row-based
        mode.
      339deb0c
  3. 19 Jun, 2006 8 commits
  4. 18 Jun, 2006 1 commit
    • unknown's avatar
      Manually merged · 610b1a4e
      unknown authored
      
      configure.in:
        Auto merged
      client/mysqlbinlog.cc:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/archive.result:
        Auto merged
      mysql-test/r/auto_increment.result:
        Auto merged
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/multi_update.result:
        Auto merged
      mysql-test/r/ndb_lock.result:
        Auto merged
      mysql-test/r/replace.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      mysql-test/t/archive.test:
        Auto merged
      mysql-test/t/auto_increment.test:
        Auto merged
      mysql-test/t/delayed.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/multi_update.test:
        Auto merged
      mysql-test/t/ndb_lock.test:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/structs.h:
        Auto merged
      storage/archive/ha_archive.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      610b1a4e
  5. 17 Jun, 2006 6 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 60a9c875
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.1
      
      
      60a9c875
    • unknown's avatar
      atomic ops: · d1fb2922
      unknown authored
          my_atomic_XX_t -> intXX, no implicit locking anymore
          simplified framework, support for requested cleanups
      
      
      dbug/dbug.c:
        compiler warning
      include/atomic/nolock.h:
        my_atomic_XX_t -> intXX
      include/atomic/rwlock.h:
        my_atomic_XX_t -> intXX, no implicit locking anymore
      include/atomic/x86-gcc.h:
        my_atomic_XX_t -> intXX, no implicit locking anymore
      include/atomic/x86-msvc.h:
        my_atomic_XX_t -> intXX
        simplified defines
        support for cleanups
      include/my_atomic.h:
        my_atomic_XX_t -> intXX, no implicit locking anymore
        simplified framework, support for requested cleanups
      unittest/examples/no_plan-t.c:
        compiler warning
      unittest/mysys/Makefile.am:
        fix for dependencies
      unittest/mysys/my_atomic-t.c:
        my_atomic_XX_t -> intXX, no implicit locking anymore
      unittest/mytap/tap.c:
        cosmetic fix
      d1fb2922
    • unknown's avatar
      ndb - bug#19285 post merge 5.0->5.1 fix (error codes) · 4f36bb01
      unknown authored
      
      storage/ndb/src/ndbapi/ndberror.c:
        postmerge fix
      4f36bb01
    • unknown's avatar
      Merge clam.ndb.mysql.com:/space/pekka/ndb/version/my50-bug19285 · 03c6f8cb
      unknown authored
      into  clam.ndb.mysql.com:/space/pekka/ndb/version/my51-bug19285
      
      
      storage/ndb/src/ndbapi/NdbBlob.cpp:
        SCCS merged
      storage/ndb/src/ndbapi/ndberror.c:
        use local
      03c6f8cb
    • unknown's avatar
      ndb - bug#19285 minor fixes · 76d2ecea
      unknown authored
      
      ndb/src/ndbapi/NdbBlob.cpp:
        bug#19285 minor fixes
      ndb/src/ndbapi/ndberror.c:
        bug#19285 minor fixes
      76d2ecea
    • unknown's avatar
      Merge clam.ndb.mysql.com:/space/pekka/ndb/version/my50-bug19285 · 6e0cdd89
      unknown authored
      into  clam.ndb.mysql.com:/space/pekka/ndb/version/my51-bug19285
      
      
      storage/ndb/include/ndbapi/NdbBlob.hpp:
        manual merge
      storage/ndb/include/ndbapi/NdbScanOperation.hpp:
        SCCS merged
      storage/ndb/src/ndbapi/NdbBlob.cpp:
        SCCS merged
      storage/ndb/src/ndbapi/NdbBlobImpl.hpp:
        manual merge
      storage/ndb/src/ndbapi/ndberror.c:
        use local - add 4275 afterwards
      storage/ndb/test/ndbapi/testBlobs.cpp:
        automerge
      6e0cdd89
  6. 16 Jun, 2006 23 commits
    • unknown's avatar
      Merge moonbone.local:/work/tmp_merge-5.0 · 9ec3f63f
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      configure.in:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/archive.result:
        Auto merged
      mysql-test/r/auto_increment.result:
        Auto merged
      mysql-test/r/ndb_lock.result:
        Auto merged
      mysql-test/r/rpl_log.result:
        Auto merged
      mysql-test/t/archive.test:
        Auto merged
      mysql-test/t/auto_increment.test:
        Auto merged
      mysql-test/t/ndb_lock.test:
        Auto merged
      mysql-test/t/rpl_log.test:
        Auto merged
      sql/ha_archive.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      9ec3f63f
    • unknown's avatar
      Manually merged · 9d3ddf38
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/archive.result:
        Auto merged
      mysql-test/r/auto_increment.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/ndb_lock.result:
        Auto merged
      mysql-test/r/rpl_log.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/archive.test:
        Auto merged
      mysql-test/t/auto_increment.test:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/ndb_lock.test:
        Auto merged
      mysql-test/t/rpl_log.test:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      9d3ddf38
    • unknown's avatar
      select.result: · 60d55cc5
      unknown authored
        After merge fix
      
      
      mysql-test/r/select.result:
        After merge fix
      60d55cc5
    • unknown's avatar
      Manually merged · d0f39b6a
      unknown authored
      
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      d0f39b6a
    • unknown's avatar
      Merge moonbone.local:/home/evgen/bk-trees/mysql-4.1-opt · 707de39a
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      707de39a
    • unknown's avatar
      Manually merged · de292d67
      unknown authored
      
      configure.in:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/item_timefunc.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      de292d67
    • unknown's avatar
      item_strfunc.cc: · ca22a81b
      unknown authored
        Fix for bug#16716 for --ps-protocol mode.
      item_cmpfunc.cc:
        Fix for a memory allocation/freeing problem in agg_cmp_type() after fix
      for bug#16377. Few language corrections.
      
      
      sql/item_cmpfunc.cc:
        Fix for a memory allocation/freeing problem in agg_cmp_type(). Few language corrections.
      sql/item_strfunc.cc:
        Fix for bug#16716 for --ps-protocol mode.
      ca22a81b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 0d8d39c8
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/m51
      
      
      sql/log.cc:
        Auto merged
      0d8d39c8
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · a245f597
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/m51
      
      
      a245f597
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.1 · 1e56f376
      unknown authored
      into  mysql.com:/home/cps/mysql/devel/5.1-csv-remove-mmap
      
      
      1e56f376
    • unknown's avatar
      Merge mronstrom@bk-internal.mysql.com:/home/bk/mysql-5.1 · 9479462b
      unknown authored
      into  c-0409e253.1238-1-64736c10.cust.bredbandsbolaget.se:/home/pappa/mysql-5.1-fix
      
      
      9479462b
    • unknown's avatar
      9224719d
    • unknown's avatar
      remove wrong assert · 6f160532
      unknown authored
      6f160532
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 1a7be737
      unknown authored
      into  mysql.com:/Users/emurphy/src/mysql/clean/mysql-5.1
      
      
      1a7be737
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/main · 9addb8fd
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.1/main
      
      
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      9addb8fd
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/merge-queue · 70cf8240
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.0/main
      
      
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      70cf8240
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/merge-queue · ee1969d2
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.1/main
      
      
      storage/ndb/include/mgmapi/mgmapi.h:
        Auto merged
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Auto merged
      storage/ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      storage/ndb/src/mgmsrv/Services.hpp:
        Auto merged
      ee1969d2
    • unknown's avatar
      String::set(double) and set(longlong) -> set_real() and set_int() · 0237d9b0
      unknown authored
      fix Field::store(double) being used instead of store(longlong)
      
      NB: overloading functions is evil
      
      
      0237d9b0
    • unknown's avatar
      after-merge fixes. · dd285aac
      unknown authored
      
      mysql-test/r/rpl_log.result:
        after-merge fix.
      sql/ha_archive.cc:
        after-merge fix.
      sql/item_func.cc:
        after-merge fix.
      sql/sql_class.cc:
        after-merge fix.
      sql/sql_class.h:
        after-merge fix.
      dd285aac
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/main · 61f4440c
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.1/main
      
      
      mysql-test/r/ndb_condition_pushdown.result:
        Auto merged
      mysql-test/r/type_newdecimal.result:
        Auto merged
      mysql-test/r/view_grant.result:
        Auto merged
      mysql-test/t/ndb_condition_pushdown.test:
        Auto merged
      mysql-test/t/type_newdecimal.test:
        Auto merged
      mysql-test/t/view_grant.test:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      mysql-test/valgrind.supp:
        Manual merge
      61f4440c
    • unknown's avatar
      Bug#18775 - Temporary table from alter table visible to other threads · 1b1cb63d
      unknown authored
      The intermediate (not temporary) files of the new table
      during ALTER TABLE was visible for SHOW TABLES. These
      intermediate files are copies of the original table with
      the changes done by ALTER TABLE. After all the data is
      copied over from the original table, these files are renamed 
      to the original tables file names. So they are not temporary 
      files. They persist after ALTER TABLE, but just with another 
      name.
      
      Normal GRANT checking takes place for the intermediate table.
      Everyone who can see the original table (and hence the final
      table) can also see the intermediate table. But noone else.
      
      In 5.0 the intermediate files are invisible for SHOW TABLES
      because all file names beginning with "#sql" were suppressed.
      In 5.1 temporary files are created in TMPDIR, so that they
      don't appear in the database directories. Also in 5.1 a
      translation between table names and file names is done. The
      tmp_file_prefix on file level is now "@0023sql".
      
      The suppression of files starting with tmp_file_prefix is
      still in place, but still only files beginning with "#sql"
      were suppressed.
      
      I do now translate tmp_file_prefix from table name to file
      name before comparing it with the files in a directory.
      This suppresses the intermediate files again.
      
      No test case. The test case looks so that a reasonable big
      table is altered while a second thread runs SHOW TABLES.
      This in itself would be possible to do, but on slow machines
      it would add too much time to the test suite, while on fast
      machines the ALTER TABLE might have finished before SHOW
      TABLES looks at the directory. Even if there might be a good
      balance for todays machines, one day the test would become
      void as the intermediate table would not be seen even with
      the bug in place. I added a test script to the bug report.
      It can easily be changed so that it uses a table size that
      is appropriate for the test machine.
      
      
      sql/sql_show.cc:
        Bug#18775 - Temporary table from alter table visible to other threads
        Translating tmp_file_prefix to filename before comparison.
      1b1cb63d
    • unknown's avatar
      Merge mysql.com:/home/marty/MySQL/mysql-5.0 · 81284709
      unknown authored
      into  mysql.com:/home/marty/MySQL/mysql-5.1
      
      
      mysql-test/t/ndb_lock.test:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      storage/ndb/src/mgmsrv/Services.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Auto merged
      storage/ndb/src/ndbapi/NdbDictionaryImpl.hpp:
        Auto merged
      mysql-test/r/ndb_lock.result:
        Merge (using local)
      81284709
    • unknown's avatar
      Post_merges fixes. · b47705ab
      unknown authored
      b47705ab