1. 21 Sep, 2005 1 commit
    • unknown's avatar
      Bug #13231 mysqltest: fails to dectect when mysql_next_result fails · 83016f14
      unknown authored
       - Added functionality to check errors returned from mysql_next_result
       - Exit from mysqltest when and unexpected error occurs.
       - The above fixes reveal problems with rpl000009, sp-error and query_cache-
       - Fix sp-error by adding an expected error
       - Fix rpl000009 by not sending "ok" from mysql_create_db when called with silent flag from load_master_data
       - Fix query_cache in separate patch
      
      
      client/mysqltest.c:
        Check and handle error after mysql_next_result
        Change several verbose_msg to die so that the error is properly reported
        Clean up of error handling code in run_query_stmt, check all errors and use common
        function handle_error.
      mysql-test/r/mysqltest.result:
        mysqltest now dies when a query fails with wrong errno
      mysql-test/r/sp-error.result:
        Update test result to match the expected error from calling the sp closing a cursor that is not open.
      mysql-test/t/sp-error.test:
        Add missing --error 1326 before call to sp that closes a already closed cursor.
        Add test for bug9367
      sql/sql_db.cc:
        Don't send ok in mysql_create_db if silent flag is set.
      83016f14
  2. 15 Sep, 2005 7 commits
  3. 14 Sep, 2005 32 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 21607762
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-bg12704-2
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      21607762
    • unknown's avatar
      Fix for bug #12704 "Server crashes during trigger execution". · d8dea0bb
      unknown authored
      This bug occurs when some trigger for table used by DML statement is created
      or changed while statement was waiting in lock_tables(). In this situation
      prelocking set which we have calculated becames invalid which can easily lead
      to errors and even in some cases to crashes.
      
      With proposed patch we no longer silently reopen tables in lock_tables(),
      instead caller of lock_tables() becomes responsible for reopening tables and
      recalculation of prelocking set.
      
      
      mysql-test/t/trigger.test:
        Added tests for bug #12704 "Server crashes during trigger execution".
        Unfortunately these tests rely on the order in which tables are locked
        by statement so they are non-determenistic and therefore should be disabled.
      sql/lock.cc:
        mysql_lock_tables():
          Now instead of always reopening altered or dropped tables by itself
          mysql_lock_tables() can notify upper level and rely on caller doing this.
      sql/mysql_priv.h:
        Now mysql_lock_tables() can either reopen deleted or altered tables by itself
        or notify caller about such situation through 'need_reopen' argument and rely
        on it in this.
        Also lock_tables() has new 'need_reopen' out parameter through which it
        notifies caller that some tables were altered or dropped so he needs to reopen
        them (and rebuild prelocking set some triggers may change or simply appear).
      sql/sp.cc:
        sp_add_used_routine():
          To be able to restore LEX::sroutines_list to its state right after parsing
          we now adjust  LEX::sroutines_list_own_last/sroutines_list_own_elements when
          we add directly used routine.
        sp_remove_not_own_routines():
          Added procedure for restoring LEX::sroutines/sroutines_list to their state
          right after parsing (by throwing out non-directly used routines).
        sp_cache_routines_and_add_tables_for_view()/sp_update_stmt_used_routines():
          We should use LEX::sroutines_list instead of LEX::sroutines as source of
          routines used by view, since LEX::sroutines is not availiable for view
          on second attempt to open it (see comment in open_tables() about it).
      sql/sp.h:
        sp_remove_not_own_routines():
          Added procedure for restoring LEX::sroutines/sroutines_list to their state
          right after parsing (by throwing out non-directly used routines).
      sql/sp_head.cc:
        Removed assert which is no longer always true.
      sql/sql_base.cc:
        reopen_table():
          When we re-open table and do shallow copy of TABLE object we should adjust
          pointers to it in associated Table_triggers_list object. Removed nil
          operation.
        open_tables():
          Now this function is able to rebuild prelocking set for statement if it is
          needed. It also correctly handles FLUSH TABLES which may occur during its
          execution.
        lock_tables():
          Instead of allowing mysql_lock_tables() to silently reopen altered or dropped
          tables let us notify caller and rely on that it will do reopen itself.
          This solves the problem when trigger suddenly appears or changed during
          mysq_lock_tables().
        close_tables_for_reopen():
          Added routine for properly preparing for reopening of tables and recalculation
          of set of prelocked tables.
      sql/sql_handler.cc:
        Here we let mysql_lock_tables() to reopen dropped or altered tables by itself.
      sql/sql_insert.cc:
        Here we let mysql_lock_tables() to reopen dropped or altered tables by itself.
      sql/sql_lex.cc:
        LEX:
          Added 'sroutines_list_own_last' and 'sroutines_list_own_elements' members
          which are used for keeping state in which 'sroutines_list' was right after
          statement parsing (and for restoring of this list to this state).
      sql/sql_lex.h:
        LEX:
          Added 'sroutines_list_own_last' and 'sroutines_list_own_elements' members
          which are used for keeping state in which 'sroutines_list' was right after
          statement parsing (and for restoring of this list to this state).
          Added chop_off_not_own_tables() method to simplify throwing away list
          of implicitly used (prelocked) tables.
      sql/sql_prepare.cc:
        Now instead of silently reopening altered or dropped tables in
        lock_tables() we notify caller and rely on that the caller will
        reopen tables.
      sql/sql_table.cc:
        Here we let mysql_lock_tables() to reopen dropped or altered tables by itself.
      sql/sql_trigger.cc:
        Added Table_triggers_list::set_table() method to adjust Table_triggers_list
        to new pointer to TABLE instance.
      sql/sql_trigger.h:
        Added Table_triggers_list::set_table() method to adjust Table_triggers_list
        to new pointer to TABLE instance.
      sql/sql_update.cc:
        Now instead of silently reopening altered or dropped tables in
        lock_tables() we notify caller and rely on that the caller will
        reopen tables.
      d8dea0bb
    • unknown's avatar
      Merge eherman@bk-internal.mysql.com:/home/bk/mysql-5.0 · 9d5331c3
      unknown authored
      into  mysql.com:/home/eric/mysql-5.0-fed-err
      
      9d5331c3
    • unknown's avatar
      Merge eherman@bk-internal.mysql.com:/home/bk/mysql-5.0 · 0bba047a
      unknown authored
      into  mysql.com:/home/eric/mysql-5.0-fed-err
      
      0bba047a
    • unknown's avatar
      Updated test results for view test. · 9f631d5f
      unknown authored
      
      mysql-test/r/view.result:
        Updated test results
      9f631d5f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 73e414a4
      unknown authored
      into  mysql.com:/home/emurphy/src/bk-clean/mysql-5.0
      
      73e414a4
    • unknown's avatar
      fixed portability · 7946f3bd
      unknown authored
      7946f3bd
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · 6aa34feb
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-5000
      
      6aa34feb
    • unknown's avatar
      Merge mysql.com:/home/emurphy/src/work/mysql-5.0-bug-12870 · 0a91371a
      unknown authored
      into  mysql.com:/home/emurphy/src/bk-clean/mysql-5.0
      
      
      sql/sql_parse.cc:
        Auto merged
      0a91371a
    • unknown's avatar
      BUG#12870 (CREATE PROCEDURE followed by ROLLBACK is not replicated) · e7e0af1d
      unknown authored
      Fixed by making CREATE/ALTER/DROP PROCEDURE cause implicit commit.
      
      
      mysql-test/r/rpl_ddl.result:
        Updated results to include testing of implicit commit for
        create/alter/drop procedure
      mysql-test/t/rpl_ddl.test:
        BUG#12870 test implicit commit for create/alter/drop procedure.
      sql/sql_parse.cc:
        CREATE/ALTER/DROP PROCEDURE/SPFUNCTION now causes implicit commit.
      e7e0af1d
    • unknown's avatar
      Per LenZ, changed calculated buffer size to constant and removed some unused variables. · 0d0e1273
      unknown authored
      
      sql/ha_federated.cc:
        converted calculated buffer size to static interger.
        removed unused variables.
      0d0e1273
    • unknown's avatar
      Merge mysql.com:/home/alexi/mysql-5.0 · 2ae2e04b
      unknown authored
      into  mysql.com:/home/alexi/dev/mysql-5.0-13000
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      2ae2e04b
    • unknown's avatar
      Fixed BUG#12963, BUG#13000: wrong VIEW creation with DAYNAME(), · ba362ed2
      unknown authored
       DAYOFWEEK(), and WEEKDAY().
      
      
      mysql-test/r/func_time.result:
        Fixed new results for testcases containing EXPLAIN EXTENDED SELECT ...
         WEEKDAY ... DAYNAME. The new results are correct and correspond to
         the changes in create_func_weekday() and create_func_dayname().
      mysql-test/r/view.result:
        Fixed some testcases results (bugs #12963, #13000).
      mysql-test/t/view.test:
        Added testcases for for bugs #12963, #13000.
      sql/item_create.cc:
        Fixed bugs #12963, #13000: wrong VIEW creation with DAYNAME(),
         DAYOFWEEK(), and WEEKDAY().
         Modified create_func_dayname(), create_func_dayofweek(), and
         create_func_weekday(). They don´t insert Item_func_to_days
         object now.
      sql/item_timefunc.cc:
        Fixed bugs #12963, #13000: wrong VIEW creation with DAYNAME(),
         DAYOFWEEK(), and WEEKDAY().
         Modified Item_func_weekday::val_int(). The argument of weekday should
         not be considered now to be Item_func_to_days object.
      sql/item_timefunc.h:
        Fixed bugs #12963, 13000: wrong VIEW creation with DAYNAME(),
         DAYOFWEEK(), and WEEKDAY.
         Modified Item_func_weekday::func_name(). It returns now different
         names depending on the odbc_type attribute value.
      ba362ed2
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · 00310636
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-5000
      
      
      sql/sql_show.cc:
        Auto merged
      00310636
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · c7089f3d
      unknown authored
      into dl145c.mysql.com:/home/ndbdev/tomas/mysql-5.0
      
      c7089f3d
    • unknown's avatar
      Merge abelkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · ccbfaf91
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-owner2-5.0
      
      ccbfaf91
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 976bd6aa
      unknown authored
      into dl145c.mysql.com:/home/ndbdev/tomas/mysql-5.0
      
      976bd6aa
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/main · 2a83b11f
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.0/bug13136
      
      2a83b11f
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · ee4f2bfc
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-5000
      
      ee4f2bfc
    • unknown's avatar
      Merge abelkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · d498d4e3
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-owner2-5.0
      
      d498d4e3
    • unknown's avatar
      postmerge fix · f1f62651
      unknown authored
      f1f62651
    • unknown's avatar
      BUG#13136 NdbTCP.cpp compile failure on OSX 10.2 · d077c569
      unknown authored
      use select if poll is unavailable.
      
      
      ndb/src/common/portlib/NdbTCP.cpp:
        Implement Ndb_check_socket_hup for systems without poll(2)
      ndb/src/common/portlib/win32/NdbTCP.c:
        fix typo (found while fixing this bug)
      d077c569
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 6d619184
      unknown authored
      into dl145c.mysql.com:/home/ndbdev/tomas/mysql-5.0
      
      6d619184
    • unknown's avatar
      enabled mysqldump hex-blob option for bit fields · f00a75a0
      unknown authored
      f00a75a0
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · 951e269e
      unknown authored
      into mysql.com:/M50/mysql-5.0
      
      951e269e
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · b039e0f7
      unknown authored
      into mysql.com:/M50/mysql-5.0
      
      b039e0f7
    • unknown's avatar
      Fix for Metrowerks compiler. · b3d54668
      unknown authored
      b3d54668
    • unknown's avatar
      Merge mysql.com:/M41/upward-4.1 into mysql.com:/M50/merge-5.0 · fd448ed7
      unknown authored
      
      mysql-test/lib/mtr_process.pl:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        Auto merged
      fd448ed7
    • unknown's avatar
      Improve error / process handling in the Perl script to run the test suite (patch supplied by Kent). · 21360b30
      unknown authored
      
      mysql-test/lib/mtr_process.pl:
        Handle errors in child processes separate from the parent process (patch supplied by Kent).
      mysql-test/lib/mtr_report.pl:
        New function to handle errors in child processes separate from the parent process (patch supplied by Kent).
        Expected to avoid HUP signals.
      21360b30
    • unknown's avatar
      indentation correction · 131b8c95
      unknown authored
      131b8c95
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1-4100 · 6d45a18e
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-5000
      
      
      include/my_sys.h:
        Auto merged
      mysys/mf_keycache.c:
        Auto merged
      sql/sql_test.cc:
        Auto merged
      sql/mysqld.cc:
        Manual merge.
      sql/sql_show.cc:
        Manual merge.
      sql/structs.h:
        Manual merge.
      6d45a18e
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 63e10357
      unknown authored
      into dl145c.mysql.com:/home/ndbdev/tomas/mysql-5.0
      
      63e10357