1. 01 Sep, 2005 8 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 831b9133
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-4.1-bg12423
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      mysql-test/r/grant2.result:
        Manual merge.
      mysql-test/t/grant2.test:
        Manual merge.
      831b9133
    • unknown's avatar
      Fix for bug #12423 "Deadlock when doing FLUSH PRIVILEGES and GRANT in · 6e265308
      unknown authored
      multi-threaded environment".
      
      To avoid deadlocks between several simultaneously run account management 
      commands (particularly between FLUSH PRIVILEGES/SET PASSWORD and GRANT
      commands) we should always take table and internal locks during their
      execution in the same order. In other words we should first open and lock
      privilege tables and only then obtain acl_cache::lock/LOCK_grant locks.
      
      
      mysql-test/r/grant2.result:
        Added test for bug #12423 "Deadlock when doing FLUSH PRIVILEGES and GRANT in 
        multi-threaded environment".
      mysql-test/t/grant2.test:
        Added test for bug #12423 "Deadlock when doing FLUSH PRIVILEGES and GRANT in 
        multi-threaded environment".
      sql/mysqld.cc:
        acl_init/grant_init() are now used only at server start up so they always
        allocate temporary THD object and don't need argument for passing pointer
        to it.
      sql/sql_acl.cc:
        To avoid deadlocks between several simultaneously run account management 
        commands (particularly between FLUSH PRIVILEGES/SET PASSWORD and GRANT
        commands) we should always take table and internal locks during their
        execution in the same order. In other words we should first open and lock
        privilege tables and only then obtain acl_cache::lock/LOCK_grant locks.
        
        Changed acl_reload()/grant_reload() and change_password()/update_user_table()
        in such way that they obey this principle. Now in acl_reload()/grant_reload()/
        change_password() we open and lock privilege tables, then obtain internal
        locks and then call acl_load()/grant_load()/update_user_table() functions to
        do actual loading or updating.
      sql/sql_acl.h:
        acl_init/grant_init() are now used only at server start up so they always
        allocate temporary THD object and don't need argument for passing pointer
        to it. acl_reload()/grant_reload() now are able to report about their
        success or failure through return value.
      sql/sql_parse.cc:
        If reload_acl_and_cache() is called from SIGHUP handler we have to
        allocate temporary THD for execution of acl_reload()/grant_reload().
      6e265308
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · b6d6a462
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      b6d6a462
    • unknown's avatar
      mtr_process.pl: · f74763c7
      unknown authored
        Make sure mtr_kill_processes() is called with an array ref
        Corrected error string for STDERR redirect
      
      
      mysql-test/lib/mtr_process.pl:
        Make sure mtr_kill_processes() is called with an array ref
      f74763c7
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 7b275189
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      sql/examples/ha_archive.cc:
        Auto merged
      7b275189
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-7156 · 639a5c07
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      639a5c07
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-12325 · 7e61acc9
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      7e61acc9
    • unknown's avatar
      Fix handling of filenames that start the same as reserved filenames · f8452cbc
      unknown authored
      on Windows. (Bug #12325)
      
      
      mysql-test/r/lowercase_table.result:
        Update results
      mysql-test/t/lowercase_table.test:
        Move test to new windows.test, since it is Windows-specific
      mysys/my_access.c:
        Check that we've matched the whole forbidden name.
      mysql-test/include/windows.inc:
        New BitKeeper file ``mysql-test/include/windows.inc''
      mysql-test/r/windows.result:
        New BitKeeper file ``mysql-test/r/windows.result''
      mysql-test/t/windows.test:
        New BitKeeper file ``mysql-test/t/windows.test''
      f8452cbc
  2. 31 Aug, 2005 15 commits
    • unknown's avatar
      8af463b2
    • unknown's avatar
      ed344d69
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 52549105
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      52549105
    • unknown's avatar
      added make of ndb sys file printer · e997ae1b
      unknown authored
      e997ae1b
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 84583bb7
      unknown authored
      into moonbone.local:/work/12861-bug-4.1-mysql
      
      84583bb7
    • unknown's avatar
      improved the ndb redo log reader · 2e5a56a6
      unknown authored
      2e5a56a6
    • unknown's avatar
      Add test for madvise() being declared in C++ code, because it is not · 290a923b
      unknown authored
      on Solaris even though it is available, and declare it ourselves in
      that case. (Bug #7156)
      
      
      configure.in:
        Add test for madvise() being declared when C++ compiler is used.
      include/my_global.h:
        Handle madvise() being available but not declared in C++
      isam/extra.c:
        Fix typo in define test
      myisam/mi_extra.c:
        Fix typo in define test
      sql/examples/ha_tina.cc:
        Test that we have madvise() before trying to call it.
      290a923b
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 0df66847
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      0df66847
    • unknown's avatar
      mtr_timer.pl, mtr_report.pl, mtr_process.pl, mysql-test-run.pl: · 4ce4968b
      unknown authored
        Backporting from 5.0
      
      
      mysql-test/mysql-test-run.pl:
        Backporting from 5.0
      mysql-test/lib/mtr_process.pl:
        Backporting from 5.0
      mysql-test/lib/mtr_report.pl:
        Backporting from 5.0
      mysql-test/lib/mtr_timer.pl:
        Backporting from 5.0
      4ce4968b
    • unknown's avatar
      Fix bug #12861 client hang with group_concat insubquery FROM DUAL. · 490bfbc3
      unknown authored
      Item_func_group_concat::fix_fields() set maybe_null flag to 0, and set it to
      1 only if some of it's arguments may be null. When used in subquery in tmp 
      table created field which can't be null. When no data retireved result field
      have to be set to null and error mentioned in bug report occurs. Also this 
      bug can occur if selecting from not null field in empty table.
      
      Function group_concat now marked maybe_null from the very beginning not only
      if some of it's argument may be null.
      
      
      sql/item_sum.cc:
        Fix bug #12861 client hang with group_concat insubquery FROM DUAL.
      mysql-test/r/func_gconcat.result:
        Test case for bug #12861 client hang with group_concat insubquery FROM DUAL.
      mysql-test/t/func_gconcat.test:
        Test case for bug #12861 client hang with group_concat insubquery FROM DUAL.
      490bfbc3
    • unknown's avatar
      901e45e2
    • unknown's avatar
      ha_innodb.cc: · c65bd03f
      unknown authored
        Fix bug #12410 : InnoDB was too permissive with LOCK TABLE ... READ LOCAL, and alowed new inserts to the table; we now make READ LOCAL equivalent to READ for InnoDB; note that this will cause slightly more locking in mysqldump, but makes the InnoDB table dumps consistent with MyISAM table dumps; note that the real code change patch was accidentally pushed with my another patch 5 minutes ago
      
      
      sql/ha_innodb.cc:
        Fix bug #12410 : InnoDB was too permissive with LOCK TABLE ... READ LOCAL, and alowed new inserts to the table; we now make READ LOCAL equivalent to READ for InnoDB; note that this will cause slightly more locking in mysqldump, but makes the InnoDB table dumps consistent with MyISAM table dumps; note that the real code change patch was accidentally pushed with my another patch 5 minutes ago
      c65bd03f
    • unknown's avatar
      ha_innodb.cc: · 2a893e63
      unknown authored
        Fix bug #12852 : do not increment the open handle count to a table if the table does not have an .ibd file and InnoDB decides to return an error from the ::open() function; then the table can be dropped even if the user has tried to open it
      
      
      sql/ha_innodb.cc:
        Fix bug #12852 : do not increment the open handle count to a table if the table does not have an .ibd file and InnoDB decides to return an error from the ::open() function; then the table can be dropped even if the user has tried to open it
      2a893e63
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · a237d460
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      a237d460
    • unknown's avatar
      corrected some erroneous ndb error messages · 9dfa94ce
      unknown authored
      9dfa94ce
  3. 30 Aug, 2005 17 commits