1. 21 Mar, 2006 1 commit
    • unknown's avatar
      BUG#18293 (Values in stored procedures written to binlog unescaped): · 83ba974a
      unknown authored
      Generating character set-independent quoting of strings for the
      binary log when executing statements from inside stored procedure.
      
      
      mysql-test/r/ctype_cp932_binlog.result:
        Result change
      mysql-test/t/ctype_cp932_binlog.test:
        Adding check that string literals are written correctly for multi-byte
        character sets.
      sql/item.cc:
        Cutting out character set-independent string escaping code and putting it
        in a separate function.
      sql/log_event.cc:
        Adding characters set-independent code to separate function.
      sql/mysql_priv.h:
        Adding new function.
      sql/sp_head.cc:
        Escaping string value representing a string item.
      83ba974a
  2. 16 Mar, 2006 6 commits
  3. 15 Mar, 2006 1 commit
    • unknown's avatar
      We should prohobit concurent read of inserting file in SP · bb69d16d
      unknown authored
      because it can couse problem with Query cache (BUG#14767)
      
      
      mysql-test/r/query_cache_notembedded.result:
        BUG#14767 test suite.
      mysql-test/t/query_cache_notembedded.test:
        BUG#14767 test suite.
      sql/sql_insert.cc:
        Query cache invalidation table we was inserting in just after
        unlocking table added to avoid the race condition as we had
        with SP.
      sql/sql_parse.cc:
        Query cache invalidation table we was inserting in just after
        unlocking table added to avoid the race condition as we had
        with SP.
      sql/sql_yacc.yy:
        We should prohibit concurent read of unserting file in SP
        because it can cause problem with query cache.
      bb69d16d
  4. 14 Mar, 2006 5 commits
  5. 13 Mar, 2006 11 commits
    • unknown's avatar
      Fixed bug#17366: Unchecked Item_int results in server crash · 8ba5a687
      unknown authored
      When there is conjunction of conds, the substitute_for_best_equal_field()
      will call the eliminate_item_equal() function in loop to build final
      expression. But if eliminate_item_equal() finds that some cond will always
      evaluate to 0, then that cond will be substituted by Item_int with value ==
      0. In this case on the next iteration eliminate_item_equal() will get that 
      Item_int and treat it as Item_cond. This is leads to memory corruption and
      server crash on cleanup phase.
      
      To the eliminate_item_equal() function was added DBUG_ASSERT for checking
      that all items treaten as Item_cond are really Item_cond.
      The substitute_for_best_equal_field() now checks that if
      eliminate_item_equal() returns Item_int and it's value is 0 then this 
      value is returned as the result of whole conjunction.
      
      
      mysql-test/t/subselect.test:
        Added test for bug#17366: Unchecked Item_int results in server crash
      mysql-test/r/subselect.result:
         Added test for bug#17366: Unchecked Item_int results in server crash
      sql/sql_select.cc:
        Fixed bug#17366: Unchecked Item_int results in server crash
         
        To the eliminate_item_equal() function was added DBUG_ASSERT for checking
        that all items treaten as Item_cond are really Item_cond.
        The substitute_for_best_equal_field() now checks that if
        eliminate_item_equal() returns something other than Item_cond and if it is
        then this value is returned as the result of whole conjunction.
      8ba5a687
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/50-work · 358e0883
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      358e0883
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/41-work · b0a73946
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-4.1
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      b0a73946
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/41-work · e5ad6196
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/50-work
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      e5ad6196
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-4.1 · 99824b4e
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-4.1
      
      
      99824b4e
    • unknown's avatar
      bug#14028 - · 9d8992f7
      unknown authored
          ndb crash if trigger record get to big, fix incorrect max size of trigger record
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Increase size of max trigger record
      9d8992f7
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0 · 7b3b008b
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0
      
      
      7b3b008b
    • unknown's avatar
      bug#14028 - · 0d89407a
      unknown authored
        ndb crash if trigger record get to big, fix incorrect max size of trigger record
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Increase size of max trigger record
      0d89407a
    • unknown's avatar
      Merge shellback.(none):/home/msvensson/mysql/init_rm/my50-init_rm · 38b40482
      unknown authored
      into  shellback.(none):/home/msvensson/mysql/mysql-5.0
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      38b40482
    • unknown's avatar
      Remove printouts · 9f4f77ab
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Remove extra printouts
      9f4f77ab
    • unknown's avatar
      Make mysql-test-run.pl restore the db(s) to a known state before continuing after test case failure · a7a2db66
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Take a snapshot of the data dirs just after all db's have been installed and usedthat snasphot to restore the db(s) to a known state after a test case has failed.
        Thus avoiding subsequent test cases to fail because of previous test failures.
      a7a2db66
  6. 11 Mar, 2006 2 commits
  7. 10 Mar, 2006 14 commits
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 00852307
      unknown authored
      into  mysql.com:/home/mydev/mysql-4.1-bug14980
      
      
      00852307
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0 · 34e43cd3
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-bug14980
      
      
      34e43cd3
    • unknown's avatar
    • unknown's avatar
      Fix version of DEFINER-clause in mysqldump. · dafa39f1
      unknown authored
      Now DEFINER-clause in stored routines is expected to appear
      in 5.0.20 release, not in 5.0.19. as it was supposed before.
      
      
      client/mysqldump.c:
        Fixing version.
      mysql-test/r/mysqldump.result:
        Updated the result file.
      dafa39f1
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · da150725
      unknown authored
      into mysql.com:/M50/merge-5.0
      
      
      da150725
    • unknown's avatar
      Merge mysql.com:/M50/clone-5.0 into mysql.com:/M50/merge-5.0 · e098024d
      unknown authored
      
      libmysql/libmysql.c:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      e098024d
    • unknown's avatar
      Include the system header file "pthread.h" even in a non-threaded build. · 7ec0c0d9
      unknown authored
      Fixes bug#15861
      
      
      include/my_no_pthread.h:
        Even in a non-threaded build, some modules (at least "mysys/mf_keycache.c")
        need some type definitions provided by the system header file "pthread.h".
        Rather than add complexity to the code, include the header.
        
        Fixes bug#15861
      7ec0c0d9
    • unknown's avatar
      Merge mysql.com:/usr_rh9/home/elkin.rh9/MySQL/BARE/5.0 · adc60cf8
      unknown authored
      into  mysql.com:/usr_rh9/home/elkin.rh9/MySQL/FIXES/5.0.20-bug15101-sysdate
      
      
      adc60cf8
    • unknown's avatar
      BUG#15101 SYSDATE() disregards SET TIMESTAMP. · 8f543b5e
      unknown authored
         After the ChangeSet 1.1892.20.1 2005/08/24 (Bug #12562) SYSDATE() is not an alias
         of NOW() and is unsafe for replication.
         `SYSDATE()' backward compatible aliasing clashes with the idea #12562 
         fix. To make it safe-replicatable we have to either use RBR or to restore
         the pre-5.0 style.
         --sysdate-is-now command line flag was introduced to provide backward compatibility.
      
      
      sql/mysqld.cc:
        New option to force SYSDATE's backward compatible with 4.1 aliasing to NOW (not default)
      sql/sql_class.h:
        new slot to fill at init time and check at parse
      sql/sql_yacc.yy:
        calling NOW's branches when --sysdate-is-now
      mysql-test/r/sysdate_is_now.result:
        New BitKeeper file ``mysql-test/r/sysdate_is_now.result''
      mysql-test/t/sysdate_is_now-master.opt:
        New BitKeeper file ``mysql-test/t/sysdate_is_now-master.opt''
      mysql-test/t/sysdate_is_now.test:
        New BitKeeper file ``mysql-test/t/sysdate_is_now.test''
      8f543b5e
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1-bug14980 · cefb1dc2
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-bug14980
      
      
      include/my_base.h:
        Auto merged
      myisam/mi_delete.c:
        Auto merged
      myisam/mi_key.c:
        Auto merged
      myisam/mi_rnext_same.c:
        Auto merged
      myisam/mi_unique.c:
        Auto merged
      myisam/mi_update.c:
        Auto merged
      myisam/mi_write.c:
        Auto merged
      mysql-test/r/myisam.result:
        SCCS merged
      mysql-test/t/myisam.test:
        SCCS merged
      cefb1dc2
    • unknown's avatar
      Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX · fbe17c2a
      unknown authored
      For "count(*) while index_column = value" an index read
      is done. It consists of an index scan and retrieval of
      each key.
      
      For efficiency reasons the index scan stores the key in
      the special buffer 'lastkey2' once only. At the first 
      iteration it notes this fact with the flag 
      HA_STATE_RNEXT_SAME in 'info->update'.
      
      For efficiency reasons, the key retrieval for blobs
      does not allocate a new buffer, but uses 'lastkey2'...
      
      Now I clear the HA_STATE_RNEXT_SAME flag whenever the 
      buffer has been polluted. In this case, the index scan
      copies the key value again (and sets the flag again).
      
      
      include/my_base.h:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Changed the comment for HA_STATE_RNEXT_SAME as a warning
        for future uses.
      myisam/mi_delete.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      myisam/mi_key.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      myisam/mi_rnext_same.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removed trailing space and fixed a comment.
      myisam/mi_unique.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      myisam/mi_update.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      myisam/mi_write.c:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Removing the flag HA_STATE_RNEXT_SAME from info->update
        if info->lastkey2 was reused for another purpose than
        index scanning.
      mysql-test/r/myisam.result:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Added test result.
      mysql-test/t/myisam.test:
        Bug#14980 - COUNT(*) incorrect on MyISAM table with certain INDEX
        Added test.
      fbe17c2a
    • unknown's avatar
      Additional fix for BUG#16777: Can not create trigger nor view · cf539a5a
      unknown authored
      w/o definer if --skip-grant-tables specified.
        
      The previous patch does not allow to specify empty host name in
      DEFINER-clause explicitly.
      
      
      mysql-test/r/skip_grants.result:
        Updated the result file.
      mysql-test/r/view_grant.result:
        Updated the result file.
      mysql-test/t/skip_grants.test:
        Added test cases for BUG#16777; re-organized tests.
      mysql-test/t/view_grant.test:
        Updated after final fix of BUG#16777.
      sql/sql_parse.cc:
        The final part of fixing BUG#16777: allow empty host name in explicitly
        specified DEFINER-clause.
      sql/sql_show.cc:
        Quote an identifier if it is empty.
      cf539a5a
    • unknown's avatar
      Merge mysql.com:/M41/comment-4.1 into mysql.com:/M50/mysql-5.0 · be42706c
      unknown authored
      
      scripts/make_binary_distribution.sh:
        Auto merged
      be42706c
    • unknown's avatar
      Fixed bug#13575: SP funcs in select with distinct/group and order by can · 50c8c206
      unknown authored
      produce wrong data
      
      By default Item_sp_func::val_str() returns string from it's result_field 
      internal buffer. When grouping is present Item_copy_string is used to 
      store SP function result, but it doesn't additionally buffer the result.
      When the next record is read, internal buffer is overwritten, due to
      this Item_copy_string::val_str() will have wrong data. Thus producing
      weird query result.
      
      The Item_func_sp::val_str() now makes a copy of returned value to prevent
      occasional corruption.
      
      
      mysql-test/t/sp.test:
        Added test case for bug#13575: SP funcs in select with distinct/group and order by can
        produce wrong data
      mysql-test/r/sp.result:
        Added test case for bug#13575: SP funcs in select with distinct/group and
            order by can produce wrong data
      sql/item_func.h:
        Fixed bug#13575: SP funcs in select with distinct/group and order by can
            produce wrong data
            The Item_func_sp::val_str() now makes a copy of returned value to prevent
            occasinal corruption.
      50c8c206