1. 29 Jul, 2021 1 commit
  2. 28 Jul, 2021 5 commits
  3. 27 Jul, 2021 12 commits
    • Sergei Golubchik's avatar
      latest C/C · dfadc903
      Sergei Golubchik authored
      dfadc903
    • Sergei Golubchik's avatar
      MDEV-7209 mroonga storage engine fails to build on OpenBSD · 65e3d085
      Sergei Golubchik authored
      rename files `version` -> `version_full`
      65e3d085
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      8.45 · 4683ce82
      Sergei Golubchik authored
      4683ce82
    • Sergei Golubchik's avatar
      a32373b6
    • Nikita Malyavin's avatar
      add const qualifiers to sys_var::value_ptr functions and fix const casts · 6ed47508
      Nikita Malyavin authored
      This is important since Sys_var_typelib and its descendants return
      pointers to constant symbols from *_value_ptr, which are situated in
      write-protected-memory.
      
      * functions const-qualified:
        - value_ptr
        - session_value_ptr
        - global_value_ptr
        - default_value_ptr
        - Sys_var_vers_asof::value_ptr
        - other minor private ones
      
      * remove C-style typecasts when it discards qualifiers
      6ed47508
    • Nikita Malyavin's avatar
      MDEV-16026 MDEV-16481 refactor Sys_var_vers_asof · c6bff469
      Nikita Malyavin authored
      MDEV-16026: Forbid global system_versioning_asof in non-default time zone
      
      * store `system_versioning_asof` in unix time;
      * both session and global vars are processed in session timezone;
      * setting `default` does not copy global variable anymore. Instead, it sets
        system_time to SYSTEM_TIME_UNSPECIFIED, which means that no 'AS OF' time
        is applied and `now()` can be assumed
      
      As a regression, we cannot assign values below 1970 (UTC) anymore
      
      MDEV-16481: set global system_versioning_asof=sf() crashes in specific case
      
      * sys_vars.h: add `MYSQL_TIME` field to `set_var::save_result`
      * sys_vars.ic: get rid of calling `var->value->get_date()` from
       `Sys_var_vers_asof::update()`
      * versioning.sysvars: add test; remove double warning
      
      refactor Sys_var_vers_asof
      
      * inherit from sys_var rather than Sys_var_enum
      * remove junk "DEFAULT" keyword. There is DEFAULT in SQL grammar for it.
      * make all conversions in check() to avoid possible errors
      * avoid double var->value evaluation, which could
        consequence in undefined behavior
      c6bff469
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · f50eb0d3
      Marko Mäkelä authored
      f50eb0d3
    • Marko Mäkelä's avatar
      MDEV-25998 fixup: Avoid a hang · afe00bb7
      Marko Mäkelä authored
      btr_scrub_start_space(): Avoid an unnecessary tablespace lookup
      and related acquisition of fil_system->mutex. In MariaDB Server 10.3
      we would get deadlocks between that mutex and a crypt_data mutex.
      
      The fix was developed by Thirunarayanan Balathandayuthapani.
      afe00bb7
    • Marko Mäkelä's avatar
      e11cae71
    • Marko Mäkelä's avatar
      MDEV-24393 InnoDB disregards --skip-external-locking · da094188
      Marko Mäkelä authored
      On POSIX systems, InnoDB would unconditionally acquire advisory locks
      on the files that it opens. On Linux, this would be observable by
      a large number of entries in /proc/locks.
      
      Other storage engines would only acquire advisory locks on files
      based on the Boolean configuration parameter external_locking.
      
      Let InnoDB do the same.
      
      NOTE: The --skip-external-locking is activated by default. To have
      InnoDB acquire advisory locks, --external-locking must be specified.
      
      Reviewed by: Sergei Golubchik
      da094188
    • Marko Mäkelä's avatar
      MDEV-25594: Improve debug checks · cf1fc598
      Marko Mäkelä authored
      trx_t::will_lock: Changed the type to bool.
      
      trx_t::is_autocommit_non_locking(): Replaces
      trx_is_autocommit_non_locking().
      
      trx_is_ac_nl_ro(): Remove (replaced with equivalent assertion expressions).
      
      assert_trx_nonlocking_or_in_list(): Remove.
      Replaced with at least as strict checks in each place.
      
      check_trx_state(): Moved to a static function; partially replaced with
      individual debug assertions implementing equivalent or stricter checks.
      
      This is a backport of commit 7b51d11c
      from 10.5.
      cf1fc598
  4. 26 Jul, 2021 5 commits
    • Jan Lindström's avatar
      MDEV-26062 : InnoDB: WSREP: referenced FK check fail: Lock wait index... · 0bd9f755
      Jan Lindström authored
      MDEV-26062 : InnoDB: WSREP: referenced FK check fail: Lock wait index `PRIMARY` table `schema`.`child_table`
      
      Problem was that not all normal error codes where not handled
      after wsrep_row_upd_check_foreign_constraints() call. Furhermore,
      debug assertion did not contain all normal error cases. Changed
      ib:: calls to WSREP_ calls to use wsrep instrumentation.
      0bd9f755
    • Sergei Golubchik's avatar
      dissapear -> disappear · 2575eaa5
      Sergei Golubchik authored
      2575eaa5
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-25998 InnoDB removes the tablespace from default encrypt list early · ce870b2a
      Thirunarayanan Balathandayuthapani authored
      Problem:
      =========
      As a part of MDEV-14398 patch, InnoDB added and removed
      the tablespace from default encrypt list. But InnoDB removes
      the tablespace from the default encrypt list too early due to
      i) other encryption thread working on the tablespace
      ii) When tablespace is being flushed at the end of
      key rotation
      
      InnoDB fails to decrypt/encrypt the tablespace since
      the tablespace removed too early and it leads to
      test case failure.
      
      Solution:
      =========
      Avoid the removal of tablespace from default_encrypt_list
      only when
      1) Another active encryption thread working on tablespace
      2) Eligible for tablespace key rotation
      3) Tablespace is in flushing phase
      
      Removed the workaround in encryption.innodb_encryption_filekeys test case.
      ce870b2a
    • Eugene Kosov's avatar
      0711a53a
    • Rucha Deodhar's avatar
      MDEV-23786: Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' · af0b26f9
      Rucha Deodhar authored
      failed for TokuDB engine CREATE TABLE
      
      Analysis: Assertion failure happens because the database doesn't exist to
      create the table but ha_tokudb::create() still returns false.
      So error is not reported.
      Fix: Store the error state and report the error.
      af0b26f9
  5. 25 Jul, 2021 1 commit
    • Nayuta Yanagisawa's avatar
      MDEV-24517 follow-up: Fix for test with --ps-protocol · f52d3936
      Nayuta Yanagisawa authored
      Tests for the Spider storage engine often use the following idiom:
      
      --let $command=CREATE TABLE t1 (...);CREATE TABLE t2 (...); ...
      --eval $command
      
      However, the idiom seems to work in the normal protocol, but fails
      in the prepared statement (ps) protocol.
      As testing CREATE TABLE statements in the ps protocol, we wrap the
      idiom by --disable_ps_protocol and --enable_ps_protocol.
      f52d3936
  6. 24 Jul, 2021 5 commits
  7. 23 Jul, 2021 5 commits
  8. 22 Jul, 2021 6 commits