1. 23 May, 2005 10 commits
  2. 21 May, 2005 1 commit
    • unknown's avatar
      BUG# 9148: Denial of service · 455b259d
      unknown authored
      This is a second patch needing another review.  The first patch didn't solve
      the entire problem.  open and fopen on Windows will still open
      files like "com1.sym" when they shouldn't.  This patch
      checks that the file exists before trying to open it.
      
      
      
      mysys/my_fopen.c:
        on Windows, if we are not creating a file the we call my_access to make sure the
        file exists before trying to open it.
      mysys/my_open.c:
        on Windows, if we are not creating a file the we call my_access to make sure the
        file exists before trying to open it.
      455b259d
  3. 20 May, 2005 5 commits
    • unknown's avatar
      8ec1ffc6
    • unknown's avatar
      BUG# 9148: Denial of service · d7a4a8b6
      unknown authored
      The problem was that on Windows the access method indicates that access to file 
      such as "com1" and "lpt1" is allowed (since they are device names) and
      this causes mysql to attempt to open them as databases or tables.
      
      The fix was to write our own my_access method that uses other Win32 functions
      to determine if the given argument is indeed a file and has to requested
      mode.
      
      
      VC++Files/mysys/mysys.dsp:
        added my_access
      VC++Files/mysys/mysys_ia64.dsp:
        added my_access.c
      include/my_sys.h:
        if on windows, we use my_access.
        if not on windows, then my_access points to the native access method
      mysys/Makefile.am:
        added my_access to mysys build file
      mysys/mf_pack.c:
        changed call to access to my_access
      sql/sql_db.cc:
        changed call to access to my_access
      d7a4a8b6
    • unknown's avatar
      Merge mysql.com:/usr/home/ram/work/mysql-4.1-build · eb2a4c65
      unknown authored
      into mysql.com:/usr/home/ram/work/mysql-4.1
      
      eb2a4c65
    • unknown's avatar
      a fix (bug #10757: gis-rtree.test fails) · 526525dc
      unknown authored
      
      
      myisam/sp_key.c:
        a fix (bug #10757: gis-rtree.test fails)
        float8get() doesn't properly work with local variables sometimes.
      526525dc
    • unknown's avatar
  4. 19 May, 2005 8 commits
  5. 18 May, 2005 16 commits
    • unknown's avatar
      merged · 32c5a3fc
      unknown authored
      
      sql/unireg.cc:
        Auto merged
      32c5a3fc
    • unknown's avatar
      Merge book.sanja.is.com.ua:/Users/bell/mysql/bk/mysql-4.1 · b5ca7a75
      unknown authored
      into book.sanja.is.com.ua:/Users/bell/mysql/bk/work-4.1
      
      b5ca7a75
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · 75cd72f7
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      75cd72f7
    • unknown's avatar
      udf: when banning paths from soname in CREATE FUNCTION, check for \ on windows. · 644fcab9
      unknown authored
      when reporting an error, use an appropriate buffer for udf->name
      
      644fcab9
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-4.1 · 79ac77e4
      unknown authored
      into mysql.com:/home/mydev/mysql-4.1-4100
      
      79ac77e4
    • unknown's avatar
      Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE · 6f0ea859
      unknown authored
      After review version.
      Added a condition for MERGE tables. These do not have unique
      indexes. But every key could be a unique key on the underlying
      MyISAM table. So get the maximum key length for MERGE tables
      instead of the maximum unique key length. This is used for
      buffer allocation in write_record().
      
      
      mysql-test/r/merge.result:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        The test result.
      mysql-test/t/merge.test:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        The test case does not in all cases show the problem
        without the bugfix. The improper memory allocation
        might get through undetected in many cases.
      sql/ha_myisammrg.h:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        Set a table_flag for the MERGE engine telling that any index
        might be unique without being specified as such.
      sql/handler.h:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        Added a new table_flag telling that any index
        might be unique without being specified as such.
      sql/sql_insert.cc:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        Changed the freeing of the memory to be symmetric to its
        allocation (my_safe_alloc -> my_safe_afree).
        This is not directly related to the bug.
      sql/table.cc:
        Bug#10400 - Improperly-defined MERGE table crashes with INSERT ... ON DUPLICATE KEY UPDATE
        Added a condition for MERGE tables. These do not have unique
        indexes. But every key could be a unique key on the underlying
        MyISAM table. So get the maximum key length for MERGE tables
        instead of the maximum unique key length. This is used for
        buffer allocation in write_record().
      6f0ea859
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 4ac1a1ce
      unknown authored
      into mysql.com:/home/jimw/my/mysql-4.1-clean
      
      4ac1a1ce
    • unknown's avatar
      Update mysqldump test and results · 99df20b9
      unknown authored
      
      mysql-test/r/mysqldump.result:
        Update results
      mysql-test/t/mysqldump.test:
        Fix test to not include version number in results
      99df20b9
    • unknown's avatar
      Resolve bugfix merge · 3ed3377f
      unknown authored
      
      client/mysqldump.c:
        Merge bug fix
      mysql-test/r/mysqldump.result:
        Update results
      mysql-test/t/mysqldump.test:
        Merge bug fix
      3ed3377f
    • unknown's avatar
      Small optimization to bug fix, from Monty. · 7ee677bf
      unknown authored
      
      client/mysqldump.c:
        Optimize away a call to strend() by using return value of my_snprintf()
      7ee677bf
    • unknown's avatar
      Merge pnousiainen@bk-internal.mysql.com:/home/bk/mysql-4.1 · b5cd90dd
      unknown authored
      into mysql.com:/space/pekka/ndb/version/my41
      
      b5cd90dd
    • unknown's avatar
      ndb - allow upgrade 4.1.10->4.1.12 · 5cc9e4be
      unknown authored
      
      ndb/src/common/util/version.c:
        allow upgrade 4.1.10->4.1.12
      5cc9e4be
    • unknown's avatar
      Merge book.sanja.is.com.ua:/Users/bell/mysql/bk/mysql-4.1 · 2f71d1d9
      unknown authored
      into book.sanja.is.com.ua:/Users/bell/mysql/bk/work-4.1
      
      2f71d1d9
    • unknown's avatar
      reduced 1 server reloding during test · 67f08b12
      unknown authored
      
      BitKeeper/deleted/.del-grant_cache-master.opt~1b04b4b1116a7a2:
        Delete: mysql-test/t/grant_cache-master.opt
      mysql-test/r/grant_cache.result:
        query cache management moved inside test
      mysql-test/t/grant_cache.test:
        query cache management moved inside test to privent server reloading during test
      67f08b12
    • unknown's avatar
      olap.result, olap.test: · 19738af4
      unknown authored
        Added test cases for bug #7914.
      sql_select.cc:
        Fixed bug #7914: rollup over expresssions such as sum(a)+1.
      
      
      sql/sql_select.cc:
        Fixed bug #7914: rollup over expresssions such as sum(a)+1.
      mysql-test/t/olap.test:
        Added test cases for bug #7914.
      mysql-test/r/olap.result:
        Added test cases for bug #7914.
      19738af4
    • unknown's avatar
      sql_yacc.yy: · ed35fb0a
      unknown authored
        Added missing ';'.
      
      
      sql/sql_yacc.yy:
        Added missing ';'.
      ed35fb0a