1. 16 May, 2007 15 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-runtime · 86055a01
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      86055a01
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1 · 09e7b8e2
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      09e7b8e2
    • unknown's avatar
      Comment fix. · 26e7b221
      unknown authored
      
      storage/ndb/include/mgmapi/mgmapi.h:
        A tiny fix to make sure MGM API does not clutter doxygen index
        page for the entire MySQL Server.
      26e7b221
    • unknown's avatar
      Merge kpettersson@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 46bb989f
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      46bb989f
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug27415/my50-bug27415 · 18ebab54
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug27415/my51-bug27415
      
      
      mysql-test/r/sp-vars.result:
        Auto merged
      mysql-test/t/sp-vars.test:
        Auto merged
      18ebab54
    • unknown's avatar
      Bug#27415 Text Variables in stored procedures · f1239122
      unknown authored
       - Problem was reported as a SP variable using itself as 
         right value inside SUBSTR caused corruption of data. 
       - This bug could not be verified in either 5.0bk or 5.1bk
       - Added test case to prevent future regressions.
      
      
      mysql-test/r/sp-vars.result:
        Added test case for a reported regression which couldn't be
        verified.
      mysql-test/t/sp-vars.test:
        Added test case for a reported regression which couldn't be
        verified.
      f1239122
    • unknown's avatar
      Fix a typo. · b4182897
      unknown authored
      
      sql/event_data_objects.cc:
        Fix typo.
      b4182897
    • unknown's avatar
      An attempt to fix event_bugs.test failure on Debian · 60d05808
      unknown authored
      (Bug#26338 "events_bugs.test fail on Debian")
      
      
      mysql-test/r/events_bugs.result:
        Update results.
      mysql-test/t/events_bugs.test:
        Make a stab at fixing events_bugs.test failure on Debian.
        The problem is purely in the race inherent in the test case: an
        event that was started doesn't go away fast enough and clutters the 
        processlist. This patch remove the part of the event that
        we can not wait on synchronously (there is no table 'hashed_num'
        referenced anywhere).
      60d05808
    • unknown's avatar
      Make a stab at events_bugs.test failure under valgrind (no · d198d8df
      unknown authored
      open bug report, reproduced in the runtime team tree).
      
      
      sql/event_data_objects.cc:
        Make a stub at fixing a race in event_bugs.test under valgrind:
        read of uninitialized byte in SHOW PROCESSLIST from an event thread.
      d198d8df
    • unknown's avatar
      Merge vajra.(none):/opt/local/work/mysql-5.0-21483 · efe44813
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-21483
      
      
      sql/sql_insert.cc:
        Auto merged
      efe44813
    • unknown's avatar
      Fix a failing assert. · e7ec12f7
      unknown authored
      
      sql/sql_insert.cc:
        Do not access delayed thread memory without a mutex.
      e7ec12f7
    • unknown's avatar
      Correct a merge error. · 28fb78f1
      unknown authored
      
      sql/sql_insert.cc:
        Correct a merge error (wrong declaration was used).
      28fb78f1
    • unknown's avatar
      Merge vajra.(none):/opt/local/work/mysql-5.0-21483 · 0744fa5c
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-21483
      
      
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      mysql-test/r/insert.result:
        Manual merge.
      mysql-test/t/insert.test:
        Manual merge.
      sql/sql_insert.cc:
        Manual merge.
      0744fa5c
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-runtime · a2cb3dfd
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.0-21483
      
      
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      a2cb3dfd
    • unknown's avatar
      A fix and a test case for · 4adc007e
      unknown authored
      Bug#21483 "Server abort or deadlock on INSERT DELAYED with another
      implicit insert"
      Also fixes and adds test cases for bugs:
      20497 "Trigger with INSERT DELAYED causes Error 1165"
      21714 "Wrong NEW.value and server abort on INSERT DELAYED to a
      table with a trigger".
      Post-review fixes.
      
      Problem:
      In MySQL INSERT DELAYED is a way to pipe all inserts into a
      given table through a dedicated thread. This is necessary for
      simplistic storage engines like MyISAM, which do not have internal
      concurrency control or threading and thus can not
      achieve efficient INSERT throughput without support from SQL layer.
      DELAYED INSERT works as follows:
      For every distinct table, which can accept DELAYED inserts and has
      pending data to insert, a dedicated thread is created to write data
      to disk. All user connection threads that attempt to
      delayed-insert into this table interact with the dedicated thread in
      producer/consumer fashion: all records to-be inserted are pushed
      into a queue of the dedicated thread, which fetches the records and 
      writes them.
      In this design, client connection threads never open or lock
      the delayed insert table.
      This functionality was introduced in version 3.23 and does not take 
      into account existence of triggers, views, or pre-locking.
      E.g. if INSERT DELAYED is called from a stored function, which,
      in turn, is called from another stored function that uses the delayed
      table, a deadlock can occur, because delayed locking by-passes
      pre-locking. Besides:
       * the delayed thread works directly with the subject table through
         the storage engine API and does not invoke triggers
       * even if it was patched to invoke triggers, if triggers,
         in turn, used other tables, the delayed thread would
         have to open and lock involved tables (use pre-locking).
       * even if it was patched to use pre-locking, without deadlock
         detection the delayed thread could easily lock out user 
         connection threads in case when the same table is used both
         in a trigger and on the right side of the insert query: 
         the delayed thread would not release locks until all inserts 
         are complete, and user connection can not complete inserts 
         without having locks on the tables used on the right side of the
         query.
      
      Solution:
      
      These considerations suggest two general alternatives for the
      future of INSERT DELAYED:
       * it is considered a full-fledged alternative to normal INSERT
       * it is regarded as an optimisation that is only relevant 
         for simplistic engines.
      Since we missed our chance to provide complete support of new
      features when 5.0 was in development, the first alternative
      currently renders infeasible.
      However, even the second alternative, which is to detect
      new features and convert DELAYED insert into a normal insert, 
      is not easy to implement.
      The catch-22 is that we don't know if the subject table has triggers
      or is a view before we open it, and we only open it in the
      delayed thread. We don't know if the query involves pre-locking
      until we have opened all tables, and we always first create
      the delayed thread, and only then open the remaining tables.
      This patch detects the problematic scenarios and converts
      DELAYED INSERT to a normal INSERT using the following approach:
       * if the statement is executed under pre-locking (e.g. from
         within a stored function or trigger) or the right
         side may require pre-locking, we detect the situation
         before creating a delayed insert thread and convert the statement
         to a conventional INSERT.
        * if the subject table is a view or has triggers, we shutdown
         the delayed thread and convert the statement to a conventional
         INSERT.
      
      
      mysql-test/r/insert.result:
        Update test results.
      mysql-test/t/insert.test:
        Add a test case for Bug#21483, Bug#20497, Bug#21714 (INSERT DELAYED
        and stored routines, triggers).
      sql/sp_head.cc:
        Upgrade lock type to TL_WRITE when computing the pre-locking set.
      sql/sql_base.cc:
        Use a new method.
      sql/sql_insert.cc:
        INSERT DELAYED and pre-locking:
        - if  under pre-locking, upgrade the lock type to TL_WRITE
        and proceed as a normal write
        - if DELAYED table has triggers, also request a lock upgrade.
        - make sure errors in the delayed thread are propagated
        correctly
      sql/sql_lex.h:
        Add a method to check if a parsed tree refers to stored
        routines.
      4adc007e
  2. 15 May, 2007 6 commits
    • unknown's avatar
      Merge vajra.(none):/opt/local/work/mysql-5.0-runtime · 6ae7ddd4
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-runtime
      
      
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/t/disabled.def:
        Manual merge.
      6ae7ddd4
    • unknown's avatar
      A post-merge fix. · 21e6018e
      unknown authored
      21e6018e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 927b63c2
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/ps_1general.result:
        Auto merged
      mysql-test/t/disabled.def:
        Auto merged
      mysql-test/t/ps_1general.test:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_ndbcluster_binlog.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_partition.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/table.h:
        Auto merged
      sql/sql_insert.cc:
        SCCS merged
      927b63c2
    • unknown's avatar
      Merge vajra.(none):/opt/local/work/mysql-4.1-runtime · eb1f784e
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.0-runtime
      
      eb1f784e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · b0be8b57
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.0-runtime
      
      
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      b0be8b57
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 6c7510fc
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-4.1-runtime
      
      6c7510fc
  3. 14 May, 2007 14 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 1d502603
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-cts-3
      
      1d502603
    • unknown's avatar
      Fix for bug #28415 "Some ALTER TABLE statements no longer work under LOCK · 48b0f260
      unknown authored
      TABLES" and failures of alter_table.test on Windows which occured after
      pushing fix for bugs #20662, #20903, #24508, #24738 (various problems
      with CREATE TABLE SELECT).
      
      ALTER TABLE statements which were handled using "fast" alter table
      optimization were not properly working under LOCK TABLES if table
      was transactional (for all table types under Windows).
      
      Code implementing "fast" version of ALTER TABLE tried to open and
      lock table using open_ltable() after renaming .FRM files (which
      corresponds to renaming tables in normal case) in some cases
      (for transactional tables or on Windows). This caused problems
      under LOCK TABLES and conflicted with name-lock taken by 
      ALTER TABLE RENAME on target tables.
      
      This patch solves this issue by using reopen_name_locked_table()
      instead of open_ltable().
      
      
      mysql-test/include/mix1.inc:
        Added test for bug #28415 "Some ALTER TABLE statements no longer work
        under LOCK TABLES" and minimal coverage for fast ALTER TABLE behaviour
        for transactional tables.
      mysql-test/r/innodb_mysql.result:
        Added test for bug #28415 "Some ALTER TABLE statements no longer work
        under LOCK TABLES" and minimal coverage for fast ALTER TABLE behaviour
        for transactional tables.
      sql/sql_table.cc:
        mysql_alter_table():
          Fixed handling of transactional tables (and all tables on Windows)
          by "fast" ALTER TABLE.
          Code implementing "fast" version of ALTER TABLE tried to open and
          lock table using open_ltable() after renaming .FRM files (which
          corresponds to renaming tables in normal case) for such tables.
          This caused problems under LOCK TABLES and conflicted with name-lock
          taken by ALTER TABLE RENAME on target tables. We solve this issue by
          using reopen_name_locked_table() instead of open_ltable().
      48b0f260
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.1-build · e8a6e5f6
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      e8a6e5f6
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · 5222a15d
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      5222a15d
    • unknown's avatar
      Disable im_life_cycle in 5.0. · d0e1f6f3
      unknown authored
      d0e1f6f3
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build · d9e73c1d
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      
      configure.in:
        null merge
      d9e73c1d
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1 · 21002d15
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      21002d15
    • unknown's avatar
      Raise version number after cloning 5.0.42 · d70b8ebc
      unknown authored
      d70b8ebc
    • unknown's avatar
      Update description. · 50a331ed
      unknown authored
      50a331ed
    • unknown's avatar
      Update description. · bab73c03
      unknown authored
      bab73c03
    • unknown's avatar
      Disable random-failing IM tests. · 9997e6c5
      unknown authored
      9997e6c5
    • unknown's avatar
      Disable random-failing IM tests. · b76ae76b
      unknown authored
      b76ae76b
    • unknown's avatar
      Merge vajra.(none):/opt/local/work/mysql-5.0-runtime · 1f2e8361
      unknown authored
      into  vajra.(none):/opt/local/work/mysql-5.1-runtime
      
      
      sql/sql_insert.cc:
        Manual merge.
      1f2e8361
    • unknown's avatar
      Fix a warning. · eb9f0d38
      unknown authored
      
      sql/sql_insert.cc:
        Fix a compile-time warning (log_on is not used in embedded).
      eb9f0d38
  4. 12 May, 2007 5 commits