An error occurred fetching the project authors.
  1. 03 Nov, 2006 2 commits
  2. 26 Oct, 2006 1 commit
    • unknown's avatar
      Bug#20894 Reproducible MySQL client segmentation fault · 08d43705
      unknown authored
       - Add two null bytes in  "buff" variable allowing us to call
         get_arg two times also for strings longer than sizeof(buff) 
      
      
      client/mysql.cc:
        Make sure there are _two_ zero bytes at the end of buff, to allow 'get_arg' to be
        called twice on long strings. The first time it will mark end of string with a
        zero and the second time it will "skip ahead" to the first zero, and the find the
        second one indicating end of buff.
      mysql-test/r/mysql.result:
        Update test results
      mysql-test/t/mysql.test:
        Add tests for "com_connect" function in mysql
        Add test reported in bug
      08d43705
  3. 09 Oct, 2006 1 commit
  4. 13 Sep, 2006 1 commit
    • unknown's avatar
      Bug #21618: NULL shown as empty string in client · 306827a5
      unknown authored
      The column's NOT NULL flag doesn't affect what we should print.  Remove the
      wrong logic that does check it.
      
      Also, verify that this and the previous two tests print the same data as 
      other output formats.
      
      
      client/mysql.cc:
        Don't check the column's NOT NULL flag when determining whether to print 
        "NULL" or not.
      mysql-test/r/mysql.result:
        Add results and confirm that the other output forms give the same results
        for other similar tests.
      mysql-test/t/mysql.test:
        Add regression tests for this bug and two similar bugs.
      306827a5
  5. 06 Sep, 2006 1 commit
  6. 24 Aug, 2006 1 commit
    • unknown's avatar
      Bug #11972: client uses wrong character set after reconnect. · 689fae64
      unknown authored
      The mysql client uses the default character set on reconnect.  The default character set is now controled by the client charset command while the client is running.  The charset command now also issues a SET NAMES command to the server to make sure that the client's charset settings are in sync with the server's.
      
      
      client/mysql.cc:
        Client charset command now changes the default character set and issues a SET NAMES command to the server.
      mysql-test/r/mysql.result:
        Corrected results for new behaviour.
      mysql-test/t/mysql.test:
        Removed redundant commands from test.
      689fae64
  7. 16 Aug, 2006 1 commit
    • unknown's avatar
      Bug#20328 mysql client: dumb about trailing spaces on 'help' command · a707d490
      unknown authored
       Fix testcase to also work on windows
      
      
      BitKeeper/deleted/.del-mysql_client.test:
        Delete: mysql-test/t/mysql_client.test
      BitKeeper/deleted/.del-mysql_client.result:
        Delete: mysql-test/r/mysql_client.result
      mysql-test/r/mysql.result:
        Update test result
      mysql-test/t/mysql.test:
        Move tests from mysql_client to mysql
        Fix test case for bug#20328 to work on windows by comparing the output from "help" and "help "
      a707d490
  8. 02 Aug, 2006 1 commit
  9. 31 Jul, 2006 1 commit
    • unknown's avatar
      Bug#21042 mysql client segfaults on importing a mysqldump export · 71c896c2
      unknown authored
       - Use strmake, that will both protect the buffer and make sure it's terminated by a zero
       - Add test case
      
      
      client/mysql.cc:
        Use strmake instead of strxnmov as that function will make sure the string is terminated by 0
      mysql-test/r/mysql.result:
        Update test result
      mysql-test/t/mysql.test:
        Add test case
      71c896c2
  10. 24 Jul, 2006 1 commit
  11. 17 Jul, 2006 1 commit
    • unknown's avatar
      mysql.test, mysql.result: · 9a5daa60
      unknown authored
        Corrected the test case after fixing bug#10977
      
      
      mysql-test/t/mysql.test:
        Corrected the test case after fixing bug#10977
      mysql-test/r/mysql.result:
        Corrected the test case after fixing bug#10977
      9a5daa60
  12. 10 May, 2006 1 commit
    • unknown's avatar
      Bug#19564: mysql displays NULL instead of space · 2e72ae3d
      unknown authored
      Correct a bug (that I introduced, after using Oracle's database software for 
      too many years) where the length of the database-sent data is incorrectly 
      used to infer NULLness.
      
      
      client/mysql.cc:
        No longer use the length of the data to infer whether it is NULL or not.
      mysql-test/r/mysql.result:
        Add result and version marker, and correct previous result.
      mysql-test/t/mysql.test:
        Add test and version marker
      2e72ae3d
  13. 16 Apr, 2006 1 commit
    • unknown's avatar
      Only expand the empty string to the letters "NULL" if the column · 1e2bde0d
      unknown authored
      does not have "NOT NULL" attribute set.  Also, calculate the padding
      characters more safely, so that a negative number doesn't cause it to 
      print MAXINT-n spaces.
      
      
      mysql-test/r/mysql.result:
        Add test result.
      mysql-test/t/mysql.test:
        Add test.
      1e2bde0d
  14. 04 Apr, 2006 1 commit
    • unknown's avatar
      Bug#18265: mysql client: No longer right-justifies numeric columns · 0fae7e3b
      unknown authored
      Also fixes a new bug for which "NULL" wasn't printed (because the 
      data it represents has length zero).  (Discovered my Paul DuBois.)
      
      
      client/mysql.cc:
        Cleaned up the interactive-session table-printing function.
        
        - No longer rely on the length of the data to pad column boundries.
        - Be smarter about how we detect if the column is NULL.
        - Document how multibyte characters affect the output printing.
        - Use more descriptive variable names.
        
        More importantly, (re-)add these features that were crippled in an
        earlier change:
        - Print "NULL".
        - Right-justify numbers.
      mysql-test/r/mysql.result:
        Updated old result and added new case.
      mysql-test/t/mysql.test:
        Added new test case.
      0fae7e3b
  15. 03 Mar, 2006 1 commit
    • unknown's avatar
      Bug#16859 involves truncating column data at NUL characters. Instead, the · 21d6e172
      unknown authored
      client will now substitute spaces for NULs, so that the grid isn't messed up
      due to silently consumed NULs and that the full field is shown.
      
      
      client/mysql.cc:
        For non-numbers, print each character at a time, instead of using the 
        fprintf() facility, which interprets an array of chars as a C string, which 
        is necessarily NUL terminated.  We mustn't terminate on NULs, and since we 
        know the length of the data, we needn't.
      mysql-test/r/mysql.result:
        Add a test.
      mysql-test/t/mysql.test:
        Add a test.
      21d6e172
  16. 24 Feb, 2006 1 commit
    • unknown's avatar
      Fixes to embedded server to be able to run tests with it · 0afb6ff6
      unknown authored
      (Needed for "list of pushes" web page and autopush)
      
      
      include/mysql.h:
        Fix to embedded server to be able to run tests on it
      libmysql/libmysql.c:
        Fix to embedded server to be able to run tests on it
      libmysqld/emb_qcache.cc:
        Fix to embedded server to be able to run tests on it
      libmysqld/embedded_priv.h:
        Fix to embedded server to be able to run tests on it
      libmysqld/lib_sql.cc:
        Fix to embedded server to be able to run tests on it
      libmysqld/libmysqld.c:
        Fix to embedded server to be able to run tests on it
      mysql-test/mysql-test-run.sh:
        Fix to embedded server to be able to run tests on it
      mysql-test/r/binlog.result:
        Updated test for embedded server
      mysql-test/r/ctype_cp932.result:
        Updated test for embedded server
      mysql-test/r/innodb.result:
        Updated test for embedded server
      mysql-test/r/mysqltest.result:
        Updated test for embedded server
      mysql-test/r/query_cache.result:
        Updated test for embedded server
      mysql-test/r/query_cache_notembedded.result:
        Updated test for embedded server
      mysql-test/r/sp-error.result:
        Updated test for embedded server
      mysql-test/r/sp.result:
        Updated test for embedded server
      mysql-test/r/subselect.result:
        Updated test for embedded server
      mysql-test/r/view.result:
        Updated test for embedded server
      mysql-test/r/view_grant.result:
        Updated test for embedded server
      mysql-test/t/backup.test:
        Updated test for embedded server
      mysql-test/t/binlog.test:
        Updated test for embedded server
      mysql-test/t/blackhole.test:
        Updated test for embedded server
      mysql-test/t/compress.test:
        Updated test for embedded server
      mysql-test/t/ctype_cp932.test:
        Updated test for embedded server
      mysql-test/t/delayed.test:
        Updated test for embedded server
      mysql-test/t/handler.test:
        Updated test for embedded server
      mysql-test/t/innodb.test:
        Updated test for embedded server
      mysql-test/t/mysql.test:
        Updated test for embedded server
      mysql-test/t/mysql_client_test.test:
        Updated test for embedded server
      mysql-test/t/mysqltest.test:
        Updated test for embedded server
      mysql-test/t/query_cache.test:
        Updated test for embedded server
      mysql-test/t/query_cache_notembedded.test:
        Updated test for embedded server
      mysql-test/t/read_only.test:
        Updated test for embedded server
      mysql-test/t/skip_grants.test:
        Updated test for embedded server
      mysql-test/t/sp-destruct.test:
        Updated test for embedded server
      mysql-test/t/sp-error.test:
        Updated test for embedded server
      mysql-test/t/sp-threads.test:
        Updated test for embedded server
      mysql-test/t/sp.test:
        Updated test for embedded server
      mysql-test/t/subselect.test:
        Updated test for embedded server
      mysql-test/t/temp_table.test:
        Updated test for embedded server
      mysql-test/t/view.test:
        Updated test for embedded server
      mysql-test/t/view_grant.test:
        Updated test for embedded server
      mysql-test/t/wait_timeout.test:
        Updated test for embedded server
      mysys/mf_dirname.c:
        Review fix: Don't access data outside of array
      mysys/my_bitmap.c:
        Remove compiler warnings
      scripts/mysql_fix_privilege_tables.sql:
        Add flush privileges to .sql script so that one doesn't have to reboot mysqld when one runs the mysql_fix_privilege_script
      sql-common/client.c:
        Updated test for embedded server
      sql/item.cc:
        Remove DBUG_PRINT statement that can cause crashes when running with --debug
      sql/mysqld.cc:
        Fix to embedded server to be able to run tests on it
      sql/protocol.cc:
        Fix to embedded server to be able to run tests on it
        (Trivial reconstruction of code)
      sql/protocol.h:
        Fix to embedded server to be able to run tests on it
      sql/sql_base.cc:
        Better comment
      sql/sql_class.cc:
        Fix to embedded server to be able to run tests on it
      sql/sql_class.h:
        Fix to embedded server to be able to run tests on it
      sql/sql_cursor.cc:
        Fix to embedded server to be able to run tests on it
      sql/sql_parse.cc:
        Fix to embedded server to be able to run tests on it
        Don't crash for disabled commands when using embedded server
      sql/sql_prepare.cc:
        Fix to embedded server to be able to run tests on it
      mysql-test/r/ctype_cp932_notembedded.result:
        New BitKeeper file ``mysql-test/r/ctype_cp932_notembedded.result''
      mysql-test/r/innodb_notembedded.result:
        New BitKeeper file ``mysql-test/r/innodb_notembedded.result''
      mysql-test/r/sp.result.orig:
        New BitKeeper file ``mysql-test/r/sp.result.orig''
      mysql-test/r/sp_notembedded.result:
        New BitKeeper file ``mysql-test/r/sp_notembedded.result''
      mysql-test/r/subselect_notembedded.result:
        New BitKeeper file ``mysql-test/r/subselect_notembedded.result''
      mysql-test/t/ctype_cp932_notembedded.test:
        New BitKeeper file ``mysql-test/t/ctype_cp932_notembedded.test''
      mysql-test/t/innodb_notembedded.test:
        New BitKeeper file ``mysql-test/t/innodb_notembedded.test''
      mysql-test/t/sp.test.orig:
        New BitKeeper file ``mysql-test/t/sp.test.orig''
      mysql-test/t/sp_notembedded.test:
        New BitKeeper file ``mysql-test/t/sp_notembedded.test''
      mysql-test/t/subselect_notembedded.test:
        New BitKeeper file ``mysql-test/t/subselect_notembedded.test''
      0afb6ff6
  17. 09 Feb, 2006 1 commit
    • unknown's avatar
      BUG#16217 forced to introduce a separate mysql client command to adopt its · e025e47a
      unknown authored
      internal charset to one associated with currently being handled query. 
      To note such a query can come from interactive client either.
      
      There was a discussion within replication team and Monty who's suggestion won.
      It avoids straightforward parsing of all `set' queries that could affect client side 
      character set. 
      According to the idea, mysql client does not parse `set' queries but rather cares of
      `charset new_cs_name' command.
      This command is generated by mysqlbinlog in form of exclaiming comment (Lars' suggestion)
      so that enlightened clients like `mysql' knows what to do with it.
      
      Interactive human can switch between many multi-byte charsets during the session 
      providing the command explicitly. 
      To note that setting new internal mysql's charset does not
      trigger sending any `SET' sql statement to the server. 
      
      
      client/mysql.cc:
        BUG#16217 revealed the problem of switching between charsets in mysql client.
        Such switching is necessary in a case when being scanned query consists of 
        multi-byte chars and internal charset was initialized differently. mysql finds 
        `/' escape and misiterprete it 
        while in fact one could be a part of a multi-byte symbol like the bug page reported. 
        
        This patch extends mysql `charset' command, '\C' shortcut.
      mysql-test/r/ctype_ucs_binlog.result:
        comment line generated by mysqlbinlog for processing of logs with multi-byte chars.
      mysql-test/r/mysql.result:
        results are altered due to #16217
      mysql-test/r/mysqlbinlog.result:
        Results are altered due to #16217
      mysql-test/r/mysqlbinlog2.result:
        commeted command for mysql client due to multi-byte binlog
      mysql-test/r/rpl_charset.result:
        commented command for mysql due to multi-byte binlogs
      mysql-test/r/rpl_timezone.result:
        commented command for mysql client due to multi-byte binlogs
      mysql-test/r/user_var-binlog.result:
        commented command for mysql client due to multi-byte binlogs
      mysql-test/t/mysql.test:
        Main test for mysql client is extended to check `charset' command.
      mysql-test/t/mysqlbinlog.test:
        Checking how /*! \C cs_name */ are added to the output of mysqlbinlog.
        The exclaiming comment is for further processing by mysql client.
        The added part mimics the failure to recover tables from binlog - see BUG#16217.
      sql/log_event.cc:
        Sending into output instructions for mysql client to switch internally 
        to appropriate charset.
        mysql client is supposed to be invoked with --default-character-set=
        "to default character set of the server created the binlog".
      e025e47a
  18. 06 Oct, 2005 1 commit
    • unknown's avatar
      Review of code pushed since last 5.0 pull: · c807724f
      unknown authored
      Ensure that ccache is also used for C programs
      mysql: Ensure that 'delimiter' works the same way in batch mode as in normal mode
      mysqldump: Change to use ;; (instead of //) as a stored procedure/trigger delimiter
      Fixed test cases by adding missing DROP's and rename views to be of type 'v#'
      Removed MY_UNIX_PATH from fn_format()
      Removed current_db_used from TABLE_LIST
      Removed usage of 'current_thd' in Item_splocal
      Removed some compiler warnings
      A bit faster longlong2str code
      
      
      
      BUILD/FINISH.sh:
        Ensure that ccache is also used for C programs
      BUILD/SETUP.sh:
        Ensure that ccache is also used for C programs
      client/mysql.cc:
        More debugging
        Ensure that 'delimiter' works the same way in batch mode as in normal mode.
        Compare 'delimiter' command case-insensitive.
        The above fixes the delimiter bugs so that we can now use ;; as a trigger/SP function delimiter in mysqldump.
      client/mysqldump.c:
        Indentation fixes
        Use ;; as a delmimiter for stored procedures and triggers instead of //
      client/mysqltest.c:
        Indentation fixes
      include/my_sys.h:
        Remove not needed MY_UNIX_PATH parameter
      mysql-test/r/alter_table.result:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/r/func_str.result:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/r/information_schema.result:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/r/information_schema_inno.result:
        Drop all used tables
      mysql-test/r/multi_statement.result:
        Drop used tables
      mysql-test/r/mysql.result:
        Add error messages to result
      mysql-test/r/mysqldump.result:
        ;; is now used as SP/trigger delimiter
      mysql-test/r/mysqlshow.result:
        Drop used tables
      mysql-test/r/temp_table.result:
        Drop used views
        Rename views to v#
      mysql-test/t/alter_table.test:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/t/func_str.test:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/t/information_schema.test:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/t/information_schema_inno.test:
        Drop all used tables
      mysql-test/t/multi_statement.test:
        Drop used tables
      mysql-test/t/mysql.test:
        Add error messages to result
      mysql-test/t/mysqlshow.test:
        Drop used tables
      mysql-test/t/temp_table.test:
        Drop used views
        Rename views to v#
      mysys/mf_format.c:
        Remove not needed MY_UNIX_PATH parameter
        (This goes against how fn_format() is supposed to work and also conflicts with other options like MY_RETURN_REAL_PATH)
      sql/ha_federated.cc:
        Removed extra empty line
      sql/item.cc:
        Use 'str_value' instead of 'str_value_ptr' to hold result for Item_splocal
        Remove some calls to 'thd' in Item_splocal by making 'thd' a class variable
        One doesn't have to set 'null_value' when calling 'is_null()'
      sql/item.h:
        Add THD as a class variable to Item_splocal
        Use 'str_value' instead of 'str_value_ptr' to hold temp result
        Fixed bug in Item_hex when used in CAST()
      sql/item_func.cc:
        Optimize new code
      sql/log_event.cc:
        Move 'to_unix_path()' out of fn_format()
      sql/opt_range.cc:
        Simplify code
      sql/sp_head.cc:
        Ensure that Item_splocal has thd set before we call '->this_item()'
      sql/sql_class.cc:
        Return error if Statement::insert() fails in either hash_insert()
      sql/sql_parse.cc:
        Remove 'current_db_used' as we can trivially check if db table qualifier was used without this.
        Simplify code
      sql/sql_prepare.cc:
        Use enum instead of const int, to avoid ugly code for VC++
      sql/structs.h:
        Remove compiler warnings when using STRING_WITH_LEN() with constant strings.
      sql/table.cc:
        Fixed indentation
      sql/table.h:
        Remove not needed current_db_used
      strings/decimal.c:
        Simplify code
      strings/longlong2str-x86.s:
        A bit faster longlong2str.
        (Took some ideas from Peter Gulutzan's code)
      strings/my_strtoll10.c:
        Simplify code for MetroWerks compiler
      c807724f
  19. 24 Sep, 2005 1 commit
    • unknown's avatar
      mysqlbinlog.test: · f437ec9a
      unknown authored
        Windows have no 'cat' command, use <
      mysql.test:
        Windows can't handle single quotes in --exec line
      
      
      mysql-test/t/mysql.test:
        Windows can't handle single quotes in --exec line
      mysql-test/t/mysqlbinlog.test:
        Windows have no 'cat' command, use <
      f437ec9a
  20. 03 Jun, 2005 1 commit
    • unknown's avatar
      BUG#9998 MySQL client hangs on "USE database" · 1d6addd9
      unknown authored
       Use open_normal_and_derived_tables instead of open_and_lock_tables when reading metadata for a table.
       Add two test cases, one for "USE database" and one for "SHOW COLUMNS FROM table"
      
      
      mysql-test/r/lock_multi.result:
        Updated test results for test case for bug9998
      mysql-test/r/mysql.result:
        Updated results for test case for bug9998
      mysql-test/t/lock_multi.test:
        Test that "show columsn from t1" is not locked by another thread having a write lock on t1
      mysql-test/t/mysql.test:
        Add test case for BUG9998
          - lock table t1 for write from mysql-test, then execute 'mysql' and call "USE test". This will test exactly what caused the bug.
      sql/sql_show.cc:
        Open tables without locking when reading metadata
      1d6addd9
  21. 17 May, 2005 1 commit