1. 29 Mar, 2004 6 commits
  2. 28 Mar, 2004 1 commit
    • unknown's avatar
      Simplification: MYSQL_RES *result replaced with MYSQL_DATA result; · 7e5cd910
      unknown authored
      No need to check for result existence any more, store_result functions
      now are shorter.
      cli_read_binary_rows rewritten to handle MYSQL_DATA directly.
      
      
      include/mysql.h:
        MYSQL_RES * pointer replaced with MYSQL_DATA: it saves us at least 2 mallocs
        per store_result and simplifies stored result handling.
        Plus it's done with cursor fetch in mind: cursor fetch will use this
        structure to buffer fetched rows.
      libmysql/client_settings.h:
        signature of cli_read_binary_rows changed
      libmysql/libmysql.c:
        MYSQL_DATA is now used to handle result.
        cli_read_binary_rows rewritten to use MYSQL_DATA directly.
      libmysql/libmysql.def:
        declarations of new calls in the library
      libmysqld/lib_sql.cc:
        MYSQL_DATA is now used to handle result.
        cli_read_binary_rows rewritten to use MYSQL_DATA directly.
      7e5cd910
  3. 27 Mar, 2004 4 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 76385f32
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.1.clean
      
      
      76385f32
    • unknown's avatar
      Small fix to embedded library · 8b0d52ab
      unknown authored
      we should call check_user in NO_EMBEDDED_ACCESS_CHECKS case
      to do necessary initializations
      
      
      libmysqld/lib_sql.cc:
        call of check_user added
      8b0d52ab
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.1 · a8feb0d6
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.1
      
      
      a8feb0d6
    • unknown's avatar
      A previous changeset by me today about SQL_LOG_BIN had the problem · ec4a9dc9
      unknown authored
      that it tested the privilege in ::update() whereas it should be
      in ::check() (see email from Serg, subject
      "Re: bk commit - 4.1 tree (guilhem:1.1706)").
      So I add instead a check_func function to sys_var_thd_bit.
      I do the same addition to sys_var_thd_ulong, to unify handling
      of PSEUDO_THREAD_ID with the one of SQL_LOG_BIN. So class
      sys_var_pseudo_thread_id is not needed anymore, removing it.
      
      
      mysql-test/r/rpl_temporary.result:
        result update
      mysql-test/t/rpl_temporary.test:
        tests after new way of fixing; verify that when second variable
        assignment is refused then first is not done.
      sql/set_var.cc:
        a check_func (check_log_update) when setting SQL_LOG_BIN,
        and one when setting PSEUDO_THREAD_ID.
        Removing class sys_var_pseudo_thread_id.
        Updates for new prototypes of constructor in sys_var_thd_bit
        and sys_var_thd_ulong.
      sql/set_var.h:
        Adding check_func to sys_var_thd_bit.
        Adding check_func to sys_var_thd_ulong, so class sys_var_pseudo_thread_id
        is not needed anymore, removing it.
      ec4a9dc9
  4. 26 Mar, 2004 14 commits
    • unknown's avatar
      fixed bug #2342 · 67e4f431
      unknown authored
      "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      
      
      mysql-test/r/bdb-crash.result:
        added test for bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      mysql-test/t/bdb-crash.test:
        added test for bug #2342 
        "Running ANALYZE TABLE on bdb table inside a transaction hangs server thread"
      sql/handler.h:
        added constant HA_ADMIN_REJECT
      sql/sql_table.cc:
        added processing of HA_ADMIN_REJECT in ha_berkley::analyze
      67e4f431
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.1 · 266d3619
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.1
      
      
      mysql-test/r/rpl_temporary.result:
        Auto merged
      mysql-test/t/rpl_temporary.test:
        Auto merged
      sql/set_var.cc:
        Auto merged
      266d3619
    • unknown's avatar
      Changing SET SQL_LOG_BIN so that it explicitely throws an error if · ab8c3d89
      unknown authored
      user is not SUPER, instead of setting the value but ignoring it
      silently internally.
      
      
      mysql-test/r/rpl_temporary.result:
        result update
      mysql-test/t/rpl_temporary.test:
        adding test for privileges for SET SQL_LOG_BIN
      sql/log.cc:
        don't need to check SUPER
      sql/set_var.cc:
        refuse SET SQL_LOG_BIN if not SUPER
      sql/sql_insert.cc:
        Don't need to check SUPER
      ab8c3d89
    • unknown's avatar
      To save 32KB memory per thread when --log-bin is not used, we do not · 11bea84e
      unknown authored
      init the binlog_cache (THD::transaction.trans_log).
      I have checked all places where trans_log is used, because as now
      it may not be inited in some cases, we have to be cautious
      (will forward this commit mail to Heikki).
      
      
      sql/handler.cc:
        Do not use the transaction binlog cache if binlog is not open
      sql/sql_class.cc:
        We do not init the transaction binlog cache if binlog is not open.
        This saves 32 KB memory per thread, if --log-bin is not used.
      sql/sql_class.h:
        warning comment
      11bea84e
    • unknown's avatar
      mem0dbg.c: · e320ade2
      unknown authored
        Let mem_current_allocated_memory be a global variable, because it is used in an .ic file if UNIV_MEM_DEBUG is defined
      
      
      innobase/mem/mem0dbg.c:
        Let mem_current_allocated_memory be a global variable, because it is used in an .ic file if UNIV_MEM_DEBUG is defined
      e320ade2
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 4ac3ca69
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-4.1
      
      
      sql/sql_base.cc:
        Auto merged
      4ac3ca69
    • unknown's avatar
      63e1d22f
    • unknown's avatar
      typo in comment fixed · b0979bc9
      unknown authored
      b0979bc9
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 403948cb
      unknown authored
      into bar.intranet.mysql.r18.ru:/usr/home/bar/mysql-4.1
      
      
      403948cb
    • unknown's avatar
      bad merge (?) fixed · 1712fced
      unknown authored
      1712fced
    • unknown's avatar
      1. New data types, from the user point of view: · 3eff4316
      unknown authored
         BINARY(N) and VARBIBARY(N)
      2. More 4.0 compatibility and more BINARY keyword consistency:
      2a. CREATE TABLE a (a CHAR(N) BINARY) 
          is now synonym for
          CREATE TABLE a (a CHAR(N) COLLATE xxxx_bin)
      2b. SELECT BINARY x
          is still synonin for
          SELECT x COLLATE xxxxx_bin.
      
      
      3eff4316
    • unknown's avatar
      version updated after merge :) · c1e76fc0
      unknown authored
      c1e76fc0
    • unknown's avatar
      charset2html.c: · 1d093b7f
      unknown authored
        Don't print control characters
      
      
      mysys/charset2html.c:
        Don't print control characters
      1d093b7f
    • unknown's avatar
      After merge fixes + simple optimizations · 918519ea
      unknown authored
      
      mysql-test/r/alter_table.result:
        Updated results after merge
      mysql-test/r/drop_temp_table.result:
        Updated results after merge
      mysql-test/r/union.result:
        Updated results after merge
      sql/sql_db.cc:
        optimization: Use my_stat() instead of my_dir() to test if directory exists
      sql/sql_union.cc:
        Fixed error in merge
      918519ea
  5. 25 Mar, 2004 15 commits
    • unknown's avatar
      Merge with 4.0 · 526b25e2
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      BitKeeper/deleted/.del-libmysql.def~f5dffcb3ed925d28:
        Auto merged
      BitKeeper/deleted/.del-post-incoming~9f2168f531f09f3b:
        Auto merged
      BitKeeper/deleted/.del-post-outgoing~1dd3d8f0f6e8f3cd:
        Auto merged
      VC++Files/innobase/innobase.dsp:
        Auto merged
      VC++Files/strings/MASM6x/strings.dsp:
        Auto merged
      client/mysqldump.c:
        Auto merged
      innobase/sync/sync0sync.c:
        Auto merged
      myisam/mi_check.c:
        Auto merged
      mysql-test/t/union.test:
        Auto merged
      mysql-test/t/update.test:
        Auto merged
      mysys/mf_iocache.c:
        Auto merged
      sql/nt_servc.cc:
        Auto merged
      mysql-test/r/system_mysql_db.result:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      526b25e2
    • unknown's avatar
      Updated tests after merge · 922818a7
      unknown authored
      
      mysql-test/r/alter_table.result:
        Updated tests
      mysql-test/t/alter_table.test:
        Updated tests
      922818a7
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · f6e33d67
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      sql/item_func.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      f6e33d67
    • unknown's avatar
      Cleanups & safety fixes · 054d2de4
      unknown authored
      
      include/mysql.h:
        cleanup of load data infile patch
      libmysql/libmysql.c:
        cleanup of load data infile patch
      myisam/mi_search.c:
        Added missing assert.h
      mysql-test/r/func_time.result:
        Make test more secure
      mysql-test/t/func_time.test:
        Make test more secure
      sql/item.cc:
        restore to use str_value in item::save_in_field
      sql/item.h:
        Simple cleanup
      sql/item_cmpfunc.cc:
        Safety fix
      sql/item_cmpfunc.h:
        Simple optimization
      sql/item_func.cc:
        Updated comment
      sql/sql_base.cc:
        Simple optimization
      sql/sql_select.cc:
        Simple optimization
      sql/sql_union.cc:
        safey fixes
      054d2de4
    • unknown's avatar
      merge with 3.23 · 7f0a632c
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      scripts/mysqlbug.sh:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      mysql-test/t/alter_table.test:
        Merge code with 3.23
      sql/nt_servc.cc:
        use original code
      7f0a632c
    • unknown's avatar
      Improved test case · 143e585a
      unknown authored
      service backport from 4.0
      
      
      mysql-test/t/alter_table.test:
        Improved test case
      sql/nt_servc.cc:
        service backport from 4.0
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      143e585a
    • unknown's avatar
      Merge fix. · d31bb74a
      unknown authored
      
      sql/sql_yacc.yy:
        Auto merged
      tests/client_test.c:
        Merge fix (two new test cases at the same time).
      d31bb74a
    • unknown's avatar
      Fixed BUG#3117: LAST_INSERT_ID() works incorrectly inside stored procedure. · df064669
      unknown authored
      This turned out to be a problem for prepared statements as well; the id was
      evaluated once, at parse time.
      
      
      mysql-test/r/auto_increment.result:
        Updated results after bugfix in last_insert_id().
      mysql-test/r/query_cache.result:
        Updated results after bugfix in last_insert_id().
      mysql-test/r/variables.result:
        Updated results after bugfix in last_insert_id().
      sql/item_func.cc:
        Fixed bug in last_insert_id(); get id at each evaluation (and not in the parser).
        Renamed the class Item_func_set_last_insert_id too, since it's not only for setting.
      sql/item_func.h:
        Fixed bug in last_insert_id(); get id at each evaluation (and not in the parser).
        Renamed the class Item_func_set_last_insert_id too, since it's not only for setting.
      sql/sql_yacc.yy:
        Fixed bug in last_insert_id(); get id at each evaluation (and not in the parser).
        Renamed the class Item_func_set_last_insert_id too, since it's not only for setting.
      tests/client_test.c:
        Test case for last_insert_id() in prepared statements.
      df064669
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · d78cb899
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      myisam/mi_check.c:
        Auto merged
      sql/field.cc:
        Auto merged
      strings/ctype-sjis.c:
        Auto merged
      strings/ctype-ucs2.c:
        Auto merged
      d78cb899
    • unknown's avatar
      BTREE-indexes in HEAP tables can now be used to optimize ORDER BY · 3c46af6c
      unknown authored
      Don't read character set files if we are using only the default charset. In most cases the user will not anymore get a warning about missing character set files
      Compare strings with space extend instead of space strip. Now the following comparisons holds:  "a" == "a " and "a\t" < "a". (Bug #3152).
      Note: Because of the above fix, one has to do a REPAIR on any table that has an ascii character < 32 last in a CHAR/VARCHAR/TEXT columns.
      
      
      heap/hp_hash.c:
        Comments and DBUG information
      include/my_handler.h:
        Updated prototype for mi_compare_text
      myisam/ft_boolean_search.c:
        Updated calls to mi_compare_text
      myisam/ft_nlq_search.c:
        Updated calls to mi_compare_text
      myisam/ft_parser.c:
        Updated calls to mi_compare_text
      myisam/ft_stopwords.c:
        Updated calls to mi_compare_text
      myisam/ft_update.c:
        Updated calls to mi_compare_text
      myisam/mi_check.c:
        Updated calls to mi_compare_text
      myisam/mi_search.c:
        Changed all string comparisons that removed end space to instead extend the shorter string with space
      myisam/mi_unique.c:
        Updated calls to mi_compare_text
      myisam/mi_write.c:
        Updated calls to mi_compare_text
      myisam/myisam_ftdump.c:
        Removed compiler warning
      mysql-test/r/ctype_collate.result:
        Fixed wrong result
      mysql-test/r/heap_btree.result:
        More tests
      mysql-test/t/heap_btree.test:
        more tests
      mysys/charset.c:
        Don't read charsets if we are only using default charset
        Don't require 'init_available_charsets' to succeed.
      mysys/my_handler.c:
        Compare strings with space extend instead of space strip
      mysys/tree.c:
        Fixed code to get better results for range optimzier
      sql/field.cc:
        Compare strings with space extend instead of space strip
      sql/filesort.cc:
        Compare strings with space extend instead of space strip
      sql/ha_heap.cc:
        Created bit map for keys that are using BTREE. This allows the optimzer to use BTREE's for sorting
      sql/ha_heap.h:
        Created bit map for keys that are using BTREE. This allows the optimzer to use BTREE's for sorting
      strings/ctype-big5.c:
        Compare strings with space extend instead of space strip
      strings/ctype-czech.c:
        Indentation cleanup. Should be fixed to use space extend
      strings/ctype-gbk.c:
        Compare strings with space extend instead of space strip
      strings/ctype-latin1.c:
        Compare strings with space extend instead of space strip
        Added missing my_hash_sort_latin1_de function
      strings/ctype-mb.c:
        For binary strings, don't remove end space when comparing
      strings/ctype-simple.c:
        Compare strings with space extend instead of space strip
      strings/ctype-sjis.c:
        Compare strings with space extend instead of space strip
      strings/ctype-tis620.c:
        Added comments that we should fix end space handling
      strings/ctype-ucs2.c:
        indentation fixes
      strings/ctype-utf8.c:
        Added comments that we should fix end space handling
      strings/ctype-win1250ch.c:
        Added comments that we should fix end space handling
      3c46af6c
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-3.23 · 8711aa16
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-alter-3.23
      
      
      8711aa16
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · bdb87422
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-alias-4.1
      
      
      sql/sql_lex.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      bdb87422
    • unknown's avatar
      bugs-aware post-commit trigger · 5a685dc8
      unknown authored
      cleanup (VERSION variable)
      
      
      5a685dc8
    • unknown's avatar
      7674fd06
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.0/ · fb9b5fd9
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.0
      
      
      fb9b5fd9