- 05 Jan, 2021 1 commit
-
-
Marko Mäkelä authored
-
- 04 Jan, 2021 3 commits
-
-
Marko Mäkelä authored
Let us access trx->lock.n_rec_locks directly.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 01 Jan, 2021 3 commits
-
-
Marko Mäkelä authored
Let us use Intel intrinsic functions in WolfSSL whenever possible. This allows such code to be compiled WITH_MSAN.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
ha_innobase::check_if_supported_inplace_alter(): Invoke is_read_only() only after calling update_thd(). In this way, the assertion failure should be avoided even if the client was reconnected right before an ALTER TABLE statement. This bug was introduced by MDEV-23497.
-
- 26 Dec, 2020 1 commit
-
-
Otto Kekäläinen authored
Move 'encryption' tests to another job, since the 'binlog' and 'rpl' tests are so slow and often make the job timeout (after 50 minutes). Allow failure in ppc64el as it frequently fails due to out-of-memory. A simple restart often fixes it, but we can't depend on restarts. Also re-enable arm64 as MDEV-23955 is now fixed. MERGING: This commit is OK to merge 10.6 and upwards.
-
- 25 Dec, 2020 1 commit
-
-
Vladislav Vaintroub authored
WaitOnAddress() turns out to be too CPU-heavy for the specific scenario, which makes it prominent in profiler output on several benchmarks with contended sux_lock. The condition variable implementation does not show the same behavior. Thus, defined SRWLOCK_DUMMY for Windows srw_mutex should remain mapped to SRWLOCK on Windows (since SRWLOCK is smaller).
-
- 23 Dec, 2020 4 commits
-
-
Otto Kekäläinen authored
If PLUGIN_COLUMNSTORE is not defined, ColumnStore will build automatically by default on supported architectures as defined in its CMakeFile.txt. Thus there should not be any need to inject this build flag at any point and it can be removed to keep thing lean and clean.
-
Otto Kekäläinen authored
ColumnStore seems to build by default, so it must be explicitly disabled with a build flag, so that it does not build at all and thus build machine disk space and CPU will be spared. This reverts commit 113f1868.
-
Marko Mäkelä authored
-
xzhangxian1008 authored
The function is not used anywhere and it seems buggy anyway given Rinat's observations from MDEV-24031 r=robertbindar
-
- 22 Dec, 2020 2 commits
-
-
Aleksey Midenkov authored
Add missed PSI_CALL_drop_table_share().
-
Marko Mäkelä authored
recv_sys_t::apply(): At the end of the last batch, wait for pending reads to complete (read_slots->wait()), instead of waiting for some time, and assert that buf_pool.n_pend_reads==0 after that wait. io_callback(): Do not invoke read_slots->release() before the callback function has returned, to ensure the correct operation of recv_sys_t::apply().
-
- 21 Dec, 2020 14 commits
-
-
Kentoku SHIBA authored
Change default wrapper from mysql to mariadb.
-
Otto Kekäläinen authored
Refactor previous commit to fix mistake revealed by Buildbot. We can't have a structure where PLUGIN_COLUMNSTORE would ever be 'YES' on an arch that does not support it, as the flag overrides any potential platform detection code and builds on non-amd64 would all fail.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
srv_monitor_task(): Make the innodb_fatal_semaphore_wait_threshold watchdog tolerate non-monotonic clock. On NUMA systems, the my_hrtime_coarse() executed by different NUMA nodes are not in sync, and the clock could appear to run backwards. We must treat negative time durations as zero, just like we did in commit ff5d306e in dict_sys_t::mutex_lock_wait(). The wrong logic caused occasional crashes of the test mariabackup.apply-log-only-incr when it was run concurrently with itself with a large number of instances.
-
Otto Kekäläinen authored
- Use new Salsa-CI templates just like downstream does - Also apply adaptations needed for native MariaDB to build correctly on Salsa-CI - Adapt for mysql-8.0 now in Debian Sid, keep also mysql-5.7 test - Test TLSv1.3 to ensure it does not regress - Remove Snappy compression from autopkgtest as it not longer works
-
Otto Kekäläinen authored
ColumnStore files and debian/control stanza was removed in 1edd2243, and thus will not be included in a native build. Also adapt the debian/rules to follow this same policy and only build ColumnStore in builds triggered from autobake-deb.sh. Avoiding building ColumnStore in vain saves a lot of build time and disk space.
-
Otto Kekäläinen authored
Maintaining the same deterministic file order in both upstream (this) and downstream (Debian) repositories makes it easier to compare the delta.
-
Marko Mäkelä authored
We are seeing !buf_pool.any_io_pending() assertion failures in srv_start() ever since MDEV-21452 in 10.6. But, the problem appears to be older. In 10.5 since MDEV-19514 removed writes from the precursor of buf_page_read_complete(), it seems that the debug assertion failure could have been harmless. recv_sys_t::apply(): At the end of each batch, wait not only for all log records to have been processed, but also for all pending reads to complete, so that the buffer pool will be in an idle state.
-
Sergei Golubchik authored
list all supported options in the comment. remove wsrep-specific hack of EXPORT_SYMBOLS, wsrep-specific hacks belong to wsrep
-
Sergei Golubchik authored
Reverts 10.5 commit 6033cc85 The fix a587ded2 will be merged from 10.2
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Marko Mäkelä authored
In commit 0c23e32d (MDEV-24445) we forgot to keep m_freed_space in sync with m_freed_pages in one case.
-
- 19 Dec, 2020 1 commit
-
-
Marko Mäkelä authored
-
- 18 Dec, 2020 4 commits
-
-
Marko Mäkelä authored
In the rewrite of MDEV-8139 (based on MDEV-15528), we introduced a wrong assumption that any persistent tablespace that is not an .ibd file is the system tablespace. This assumption is broken when innodb_undo_tablespaces (files undo001, undo002, ...) are being used. By default, we have innodb_undo_tablespaces=0 (the persistent undo log is being stored in the system tablespace). In MDEV-15528 and MDEV-8139 we rewrote the page scrubbing logic so that it will follow the tried-and-true write-ahead logging protocol, first writing FREE_PAGE records and then in the page flushing, zerofilling or hole-punching freed pages. Unfortunately, the implementation included a wrong assumption that that anything that is not in an .ibd file must be the system tablespace. This wrong assumption would cause overwrites of valid data pages in the system tablespace. mtr_t::m_freed_in_system_tablespace: Remove. mtr_t::m_freed_space: The tablespace associated with m_freed_pages. buf_page_free(): Take the tablespace and page number as a parameter, instead of taking a page identifier.
-
Marko Mäkelä authored
A race condition between deleting an .ibd file and fil_crypt_thread marking pages dirty was introduced in commit 118e258a (part of MDEV-23855). fil_space_t::acquire_if_not_stopped(): Correctly return false if the STOPPING flag is set, indicating that any further activity on the tablespace must be avoided. Also, remove the constant parameter have_mutex=true and move the function declaration to the same compilation unit with the only callers. fil_crypt_flush_space(): Remove an unused variable.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
fil_crypt_find_space_to_rotate(): Always treat the sentinel value that indicates that we have run out of work, even if at the same time the thread should shut down due to other reasons. Thanks to Matthias Leich for reproducing this bug with RQG.
-
- 17 Dec, 2020 2 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
After MDEV-15528, two modes of operation in the fil_crypt_thread remains, depending on whether innodb_encryption_rotate_key_age=0 (whether key rotation is disabled). If the key rotation is disabled, the fil_crypt_thread miss the opportunity to sleep, which will result in lots of wasted CPU usage. fil_crypt_return_iops(): Add a parameter to specify whether other fil_crypt_thread should be woken up. fil_system_t::keyrotate_next(): Return the special value fil_system.temp_space to indicate that no work is to be done. fil_space_t::next(): Propagage the special value fil_system.temp_space to the caller. fil_crypt_find_space_to_rotate(): If no work is to be done, do not wake up other threads.
-
- 16 Dec, 2020 2 commits
-
-
Marko Mäkelä authored
With system mutexes, contention can be very expensive. Let us configure innodb_encryption_threads=1 to minimize contention. The actual work is being done in buf_flush_page_cleaner thread anyway.
-
Marko Mäkelä authored
It turns out that the hang that was fixed in commit 43d3dad1 for the SRW_LOCK_DUMMY implementation is also possible in the futex implementation. We have observed hangs of ssux_lock_low::u_unlock() on Windows where the undesirable value is rw_lock::UPDATER, in the test mariabackup.xb_compressed_encrypted. The exact sequence of events to the hang is not known, but it seems that u_unlock() had better always wake up one thread. Possibly, the case involves multiple blocked u_unlock(). On a busy server, the hang might be 'rescued' by a subsequent lock acquisition and release that is executed by another thread. rw_lock::update_unlock(): Change the return type to void. ssux_lock_low::u_unlock(): Always invoke readers_wake() [sic], to wake up any pending update_lock() or write_lock(). On futex implementation, this will wake up all waiters. On SRW_LOCK_DUMMY, writer_wake() and readers_wake() do the same thing: wake up one write_lock(), or all update_lock() waiters.
-
- 15 Dec, 2020 2 commits
-
-
Etienne Guesnet authored
-
Etienne Guesnet authored
-