1. 05 Jan, 2021 1 commit
  2. 04 Jan, 2021 3 commits
  3. 01 Jan, 2021 3 commits
  4. 26 Dec, 2020 1 commit
    • Otto Kekäläinen's avatar
      Travis-CI: Optimize rate of false negatives vs true failures · 139c85aa
      Otto Kekäläinen authored
      Move 'encryption' tests to another job, since the 'binlog' and 'rpl'
      tests are so slow and often make the job timeout (after 50 minutes).
      
      Allow failure in ppc64el as it frequently fails due to out-of-memory.
      A simple restart often fixes it, but we can't depend on restarts.
      
      Also re-enable arm64 as MDEV-23955 is now fixed.
      
      MERGING: This commit is OK to merge 10.6 and upwards.
      139c85aa
  5. 25 Dec, 2020 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-24142 - Windows - do not use WaitOnAddress-based ssux_lock. · 9118fd36
      Vladislav Vaintroub authored
      WaitOnAddress() turns out to be too CPU-heavy for the specific scenario,
      which makes it prominent in profiler output on several benchmarks with
      contended sux_lock.
      
      The condition variable implementation does not show the same behavior.
      Thus, defined SRWLOCK_DUMMY for Windows
      
      srw_mutex should remain mapped to SRWLOCK on Windows (since SRWLOCK is
      smaller).
      9118fd36
  6. 23 Dec, 2020 4 commits
  7. 22 Dec, 2020 2 commits
  8. 21 Dec, 2020 14 commits
  9. 19 Dec, 2020 1 commit
  10. 18 Dec, 2020 4 commits
    • Marko Mäkelä's avatar
      MDEV-24445 Using innodb_undo_tablespaces corrupts system tablespace · 0c23e32d
      Marko Mäkelä authored
      In the rewrite of MDEV-8139 (based on MDEV-15528), we introduced a
      wrong assumption that any persistent tablespace that is not an .ibd
      file is the system tablespace. This assumption is broken when
      innodb_undo_tablespaces (files undo001, undo002, ...) are being used.
      By default, we have innodb_undo_tablespaces=0 (the persistent undo
      log is being stored in the system tablespace).
      
      In MDEV-15528 and MDEV-8139 we rewrote the page scrubbing logic
      so that it will follow the tried-and-true write-ahead logging
      protocol, first writing FREE_PAGE records and then in the page
      flushing, zerofilling or hole-punching freed pages.
      
      Unfortunately, the implementation included a wrong assumption that
      that anything that is not in an .ibd file must be the system tablespace.
      This wrong assumption would cause overwrites of valid data pages in
      the system tablespace.
      
      mtr_t::m_freed_in_system_tablespace: Remove.
      
      mtr_t::m_freed_space: The tablespace associated with m_freed_pages.
      
      buf_page_free(): Take the tablespace and page number as a parameter,
      instead of taking a page identifier.
      0c23e32d
    • Marko Mäkelä's avatar
      MDEV-24442 Assertion space->referenced() failed in fil_crypt_space_needs_rotation · cd093d79
      Marko Mäkelä authored
      A race condition between deleting an .ibd file and fil_crypt_thread
      marking pages dirty was introduced in
      commit 118e258a (part of MDEV-23855).
      
      fil_space_t::acquire_if_not_stopped(): Correctly return false
      if the STOPPING flag is set, indicating that any further activity
      on the tablespace must be avoided. Also, remove the constant parameter
      have_mutex=true and move the function declaration to the same
      compilation unit with the only callers.
      
      fil_crypt_flush_space(): Remove an unused variable.
      cd093d79
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 4e0004ea
      Marko Mäkelä authored
      4e0004ea
    • Marko Mäkelä's avatar
      MDEV-24426 fixup: Assertion failure on shutdown · a1974d19
      Marko Mäkelä authored
      fil_crypt_find_space_to_rotate(): Always treat the sentinel value
      that indicates that we have run out of work, even if at the same
      time the thread should shut down due to other reasons.
      
      Thanks to Matthias Leich for reproducing this bug with RQG.
      a1974d19
  11. 17 Dec, 2020 2 commits
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · c36a2a0d
      Marko Mäkelä authored
      c36a2a0d
    • Marko Mäkelä's avatar
      MDEV-24426 fil_crypt_thread keep spinning even if innodb_encryption_rotate_key_age=0 · 1fe3dd00
      Marko Mäkelä authored
      After MDEV-15528, two modes of operation in the fil_crypt_thread
      remains, depending on whether innodb_encryption_rotate_key_age=0
      (whether key rotation is disabled). If the key rotation is disabled,
      the fil_crypt_thread miss the opportunity to sleep, which will result
      in lots of wasted CPU usage.
      
      fil_crypt_return_iops(): Add a parameter to specify whether other
      fil_crypt_thread should be woken up.
      
      fil_system_t::keyrotate_next(): Return the special value
      fil_system.temp_space to indicate that no work is to be done.
      
      fil_space_t::next(): Propagage the special value fil_system.temp_space
      to the caller.
      
      fil_crypt_find_space_to_rotate(): If no work is to be done,
      do not wake up other threads.
      1fe3dd00
  12. 16 Dec, 2020 2 commits
    • Marko Mäkelä's avatar
      Speed up mariabackup.xb_compressed_encrypted · af1335c2
      Marko Mäkelä authored
      With system mutexes, contention can be very expensive.
      Let us configure innodb_encryption_threads=1 to minimize contention.
      The actual work is being done in buf_flush_page_cleaner thread anyway.
      af1335c2
    • Marko Mäkelä's avatar
      MDEV-24167 fixup: Wake up all update_lock() in u_unlock() · 07e4b6b2
      Marko Mäkelä authored
      It turns out that the hang that was fixed in
      commit 43d3dad1
      for the SRW_LOCK_DUMMY implementation is also possible in the futex
      implementation. We have observed hangs of ssux_lock_low::u_unlock()
      on Windows where the undesirable value is rw_lock::UPDATER, in the
      test mariabackup.xb_compressed_encrypted.
      
      The exact sequence of events to the hang is not known, but
      it seems that u_unlock() had better always wake up one thread.
      Possibly, the case involves multiple blocked u_unlock().
      
      On a busy server, the hang might be 'rescued' by a subsequent
      lock acquisition and release that is executed by another thread.
      
      rw_lock::update_unlock(): Change the return type to void.
      
      ssux_lock_low::u_unlock(): Always invoke readers_wake() [sic],
      to wake up any pending update_lock() or write_lock().
      On futex implementation, this will wake up all waiters.
      On SRW_LOCK_DUMMY, writer_wake() and readers_wake() do the same
      thing: wake up one write_lock(), or all update_lock() waiters.
      07e4b6b2
  13. 15 Dec, 2020 2 commits