1. 16 Jun, 2004 3 commits
  2. 15 Jun, 2004 2 commits
    • unknown's avatar
      Fixed BUG#3339: Stored procedures in nonexistent schemas are uncallable. · 44d2934f
      unknown authored
      Also added some related security tests and corrected related error messages.
      
      
      mysql-test/r/sp-error.result:
        New test case for BUG#3339, and updated results for other modified error messages.
      mysql-test/r/sp-security.result:
        Added tests for creating procedures in another database with and wihout
        access rights.
      mysql-test/t/sp-error.test:
        New test case for BUG#3339.
      mysql-test/t/sp-security.test:
        Added tests for creating procedures in another database with and wihout
        access rights.
      sql/sp.cc:
        Check existance (and access rights) for database when creating a stored routine.
      sql/sp.h:
        New error return value for sp_create_* functions, for non existing database.
      sql/sql_parse.cc:
        Check error return for create stored routine (non existing database),
        and corrected the error output for some other commands. (Use qualified
        name, not just name.)
      44d2934f
    • unknown's avatar
      Fixed BUG#3368: Stored procedure crash if group_concat(variable). · 05f9e4dd
      unknown authored
      
      mysql-test/r/sp.result:
        New test case for BUG#3368.
      mysql-test/t/sp.test:
        New test case for BUG#3368.
      sql/item.h:
        Corrected const_item() for item_splocal. (Confusing semantics here, but this
        makes group_concat() behave as expected, instead of crashing, and does not
        appear to affect anything else.)
      05f9e4dd
  3. 14 Jun, 2004 4 commits
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 83703fcc
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      
      83703fcc
    • unknown's avatar
      Fixed BUG#3843: ANALYZE TABLE inside stored procedure causes 'Packets out of order' error. · 6fd6652b
      unknown authored
      
      mysql-test/r/sp.result:
        New test case for BUG#3843.
      mysql-test/t/sp.test:
        New test case for BUG#3843.
      sql/sql_yacc.yy:
        Added another multi results special case for stored procedures (analyze).
      6fd6652b
    • unknown's avatar
      Post-merge fixes · 8640403f
      unknown authored
      8640403f
    • unknown's avatar
      Manual merge · e851a009
      unknown authored
      
      include/my_base.h:
        Auto merged
      include/my_bitmap.h:
        Auto merged
      include/my_sys.h:
        Auto merged
      innobase/include/row0mysql.h:
        Auto merged
      innobase/row/row0sel.c:
        Auto merged
      mysys/my_bitmap.c:
        Auto merged
      sql/ha_berkeley.cc:
        Auto merged
      sql/ha_berkeley.h:
        Auto merged
      sql/ha_heap.h:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/ha_innodb.h:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/opt_range.h:
        Auto merged
      sql/sql_select.h:
        Auto merged
      e851a009
  4. 10 Jun, 2004 1 commit
  5. 09 Jun, 2004 4 commits
    • unknown's avatar
      6a0f352b
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 7a303bed
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      
      sql/sp.cc:
        Auto merged
      7a303bed
    • unknown's avatar
      Fixed BUG#2564: SHOW CREATE inconsistent W.R.T ANSI_QUOTES. · 6762a651
      unknown authored
      It's not possible to quote the definition according to the current sql_mode
      setting, so instead we use the setting stored with the SP (that's how it's
      parsed anyway), and show this setting in the SHOW CREATE output.
      
      
      mysql-test/r/sp.result:
        Modifed SHOW CREATE FUNCTION|PROCEDURE output. Show the sql_mode used at
        creation as well.
        New test case for BUG#2564: SHOW CREATE inconsistent W.R.T ANSI_QUOTES.
      mysql-test/t/sp.test:
        New test case for BUG#2564: SHOW CREATE inconsistent W.R.T ANSI_QUOTES.
      sql/sp.cc:
        Rewrote create_string to quote things correctly according to the sql_mode
        used at creation time.
      sql/sp_head.cc:
        Store sql_mode in sp_head and use it for SHOW CREATE.
      sql/sp_head.h:
        Store sql_mode in sp_head and use it for SHOW CREATE.
      6762a651
    • unknown's avatar
      Merge · e51f2946
      unknown authored
      
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      e51f2946
  6. 08 Jun, 2004 2 commits
    • unknown's avatar
      Fixed proper restoring of current db on errors. · 54e3909b
      unknown authored
      This fixes part of BUG#3229: Stored procedure comment causes packets out of order.
      
      
      sql/sp.cc:
        Fixed proper restoring of current db on errors.
      sql/sp.h:
        Fixed proper restoring of current db on errors.
      sql/sp_head.cc:
        Fixed proper restoring of current db on errors.
      54e3909b
    • unknown's avatar
      Merge mysql.com:/home/wax/mysql/mysql-5.0 · 8ac2f605
      unknown authored
      into mysql.com:/home/wax/mysql/mysql-5.0service
      
      
      sql/mysqld.cc:
        Auto merged
      8ac2f605
  7. 07 Jun, 2004 2 commits
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 8a2b50c4
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      
      sql/sql_parse.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      8a2b50c4
    • unknown's avatar
      Post-merge fixes. · 5a83f0c8
      unknown authored
      
      mysql-test/r/index_merge.result:
        Post-merge update of results. (Ok according to Sanja)
      sql/opt_range.cc:
        Post-merge fix provided by Sergey Petrunia.
      sql/sql_select.cc:
        Post-merge fix provided by Sergey Petrunia.
      5a83f0c8
  8. 03 Jun, 2004 1 commit
    • unknown's avatar
      Post-merge fixes. · 17785f63
      unknown authored
      Not finished, will not be pushed until additional fixes have been made.
      
      
      client/mysqlbinlog.cc:
        Post-merge fixes.
      mysql-test/r/func_time.result:
        Post-merge fixes.
      sql/opt_range.cc:
        Post-merge fixes.
      sql/sql_select.cc:
        Post-merge fixes.
      17785f63
  9. 01 Jun, 2004 1 commit
    • unknown's avatar
      More code cleanup, debug prints removed · 40e65508
      unknown authored
      Fixed an incorrect optimizer choice for ror-intersect(key, clustered_primary)
      Typo bug fixed in multitable update
      
      
      sql/opt_range.cc:
        More code cleanup, debug prints removed
        Fixed an incorrect optimizer choice for ror-intersect(key, clustered_primary)
      sql/opt_range.h:
        More code cleanup, debug prints removed
        Fixed an incorrect optimizer choice for ror-intersect(key, clustered_primary)
      sql/sql_update.cc:
        Typo bug fixed
      40e65508
  10. 29 May, 2004 2 commits
    • unknown's avatar
      Manual merge · b7130450
      unknown authored
      
      include/my_base.h:
        Auto merged
      innobase/include/row0mysql.h:
        Auto merged
      innobase/row/row0sel.c:
        Auto merged
      mysql-test/r/index_merge.result:
        Auto merged
      mysql-test/r/index_merge_innodb.result:
        Auto merged
      sql/ha_berkeley.cc:
        Auto merged
      sql/ha_berkeley.h:
        Auto merged
      sql/ha_heap.h:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/ha_innodb.h:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_test.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/opt_range.cc:
        Hand merged
      sql/opt_range.h:
        Hand merged
      b7130450
    • unknown's avatar
      * Undo of range optimizer fix from previous changeset · 2164db3c
      unknown authored
       * Fixed test results.
      
      
      mysql-test/r/index_merge_ror.result:
        Typo fix
      mysql-test/r/rowid_order_bdb.result:
        new index_merge EXPLAIN output format changes
      mysql-test/r/rowid_order_innodb.result:
        new index_merge EXPLAIN output format changes
      sql/opt_range.cc:
        Undo of previous fix:
        If cost(full_scan_on_covering_index) < cost(best_range_scan) <  cost(full_table_scan) 
        use full_scan_on_covering_index, not best_range_scan.
        The fix affects read plan choice for more queries then initially anticipated, so I'm reverting it for now, will get back to this later
      2164db3c
  11. 28 May, 2004 3 commits
    • unknown's avatar
      * New index_merge EXPLAIN output format · 1ce18802
      unknown authored
       * Fixed a problem with wrong query results for partially covering keys in ROR-index_merge
       * ROR-intersection retrieval plan choice algorithm now uses less disk IO
         - and properly processes clustered PK range scans 
       * Fixed several minor range optimizer problems
       * Added more comments
       * Code cleanup
      
      
      mysql-test/r/index_merge.result:
        New index_merge EXPLAIN output format changes
      mysql-test/r/index_merge_innodb.result:
        New index_merge EXPLAIN output format changes
      mysql-test/r/index_merge_ror.result:
        New index_merge EXPLAIN output format changes
        Added test for scans on keys that cover fields partially
        Fixed a minor ROR optimizer problem
      mysql-test/r/index_merge_ror_cpk.result:
        More tests added
      mysql-test/t/index_merge_ror.test:
        New index_merge EXPLAIN output format changes
        Added test for scans on keys that cover fields partially
        Fixed a minor ROR optimizer problem
      mysql-test/t/index_merge_ror_cpk.test:
        More tests added
      mysys/my_bitmap.c:
        Comments added, code cleanup
      sql/opt_range.cc:
        Comments added, code cleanup
        Numerous fixes, see changeset description
      sql/opt_range.h:
        Comments added, code cleanup
        New index_merge EXPLAIN output format related changes
      sql/sql_select.cc:
        Comments added, code cleanup
        New index_merge EXPLAIN output
      1ce18802
    • unknown's avatar
      Fixed BUG#2460: Crash wih Stored Procedure and UNION. · b0921b1f
      unknown authored
      
      mysql-test/r/sp.result:
        Added test case for BUG#2460.
      mysql-test/t/sp.test:
        Added test case for BUG#2460.
      sql/sql_union.cc:
        When called from stored procedures, tabs might be reset already.
      b0921b1f
    • unknown's avatar
      Added test cases for the following bugs that have been fixed by recent changes: · 72139b18
      unknown authored
       BUG#1863: CREATE TABLE in Stored Procedure sometimes crashes on repeated calls.
       BUG#2656: select with join in stored procedure: erroneous result on 2nd call.
       BUG#3426: IF x IS NULL in stored procedure fails on second call within connection.
       BUG#3448: Stored Procedures with inner joins possible bug.
       BUG#3734: Stored procedure returns wrong rows with fulltext parameter.
       BUG#3863: Stored procedure crash when incrementing variable in a loop.
      
      (And corrected the row count output to the client after CALL)
      
      
      mysql-test/r/sp.result:
        New test case results for fixed bugs.
      mysql-test/t/sp.test:
        New test cases for fixed bugs.
      sql/sql_parse.cc:
        Corrected the row_count output to the client.
      72139b18
  12. 26 May, 2004 4 commits
    • unknown's avatar
      Merging 4.1 to 5.0. · f8866c16
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/etc/logging_ok:
        auto-union
      client/mysqltest.c:
        Auto merged
      configure.in:
        Auto merged
      include/my_sys.h:
        Auto merged
      include/mysql_com.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/Makefile.am:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      myisam/mi_check.c:
        Auto merged
      myisam/myisamchk.c:
        Auto merged
      myisam/myisamdef.h:
        Auto merged
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/null.result:
        Auto merged
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/rpl_server_id2.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/variables.result:
        Auto merged
      mysql-test/t/rpl000015.test:
        Auto merged
      mysql-test/t/rpl_error_ignored_table.test:
        Auto merged
      mysql-test/t/rpl_log.test:
        Auto merged
      mysql-test/t/rpl_log_pos.test:
        Auto merged
      mysql-test/t/rpl_max_relay_size.test:
        Auto merged
      mysql-test/t/rpl_relayrotate.test:
        Auto merged
      mysql-test/t/rpl_rotate_logs.test:
        Auto merged
      mysql-test/t/rpl_server_id2.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      mysql-test/t/variables.test:
        Auto merged
      mysys/my_pthread.c:
        Auto merged
      netware/BUILD/compile-netware-all:
        Auto merged
      netware/BUILD/compile-netware-standard:
        Auto merged
      netware/BUILD/mwenv:
        Auto merged
      netware/Makefile.am:
        Auto merged
      netware/my_manage.c:
        Auto merged
      netware/my_manage.h:
        Auto merged
      netware/mysql_test_run.c:
        Auto merged
      scripts/mysql_install_db.sh:
        Auto merged
      sql/Makefile.am:
        Auto merged
      sql/ha_berkeley.cc:
        Auto merged
      sql/ha_berkeley.h:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/ha_innodb.h:
        Auto merged
      sql/ha_myisam.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_subselect.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      sql/lock.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/protocol.cc:
        Auto merged
      sql/protocol.h:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_string.cc:
        Auto merged
      sql/sql_string.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/client_test.c:
        Auto merged
      f8866c16
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 556b51e1
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-sp2_bak-5.0
      
      
      mysql-test/t/sp.test:
        Auto merged
      556b51e1
    • unknown's avatar
      cleunup items of instruction after every instruction execution · 82fd12f4
      unknown authored
      
      sql/sp_head.h:
        removed blanks at line end
        cleunup items of instruction after every instruction execution
      82fd12f4
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · efac33e3
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      
      efac33e3
  13. 25 May, 2004 11 commits
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-4.1 · 3a675ff5
      unknown authored
      into mysql.com:/home/jonas/src/mysql-4.1
      
      
      3a675ff5
    • unknown's avatar
      Bug#3882 · 39ace7f1
      unknown authored
      39ace7f1
    • unknown's avatar
      merge with 4.0 to get Netware patches and fixes for libmysqld.dll · a9b481d3
      unknown authored
      
      configure.in:
        Auto merged
      Build-tools/Do-compile:
        Auto merged
      client/mysql.cc:
        Auto merged
      client/mysqladmin.c:
        Auto merged
      client/mysqlcheck.c:
        Auto merged
      client/mysqldump.c:
        Auto merged
      client/mysqlimport.c:
        Auto merged
      client/mysqlshow.c:
        Auto merged
      client/mysqltest.c:
        Auto merged
      include/my_global.h:
        Auto merged
      include/thr_alarm.h:
        Auto merged
      innobase/include/trx0roll.h:
        Auto merged
      innobase/include/trx0trx.h:
        Auto merged
      innobase/que/que0que.c:
        Auto merged
      innobase/srv/srv0srv.c:
        Auto merged
      innobase/trx/trx0purge.c:
        Auto merged
      innobase/trx/trx0roll.c:
        Auto merged
      innobase/trx/trx0trx.c:
        Auto merged
      innobase/usr/usr0sess.c:
        Auto merged
      isam/isamchk.c:
        Auto merged
      myisam/myisam_ftdump.c:
        Auto merged
      myisam/myisamchk.c:
        Auto merged
      myisam/myisampack.c:
        Auto merged
      mysys/default.c:
        Auto merged
      mysys/my_getopt.c:
        Auto merged
      mysys/my_init.c:
        Auto merged
      mysys/my_pthread.c:
        Auto merged
      netware/Makefile.am:
        Auto merged
      netware/init_db.sql:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      tools/mysqlmanager.c:
        Auto merged
      VC++Files/dbug/dbug.dsp:
        Auto merged
      VC++Files/heap/heap.dsp:
        Auto merged
      VC++Files/isam/isam.dsp:
        Auto merged
      VC++Files/libmysql/libmysql.dsp:
        Auto merged
      VC++Files/myisam/myisam.dsp:
        Auto merged
      VC++Files/myisammrg/myisammrg.dsp:
        Auto merged
      VC++Files/mysys/mysys.dsp:
        Auto merged
      VC++Files/libmysqld/libmysqld.dsp:
        merge
      client/mysqlbinlog.cc:
        merge
      extra/perror.c:
        merge
      include/mysql_com.h:
        merge
      libmysqld/Makefile.am:
        merge
      netware/BUILD/mwenv:
        merge
      sql/mysqld.cc:
        merge
      a9b481d3
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · e7f108e0
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-sp2-5.0
      
      
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      e7f108e0
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · a3d0ce6b
      unknown authored
      into mysql.com:/tmp/skr99/mysql-4.0
      
      
      a3d0ce6b
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.0 · 84fbc276
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.0
      
      
      84fbc276
    • unknown's avatar
      Proposed fix for bug #3818 (libmysqld.dll leads to program's crash) · 19a78cea
      unknown authored
      configurations added to build the libraries with USE_TLS flag to be
      used for libmysqld
      
      
      VC++Files/dbug/dbug.dsp:
        TLS_DEBUG configuration added
      VC++Files/heap/heap.dsp:
        TLS and TLS_DEBUG configurations added
      VC++Files/isam/isam.dsp:
        TLS and TLS_DEBUG configurations added
      VC++Files/libmysql/libmysql.dsp:
        MYSQL_CLIENT define enabled
      VC++Files/libmysqld/libmysqld.dsp:
        using of _tls libraries added
      VC++Files/myisam/myisam.dsp:
        TLS and TLS_DEBUG configurations added
      VC++Files/myisammrg/myisammrg.dsp:
        TLS and TLS_DEBUG configurations added
      VC++Files/mysys/mysys.dsp:
        TLS and TLS_DEBUG configurations added
      include/mysql_com.h:
        __declspec(dllimport) seems to be necessary when one uses .dll
        on Windows
      19a78cea
    • unknown's avatar
      Remove not needed sql_olap.cc from Makefile.am · de5edbf8
      unknown authored
      
      VC++Files/comp_err/comp_err.dsp:
        removed not needed library
      libmysqld/Makefile.am:
        Remove not needed sql_olap.cc
      de5edbf8
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.0 · b287ca53
      unknown authored
      into mysql.com:/tmp/skr99/mysql-4.0
      
      
      client/mysqltest.c:
        Auto merged
      configure.in:
        Auto merged
      include/my_global.h:
        Auto merged
      myisam/myisam_ftdump.c:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      b287ca53
    • unknown's avatar
      Added patches from Novell · b3851363
      unknown authored
      
      Build-tools/Do-compile:
        Fixed indentation
      configure.in:
        Added patches from Novell
        Added C_EXTRA_FLAGS as an easy way to pass flags to both CFLAGS and CXXFLAGS
      extra/perror.c:
        Fixed error number reporting to not report 'Unknown error'
      include/my_global.h:
        Defines to make NETWARE patches cleaner
      include/thr_alarm.h:
        Fixed wrong macro
      netware/mysql_install_db.c:
        Indentation fix
      b3851363
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 095434e5
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      
      095434e5