1. 06 Sep, 2005 5 commits
    • unknown's avatar
      Detect comment with command using extra delimiter · 8bb92058
      unknown authored
      
      mysql-test/include/have_lowercase0.inc:
        Remove extra ; at end of command(causing it to be skipped)
      mysql-test/r/mysqltest.result:
        Update test results
      mysql-test/t/mysqltest.test:
        Add test to detect "comment with command" with extra ; delimiter
        Fix extra ; delimiter
      8bb92058
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1 · c29a8d4e
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      mysql-test/t/mysqltest.test:
        Auto merged
      c29a8d4e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · cfb7ac76
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      ndb/include/util/ndb_opts.h:
        Auto merged
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Auto merged
      ndb/src/kernel/error/ErrorReporter.cpp:
        Auto merged
      ndb/src/kernel/main.cpp:
        Auto merged
      ndb/src/kernel/vm/Emulator.cpp:
        Auto merged
      ndb/src/kernel/vm/Emulator.hpp:
        Auto merged
      ndb/src/mgmsrv/ConfigInfo.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      ndb/tools/Makefile.am:
        Auto merged
      ndb/tools/ndb_config.cpp:
        Auto merged
      ndb/tools/restore/consumer_restore.cpp:
        Auto merged
      ndb/tools/restore/restore_main.cpp:
        Auto merged
      cfb7ac76
    • unknown's avatar
      BUG#12959 mysqltest crashes if testcase passed with -x option · 3ae91695
      unknown authored
       - Update test cases
      
      
      mysql-test/t/mysqltest.test:
        Uncomment the mysqltest -x test. Can't get the output to end up in the result file.
      3ae91695
    • unknown's avatar
      Merge · 7b2aacb7
      unknown authored
      
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Auto merged
      ndb/src/kernel/error/ErrorReporter.cpp:
        Auto merged
      ndb/src/kernel/main.cpp:
        Auto merged
      ndb/src/kernel/vm/Emulator.cpp:
        Auto merged
      ndb/src/kernel/vm/Emulator.hpp:
        Auto merged
      ndb/src/mgmsrv/ConfigInfo.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      ndb/tools/ndb_config.cpp:
        Auto merged
      ndb/tools/restore/consumer_restore.cpp:
        Auto merged
      ndb/include/util/ndb_opts.h:
        merge
      ndb/tools/Makefile.am:
        merge
      ndb/tools/restore/restore_main.cpp:
        merge
      7b2aacb7
  2. 05 Sep, 2005 22 commits
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1 · dd45e416
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      client/mysqltest.c:
        Auto merged
      mysql-test/r/func_gconcat.result:
        Auto merged
      mysql-test/r/mysqltest.result:
        Auto merged
      mysql-test/t/func_gconcat.test:
        Auto merged
      mysql-test/t/mysqltest.test:
        Auto merged
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Auto merged
      ndb/src/kernel/error/ErrorReporter.cpp:
        Auto merged
      ndb/src/kernel/main.cpp:
        Auto merged
      ndb/src/kernel/vm/Emulator.cpp:
        Auto merged
      ndb/src/kernel/vm/Emulator.hpp:
        Auto merged
      ndb/src/mgmsrv/ConfigInfo.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      ndb/tools/ndb_config.cpp:
        Auto merged
      ndb/tools/restore/consumer_restore.cpp:
        Auto merged
      mysql-test/t/openssl_1.test:
        Manual merge
      ndb/include/util/ndb_opts.h:
        Manual merge
      ndb/tools/Makefile.am:
        Manual merge
      ndb/tools/restore/restore_main.cpp:
        Manual merge
      dd45e416
    • unknown's avatar
      BUG#12984 mysqltest.test: different output from "exec NonExistsinfComamdn" · 8b1751e5
      unknown authored
      
      mysql-test/r/mysqltest.result:
        Disable test for failing --exec and --system since output can't be piped to /dev/null on all platforms
      mysql-test/t/mysqltest.test:
        Disable test for failing --exec and --system since output can't be piped to /dev/null on all platforms
        Avoid "echo -e" by using a temporary .sql file for tests that require more than one line.
      8b1751e5
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 4c8361f6
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      4c8361f6
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 441d80a5
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      441d80a5
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.0 · b2d2f188
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug12959/my50-bug12959
      
      
      client/mysqltest.c:
        Auto merged
      b2d2f188
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-4.1 · e54b1fd8
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug12959/my41-bug12959
      
      
      client/mysqltest.c:
        Auto merged
      e54b1fd8
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · c9415fd4
      unknown authored
      into dl145b.mysql.com:/home/ndbdev/mysql-4.1
      
      
      c9415fd4
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/bug12959/my41-bug12959 · 9fad4fde
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug12959/my50-bug12959
      
      
      client/mysqltest.c:
        Auto merged
      mysql-test/t/mysqltest.test:
        Auto merged
      9fad4fde
    • unknown's avatar
      Bug#12959 mysqltest crashes if testcase passed with -x option · e10b50e6
      unknown authored
      
      client/mysqltest.c:
        Fixes for mysqltest -x  <filename>
      mysql-test/t/mysqltest.test:
        Test mysqltest -x <filename>
      mysql-test/include/mysqltest-x.inc:
        New BitKeeper file ``mysql-test/include/mysqltest-x.inc''
      e10b50e6
    • unknown's avatar
      added --core-file option to ndb executables · 4a584b17
      unknown authored
      added parseable printout in ndb_restore
      
      
      4a584b17
    • unknown's avatar
      func_gconcat.test, func_gconcat.result: · 5168730f
      unknown authored
        Test case for bug #12859 group_concat in subquery cause incorrect not null.
      
      
      mysql-test/r/func_gconcat.result:
        Test case for bug #12859 group_concat in subquery cause incorrect not null.
      mysql-test/t/func_gconcat.test:
        Test case for bug #12859 group_concat in subquery cause incorrect not null.
      5168730f
    • unknown's avatar
      Merge mysql.com:/usr/home/ram/work/4.1.b4214 · b48e721d
      unknown authored
      into  mysql.com:/usr/home/ram/work/mysql-5.0
      
      
      myisam/mi_check.c:
        Auto merged
      myisam/mi_packrec.c:
        Auto merged
      myisam/mi_static.c:
        Auto merged
      myisam/myisamdef.h:
        Auto merged
      ndb/src/kernel/main.cpp:
        Auto merged
      ndb/src/kernel/vm/Emulator.cpp:
        Auto merged
      myisam/myisampack.c:
        merging
      b48e721d
    • unknown's avatar
      354fa102
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 43b04480
      unknown authored
      into  mysql.com:/usr/home/ram/work/4.1.b4214
      
      
      myisam/mi_check.c:
        Auto merged
      myisam/myisampack.c:
        Auto merged
      43b04480
    • unknown's avatar
      a fix (bug #4214: Table corruption with myisampack and large BLOB objects). · 943f8335
      unknown authored
      
      myisam/mi_check.c:
        a fix (bug #4214: Table corruption with myisampack and large BLOB objects).
        - pass version to the save_pack_length().
      myisam/mi_packrec.c:
        a fix (bug #4214: Table corruption with myisampack and large BLOB objects).
        - code cleanup: read_pack_length() and calc_pack_length() introduced, 
                        save_pack_length() modified: now the behavior depends on packing version
        - save packing version in the share->pack.version
        - pass it to the read_pack_length()
      myisam/mi_static.c:
        a fix (bug #4214: Table corruption with myisampack and large BLOB objects).
        - packing version set to 2
      myisam/myisamdef.h:
        a fix (bug #4214: Table corruption with myisampack and large BLOB objects).
        - packing version slot introduced (see MI_PACK)
      myisam/myisampack.c:
        a fix (bug #4214: Table corruption with myisampack and large BLOB objects).
        - code cleanup
        - pass version to the calc_pack_length() and save_pack_length()
      943f8335
    • unknown's avatar
      Remove extra ; · e93e346a
      unknown authored
      
      mysql-test/t/openssl_1.test:
        Remove extra delimiter ;
      e93e346a
    • unknown's avatar
      BUG#12983 · a0ea35da
      unknown authored
      TRASH macro confliciting with TRASH in my_sys.h
      
      
      mysys/my_alloc.c:
        Rename TRASH to TRASH_MEM and use the TRASH macro from my_sys.h
      a0ea35da
    • unknown's avatar
      aea2e857
    • unknown's avatar
      Merge mysql.com:/M41/upward-4.1 into mysql.com:/M50/merge-5.0 · 7a0f593d
      unknown authored
      
      client/mysqltest.c:
        Auto merged
      7a0f593d
    • unknown's avatar
      added timestamp to shutdown messages in ndbd · 4345853e
      unknown authored
      4345853e
    • unknown's avatar
      fixed small bug in ndb redolog printer · 0ef85808
      unknown authored
      + added option to dumpe rest of page after exnd of data
      
      
      ndb/src/kernel/blocks/dblqh/redoLogReader/records.cpp:
        fixed small bug in ndb redolog printer
      ndb/src/kernel/blocks/dblqh/redoLogReader/records.hpp:
        fixed small bug in ndb redolog printer
      0ef85808
    • unknown's avatar
      Merge jlindstrom@bk-internal.mysql.com:/home/bk/mysql-5.0 · 4773490d
      unknown authored
      into  hundin.mysql.fi:/home/jan/new/mysql-5.0
      
      
      BitKeeper/etc/ignore:
        auto-union
      4773490d
  3. 04 Sep, 2005 4 commits
    • unknown's avatar
      row0mysql.c, ha_innodb.cc: · c02509b1
      unknown authored
        Fix bug #12308 : do not roll back the whhole transaction in a lock wait timeout error, just roll back the latest SQL statement; note that the locks set in the latest SQL statements remain, as InnoDB does not know what locks were set in which SQL statement
      
      
      sql/ha_innodb.cc:
        Fix bug #12308 : do not roll back the whhole transaction in a lock wait timeout error, just roll back the latest SQL statement; note that the locks set in the latest SQL statements remain, as InnoDB does not know what locks were set in which SQL statement
      innobase/row/row0mysql.c:
        Fix bug #12308 : do not roll back the whhole transaction in a lock wait timeout error, just roll back the latest SQL statement; note that the locks set in the latest SQL statements remain, as InnoDB does not know what locks were set in which SQL statement
      c02509b1
    • unknown's avatar
      This patch disables the query cache for the federated engine. · 7425899f
      unknown authored
      
      sql/ha_federated.h:
        Fix cache issues
      7425899f
    • unknown's avatar
      ha_innodb.cc: · d6b70bf4
      unknown authored
        Better comments about auto-inc and SHOW TABLE STATUS
      
      
      sql/ha_innodb.cc:
        Better comments about auto-inc and SHOW TABLE STATUS
      d6b70bf4
    • unknown's avatar
      ha_innodb.cc: · 53379f98
      unknown authored
        Fix bug #12973 : set the table handle field auto_increment_value if ::info() is called with the flag HA_STATUS_AUTO
      
      
      sql/ha_innodb.cc:
        Fix bug #12973 : set the table handle field auto_increment_value if ::info() is called with the flag HA_STATUS_AUTO
      53379f98
  4. 03 Sep, 2005 7 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 7f38d440
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-5.0-clean
      
      
      7f38d440
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-5.0-11787 · 3eb26b77
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-5.0-clean
      
      
      include/mysql.h:
        Auto merged
      sql-common/client.c:
        Auto merged
      client/mysqltest.c:
        Resolve conflict
      3eb26b77
    • unknown's avatar
      univ.i, page0page.ic: · 8b2b0e24
      unknown authored
        Add a sanity check to page_rec_is_comp; a new univ.i macro UNIV_RELEASE_NOT_YET_STABLE controls such sanity checks that we will remove after the release is stable enough
      
      
      innobase/include/page0page.ic:
        Add a sanity check to page_rec_is_comp; a new univ.i macro UNIV_RELEASE_NOT_YET_STABLE controls such sanity checks that we will remove after the release is stable enough
      innobase/include/univ.i:
        Add a sanity check to page_rec_is_comp; a new univ.i macro UNIV_RELEASE_NOT_YET_STABLE controls such sanity checks that we will remove after the release is stable enough
      8b2b0e24
    • unknown's avatar
      row0sel.c: · 80ea9db8
      unknown authored
        Fix a wrong debug assert in the previous patch
      
      
      innobase/row/row0sel.c:
        Fix a wrong debug assert in the previous patch
      80ea9db8
    • unknown's avatar
      row0sel.c: · cf4a47c0
      unknown authored
        Add more comments to row_search_for_mysql() and remove the ugly double use of the variable rec in that function
      
      
      innobase/row/row0sel.c:
        Add more comments to row_search_for_mysql() and remove the ugly double use of the variable rec in that function
      cf4a47c0
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · 67a74369
      unknown authored
      into  hundin.mysql.fi:/home/heikki/mysql-5.0
      
      
      67a74369
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-4.1 · fd3164e3
      unknown authored
      into  eel.(none):/home/jonas/src/mysql-4.1-push
      
      
      fd3164e3
  5. 02 Sep, 2005 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 17994730
      unknown authored
      into  mysql.com:/home/kostja/mysql/mysql-5.0-dsql3
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/share/errmsg.txt:
        manual merge
      17994730
    • unknown's avatar
      Implement WL#2661 "Prepared Statements: Dynamic SQL in Stored Procedures". · c910050a
      unknown authored
      The idea of the patch is to separate statement processing logic,
      such as parsing, validation of the parsed tree, execution and cleanup, 
      from global query processing logic, such as logging, resetting
      priorities of a thread, resetting stored procedure cache, resetting
      thread count of errors and warnings.
      This makes PREPARE and EXECUTE behave similarly to the rest of SQL
      statements and allows their use in stored procedures.
      This patch contains a change in behaviour:
      until recently for each SQL prepared statement command, 2 queries
      were written to the general log, e.g.
      [Query]   prepare stmt from @stmt_text;
      [Prepare] select * from t1 <-- contents of @stmt_text
      The chagne was necessary to prevent [Prepare] commands from being written
      to the general log when executing a stored procedure with Dynamic SQL.
      We should consider whether the old behavior is preferrable and probably
      restore it.
      This patch refixes Bug#7115, Bug#10975 (partially), Bug#10605 (various bugs
      in Dynamic SQL reported before it was disabled).
      
      
      mysql-test/r/not_embedded_server.result:
        Since we don't want to log Dynamic SQL in stored procedures,
        now the general log gets only one log entry per SQL statement.
      mysql-test/r/sp-error.result:
        - remove obsolete tests
        - a better error message for the case when a stored procedure that
        returns a result set is called from a function
      mysql-test/r/trigger.result:
        - a better error message for the case when a stored procedure that
        returns a result set is called from a trigger
      mysql-test/t/sp-error.test:
        - a better error message for the case when a stored procedure that
          returns a result set is called from a function.
        - move the comment to its place (end of file).
      mysql-test/t/trigger.test:
        - a better error message for the case when a stored procedure that
        returns a result set is called from a trigger
      sql/item_func.cc:
        - we need to pass sql_command explicitly to get_var_with_binlog, because
        when creating a query for SQL prepared statement thd->lex->sql_command
        points at SQLCOM_EXECUTE, which is not listed in the list of update
        queries.
      sql/log_event.h:
        - remove an extra copy of the previous sentence
      sql/mysql_priv.h:
        - fix declarations of sql_prepare.cc API
      sql/share/errmsg.txt:
        - a new error message, when one attempts to execute a prepared statement
        which is currently being executed (this can happen only in Dynamic SQL
        at the moment).
      sql/sp_head.cc:
        - extend sp_multi_results_command to return different flags for a
        command (and rename it)
        - add support for SQLCOM_PREPARE,SQLCOM_EXECUTE, SQLCOM_DEALLOCATE
          to sp_get_flags_for_command
        - replace multiple boolean sp_head members with uint m_flags
        - a fix for a crash when user variables are used in a stored procedure
          and binlog is on. A temporary fix for Bug#12637 "SP crashes the server 
         if it has update query with user var & binlog is enabled", which actually
         stands for stored functions: now instead of a crash we break
         replication if a user variable is used in a stored function which 
         is executed in prelocked mode.
      sql/sp_head.h:
        - replace multiple boolean flags of sp_head with uint m_flags;
        - add flag CONTAINS_DYNAMIC_SQL
        - use this flag to error if a stored procedure with Dynamic SQL is
          called from a function or trigger.
      sql/sql_class.cc:
        - Statement_map::insert should not delete a statement if it exists,
          now it's done externally to be able to handle the case when the
          statement being deleted is in use.
        - remove extra code (free_list is already reset in free_items)
      sql/sql_lex.cc:
        - add lex->stmt_prepare_mode; we can't rely on thd->command any more,
          because we don't reset it any more (Dynamic SQL requirement is that
          PS are as little intrusive as possible).
      sql/sql_lex.h:
        - declare bool LEX::stmt_prepare_mode
      sql/sql_parse.cc:
        - move prepared statement code to sql_prepare.cc
        - change declarations (refactored code)
        - better error message when one attempts to use Dynamic SQL or a 
          stored procedure that returns a result set in a function or trigger.
      sql/sql_prepare.cc:
        - major refactoring to ensure PREPARE/EXECUTE commands do not reset global THD
          state and allow their use in stored procedures.
        - add Prepared_statement::flags and use it to ensure no recursive execution
          of a prepared statement is possible
        - better comments
      sql/sql_yacc.yy:
        - enable PREPARE/EXECUTE/DEALLOCATE in stored procedures
        - produce an error message on attempt to use PREPARE/EXECUTE/DEALLOCATE
          in a stored function or trigger
      mysql-test/r/sp-dynamic.result:
        - sp-dynamic.test results
      mysql-test/t/sp-dynamic.test:
        - a new test for PREPARE/EXECUTE/DEALLOCATE in stored procedures.
      c910050a