1. 06 Nov, 2021 1 commit
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-26956 LeakSanitizer/Valgrind errors in... · 8c9cc2fb
      Thirunarayanan Balathandayuthapani authored
      MDEV-26956 LeakSanitizer/Valgrind errors in trx_mod_table_time_t::start_bulk_insert upon adding system versioning
      
       InnoDB fails to apply buffered insert operation for
      'mysql/transaction_registry' table during system versioning DDL.
      To avoid this, DDL calls extra(HA_EXTRA_IGNORE_INSERT) to
      inform the InnoDB for applying the buffered insert operation.
      8c9cc2fb
  2. 04 Nov, 2021 4 commits
    • Vladislav Vaintroub's avatar
      Merge branch '10.6' into 10.7 · d20de4d4
      Vladislav Vaintroub authored
      d20de4d4
    • Vladislav Vaintroub's avatar
      3ab358f0
    • Marko Mäkelä's avatar
      667e7139
    • Marko Mäkelä's avatar
      MDEV-26966: Remove innodb_force_load_corrupted · 576afcea
      Marko Mäkelä authored
      MySQL 5.5 in commit 177d8b0c
      introduced a configuration parameter innodb_force_load_corrupted
      whose purpose was to allow a corrupted table to be dropped.
      
      Given that MDEV-11412 in MariaDB 10.5.4 aims to allow any metadata
      for a missing or corrupted table to be dropped, and given that
      MDEV-17567 and MDEV-25506 and related tasks made DDL operations
      crash-safe, the parameter no longer serves any purpose.
      
      Because this obscure parameter was read-only (not settable by a client),
      it seems that we can simply declare it with MARIADB_REMOVED_OPTION
      (commit 1bc9cce7) without breaking
      any upgrades.
      
      DICT_ERR_IGNORE_INDEX: Replaces DICT_ERR_IGNORE_INDEX_ROOT and
      DICT_ERR_IGNORE_CORRUPT, which were always set equally.
      
      dict_load_indexes(): Report "No indexes found for table" in
      a uniform way, and only when the DICT_ERR_IGNORE_INDEX flag is
      not set.
      
      If the clustered index is marked corrupted, and the operation
      is DICT_ERR_IGNORE_DROP (we are about to drop the table), we will
      load the metadata; else, we will return DB_INDEX_CORRUPT.
      
      If SYS_INDEXES.PAGE is FIL_NULL, report an error or warning
      unless we are about to drop the table.
      
      dict_load_table_one(): Simplify the logic.
      576afcea
  3. 01 Nov, 2021 2 commits
    • Marko Mäkelä's avatar
      MDEV-26933 InnoDB fails to detect page number mismatch · 993b8edf
      Marko Mäkelä authored
      mtr_t::page_lock(): Validate the page number.
      
      ibuf_tree_root_get(): Remove assertions that became redundant.
      
      The assertions in btr_validate_level() are kind of redundant as well,
      but because they are ut_a(), they are also present in release builds,
      while the ones in mtr_t::page_lock() are only present in debug builds.
      
      btr_cur_position(): Do not duplicate an assertion that is part of
      page_cur_position().
      
      dict_load_tablespace(): Introduce a new option
      DICT_ERR_IGNORE_TABLESPACE that will suppress loading a tablespace
      when a table is going to be dropped.
      993b8edf
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-26947 UNIQUE column checks fail in InnoDB resulting in table corruption · d6e3cd6f
      Thirunarayanan Balathandayuthapani authored
      InnoDB fails to rollback the bulk insert buffered operation when
      trx_mark_sql_stat_end() encounters the DB_DUPLICATE_KEY error.
      In this case, check table fails with secondary index row count
      mismatch. InnoDB gives the error "ER_ERROR_DURING_COMMIT"
      while encountering the DB_DUPLICATE_KEY in trx_mark_sql_stat_end()
      d6e3cd6f
  4. 30 Oct, 2021 2 commits
  5. 29 Oct, 2021 13 commits
    • Sergei Golubchik's avatar
      columnstore · 960b4870
      Sergei Golubchik authored
      960b4870
    • Alexander Barkov's avatar
      MDEV-26732 Assertion `0' failed in Item::val_native · da4479ef
      Alexander Barkov authored
      add a test case
      da4479ef
    • Alexander Barkov's avatar
      6bf5a3be
    • Alexander Barkov's avatar
      MDEV-26742 Assertion `field->type_handler() == this' failed in... · 4300f502
      Alexander Barkov authored
      MDEV-26742 Assertion `field->type_handler() == this' failed in FixedBinTypeBundle<NATIVE_LEN, MAX_CHAR_LEN>::Type_handler_fbt::stored_field_cmp_to_item
      
      The bug was fixed in 10.5 using INET6 specific tests.
      
      This bugs adds only UUID specific tests (no code changes).
      4300f502
    • Alexander Barkov's avatar
      MDEV-26664 Store UUIDs in a more efficient manner · b9f19f7e
      Alexander Barkov authored
      UUID values
      
        llllllll-mmmm-Vhhh-vsss-nnnnnnnnnnnn
      
      are now stored as
      
        nnnnnnnnnnnn-vsss-Vhhh-mmmm-llllllll
      
      inside the record:
      
      - the groups (segments separated by dash) are reordered right-to-left.
      - the bytes inside the groups are not reordered (stored as before,
        in big-endian format).
      
      This provides a better sorting order: the earlier UUID was generated,
      the higher it appears in the ORDER BY output.
      
      Also, this change enables a good key prefix compression,
      because the constant part is now in the beginning, while
      the non-constant part (the timestamp) is in the end.
      b9f19f7e
    • Alexander Barkov's avatar
      Changing the FixedBinTypeBundle parameter to a "storage class" instead of sizes · 50bcda01
      Alexander Barkov authored
      - Adding a new template FixedBinTypeStorage.
      
      - Restoring classes UUID and Inet6
        as primitive "storage classes" for their data types.
        They derive from FixedBinTypeStorage.
        These storage classes have very few server dependencies so they
        can later be easily reused in smart engines, e.g. ColumnStore.
      
      - Changing the FixedBinTypeBundle parameter from
        <size_t NATIVE_LEN, size_t MAX_CHAR_LEN> to <class FbtImpl>
        and fixing UUID and INET6 bundles to get their storage
        classes as a parameter.
      50bcda01
    • Sergei Golubchik's avatar
      b1fab9bf
    • Alexander Barkov's avatar
      MDEV-4958 Adding datatype UUID · 7ab11f2b
      Alexander Barkov authored
      7ab11f2b
    • Sergei Golubchik's avatar
      cleanup: uuid · 72fb37ea
      Sergei Golubchik authored
      72fb37ea
    • Sergei Golubchik's avatar
      cleanup: move most of type_inet plugin implementation into the server · bdaa7fac
      Sergei Golubchik authored
      factor out the the common code for all plugin types that have a
      fixed-length native binary representation and a possibly variable-length
      string representation.
      bdaa7fac
    • Marko Mäkelä's avatar
    • Vicențiu Ciorbaru's avatar
      MDEV-26242: Assertion `i >= 0' failed on setting default_tmp_storage_engine to 'DEFAULT' in 10.7 · 12eb8ad7
      Vicențiu Ciorbaru authored
      Locking / unlocking plugins is already handled by Sys_var_plugin::check
      method. No need to do that in the specialized checking code, use
      var->save_value instead to get the plugin handle.
      12eb8ad7
    • Marko Mäkelä's avatar
      MDEV-25683 Atomic DDL: With innodb_force_recovery=3 InnoDB: Trying to load... · dbd6c6dc
      Marko Mäkelä authored
      MDEV-25683 Atomic DDL: With innodb_force_recovery=3 InnoDB: Trying to load index but the index tree has been freed
      
      The purpose of the parameter innodb_force_recovery is to allow some
      data to be dumped from a corrupted database. Its values used to be
      as follows:
      
      innodb_force_recovery=0: normal (default)
      
      innodb_force_recovery=1: ignore (skip log for) corrupted pages or
      missing data files when applying the redo log
      
      innodb_force_recovery=2: additionally, disable background tasks
      (such as the purge of committed undo logs)
      
      innodb_force_recovery=3: additionally, disable the rollback of
      recovered incomplete (not committed or XA PREPARE) transactions
      
      innodb_force_recovery=4: same as 3 (since MDEV-19514 in MariaDB 10.5)
      
      innodb_force_recovery=5: additionally, do not process any undo log,
      disallow any writes, and force READ UNCOMMITTED isolation level
      
      innodb_force_recovery=6: additionally, pretend that ib_logfile0 does
      not exist (prevent any recovery). Never use this!
      
      The bad thing that happens with innodb_force_recovery=3 and
      innodb_force_recovery=4 is that also the rollback of any recovered
      DDL transaction will be skipped. This would break the DDL log recovery
      that was introduced in MDEV-17567.
      
      For one data directory sample, the DDL log recovery would hangs due to
      a conflict on the InnoDB SYS_TABLES table, because the lock holder
      transaction was not rolled back due to innodb_force_recovery=3.
      
      Fix: Make innodb_force_recovery=3 skip the DML transaction rollback only,
      and make innodb_force_recovery=4 (renamed to SRV_FORCE_NO_DDL_UNDO)
      behave like innodb_force_recovery=3 used to (skip the rollback of all
      recovered transactions, both DML and DDL).
      
      Startup with innodb_force_recovery=4 will be unaffected by this change.
      (There may be hangs, possibly preceded by messages about failing to
      load an index.)
      
      Side note: With innodb_force_recovery=5, any DDL log for InnoDB tables
      will be essentially ignored by InnoDB, but the server will start up.
      dbd6c6dc
  6. 28 Oct, 2021 9 commits
  7. 27 Oct, 2021 9 commits