1. 29 Mar, 2006 1 commit
    • unknown's avatar
      Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries · 8d5277a7
      unknown authored
      The GROUP_CONCAT uses its own temporary table. When ROLLUP is present
      it creates the second copy of Item_func_group_concat. This copy receives the
      same list of arguments that original group_concat does. When the copy is
      set up the result_fields of functions from the argument list are reset to the
      temporary table of this copy.
      As a result of this action data from functions flow directly to the ROLLUP copy
      and the original group_concat functions shows wrong result.
      Since queries with COUNT(DISTINCT ...) use temporary tables to store
      the results the COUNT function they are also affected by this bug.
      
      The idea of the fix is to copy content of the result_field for the function
      under GROUP_CONCAT/COUNT from  the first temporary table to the second one,
      rather than setting result_field to point to the second temporary table.
      To achieve this goal force_copy_fields flag is added to Item_func_group_concat
      and Item_sum_count_distinct classes. This flag is initialized to 0 and set to 1
      into the make_unique() member function of both classes.
      To the TMP_TABLE_PARAM structure is modified to include the similar flag as
      well.
      The create_tmp_table() function passes that flag to create_tmp_field().
      When the flag is set the create_tmp_field() function will set result_field
      as a source field and will not reset that result field to newly created 
      field for Item_func_result_field and its descendants. Due to this there
      will be created copy func to copy data from old result_field to newly 
      created field.
      
      
      mysql-test/t/func_gconcat.test:
        Added test for bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
      mysql-test/r/func_gconcat.result:
        Added test for bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
      sql/sql_table.cc:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added 0 as a last parameter to create_tmp_field()  to force old behaviour.
      sql/sql_select.cc:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        
        Added the flag 'make_copy_field' to create_tmp_field(), so that for Item_result_field descendants create_tmp_field() sets the item's result field as a source field and deny resetting that result field to a new value.
      sql/sql_class.h:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added the flag 'force_copy_fields' to the structure TMP_TABLE_PARAM in order to make create_tmp_field() force the creation of 'copy_field' objects.
      sql/mysql_priv.h:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added the bool parameter 'make_copy_field' to create_tmp_field().
      sql/item_sum.cc:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added initialization of the force_copy_fields flag and passing it to create_tmp_table() through TMP_TBLE_PARAM in the Item_func_group_concat and Item_sum_count_distinct member functions.
      sql/item_sum.h:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added the flag 'force_copy_fields' to the Item_func_group_concat and Item_sum_count_distinct classes.
      8d5277a7
  2. 13 Feb, 2006 2 commits
  3. 11 Feb, 2006 3 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · d86a6a3b
      unknown authored
      into  mysql.com:/usr/local/mysql/mysql-4.1-fixrace
      
      d86a6a3b
    • unknown's avatar
      mysql-test-run.{pl,sh}: · c61c8077
      unknown authored
        Give space for second and third slave port
      
      
      mysql-test/mysql-test-run.pl:
        Give space for second and third slave port
        Define shell variables for all ports, and
        list these at startup
      mysql-test/mysql-test-run.sh:
        Give space for second and third slave port
      c61c8077
    • unknown's avatar
      Fix a race on some platforms in mysql-test-run.pl, where it would sometimes · 544b33c8
      unknown authored
      errorneously abort reporting failure to kill child processes, where in
      reality the problem was merely that the child had become a zombie because
      of missing waitpid() call.
      
      
      mysql-test/lib/mtr_process.pl:
        Fix race (on some platforms) when killing processes.
      544b33c8
  4. 10 Feb, 2006 7 commits
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · 37b7547c
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      37b7547c
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · f0b4ef96
      unknown authored
      into  poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
      
      f0b4ef96
    • unknown's avatar
      Bug #17249 ndb, delete statement with join where clause fails when table do not have pk · 6feda7fa
      unknown authored
      Bug #17257 ndb, update fails for inner joins if tables do not have Primary Key
      
      change: the allocated area by setValue may not be around for later, store hidden key in special member variable instead
      
      
      mysql-test/r/ndb_basic.result:
        Bug #17249 delete statement with join where clause fails when table do not have pk
        Bug #17257 update fails for inner joins if tables do not have Primary Key
      mysql-test/t/ndb_basic.test:
        Bug #17249 delete statement with join where clause fails when table do not have pk
        Bug #17257 update fails for inner joins if tables do not have Primary Key
      sql/ha_ndbcluster.cc:
        Bug #17249 delete statement with join where clause fails when table do not have pk
        Bug #17257 update fails for inner joins if tables do not have Primary Key
        
        change: the allocated area by setValue may not be around for later, store hidden key in special member variable instead
      sql/ha_ndbcluster.h:
        Bug #17249 delete statement with join where clause fails when table do not have pk
        Bug #17257 update fails for inner joins if tables do not have Primary Key
        
        change: the allocated area by setValue may not be around for later, store hidden key in special member variable instead
      6feda7fa
    • unknown's avatar
      support-files/mysql.spec.sh : Use "-i" on "make test-force", essential for log file evaluation. · 67f74290
      unknown authored
      
      support-files/mysql.spec.sh:
        Use "-i" on "make test-force";
        this will prevent "make" from writing "***" which in turn was treated as a _build_ error
        by the log evaluation tool, causing it not to list the failing tests.
      67f74290
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/41-work · f83928ac
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-4.1
      
      
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Auto merged
      f83928ac
    • unknown's avatar
      bug#10987 - ndb - unable to find restorable replica · b8d47d78
      unknown authored
        Introduce new variable c_newest_restorable_gci
          which is set _after_ both GCP_SAVE and COPY_GCI
          
        This variable is used when cutting redo (calcKeepGci)
        
        Also make sure complete GCI is run inbetween LCP's
      
      
      ndb/src/kernel/blocks/dbdih/Dbdih.hpp:
        Introduce new variable c_newest_restorable_gci
          which is set _after_ both GCP_SAVE and COPY_GCI
        
        This variable is used when cutting redo (calcKeepGci)
        Also make sure complete GCI is run inbetween LCP's
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Introduce new variable c_newest_restorable_gci
          which is set _after_ both GCP_SAVE and COPY_GCI
        
        This variable is used when cutting redo (calcKeepGci)
        Also make sure complete GCI is run inbetween LCP's
      b8d47d78
    • unknown's avatar
      bug#17295 - ndb - error while reading REDO log · 7894098e
      unknown authored
        fix corruption due to page 0, file 0 gets released
      
      
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Make sure that page 0, file 0 isnt released
      7894098e
  5. 08 Feb, 2006 1 commit
  6. 07 Feb, 2006 6 commits
  7. 06 Feb, 2006 3 commits
    • unknown's avatar
      Bug #17154 load data infile of char values into a table of char(PK) hangs · ee213a03
      unknown authored
      Bug #17158  	load data infile of char values into table of char with no (PK) fails to load
      Bug #17081  	Doing "LOAD DATA INFILE" directly after delete can cause missing data
      
      
      mysql-test/r/ndb_load.result:
        New BitKeeper file ``mysql-test/r/ndb_load.result''
      mysql-test/t/ndb_load.test:
        New BitKeeper file ``mysql-test/t/ndb_load.test''
      ee213a03
    • unknown's avatar
      bug#13966 - ndb · 6e7adf7c
      unknown authored
        better error message on invalid config change
      
      
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        fix typo
      ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Change error message...note that this is a guess
      6e7adf7c
    • unknown's avatar
      bug#13965 · 42cb2c60
      unknown authored
        ndb - error while restarting in dict
              improve error message when changed config leads to failed restart
      
      
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        improve error message
      42cb2c60
  8. 05 Feb, 2006 1 commit
    • unknown's avatar
      ndb - bug#16693 (4.1) test + workaround, analyze later · 81236ac4
      unknown authored
      
      ndb/test/ndbapi/testBlobs.cpp:
        do batched deletes + list commit across open cursor test cases
      ndb/tools/delete_all.cpp:
        if blobs, no commit across open cursor (single trans)
        cases listed in testBlobs.cpp, analyze later (in 5.0 maybe)
      81236ac4
  9. 03 Feb, 2006 2 commits
    • unknown's avatar
      ndb - replace+tinyblob back-patch from 5.0 [ discard on 4.1->5.0 merge ] · d407a609
      unknown authored
      
      mysql-test/r/ndb_blob.result:
        replace+tinyblob back-patch from 5.0
      mysql-test/t/ndb_blob.test:
        replace+tinyblob back-patch from 5.0
      ndb/src/ndbapi/NdbBlob.cpp:
        replace+tinyblob back-patch from 5.0
      d407a609
    • unknown's avatar
      BUG#16893: Crash in test 'fulltext_order_by' · ff587ac9
      unknown authored
      Fixed that fulltext query + union results in unexpected behaviour.
      
      
      sql/item_func.h:
        Remove access to table object from cleanup() as the table object
        may have been dropped earlier (In case of temporary tables or of
        close_thread_tables() is run before cleanup())
        This fixed a bug with access to already freed memory
      sql/sql_base.cc:
        Reset variables used by fulltext
      ff587ac9
  10. 01 Feb, 2006 2 commits
    • unknown's avatar
      fix for bug #12744 (MYSQL_STMT operations cause seg fault after connection reset) · ac5e4ebe
      unknown authored
      
      libmysql/libmysql.c:
        stmt->mysql could be 0x0 if the connection has failed between prepare and execute
        or any other operation. thus if the user decides to use mysql_stmt_reset()
        we should not segfault.
      tests/mysql_client_test.c:
        test for bug #12744 (MYSQL_STMT operations cause seg fault after connection reset)
      ac5e4ebe
    • unknown's avatar
      BUG#14496: Crash or strange results with prepared statement, · fae10d66
      unknown authored
                 MATCH and FULLTEXT
      Fixed that fulltext query using PS results in unexpected behaviour
      when executed 2 or more times.
      
      
      mysql-test/r/fulltext.result:
        Testcase for BUG#14496.
      mysql-test/t/fulltext.test:
        Testcase for BUG#14496.
      sql/item_func.h:
        In Item_func_match::cleanup() always reset ft_handler to 0.
      fae10d66
  11. 31 Jan, 2006 3 commits
  12. 30 Jan, 2006 4 commits
    • unknown's avatar
      Merge aivanov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 75c41d29
      unknown authored
      into  mysql.com:/home/alexi/innodb/mysql-4.1-merged
      
      75c41d29
    • unknown's avatar
      Fixed BUG#15653, BUG#16582. · 1675beef
      unknown authored
        Applied innodb-4.1-ss20 snapshot.
      
      
      innobase/btr/btr0sea.c:
        Applied innodb-4.1-ss20 snapshot.
          Account for a race condition when dropping the adaptive
          hash index for a B-tree page (Bug #16582).
          btr_search_drop_page_hash_index(): Retry the operation if a hash
          index with different parameters was built meanwhile. Add
          diagnostics for the case that hash node pointers to the page
          remain. This fix is from Heikki.
          btr_search_info_update_hash(), btr_search_info_update_slow():
          Document the parameter "info" as in/out.
      innobase/fil/fil0fil.c:
        Applied innodb-4.1-ss20 snapshot.
          Keep track on unflushed modifications to file spaces. When
          there are tens of thousnads of file spaces, flushing all files
          in fil_flush_file_spaces() would be very slow (Bug #16582).
          fil_flush_file_spaces(): Only flush unflushed file spaces.
          fil_space_t, fil_system_t: Add a list of unflushed spaces.
      innobase/include/btr0sea.ic:
        Applied innodb-4.1-ss20 snapshot.
          btr_search_info_update_hash(), btr_search_info_update_slow():
          Document the parameter "info" as in/out.
      1675beef
    • unknown's avatar
      Merge aivanov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 0f729b36
      unknown authored
      into  mysql.com:/home/alexi/innodb/mysql-4.1-merged
      
      0f729b36
    • unknown's avatar
      Fixed BUG#16387. · a323b6b7
      unknown authored
        Applied innodb-4.1-ss17 snapshot.
        Do not mistake TABLENAME_ibfk_0 for auto-generated id.
      
      
      innobase/dict/dict0dict.c:
        Applied innodb-4.1-ss17 snapshot.
          dict_table_get_highest_foreign_id(): Ignore foreign
          constraint identifiers starting with the pattern
          TABLENAME_ibfk_0 (BUG#16387).
      mysql-test/r/innodb.result:
        Applied innodb-4.1-ss17 snapshot.
          Fixed results for added test case.
      mysql-test/t/innodb.test:
        Applied innodb-4.1-ss17 snapshot.
          Added test case.
      a323b6b7
  13. 28 Jan, 2006 3 commits
    • unknown's avatar
      mysql-test-run.pl: · 98d7f3f4
      unknown authored
        Aligned the MTR_BUILD_THREAD policy to shell version
      
      
      mysql-test/mysql-test-run.pl:
        Aligned the MTR_BUILD_THREAD policy to shell version
      98d7f3f4
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.0 · 9f7b42ec
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      
      mysql-test/mysql-test-run.sh:
        Auto merged
      9f7b42ec
    • unknown's avatar
      mysql-test-run.sh: · e41208c6
      unknown authored
        Bug#16780: Extend port range to make space for 5.1 NDBCLUSTER_PORT_SLAVE
      
      
      mysql-test/mysql-test-run.sh:
        Bug#16780: Extend port range to make space for 5.1 NDBCLUSTER_PORT_SLAVE
      e41208c6
  14. 27 Jan, 2006 2 commits