1. 17 Jul, 2006 4 commits
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 8db9d704
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/subselect.result:
        Manual merge
      mysql-test/t/subselect.test:
        Manual merge
      8db9d704
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · f4aa13fe
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      f4aa13fe
    • unknown's avatar
      select.result, select.test: · a23ae773
      unknown authored
        Test case for bug#10977 altered to make it work in both plain and ps-protocol modes.
      
      
      mysql-test/t/select.test:
        Test case for bug#10977 altered to make it work in both plain and ps-protocol modes.
      mysql-test/r/select.result:
        Test case for bug#10977 altered to make it work in both plain and ps-protocol modes.
      a23ae773
    • unknown's avatar
      mysql.test, mysql.result: · 0ccdc6ab
      unknown authored
        Corrected the test case after fixing bug#10977
      
      
      mysql-test/t/mysql.test:
        Corrected the test case after fixing bug#10977
      mysql-test/r/mysql.result:
        Corrected the test case after fixing bug#10977
      0ccdc6ab
  2. 16 Jul, 2006 1 commit
  3. 15 Jul, 2006 4 commits
    • unknown's avatar
      errmsg.txt: · 6f07adce
      unknown authored
        Fixed bug#10977: No warning issued if a column name is truncated
        New warning message is added.
      
      
      sql/share/errmsg.txt:
        Fixed bug#10977: No warning issued if a column name is truncated
        New warning message is added.
      6f07adce
    • unknown's avatar
      Fixed bug#10977: No warning issued if a column name is truncated · db1c95e8
      unknown authored
      When an alias is set to a column leading spaces are removed from the alias.
      But when this is done on aliases set by user this can lead to confusion.
      
      Now Item::set_name() method issues the warning if leading spaces were removed
      from an alias set by user.
      
      New warning message is added.
      
      
      mysql-test/t/select.test:
        Added test case for bug#10977:No warning issued if a column name is truncated.
      mysql-test/r/select.result:
        Added test case for bug#10977:No warning issued if a column name is truncated.
      sql/sql_yacc.yy:
        Fixed bug#10977: No warning issued if a column name is truncated
        The is_autogenerated_name flag is set before set_name() method call.
      sql/item.cc:
        Fixed bug#10977: No warning issued if a column name is truncated
        Now Item::set_name() method issues the warning if leading spaces were removed
        from an alias set by user.
      db1c95e8
    • unknown's avatar
      Fixed bug #20869. · d771113d
      unknown authored
      The bug caused a crash of the server if a subquery with
      ORDER BY DESC used the range access method.
      The bug happened because the method QUICK_SELECT_DESC::reset
      was not reworked after MRR interface had been introduced.
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #20869.
      mysql-test/t/subselect.test:
        Added a test case for bug #20869.
      d771113d
    • unknown's avatar
      Fixed bug #20519. · c181b7d9
      unknown authored
      The bug was due to a loss happened during a refactoring made
      on May 30 2005 that modified the function JOIN::reinit.
      As a result of it for any subquery the value of offset_limit_cnt
      was not restored for the following executions. Yet the first 
      execution of the subquery made it equal to 0.
      The fix restores this value in the function JOIN::reinit.  
      
      
      mysql-test/r/subselect.result:
        Added a test case fir bug #20519.
      mysql-test/t/subselect.test:
        Added a test case fir bug #20519.
      c181b7d9
  4. 14 Jul, 2006 5 commits
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · b8daca65
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      
      VC++Files/sql/mysqld.dsp:
        Auto merged
      b8daca65
    • unknown's avatar
      fix for a compatibility build problem on MacOSX intel. · 7998b41d
      unknown authored
      Discussed with Kent.
      
      
      ndb/test/ndbapi/Makefile.am:
        Fix for a compatibility build problem on MacOSX Intel.
      7998b41d
    • unknown's avatar
      Merge macbook.gmz:/Users/kgeorge/mysql/work/B17212-4.1-opt · 6dd4b63f
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B17212-5.0-opt
      
      
      mysql-test/r/innodb_mysql.result:
        Merge 4.1->5.0 for bug #17212
      mysql-test/t/innodb_mysql.test:
        Merge 4.1->5.0 for bug #17212
      sql/sql_select.cc:
        Merge 4.1->5.0 for bug #17212
      6dd4b63f
    • unknown's avatar
      Correction for test tesults after pushing the fix for bug 19714. · 1cf79688
      unknown authored
      
      mysql-test/r/ps_7ndb.result:
        Correction for test results after pushing the fix for bug 19714.
      1cf79688
    • unknown's avatar
      Fixed bug #19714. · 31ace3a8
      unknown authored
      DESCRIBE returned the type BIGINT for a column of a view if the column
      was specified by an expression over values of the type INT.
          
      E.g. for the view defined as follows:
        CREATE VIEW v1 SELECT COALESCE(f1,f2) FROM t1
      DESCRIBE returned type BIGINT for the only column of the view if f1,f2 are
      columns of the INT type.
      At the same time DESCRIBE returned type INT for the only column of the table
      defined by the statement:
        CREATE TABLE t2 SELECT COALESCE(f1,f2) FROM t1.
          
      This inconsistency was removed by the patch.
      
      Now the code chooses between INT/BIGINT depending on the
      precision of the aggregated column type.
       
      Thus both DESCRIBE commands above returns type INT for v1 and t2.
       
      
      
      mysql-test/r/analyse.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/bigint.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/create.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/olap.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_2myisam.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_3innodb.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_4heap.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_5merge.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_6bdb.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/ps_7ndb.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/sp.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/subselect.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/type_ranges.result:
        Adjusted the results after having fixed bug #19714.
      mysql-test/r/view.result:
        Added a test case for bug #19714.
      mysql-test/t/view.test:
        Added a test case for bug #19714.
      31ace3a8
  5. 13 Jul, 2006 3 commits
    • unknown's avatar
      Merge moonbone.local:/work/16302-bug-4.1-opt-mysql · 20e4fca6
      unknown authored
      into  moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      sql/item_subselect.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        Manual merge
      mysql-test/t/subselect.test:
        Manual merge
      20e4fca6
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 71a94a5b
      unknown authored
      into  moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      
      mysql-test/r/rpl_insert_id.result:
        Auto merged
      mysql-test/t/rpl_insert_id.test:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      71a94a5b
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e7c6468b
      unknown authored
      into  moonbone.local:/home/evgen/bk-trees/mysql-5.0-opt
      
      
      sql/item.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      e7c6468b
  6. 12 Jul, 2006 4 commits
    • unknown's avatar
      Fix a valgrind warning in type_date test. · b3180c89
      unknown authored
      
      sql/item_timefunc.cc:
        Fix a valgrind warning in type_date test.	
      b3180c89
    • unknown's avatar
      Merge dl145k.mysql.com:/data0/mkindahl/bkroot/mysql-5.0 · 4136cfc3
      unknown authored
      into  dl145k.mysql.com:/data0/mkindahl/bk/mysql-5.0-rpl
      
      
      ndb/include/kernel/GlobalSignalNumbers.h:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/ndbapi/ndberror.c:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      4136cfc3
    • unknown's avatar
      Bug #17212 results not sorted correctly by ORDER BY when using index · 5337f8ae
      unknown authored
        * don't use join cache when the incoming data set is already ordered
          for ORDER BY
          This choice must be made because join cache will effectively
          reverse the join order and the results will be sorted by the index
          of the table that uses join cache.
      
      
      mysql-test/r/innodb_mysql.result:
        Bug #17212 results not sorted correctly by ORDER BY when using index
          * Test suite for the bug
      mysql-test/t/innodb_mysql.test:
        Bug #17212 results not sorted correctly by ORDER BY when using index
          * Test suite for the bug
      sql/sql_select.cc:
        Bug #17212 results not sorted correctly by ORDER BY when using index
          * don't use join cache when the incoming data set is already sorted
      5337f8ae
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · c00cabe9
      unknown authored
      into  moonbone.local:/work/16302-bug-4.1-opt-mysql
      
      
      mysql-test/r/subselect.result:
        SCCS merged
      mysql-test/t/subselect.test:
        SCCS merged
      c00cabe9
  7. 11 Jul, 2006 10 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 9b909022
      unknown authored
      into  moonbone.local:/work/18503-bug-4.1-mysql
      
      
      sql/sql_select.cc:
        Auto merged
      9b909022
    • unknown's avatar
      Fixed bug#18503: Queries with a quantified subquery returning empty set · 6cb398a5
      unknown authored
      may return a wrong result.
      
      An Item_sum_hybrid object has the was_values flag which indicates whether any
      values were added to the sum function. By default it is set to true and reset
      to false on any no_rows_in_result() call. This method is called only in
      return_zero_rows() function. An ALL/ANY subquery can be optimized by MIN/MAX
      optimization. The was_values flag is used to indicate whether the subquery
      has returned at least one row. This bug occurs because return_zero_rows() is
      called only when we know that the select will return zero rows before
      starting any scans but often such information is not known.
      In the reported case the return_zero_rows() function is not called and
      the was_values flag is not reset to false and yet the subquery return no rows
      Item_func_not_all and Item_func_nop_all functions return a wrong
      comparison result.
      
      The end_send_group() function now calls no_rows_in_result() for each item
      in the fields_list if there is no rows were found for the (sub)query.
      
      
      mysql-test/t/subselect.test:
        Added test case for bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
      mysql-test/r/subselect.result:
        Added test case for bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
      sql/sql_select.cc:
        Fixed bug#18503: Queries with a quantified subquery returning empty set may return a wrong result.
        
        The end_send_group() function now calls no_rows_in_result() for each item
        in the fields_list if there is no matching rows were found.
      6cb398a5
    • unknown's avatar
      Merge moonbone.local:/work/allany-4.1-mysql · 2f365f04
      unknown authored
      into  moonbone.local:/work/16302-bug-4.1-opt-mysql
      
      2f365f04
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 7ad3c5bf
      unknown authored
      into  moonbone.local:/home/evgen/bk-trees/mysql-4.1-opt
      
      
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      7ad3c5bf
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 9a06032b
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime-merge-41
      
      
      sql/sql_table.cc:
        Auto merged
      9a06032b
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-5.0-release · edbc99d9
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-amerge
      
      
      sql/handler.h:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      edbc99d9
    • unknown's avatar
      Raise the version number. · 3d5d9e0b
      unknown authored
      3d5d9e0b
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · cf7a380b
      unknown authored
      into  trift2.:/M50/mysql-5.0
      
      cf7a380b
    • unknown's avatar
      Merge dl145k.mysql.com:/data0/mkindahl/bkroot/mysql-5.0-rpl · 94342039
      unknown authored
      into  dl145k.mysql.com:/data0/mkindahl/bk/MERGE/mysql-5.0-merge
      
      
      ndb/include/kernel/GlobalSignalNumbers.h:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/ndbapi/ndberror.c:
        Auto merged
      94342039
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 0bb02ba4
      unknown authored
      into  bodhi.local:/opt/local/work/mysql-5.0-runtime-merge-41
      
      
      sql/opt_range.cc:
        Auto merged
      support-files/mysql.spec.sh:
        Auto merged
      mysql-test/Makefile.am:
        Manual merge.
      0bb02ba4
  8. 10 Jul, 2006 9 commits
    • unknown's avatar
      Fix yet another Windows build failure: "true" -> TRUE · 79c44420
      unknown authored
      
      sql/sql_locale.cc:
        "true" -> TRUE
      79c44420
    • unknown's avatar
      Merge trift2.:/M50/clone-5.0 · b6e3a53a
      unknown authored
      into  trift2.:/M50/mysql-5.0
      
      
      configure.in:
        Auto merged
      b6e3a53a
    • unknown's avatar
      Raise the version number. · 6362eafe
      unknown authored
      6362eafe
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 46db366f
      unknown authored
      into  moonbone.local:/work/allany-4.1-mysql
      
      46db366f
    • unknown's avatar
      Fixed bug#16302: Quantified subquery without any tables gives wrong results · b25d6158
      unknown authored
      The ALL/ANY subqueries are the subject of MIN/MAX optimization. The matter
      of this optimization is to embed MIN() or MAX() function into the subquery
      in order to get only one row by which we can tell whether the expression
      with ALL/ANY subquery is true or false.
      But when it is applied to a subquery like 'select a_constant' the reported bug
      occurs. As no tables are specified in the subquery the do_select() function 
      isn't called for the optimized subquery and thus no values have been added 
      to a MIN()/MAX() function and it returns NULL instead of a_constant.
      This leads to a wrong query result.
      
      For the subquery like 'select a_constant' there is no reason to apply
      MIN/MAX optimization because the subquery anyway will return at most one row.
      Thus the Item_maxmin_subselect class is more appropriate for handling such
      subqueries.
      
      The Item_in_subselect::single_value_transformer() function now checks
      whether tables are specified for the subquery. If no then this subselect is
      handled like a UNION using an Item_maxmin_subselect object.
      
      
      mysql-test/t/subselect.test:
        Added test case for bug#16302: Quantified subquery without any tables gives wrong results
      mysql-test/r/subselect.result:
        Added test case for bug#16302: Quantified subquery without any tables gives wrong results
      sql/item_subselect.cc:
        Fixed bug#16302: Quantified subquery without any tables gives wrong results
         
        The Item_in_subselect::single_value_transformer() function now checks
        whether tables are specified for the subquery. If no then this subselect is
        handled like a UNION using an Item_maxmin_subselect object.
      b25d6158
    • unknown's avatar
      Fix a Windows build failure. · fdbe0141
      unknown authored
      
      sql/sql_locale.cc:
        Fix Windows compilation failure "cannot convert from 'const char [6]' 
        to 'const BOOL'" and an apparent bug (use of "FALSE" instead of FALSE
        for initialization of is_ascii member of MY_LOCALE)
      fdbe0141
    • unknown's avatar
      Revoking patch for Bug#10952 on behalf of Brian. · 2c3fd953
      unknown authored
      2c3fd953
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 9d85551a
      unknown authored
      into  gbichot3.local:/home/mysql_src/mysql-5.0
      
      9d85551a
    • unknown's avatar
      more 4.1->5.0 merge fixes for bug#14553 · be148b34
      unknown authored
      
      mysql-test/r/rpl_insert_id.result:
        more merge fixes for bug#14553
      mysql-test/t/rpl_insert_id.test:
        more merge fixes for bug#14553
      be148b34