1. 09 May, 2019 1 commit
  2. 08 May, 2019 7 commits
    • Jan Lindström's avatar
      Merge 10.1 into 10.2 · 9d3e2a7c
      Jan Lindström authored
      9d3e2a7c
    • Daniel Bartholomew's avatar
      bump the VERSION · 3e5526b0
      Daniel Bartholomew authored
      3e5526b0
    • Marko Mäkelä's avatar
      Null merge mariadb-10.1.40 into 10.1 · 4ad72028
      Marko Mäkelä authored
      4ad72028
    • Andrea Kao's avatar
      edit MariaDB license info so that GitHub recognizes it · 27232a9f
      Andrea Kao authored
      GitHub uses a library called Licensee to identify a project's license
      type. It shows this information in the status bar and via the API if it
      can unambiguously identify the license.
      
      This commit modifies a few of MariaDB's docs so that Licensee is able
      to recognize the repository's license type. It renames the README's
      "License" section to "Licensing" and renames COPYING.thirdparty to
      THIRDPARTY.
      
      These changes allow Licensee to bypass both files when it
      scans the repo for license files, which thus allows Licensee to
      successfully identify the license type of MariaDB as GPL 2.0.
      Signed-off-by: default avatarAndrea Kao <eirinikos@gmail.com>
      27232a9f
    • Galina Shalygina's avatar
      MDEV-19139: pushdown condition with Item_func_set_user_var · f2e27d53
      Galina Shalygina authored
      The bug occurs because Item_func_set_user var is allowed to be pushed
      into materialized derived table/view.
      To fix it excl_dep_on_table() as added to Item_func_set_user_var class
      to prevent pushdown.
      f2e27d53
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-19387 innodb_ft_result_cache_limit_32 fails on s390x · 7b93d71a
      Thirunarayanan Balathandayuthapani authored
      Fix:
      ====
      1) Combined innodb_ft_result_cache_limit_32.test and
      innodb_ft_result_cache_limit_64.test test case in sys_vars suite.
      
      2) Use word_size.inc for combinations of innodb_ft_result_cache_limit test case.
      7b93d71a
    • Marko Mäkelä's avatar
      MDEV-19408 Assertion on trx->state failed in ReadView::copy_trx_ids · e0271a7b
      Marko Mäkelä authored
      ReadView::copy_trx_ids(): Relax a debug check. It failed to account for
      TRX_STATE_PREPARED_RECOVERED, which was introduced in MDEV-15772.
      It was also reading trx->state twice and failed to tolerate
      TRX_STATE_COMMITTED_IN_MEMORY, which could be concurrently assigned
      in lock_trx_release_locks(), which is not holding trx_sys->mutex.
      
      This bug is specific to the MariaDB 10.2 series. The ReadView was
      introduced in MariaDB 10.2.2 by merging the code that had been
      introduced in MySQL 5.7.2. In MariaDB 10.3, ReadView::snapshot()
      would use the lock-free trx_sys.rw_trx_hash. MDEV-14638 moved the
      corresponding assertion to trx_sys_t::find(), where it was duly
      protected by trx->mutex, and later MDEV-14756 moved the check to
      rw_trx_hash_t::validate_element(). This check was correctly adjusted
      when MDEV-15772 was merged to 10.3.
      e0271a7b
  3. 07 May, 2019 5 commits
  4. 06 May, 2019 7 commits
  5. 05 May, 2019 2 commits
  6. 04 May, 2019 5 commits
    • Oleksandr Byelkin's avatar
      update Connector C · 409aba76
      Oleksandr Byelkin authored
      409aba76
    • Oleksandr Byelkin's avatar
      Merge branch '10.1' into 10.2 · 8cbb14ef
      Oleksandr Byelkin authored
      8cbb14ef
    • Varun Gupta's avatar
      MDEV-18373: DENSE_RANK is not calculated correctly · 43458683
      Varun Gupta authored
      Need to call split_sum_func if an aggregate function is part of order by
      or partition by clause so that we have the required fields inside the temporary
      table, as all the fields inside the partition by and order by clause of the
      window function needs to be there in the temp table used for window function
      computation.
      43458683
    • Varun Gupta's avatar
      MDEV-14791: Crash with order by expression containing window functions · a6ea7996
      Varun Gupta authored
      The issue here is that for a window function in the ORDER BY clause, we were not
      creating an extra field in the temporary table for the window function
      (which is contained in an expression).
      So a call to split_sum_func is added to handle this case
      
      Also we need to update all items that contain a window function
      in the temp table during window function computation as filesort would need
      these values to be updated to calculate the ORDER BY clause of the select.
      a6ea7996
    • Varun Gupta's avatar
      MDEV-17781: Server crashes in next_linear_tab · e292c67b
      Varun Gupta authored
      For degenerate joins we may have JOIN::table_list as NULL, so instead
      of using JOIN::top_join_tab_count use the function JOIN::exec_join_tab_cnt
      to get the number of tables joined at the top level.
      e292c67b
  7. 03 May, 2019 4 commits
    • Marko Mäkelä's avatar
      MDEV-19385: Inconsistent definition of dtuple_get_nth_v_field() · ce195987
      Marko Mäkelä authored
      The accessor dtuple_get_nth_v_field() was defined differently between
      debug and release builds in MySQL 5.7.8 in
      mysql/mysql-server@c47e1751b742454de553937039bbf2bcbe3c6bc7
      and a debug assertion to document or enforce the questionable assumption
      tuple->v_fields == &tuple->fields[tuple->n_fields] was missing.
      
      This was apparently no problem until MDEV-11369 introduced instant
      ADD COLUMN to MariaDB Server 10.3. With that work present, in one
      test case, trx_undo_report_insert_virtual() could in release builds
      fetch the wrong value for a virtual column.
      
      We replace many of the dtuple_t accessors with const-preserving
      inline functions, and fix missing or misleadingly applied const
      qualifiers accordingly.
      ce195987
    • Marko Mäkelä's avatar
      MDEV-19346: Remove dummy InnoDB log checkpoints · 3db94d24
      Marko Mäkelä authored
      log_checkpoint(), log_make_checkpoint_at(): Remove the parameter
      write_always. It seems that the primary purpose of this parameter
      was to ensure in the function recv_reset_logs() that both checkpoint
      header pages will be overwritten, when the function is called from
      the never-enabled function recv_recovery_from_archive_start().
      
      create_log_files(): Merge recv_reset_logs() to its only caller.
      
      Debug instrumentation: Prefer to flush the redo log, instead of
      triggering a redo log checkpoint.
      
      page_header_set_field(): Disable a debug assertion that will
      always fail due to MDEV-19344, now that we no longer initiate
      a redo log checkpoint before an injected crash.
      
      In recv_reset_logs() there used to be two calls to
      log_make_checkpoint_at(). The apparent purpose of this was
      to ensure that both InnoDB redo log checkpoint header pages
      will be initialized or overwritten.
      The second call was removed (without any explanation) in MySQL 5.6.3:
      mysql/mysql-server@4ca37968da54ddc6b3b6628f41428ddba1c79bb8
      
      In MySQL 5.6.8 WL#6494, starting with
      mysql/mysql-server@00a0ba8ad92569fcf08212b3b8cf046dc8a0ce10
      the function recv_reset_logs() was not only invoked during
      InnoDB data file initialization, but also during a regular
      startup when the redo log is being resized.
      
      mysql/mysql-server@45e91679832219e2593c77185342f11f85232b58
      in MySQL 5.7.2 removed the UNIV_LOG_ARCHIVE code, but still
      did not remove the parameter write_always.
      3db94d24
    • Eugene Kosov's avatar
      MDEV-17702 fix unaligned access UB in sint4korr() and similar functions · bcc13592
      Eugene Kosov authored
      Disable (hopefully temprorary) this check. Also add tests for some serialized
      functions.
      bcc13592
    • Jan Lindström's avatar
      MDEV-17883: CREATE TABLE IF NOT EXISTS locking changes in 10.3.10 · 15f06559
      Jan Lindström authored
      Based on pull request https://github.com/MariaDB/server/pull/999
      by mkaruza@galeracluster.com
      15f06559
  8. 02 May, 2019 5 commits
    • Vladislav Vaintroub's avatar
      MDEV-17008 prepare with datadir, on Windows, does not set ACL · 13d7c721
      Vladislav Vaintroub authored
      on tablespace files
      
      Fix is to always add Full Control for NetworkService account, for every
      file that copyback/moveback copies around.
      13d7c721
    • Oleksandr Byelkin's avatar
      Merge branch '5.5' into 10.1 · b85aa200
      Oleksandr Byelkin authored
      b85aa200
    • Daniel Bartholomew's avatar
      bump the VERSION · 8cda7ab6
      Daniel Bartholomew authored
      8cda7ab6
    • Vladislav Vaintroub's avatar
      MDEV-18544 "missing required privilege PROCESS on *.*" using mariabackup for SST · 4b0f010b
      Vladislav Vaintroub authored
      If required privilege is missing, dump the output from "SHOW GRANTS"
      into mariabackup log.
      
      This will help troubleshooting, and make the bug reproducible.
      4b0f010b
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-14398 innodb_encryption_rotate_key_age=0 causes innodb_encrypt_tables to be ignored · ada1074b
      Thirunarayanan Balathandayuthapani authored
      The statement
      
      SET GLOBAL innodb_encryption_rotate_key_age=0;
      
      would have the unwanted side effect that ENCRYPTION=DEFAULT tablespaces
      would no longer be encrypted or decrypted according to the setting of
      innodb_encrypt_tables.
      
      We implement a trigger, so that whenever one of the following is executed:
      
      SET GLOBAL innodb_encrypt_tables=OFF;
      SET GLOBAL innodb_encrypt_tables=ON;
      SET GLOBAL innodb_encrypt_tables=FORCE;
      
      all wrong-state ENCRYPTION=DEFAULT tablespaces will be added to
      fil_system_t::rotation_list, so that the encryption will be added
      or removed.
      
      Note: This will *NOT* happen automatically after a server restart.
      Before reading the first page of a data file, InnoDB cannot know
      the encryption status of the data file. The statement
      SET GLOBAL innodb_encrypt_tables will have the side effect that
      all not-yet-read InnoDB data files will be accessed in order to
      determine the encryption status.
      
      innodb_encrypt_tables_validate(): Stop disallowing
      SET GLOBAL innodb_encrypt_tables when innodb_encryption_rotate_key_age=0.
      This reverts part of commit 50eb40a2
      that addressed MDEV-11738 and MDEV-11581.
      
      fil_system_t::read_page0(): Trigger a call to fil_node_t::read_page0().
      Refactored from fil_space_get_space().
      
      fil_crypt_rotation_list_fill(): If innodb_encryption_rotate_key_age=0,
      initialize fil_system->rotation_list. This is invoked both on
      SET GLOBAL innodb_encrypt_tables and
      on SET GLOBAL innodb_encryption_rotate_key_age=0.
      
      fil_space_set_crypt_data(): Remove.
      
      fil_parse_write_crypt_data(): Simplify the logic.
      
      This is joint work with Marko Mäkelä.
      ada1074b
  9. 01 May, 2019 4 commits
    • Varun Gupta's avatar
      MDEV-19352: Server crash in alloc_histograms_for_table_share upon query from information schema · ca94ce2a
      Varun Gupta authored
      To read histograms for a table, we should check if the allocation of statistics was done or not,
      if not done we should not try to read histograms for such a table.
      ca94ce2a
    • Varun Gupta's avatar
      Adjusting sql_command to align with higher version, this is an adjustment · 57c37e6c
      Varun Gupta authored
      to the patch for MDEV-17605
      57c37e6c
    • Anel Husakovic's avatar
      MDEV-17654 Incorrect syntax returned for column with CHECK constraint in the... · 2370eeb0
      Anel Husakovic authored
      MDEV-17654 Incorrect syntax returned for column with CHECK constraint in the "SHOW CREATE TABLE ..." result
      
      Prepend COMMENT before CHECK constraint in SHOW CREATE
      
      Closes #924
      2370eeb0
    • Daniel Black's avatar
      MDEV-15051: signal handler - output information about the core generation · dc8e15db
      Daniel Black authored
      The working directory, resource limits and core pattern will
      aid the user finding a core file in the case of failure.
      
      While the core file size is most relevant however other resource
      limits may give a clue as the the cause of the fatal signal so
      include them also.
      
      As signal handler functions are limited, proc filesystem reads/
      readlink calls are used instead of the more obvious getcwd/getrlimits
      functions which aren't listed as signal safe.
      
      Results in output of the form:
      
      Writing a core file: working directory at /tmp/datadir
      Resource Limits:
      Limit                     Soft Limit           Hard Limit Units
      Max cpu time              unlimited            unlimited seconds
      Max file size             unlimited            unlimited bytes
      Max data size             unlimited            unlimited bytes
      Max stack size            8388608              unlimited bytes
      Max core file size        unlimited            unlimited bytes
      Max resident set          unlimited            unlimited bytes
      Max processes             47194                47194 processes
      Max open files            1024                 4096 files
      Max locked memory         65536                65536 bytes
      Max address space         unlimited            unlimited bytes
      Max file locks            unlimited            unlimited locks
      Max pending signals       47194                47194 signals
      Max msgqueue size         819200               819200 bytes
      Max nice priority         0                    0
      Max realtime priority     0                    0
      Max realtime timeout      unlimited            unlimited            us
      Core pattern: |/usr/libexec/abrt-hook-ccpp %s %c %p %u %g %t %P %I
      
      Segmentation fault (core dumped)
      
      Closes #537
      dc8e15db