An error occurred fetching the project authors.
  1. 02 Jun, 2005 1 commit
    • unknown's avatar
      Additional tweak to fix for bug #10543, to prevent a change in · 9087bc6c
      unknown authored
      behavior when extending fields that were fully part of a
      multi-part key.
      
      
      mysql-test/r/key.result:
        Update results
      mysql-test/t/key.test:
        Add test for behavior of extending fields in a multi-part key
        that were defined with a partial length the same as their
        field length.
      sql/sql_table.cc:
        Reset key_part_length when old field length was the same as the
        old key_part_length.
      9087bc6c
  2. 26 May, 2005 1 commit
    • unknown's avatar
      Fix partial keys when converting VARCHAR to TEXT. (Bug #10543) · 36808374
      unknown authored
      mysql-test/r/type_varchar.result:
        Update results
      mysql-test/t/type_varchar.test:
        Add new regression test
      sql/field.cc:
        Add Field::type_can_have_key_part() static method
      sql/field.h:
        Add Field::type_can_have_key_part() signature.
      sql/sql_table.cc:
        Only reset the length of a key part when changing from a
        field type that can't be used partially to a field that can,
        or vice versa, or when the part is smaller than the length
        of the field.
      36808374
  3. 16 May, 2005 1 commit
    • unknown's avatar
      After merge fixes · d17645ed
      unknown authored
      mysql-test/r/alter_table.result:
        Fixed results after merge
      sql/handler.cc:
        Trivial optimzation
      sql/sql_table.cc:
        Trvial optimization
      sql/sql_yacc.yy:
        After merge fix
      sql/unireg.cc:
        Removed argument 'null_fields' from make_empty_rec() as it was not needed
        Moved assert() to right place to take bit fields into account
      d17645ed
  4. 14 May, 2005 1 commit
    • unknown's avatar
      After merge fixes · 2fc28a36
      unknown authored
      BitKeeper/deleted/.del-outfile2.result~fb702ee2518d8e6d:
        Delete: mysql-test/r/outfile2.result
      libmysql/libmysql.c:
        Fix indentation for new function mysql_set_character_set()
      mysql-test/r/alter_table.result:
        Fix test to be in same order as in 4.0
      mysql-test/r/innodb.result:
        After merge fix
      mysql-test/r/insert_update.result:
        Add extra test for insert into ... on duplicate key upate
      mysql-test/r/outfile.result:
        After merge fix
      mysql-test/t/alter_table.test:
        Fix test to be in same order as in 4.0
      mysql-test/t/insert_update.test:
        Add extra test for insert into ... on duplicate key upate
      mysql-test/t/outfile.test:
        After merge fix
      sql/item_func.cc:
        After merge fix
      sql/sql_table.cc:
        After merge fix
      2fc28a36
  5. 13 May, 2005 1 commit
    • unknown's avatar
      Change create_field->offset to store offset from start of fields, independent of null bits. · d19e0585
      unknown authored
      Count null_bits separately from field offsets and adjust them in case of primary key parts.
      (Previously a CREATE TABLE with a lot of null fields that was part of a primary key caused MySQL to wrongly count the number of bytes needed to store null bits)
      This is a more complete bug fix for #6236
      
      
      mysql-test/r/alter_table.result:
        More test for bug #6236 (CREATE TABLE didn't properly count not null columns for primary keys)
      mysql-test/t/alter_table.test:
        More test for bug #6236 (CREATE TABLE didn't properly count not null columns for primary keys)
      sql/handler.h:
        Add counter for null fields
      sql/sql_table.cc:
        Change create_field->offset to store offset from start of fields, independent of null bits.
        Count null_bits separately from field offsets and adjust them in case of primary key parts.
      sql/unireg.cc:
        Change create_field->offset to store offset from start of fields, independent of null bits.
        Count null_bits separately from field offsets and adjust them in case of primary key parts.
      d19e0585
  6. 12 May, 2005 1 commit
    • unknown's avatar
      fix (Bug #8295 and #8296: varchar and varbinary conversion) · 8e8d66ea
      unknown authored
      select, gis & gis-tree tests fails at the moment, but
      I will push this CS because it was tested before and I'm absolutely
      sure it's right.
      
      
      mysql-test/r/strict.result:
        fix (Bugs #8295 and #8296: varchar and varbinary conversion)
      mysql-test/r/type_blob.result:
        fix (Bugs #8295 and #8296: varchar and varbinary conversion)
      mysql-test/t/strict.test:
        fix (Bugs #8295 and #8296: varchar and varbinary conversion)
      sql/sql_table.cc:
        fix (Bugs #8295 and #8296: varchar and varbinary conversion):
        1. fon't convert datatypes if it's strict mode;
        2. better warning.
      8e8d66ea
  7. 08 May, 2005 1 commit
    • unknown's avatar
      Bug#6236 · 454070c1
      unknown authored
        Incomplete ALTER TABLE breaks MERGE compatibility
        Fix implicit NOT NULL not set on ALTER of PK columns
      
      
      mysql-test/r/alter_table.result:
        Test for Bug#6236
      mysql-test/t/alter_table.test:
        Test for Bug#6236
      sql/sql_table.cc:
        Implicit NOT NULL not set on ALTER of PK columns
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      454070c1
  8. 07 May, 2005 1 commit
    • unknown's avatar
      Fix for bug#9897: Views: 'Check Table' crashes MySQL, with a view and a table in the statement · 7fb76f01
      unknown authored
         thd->lex->derived_tables should be zero(it may be changed if we open a view)
      
      
      mysql-test/r/check.result:
        Fix for bug#9897: Views: 'Check Table' crashes MySQL, with a view and a table in the statement
      mysql-test/t/check.test:
        Fix for bug#9897: Views: 'Check Table' crashes MySQL, with a view and a table in the statement
      sql/sql_table.cc:
        Fix for bug#9897: Views: 'Check Table' crashes MySQL, with a view and a table in the statement
      7fb76f01
  9. 06 May, 2005 1 commit
    • unknown's avatar
      Fixes while reviewing new code · 19fc09c5
      unknown authored
      Added option --count to mysqlshow (to show number of rows)
      Fixed possible core dump in information schema
      
      
      client/client_priv.h:
        --count for mysqlshow
      client/mysqlshow.c:
        Added option --count to be used when the user want's number of rows per table in the output
        (We shouldn't use count(*) as default as this can be a slow operation)
      mysys/my_thr_init.c:
        Correct comment
      sql/ha_berkeley.cc:
        Remove not used variable
      sql/ha_berkeley.h:
        Remove not used variable
      sql/ha_innodb.cc:
        Remove not used function
      sql/ha_ndbcluster.cc:
        false -> FALSE
        true -> TRUE
      sql/handler.cc:
        Added and fixed comments
        Remove 'strange' code to remove compiler warnings (better to do things like this with attribute)
      sql/item.cc:
        false -> FALSE
      sql/item_cmpfunc.cc:
        Fixed indentation
      sql/item_cmpfunc.h:
        marked BETWEEN as a bool function
      sql/item_func.cc:
        Simple optimzation
      sql/key.cc:
        Removed wrong code
      sql/log.cc:
        Check result from open_index_file()
      sql/mysql_priv.h:
        Simplyfy some test of netware
      sql/mysqld.cc:
        Fixed indentation
        Check result form open_index_file()
        Simplify code with IF_NETWARE()
      sql/opt_range.cc:
        false -> FALSE
        true -> TRUE
        Fixed indentation
      sql/opt_sum.cc:
        Fixed comments
      sql/sp_head.cc:
        Simple optimzation
        Move variable declarations to begining of blocks
      sql/sql_acl.cc:
        Fix long lines
        Rename xx -> column
        Move declaration to beginning of block
      sql/sql_parse.cc:
        Removed comment
      sql/sql_select.cc:
        Indentation fixes
      sql/sql_show.cc:
        Fixed reference outside of array (possible core dump)
      sql/sql_table.cc:
        Simplify code
        Combine common code
      sql/sql_test.cc:
        false -> FALSE
      sql/sql_trigger.cc:
        false -> false
        true -> TRUE
      sql/sql_yacc.yy:
        Simpler test
      sql/unireg.cc:
        Added comment
      19fc09c5
  10. 28 Apr, 2005 1 commit
    • unknown's avatar
      Fix 'CREATE TABLE ... LIKE ...' when lower_case_table_names · f54194e2
      unknown authored
      is set on case-sensitive file systems and the source table
      was specified in something other than lowercase. (Bug #9761)
      
      
      mysql-test/r/lowercase_table.result:
        Add results
      mysql-test/t/lowercase_table.test:
        Regression test for Bug #9761
      sql/sql_table.cc:
        When lower_case_table_names is set, make sure to look for
        the source table using a lowercase filename.
      f54194e2
  11. 19 Apr, 2005 1 commit
    • unknown's avatar
      Bug#9102 - Stored proccedures: function which returns blob causes crash · 515f37f2
      unknown authored
        Initialization of fields for sp return type was not complete.
      
      
      mysql-test/r/sp.result:
        Bug#9102
          Test for bug
      mysql-test/t/sp.test:
        Bug#9102
          Test for bug
      sql/mysql_priv.h:
        Bug#9102
          new function: sp_prepare_create_field()
      sql/sp_head.cc:
        Strip spaces and do charset conversion for sp function typelibs
      sql/sql_table.cc:
        Bug#9102
          new function - sp_prepare_create_field()
          prepares create_field in similar way to mysql_prepare_table()
      sql/sql_yacc.yy:
        Bug#9102
      515f37f2
  12. 12 Apr, 2005 3 commits
    • unknown's avatar
      Bit type: code clean-up. · bd5c737c
      unknown authored
      sql/field.h:
        Field_bit_as_char::size_of() added - we use it in the ::new_key_field().
      sql/sql_table.cc:
        We have to set pack_flag for bit fields in the mysql_prepare_table()
        as we use it in the create_length_to_internal_length().
      bd5c737c
    • unknown's avatar
      Bit type: code cleanup. · 5900eb79
      unknown authored
      sql/field.cc:
        We have to use memcmp() here to get determinate results.
      sql/sql_table.cc:
        Should set pack_flag here instead of doing |=
      5900eb79
    • unknown's avatar
      Bit type support for non-MyISAM tables. · 8be051ae
      unknown authored
      8be051ae
  13. 11 Apr, 2005 1 commit
    • unknown's avatar
      Fix for BUG#9149 "OPTIMIZE TABLE statement on InnoDB table is logged twice in the binary log" · 92c44205
      unknown authored
      if we fall back to mysql_alter_table() (for InnoDB), don't do binlogging in mysql_alter_table(), as mysql_admin_table()
      is not supposed to do any binlogging (it is done by the caller).
      
      
      sql/sql_table.cc:
        When optimizing a table, if we fall back to mysql_alter_table()
        (for InnoDB), don't do binlogging in mysql_alter_table(), as mysql_admin_table()
        is not supposed to do any binlogging (it is done by the caller).
      92c44205
  14. 07 Apr, 2005 1 commit
    • unknown's avatar
      InnoDB: Prevent ALTER TABLE ... ENGINE=... · 8579d3cd
      unknown authored
      if there are foreign key constraints on the table. (Bug #5574)
      
      
      sql/ha_innodb.cc:
        Add method can_switch_engines()
      sql/ha_innodb.h:
        Add method can_switch_engines()
      sql/handler.h:
        Add method can_switch_engines()
      sql/sql_table.cc:
        Check handler::can_switch_engines() before switching storage engines
      8579d3cd
  15. 04 Apr, 2005 1 commit
  16. 02 Apr, 2005 1 commit
    • unknown's avatar
      bug#3891 - DROP TABLE many-unexistent-tables, was printing an error with %s instead of table names · ee2923fc
      unknown authored
      sql/sql_table.cc: print an error with a function that respects width modifiers (%.64s)
      
      
      mysql-test/r/drop.result:
        bug#3891 - DROP TABLE many-unexistent-tables, was printing an error with %s instead of table names
      mysql-test/t/drop.test:
        bug#3891 - DROP TABLE many-unexistent-tables, was printing an error with %s instead of table names
      sql/share/english/errmsg.txt:
        allow longer "table names" as DROP TABLE puts a list here
      sql/share/russian/errmsg.txt:
        allow longer "table names" as DROP TABLE puts a list here
      sql/share/ukrainian/errmsg.txt:
        allow longer "table names" as DROP TABLE puts a list here
      sql/sql_table.cc:
        print an error with a function that respects width modifiers (%.64s)
      ee2923fc
  17. 01 Apr, 2005 1 commit
    • unknown's avatar
      Invalid DEFAULT values for CREATE TABLE now generates errors. (Bug #5902) · ec6be08b
      unknown authored
      CAST() now produces warnings when casting a wrong INTEGER or CHAR values. This also applies to implicite string to number casts. (Bug #5912)
      ALTER TABLE now fails in STRICT mode if it generates warnings.
      Inserting a zero date in a DATE, DATETIME or TIMESTAMP column during TRADITIONAL mode now produces an error. (Bug #5933)
      
      
      mysql-test/r/bigint.result:
        New warning added
      mysql-test/r/cast.result:
        Added testing of wrong CAST's of strings to numbers and numbers to strings
      mysql-test/r/create.result:
        Added test for wrong default values (#5902)
      mysql-test/r/func_if.result:
        Changed tests to produce less warnings
      mysql-test/r/func_misc.result:
        New warning
      mysql-test/r/func_str.result:
        Added missing drop table
        Changed test to produce less warnings
        New warnings
      mysql-test/r/ndb_index_unique.result:
        Removed wrong default usage
      mysql-test/r/ps_1general.result:
        Changed tests to produce less warnings
      mysql-test/r/row.result:
        New warnings
      mysql-test/r/rpl_session_var.result:
        Changed tests to produce less warnings
      mysql-test/r/strict.result:
        New tests for CAST() and zero date handling
      mysql-test/r/subselect.result:
        Changed tests to produce less warnings
      mysql-test/r/type_ranges.result:
        Changed tests to produce less warnings
      mysql-test/t/cast.test:
        Added testing of wrong CAST's of strings to numbers and numbers to strings
      mysql-test/t/create.test:
        Added test for wrong default values (#5902)
      mysql-test/t/func_if.test:
        Changed tests to produce less warnings
      mysql-test/t/func_str.test:
        Added missing drop table
        Changed test to produce less warnings
        New warnings
      mysql-test/t/ndb_index_unique.test:
        Removed wrong default usage
      mysql-test/t/ps_1general.test:
        Changed tests to produce less warnings
      mysql-test/t/rpl_session_var.test:
        Changed tests to produce less warnings
      mysql-test/t/strict.test:
        New tests for CAST() and zero date handling
      mysql-test/t/subselect.test:
        Changed tests to produce less warnings
      mysql-test/t/type_ranges.test:
        Changed tests to produce less warnings
      sql/Makefile.am:
        Added new include file
      sql/field.cc:
        Added warnings for zero dates for DATE, DATETIME and TIMESTAMP
        Moved Field_blob::max_length() to a more appropriate position
        Changed type for 'level' in set_warning() to avoid casts
      sql/field.h:
        Changed type for 'level' in set_warning() to avoid casts
      sql/field_conv.cc:
        Copy date and datetime fields through string in 'traditional' mode to detect zero dates
      sql/item.cc:
        Removed compiler warnings
        Give warnings for wrong CAST of strings -> number
      sql/item.h:
        Moved Item_string::val_real() and ::val_int() to item.cc
      sql/item_row.cc:
        Better detection of null values (which doesn't produce warnings)
      sql/item_sum.cc:
        Better detection of null values (which doesn't produce warnings)
      sql/item_timefunc.cc:
        Give warnings for wrong CAST of number -> string
      sql/my_decimal.cc:
        Fixed typo in comment
      sql/mysql_priv.h:
        Removed prototype for static function
        Moved defines for error handling to sql_error.h (to be able to use these in field.h)
      sql/mysqld.cc:
        Simplify code
      sql/sql_class.h:
        Moved to sql_error.h
      sql/sql_load.cc:
        Removed wrong cast
      sql/sql_parse.cc:
        Fixed wrong printf()
      sql/sql_table.cc:
        Made mysql_prepare_table() static
        Changed references to pointers to make code more readable
        ALTER TABLE now aborts if one gets warnings in STRICT mode
      sql/time.cc:
        Fixed possible wrong call
      sql/unireg.cc:
        Removed one call to current_thd
        Give errors if one uses a wrong DEFAULT value
      ec6be08b
  18. 27 Mar, 2005 1 commit
    • unknown's avatar
      Fix for bugs #5859 "DROP TABLE does not drop triggers" and · 64ed3d13
      unknown authored
      #6559 "DROP DATABASE forgets to drop triggers".
      
      If we drop table we should also drop all triggers associated with it.
      To do this we have to check for existence of .TRG file when we are 
      dropping table and delete it too.
      
      
      mysql-test/r/trigger.result:
        Added tests for bugs #5859 "DROP TABLE does not drop triggers"
        and #6559 "DROP DATABASE forgets to drop triggers".
      mysql-test/t/trigger.test:
        Added tests for bugs #5859 "DROP TABLE does not drop triggers"
        and #6559 "DROP DATABASE forgets to drop triggers".
      sql/handler.cc:
        Added .TRG to the list of known extensions of files associated with 
        tables.
      sql/mysql_priv.h:
        Added declaration of constant holding extension for trigger files.
      sql/sql_table.cc:
        mysql_rm_table_part2():
          If we drop table we should also drop all triggers associated with it.
          To do this we have to check for existence of .TRG file and delete it
          (until the moment when we will store trigger definitions in the same
           .FRM file as table description).
      sql/sql_trigger.cc:
        Made constant holding extension for trigger files externally visible.
      64ed3d13
  19. 22 Mar, 2005 2 commits
    • unknown's avatar
      Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if · 94056a48
      unknown authored
      the row type is dynamic (For 4.1 tables old 'VARCHAR' fields are converted to
      true VARCHAR in the next ALTER TABLE)
            
      This ensures that one can use MySQL 5.0 privilege tables with MySQL 4.1.
      
      (Fix imported from main 5.0 tree to 5.0.3 build tree.)
      
      
      mysql-test/r/information_schema.result:
        Update results (for .frm version number change)
      mysql-test/r/ndb_autodiscover.result:
        Update results (for .frm version number change)
      mysql-test/r/ps_1general.result:
        Update results (for .frm version number change)
      mysql-test/r/show_check.result:
        Update results (for .frm version number change)
      mysql-test/r/view.result:
        Update results (for .frm version number change)
      scripts/fill_func_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      scripts/mysql_create_system_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      sql/sql_table.cc:
        Only set create_info->varchar if we are using the new VARCHAR field
      scripts/mysql_fix_privilege_tables.sh:
        Fixed bug that made it impossible to run the script from the mysql source dist
      scripts/mysql_fix_privilege_tables.sql:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      sql/table.cc:
        Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if
        the row type is dynamic (For 4.1 tables old 'VARCHAR' fields are converted to
        true VARCHAR in the next ALTER TABLE)
      94056a48
    • unknown's avatar
      Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if... · 3bd059e9
      unknown authored
      Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if the row type is dynamic
      (For 4.1 tables old 'VARCHAR' fields are converted to true VARCHAR in the next ALTER TABLE)
      
      This ensures that one can use MySQL 5.0 privilege tables with MySQL 4.1
      
      
      mysql-test/r/information_schema.result:
        Update results (for .frm version number change)
      mysql-test/r/ndb_autodiscover.result:
        Update results (for .frm version number change)
      mysql-test/r/ps_1general.result:
        Update results (for .frm version number change)
      mysql-test/r/show_check.result:
        Update results (for .frm version number change)
      mysql-test/r/view.result:
        Update results (for .frm version number change)
      scripts/fill_func_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      scripts/mysql_create_system_tables.sh:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      scripts/mysql_fix_privilege_tables.sh:
        Fixed bug that made it impossible to run the script from the mysql source dist
      scripts/mysql_fix_privilege_tables.sql:
        Ensure that no privilege tables that is used in 4.1 uses VARCHAR
      sql/sql_table.cc:
        Only set create_info->varchar if we are using the new VARCHAR field
      sql/table.cc:
        Hack to ensure that CHAR's created in 5.0 are not converted to VARCHAR even if the row type is dynamic
        (For 4.1 tables old 'VARCHAR' fields are converted to true VARCHAR in the next ALTER TABLE)
      3bd059e9
  20. 19 Mar, 2005 1 commit
    • unknown's avatar
      Eliminate warnings noticed by VC7. This includes fixing my_mmap() on · 22234f31
      unknown authored
      Windows to call CreateFileMapping() with correct arguments, and
      propogating the introduction of query_id_t to everywhere query ids are
      passed around. (Bug #8826)
      
      
      libmysql/libmysql.c:
        Make implicit cast explicit
      myisam/mi_open.c:
        Make cast of value to smaller data size explicit
      myisam/mi_packrec.c:
        Cast file size (my_off_t) to size_t for mmap
      mysys/my_mmap.c:
        Fix Windows version of my_mmap() to use the right parameters
        for call to CreateFileMapping()
      sql/field.cc:
        Use temporary value of correct type
      sql/field.h:
        Use query_id_t for query_id value
      sql/ha_berkeley.cc:
        Fix flag check
      sql/ha_innodb.h:
        Use query_id_t for query_id value
      sql/handler.cc:
        Explain opt_using_transactions calculation, and add cast
      sql/handler.h:
        Fix forward declaration of COND
      sql/item.cc:
        Fix val_bool() tests of val_int() to avoid implicit cast
      sql/item_cmpfunc.cc:
        Fix typo in switch label
      sql/item_func.cc:
        Make implicit cast explicit
      sql/item_strfunc.cc:
        Now that query_id is a query_id_t, need to cast it to a ulong here
      sql/item_subselect.cc:
        Fix test of value
      sql/log.cc:
        Cast my_off_t used for file size to size_t for memory allocation
        Also cast my_off_t when using it to calculate the number of pages for TC log
        Cast total_ha_2pc to uchar when saving it
      sql/mysql_priv.h:
        Move up query_id definition so it can be used more widely
      sql/opt_range.cc:
        Add unused delete operator to prevent compiler warning
      sql/set_var.cc:
        Cast value for max_user_connections
      sql/sql_cache.cc:
        Remove unused label
      sql/sql_class.h:
        Fix query id values to be of type query_id_t
      sql/sql_db.cc:
        Move variable only used inside #ifdef within the #ifdef
      sql/sql_help.cc:
        Remove unused label
      sql/sql_insert.cc:
        Use query_id_t for query id values
      sql/sql_lex.h:
        Add unused delete operator to prevent compiler warning
      sql/sql_select.cc:
        Remove unused variable
        Make cast of value explicit
      sql/sql_select.h:
        Use query_id_t for query id values
      sql/sql_table.cc:
        Make comparison to function pointer explicit
      sql/sql_update.cc:
        Use query_id_t for query id values
      sql/table.h:
        Use query_id_t for query id values
      strings/ctype-simple.c:
        Add cast of long value to (char) in expression
      strings/ctype-ucs2.c:
        Add cast of long value to (char) in expression
      strings/ctype-utf8.c:
        Make cast to smaller size explicit
      22234f31
  21. 16 Mar, 2005 3 commits
    • unknown's avatar
      Move handler dependent tests to the specific handler (myisam, bdb, innodb) · de53c2b3
      unknown authored
      Enabled VARCHAR testing for innodb
      
      NOTE: innodb.test currently fails becasue of a bug in InnoDB. 
      I have informed Heikki about this and expect him to fix this ASAP
      
      
      mysql-test/include/varchar.inc:
        Move handler dependent tests to the specific handler (myisam, bdb, innodb)
      mysql-test/r/innodb.result:
        Added varchar tests
      mysql-test/r/myisam.result:
        Update results
      mysql-test/t/bdb.test:
        Move handler dependent tests to the specific handler (myisam, bdb, innodb)
      mysql-test/t/innodb.test:
        Enabled VARCHAR testing
      mysql-test/t/myisam.test:
        Move handler dependent tests to the specific handler (myisam, bdb, innodb)
      sql/sql_parse.cc:
        Indentation fixes
      sql/sql_table.cc:
        Fixed bug introduced when doing cleanup
      de53c2b3
    • unknown's avatar
      Cleanup during reviews · 1637a873
      unknown authored
      Removed some optional arguments
      Fixed portability problem in federated tests
      
      
      client/sql_string.cc:
        update from sql/sql_string.cc
      client/sql_string.h:
        update from sql/sql_string.h
      mysql-test/r/federated.result:
        Fixed error message
      sql/field.cc:
        Cleanup during review
        Remove const in 'const unsigned int'
      sql/field.h:
        Remove const in 'const unsigned int'
      sql/ha_federated.cc:
        Better error string.  Add missing argument to error (before 'errno' was picked up from stack)
      sql/handler.cc:
        Removed compiler warning
      sql/item_func.cc:
        Cleanup during review
      sql/item_sum.cc:
        Cleanup during review
      sql/lock.cc:
        Remove optional arguments
      sql/log_event.cc:
        Remove optional arguments
      sql/mysql_priv.h:
        Remove optional arguments
        cahnge preapre_create_fields to use pointers instead of references
      sql/opt_range.cc:
        Fix arguments so that return value is last
      sql/sql_base.cc:
        Remove optional arguments
      sql/sql_delete.cc:
        Remove optional arguments
      sql/sql_error.cc:
        Remove optional arguments
      sql/sql_help.cc:
        Remove optional arguments
      sql/sql_parse.cc:
        Remove optional arguments
      sql/sql_prepare.cc:
        Remove optional arguments
      sql/sql_rename.cc:
        Remove optional arguments
      sql/sql_select.cc:
        Remove optional arguments
      sql/sql_show.cc:
        Cleanup during review
      sql/sql_string.cc:
        Simple optimization
      sql/sql_table.cc:
        Remove optional arguments
        Fixed indentation
      sql/sql_update.cc:
        Remove optional arguments
      sql/sql_yacc.yy:
        Change references to pointers
      1637a873
    • unknown's avatar
      global read lock code now uses a dedicated mutex · 370aca10
      unknown authored
      (otherwise a deadlock when ALTER writes to
      binlog holding LOCK_open, it causes binlog rotation,
      binlog waits for prepared transactions to commit, and commit
      needs LOCK_open to check for global read lock)
      
      
      mysql-test/r/flush.result:
        global read lock code now uses a dedicated mutex
      mysql-test/t/flush.test:
        global read lock code now uses a dedicated mutex
      sql/lock.cc:
        global read lock code now uses a dedicated mutex
      sql/mysql_priv.h:
        global read lock code now uses a dedicated mutex
      sql/mysqld.cc:
        global read lock code now uses a dedicated mutex
      sql/sql_table.cc:
        global read lock code now uses a dedicated mutex
      370aca10
  22. 08 Mar, 2005 1 commit
    • unknown's avatar
      Flush entries from the query cache for tables used in · dd522efd
      unknown authored
      administrative statements that may alter the table, such
      as REPAIR TABLE. (Bug #8480)
      
      
      mysql-test/r/query_cache.result:
        Add new results
      mysql-test/t/query_cache.test:
        Add regression test
      sql/sql_table.cc:
        Make sure entries are flushed from the query cache for
        any administrative command run on a table that acquires
        a write lock on it (and thus might change it), like 
        REPAIR TABLE.
      dd522efd
  23. 04 Mar, 2005 1 commit
    • unknown's avatar
      Bug#3788 · 44dec2b3
      unknown authored
        Crashes with stored procedure return non-string values
        Also fixes Bug#2773
      
      
      mysql-test/r/information_schema.result:
        Bug#3788
          Fix results for bugfix
      mysql-test/r/sp.result:
        Bug#3788
          Tests for Bug
          Fix results for bugfix
      mysql-test/t/sp.test:
        Bug#3788
          New tests for bug
      sql/item.cc:
        Fix unrelated crash in view test with --ps-protocol.
      sql/item_func.cc:
        Bug#3788
          Alter how SP function result types are handled.
      sql/item_func.h:
        Bug#3788
          Alter how SP function result types are handled.
      sql/mysql_priv.h:
        Bug#3788
          Prototypes for new global functions
      sql/sp.cc:
        Bug#3788
          Alter how function return type is reported
      sql/sp_head.cc:
        Bug#3788
          Change how function return types are stored for SPs
      sql/sp_head.h:
        Bug#3788
          Change how function return types are stored for SPs
      sql/sql_parse.cc:
        Bug#3788
          Split out field construction into its own function
      sql/sql_table.cc:
        Bug#3788
          Split out field preparation code into its own function
      sql/sql_yacc.yy:
        Bug#3788
          Change how function return types are stored for SPs
      sql/unireg.cc:
        Bug#3788
          Add assertion check
      44dec2b3
  24. 25 Feb, 2005 1 commit
    • unknown's avatar
      Remove compiler warnings and remove not used variables · 0bc36004
      unknown authored
      (Found during build process)
      
      
      extra/comp_err.c:
        Remove compiler warnings
      extra/perror.c:
        Remove compiler warnings
      innobase/dict/dict0dict.c:
        Remove compiler warnings
      innobase/dict/dict0load.c:
        Remove compiler warnings
      innobase/pars/pars0sym.c:
        Remove compiler warnings
      innobase/row/row0row.c:
        Remove compiler warnings
      innobase/row/row0sel.c:
        Remove compiler warnings
      libmysqld/lib_sql.cc:
        Remove not used variables
      myisam/mi_key.c:
        Remove compiler warnings
      regex/engine.c:
        Added comment
      sql/derror.cc:
        Remove not used variables
      sql/examples/ha_archive.cc:
        Fixed bug in blob handling
        Removed not used variable
      sql/field.cc:
        Remove compiler warnings
        Remove not used variables
      sql/filesort.cc:
        Remove compiler warnings
      sql/ha_heap.cc:
        Remove not used variable
      sql/ha_innodb.cc:
        Remove not used variables
        Remove compiler warnings
      sql/handler.cc:
        Remove compiler warnings and remove not used variables
      sql/item.cc:
        Remove compiler warnings and remove not used variables
      sql/item_subselect.cc:
        Remove compiler warnings
      sql/item_sum.cc:
        Remove compiler warnings
      sql/item_sum.h:
        Remove compiler warnings and remove not used variables
      sql/log.cc:
        Remove compiler warnings and remove not used variables
      sql/log_event.cc:
        Remove compiler warnings
      sql/mysqld.cc:
        Remove compiler warnings and remove not used variables
      sql/opt_range.cc:
        Remove compiler warnings and remove not used variables
      sql/slave.cc:
        Remove compiler warnings and remove not used variables
      sql/sp_pcontext.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_acl.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_analyse.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_base.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_db.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_help.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_insert.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_load.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_parse.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_prepare.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_select.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_show.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_table.cc:
        Remove compiler warnings
      sql/sql_union.cc:
        Remove compiler warnings
      sql/sql_update.cc:
        Remove compiler warnings and remove not used variables
      sql/sql_yacc.yy:
        Remove compiler warnings and remove not used variables
      sql/strfunc.cc:
        Remove compiler warnings and remove not used variables
      strings/ctype-ucs2.c:
        Remove compiler warnings
      tests/mysql_client_test.c:
        Remove compiler warnings and remove not used variables
      tools/mysqlmanager.c:
        Remove compiler warnings and remove not used variables
      0bc36004
  25. 24 Feb, 2005 1 commit
    • unknown's avatar
      Show all generated warnings in SHOW ERROR · fc785bd4
      unknown authored
      Previously we only stored the first given error (the error sent to the client)
      
      
      include/mysys_err.h:
        Moved ER_FILENOTFOUND last to avoid getting 'error 0'
      mysql-test/r/backup.result:
        More warnings from in case of errors
      mysql-test/r/innodb.result:
        More warnings from in case of errors
      mysql-test/r/key_cache.result:
        More warnings from in case of errors
      mysql-test/r/myisam.result:
        More warnings from in case of errors
      mysql-test/r/preload.result:
        More warnings from in case of errors
      mysql-test/r/repair.result:
        More warnings from in case of errors
      mysql-test/r/rpl_failed_optimize.result:
        More warnings from in case of errors
      mysql-test/r/subselect.result:
        More warnings from in case of errors
      mysql-test/t/backup.test:
        Portability fix
      mysql-test/t/innodb.test:
        Avoid some warnings
      mysql-test/t/myisam.test:
        Portability fix
      mysql-test/t/rpl_rotate_logs.test:
        Portablitiy fix
      mysys/errors.c:
        Move ER_FILENOTFOUND last to avoid error 0
      sql/mysql_priv.h:
        Indentation change
      sql/mysqld.cc:
        Save all given errors for SHOW ERRORS
      sql/protocol.cc:
        Store new errors for SHOW ERROR
        (Ignore those that are already reported with my_error())
      sql/sql_class.cc:
        More errors with SHOW ERROR
      sql/sql_class.h:
        More errors with SHOW ERROR
      sql/sql_error.cc:
        More errors with SHOW ERROR
      sql/sql_parse.cc:
        Temporary fix: Don't give error for the to-be-removed 'pre-open tables code'
      sql/sql_show.cc:
        More debugging
        Don't register errors while populating schema tables.
        (If we do, we get a LOT of warnings from information_schema.test)
      sql/sql_table.cc:
        Don't register errors from handler in drop table (as we already do it the upper level DROP TABLE code)
        Don't register errors for 'restore_table' as in most cases the table doesn't exists
      sql/sql_union.cc:
        Use file->write_row() instead of 'write_record'.
        This gives us easer to handle error messages and is faster than the old version
      fc785bd4
  26. 21 Feb, 2005 2 commits
    • unknown's avatar
      Generate warning in ha_delete_table() if files is missing in handler · 0834c079
      unknown authored
      
      mysql-test/r/myisam.result:
        Test of DROP TABLE when .MYI or .MYD is missing
      mysql-test/r/ndb_autodiscover.result:
        Update test results
      mysql-test/r/rpl_EE_error.result:
        Change test to conform with new handling of drop table when handler file is missing
      mysql-test/t/myisam.test:
        Test of DROP TABLE when .MYI or .MYD is missing
      mysql-test/t/rpl_EE_error.test:
        Change test to conform with new handling of drop table when handler file is missing
      sql/handler.cc:
        Generate a warning in ha_delete_table() if we get an error from 'delete_table()'
      sql/handler.h:
        More parameters to ha_delete_table() so that we can generate better error messages
      sql/sql_table.cc:
        Generate warning in ha_delete_table()
      0834c079
    • unknown's avatar
      Review of new pushed code (XA & other) · 7f54e80d
      unknown authored
      Portability fixes and cleanups
      Fixed setting of 'res' in mysql_execute_command()
      
      
      sql/handler.cc:
        delete_table() will not return error for not found files if one handler file was found and deleted
      sql/handler.h:
        Incremented MAX_HA so that ndb works again
        Don't convert char pointer to (my_xid*) as we don't know if the address is aligned on 8
      sql/log.cc:
        Indentation fixes
        Simplified loop to find next log
        Fixed race condition in reset_logs that caused mix_innodb_myisam_binlog to fail
      sql/log_event.cc:
        Don't convert char pointer to (my_xid*) as we don't know if the address is aligned on 8
      sql/sql_acl.cc:
        Convert db name directly to avoid extra strmov
      sql/sql_base.cc:
        Added comment
        Removed not needed code
      sql/sql_db.cc:
        Added comment
        Remove not needed code
      sql/sql_parse.cc:
        Always call mysql_rm_db() with lower case db name
        Ensure that 'res' is set correctly in mysql_execute_command()
        (One don't have to set res if one calls my_error() and res should be = 0 for correct commands)
      sql/sql_repl.cc:
        Indentation fixes
        use packet->ptr() instead of packet->c_ptr()
      sql/sql_table.cc:
        Join similar code when table didn't exist in engine
      7f54e80d
  27. 17 Feb, 2005 1 commit
    • unknown's avatar
      BUG#8547: Wrong errormessage when dropping table that does not exist in NDB · 64408c99
      unknown authored
       - Added tescases
       - Added handling of HA_ERR_NO_SUCH_TABLE in mysql_rm_table_part2 so that 
         error messages now are consistent
      
      
      mysql-test/r/ndb_autodiscover.result:
        Added tess for dropping tables that does not exists in engine
      mysql-test/t/ndb_autodiscover.test:
        Added tess for dropping tables that does not exists in engine
      sql/ha_ndbcluster.cc:
        Updated delete_table and drop_table to retrn HA_ERR_NO_SUCH_TABLE if table was not found in engine.
        Clear error after calling mysql_rm_table_part2 from mysql_find_files
      sql/sql_table.cc:
        Added handling of the case when table does not exist in storage engine but on disk as .frm file.
      64408c99
  28. 08 Feb, 2005 1 commit
    • unknown's avatar
      Precision Math implementation · c346d5c3
      unknown authored
      BitKeeper/etc/ignore:
        Added client/decimal.c client/my_decimal.cc client/my_decimal.h to the ignore list
      c346d5c3
  29. 02 Feb, 2005 1 commit
    • unknown's avatar
      Fixed during review of new pulled code · 349bcbac
      unknown authored
      extra/perror.c:
        Use strmov() instead of strcpy()
        Indentation fixes
      sql/sql_table.cc:
        Revert back part of the old code as the new code didn't use mysql_data_home, which would have caused problems in the embedded server
      sql/sql_update.cc:
        Ensure that used_index is always set (It has to be set because it's value is tested if order != 0)
      349bcbac
  30. 31 Jan, 2005 1 commit
  31. 27 Jan, 2005 1 commit
    • unknown's avatar
      query_id and my_xid -> ulonglong · 90a7ce5c
      unknown authored
      fix for binlog+autocommit+tclog
      comments, style fixes
      
      
      libmysqld/libmysqld.rc:
        Change mode to -rw-rw-r--
      libmysqld/resource.h:
        Change mode to -rw-rw-r--
      configure.in:
        check for getpagesize
      include/my_global.h:
        typo ?
      include/my_pthread.h:
        bug in thread_safe_decrement_and_test()
      mysql-test/r/bdb.result:
        results updated
      mysql-test/r/innodb.result:
        results updated
      mysql-test/r/mix_innodb_myisam_binlog.result:
        results updated
      mysql-test/r/rpl_relayrotate.result:
        results updated
      sql/ha_berkeley.cc:
        style fixes
      sql/ha_innodb.cc:
        fixes to follow innodb coding style
      sql/handler.cc:
        more comments. XA COMMIT ONE PHASE fix.
      sql/handler.h:
        my_xid -> ulonglong. comments
      sql/item_func.cc:
        DO RELEASE_LOCK("...") is no cache_stmt
      sql/log.cc:
        comments, better error messages
      sql/log_event.cc:
        even in autocommit mode we may need to cache_stmt
        xid is ulonglong
      sql/log_event.h:
        more comments.
      sql/mysql_priv.h:
        query_id is ulonglong
      sql/mysqld.cc:
        default value for --log-tc changed
      sql/share/errmsg.txt:
        better error messages
      sql/sql_class.h:
        cleanup, comments
      sql/sql_delete.cc:
        deleting from temporary tables is not always transactional
      sql/sql_insert.cc:
        insert into temporary table is not always transactional
      sql/sql_load.cc:
        load data into temp table is not always transactional
      sql/sql_parse.cc:
        comments. bad merge fixed. xa_state_names[]
      sql/sql_table.cc:
        create/drop temp table is not always transactional
      sql/sql_update.cc:
        update temp table is not always transactional
      90a7ce5c
  32. 24 Jan, 2005 1 commit
  33. 21 Jan, 2005 1 commit
  34. 10 Jan, 2005 1 commit