1. 02 Nov, 2004 2 commits
    • unknown's avatar
      fixed spelling · 90d08d0f
      unknown authored
      90d08d0f
    • unknown's avatar
      WL#1972 "Evaluate HAVING before SELECT select-list" · c3877cc5
      unknown authored
      - Changed name resolution for GROUP BY so that derived columns do not shadow table columns
        from the FROM clause. As a result GROUP BY now is handled as a true ANSI extentsion.
      - Issue a warning when HAVING is resolved into ambiguous columns, and prefer the columns from
        the GROUP BY clause over SELECT columns.
      
      
      mysql-test/r/having.result:
        Correct result for updated GROUP BY name resolution.
      sql/item.cc:
        - prefer GROUP columns, but if none is found use SELECT list
        - issue a waring when a field may be resolved ambiguously
        - more/fixed comments
      sql/mysql_priv.h:
        More flexible find_field_in_tables().
      sql/sp.cc:
        More flexible find_field_in_tables().
      sql/sql_base.cc:
        More flexible find_field_in_tables().
      sql/sql_help.cc:
        More flexible find_field_in_tables().
      sql/sql_select.cc:
        - name resolution of GROUP/ORDER BY column references is differentiated:
          - GROUP BY is resolved in SELECT and FROM clauses
          - ORDER BY is resolved only in SELECT (as before)
        - more informative variable names
        - more comments
      c3877cc5
  2. 28 Oct, 2004 1 commit
  3. 23 Oct, 2004 2 commits
    • unknown's avatar
      Fixed BUG#6029: Stored procedure specific handlers should have priority. · d9c12f82
      unknown authored
      
      mysql-test/r/sp.result:
        New test case for BUG#6022.
      mysql-test/t/sp.test:
        New test case for BUG#6022.
      sql/sp_rcontext.cc:
        Find the most specific condition handler, not just the first one.
        (And corrected the return type for find_handler)
      sql/sp_rcontext.h:
        Corrected return type for find_handler.
      d9c12f82
    • unknown's avatar
      Fixed BUG#6022: Stored procedure shutdown problem with self-calling function. · 5174a837
      unknown authored
        Fixed the pre-caching of functions. It now gives the expected stack overrun
        error for functions recursing too deep.
      
      
      mysql-test/r/sp.result:
        New test case for BUG#6022.
      mysql-test/t/sp.test:
        New test case for BUG#6022.
      sql/sp.cc:
        Cache function first, then recurse, or the pre-caching loops infinitely
        for recursive functions.
      5174a837
  4. 22 Oct, 2004 7 commits
    • unknown's avatar
      Updated view test result (after a warning's been removed). · 25c45fd1
      unknown authored
      
      mysql-test/r/view.result:
        Updated test result (after a warning's been removed).
      25c45fd1
    • unknown's avatar
      Fixed BUG#6030: Stored procedure has no appropriate DROP privilege. · 1239d3e6
      unknown authored
        ...and no ALTER privilege either.
        For now, only the definer and root can drop or alter an SP.
      
      
      include/mysqld_error.h:
        New access denied error code when dropping/altering stored procedures.
      include/sql_state.h:
        New access denied error code when dropping/altering stored procedures.
      mysql-test/r/sp-error.result:
        Removed warning for "unitialized variable", as this popped up in unexpected
        places after the access control for drop/alter SPs was added. (And the warning
        was wrong and planned to be removed anyway.)
      mysql-test/r/sp-security.result:
        Added tests for access control on who's allowed to drop and alter SPs.
      mysql-test/r/sp.result:
        Updated results. (Warning removed.)
      mysql-test/t/sp-error.test:
        Removed warning for "unitialized variable", as this popped up in unexpected
        places after the access control for drop/alter SPs was added. (And the warning
        was wrong and planned to be removed anyway.)
      mysql-test/t/sp-security.test:
        Added tests for access control on who's allowed to drop and alter SPs.
      sql/share/czech/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/danish/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/dutch/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/english/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/estonian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/french/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/german/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/greek/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/hungarian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/italian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/japanese/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/korean/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/norwegian-ny/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/norwegian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/polish/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/portuguese/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/romanian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/russian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/serbian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/slovak/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/spanish/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/swedish/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/share/ukrainian/errmsg.txt:
        New access denied error message when dropping/altering stored procedures.
      sql/sql_parse.cc:
        Added minimal access control for DROP/ALTER PROCEDURE/FUNCTION. Only the definer
        and root are allowed to do this.
      sql/sql_yacc.yy:
        Removed warning for "unitialized variable", as this popped up in unexpected
        places after the access control for drop/alter SPs was added. (And the warning
        was wrong and planned to be removed anyway.)
      1239d3e6
    • unknown's avatar
      Fixed BUG#6027: Stored procedures can be renamed. · a1c76866
      unknown authored
      Removed the support for renaming SPs. It's non-standard, conflicted with a standard
      syntax, and was a bit broken anyway.
      
      
      mysql-test/r/sp-error.result:
        Removed test for renaming procedures with alter.
      mysql-test/r/sp.result:
        Removed test for renaming procedures with alter.
      mysql-test/t/sp-error.test:
        Removed test for renaming procedures with alter.
      mysql-test/t/sp.test:
        Removed test for renaming procedures with alter.
      sql/sp.cc:
        Removed support for renaming SPs. It's non-standard, conflicted with a standard
        syntax, and was a bit broken anyway.
      sql/sp.h:
        Removed support for renaming SPs. It's non-standard, conflicted with a standard
        syntax, and was a bit broken anyway.
      sql/sql_parse.cc:
        Removed support for renaming SPs. It's non-standard, conflicted with a standard
        syntax, and was a bit broken anyway.
      sql/sql_yacc.yy:
        Removed support for renaming SPs. It's non-standard, conflicted with a standard
        syntax, and was a bit broken anyway.
      a1c76866
    • unknown's avatar
      handler.cc: · 8c17290e
      unknown authored
        Typos in comments.
      
      
      sql/handler.cc:
        Typos in comments.
      8c17290e
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 03c487b5
      unknown authored
      into gw.mysql.r18.ru:/usr/home/ram/work/5.0
      
      03c487b5
    • unknown's avatar
      A fix (bug #5999 Typo in code, wrong config variable naming). · 52d9e429
      unknown authored
      
      mysql-test/r/rpl_auto_increment.result:
        A fix (bug #5999 Typo in code, wrong config variable naming).
        Typo fixed.
      sql/set_var.cc:
        A fix (bug #5999 Typo in code, wrong config variable naming).
        Typo fixed.
      52d9e429
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 224ada87
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-view-5.0
      
      
      sql/item_strfunc.h:
        Auto merged
      sql/table.h:
        Auto merged
      224ada87
  5. 21 Oct, 2004 10 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 899d5e9f
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      899d5e9f
    • unknown's avatar
      ps.result: · e2fb7395
      unknown authored
        Post-merge fixes.
      sql_select.cc:
        Post-merge cleanup.
      
      
      sql/sql_select.cc:
        Post-merge cleanup.
      mysql-test/r/ps.result:
        Post-merge fixes.
      e2fb7395
    • unknown's avatar
      added support of view and CHECK OPTION of view to LOAD DATA (BUG#5996) · d83b8d32
      unknown authored
      
      mysql-test/r/view.result:
        LOAD DATA with view and CHECK OPTION
      mysql-test/t/view.test:
        LOAD DATA with view and CHECK OPTION
      sql/log_event.cc:
        new parameter for load data
      sql/mysql_priv.h:
        new parameter for load data
      sql/sql_lex.cc:
        LOAD DATA supported by view
      sql/sql_load.cc:
        added support of view and CHECK OPTION of view to LOAD DATA
      sql/sql_parse.cc:
        new parameter for CHECK OPTION
      d83b8d32
    • unknown's avatar
      new behaviour of CHECK option build, for mor efficience and more correct: · 11d8bf16
      unknown authored
      check option build only according most top VIEW  CHECK OPTION TYPE  (BUG#5993)
      
      
      mysql-test/r/view.result:
        CASCADED should be used for all underlaying VIEWs
      mysql-test/t/view.test:
        CASCADED should be used for all underlaying VIEWs
      sql/sql_base.cc:
        new behaviour of CHECK option build, for mor efficience and more correct.
      sql/table.cc:
        new behaviour of CHECK option build, for mor efficience and more correct.
      sql/table.h:
        new behaviour of CHECK option build, for mor efficience and more correct.
      11d8bf16
    • unknown's avatar
      ha_innodb.cc: · 2194aac1
      unknown authored
        Remove compiler warning 'skip_auto_inc_decr' : unreferenced local variable in Visual C++; of course, I still have to check Monty's auto-inc patch in whole
      
      
      sql/ha_innodb.cc:
        Remove compiler warning 'skip_auto_inc_decr' : unreferenced local variable in Visual C++; of course, I still have to check Monty's auto-inc patch in whole
      2194aac1
    • unknown's avatar
      value should be checked after 'before' trigger work (BUG#5992) · 3653ecb0
      unknown authored
      
      mysql-test/r/view.result:
        changing value by trigger and CHECK OPTION
      mysql-test/t/view.test:
        changing value by trigger and CHECK OPTION
      sql/sql_insert.cc:
        value should be checked after 'before' trigger work
      3653ecb0
    • unknown's avatar
      inserting single value with check option failed always get error (part of BUG#5995) · 19671bd9
      unknown authored
      
      mysql-test/r/view.result:
        inserting single value with check option failed always get error
      mysql-test/t/view.test:
        inserting single value with check option failed always get error
      sql/sql_insert.cc:
        inserting single value with check option failed always get error
      19671bd9
    • unknown's avatar
      fixed default behaviour of WITH CHECK OPTIONS according to standard (BUG#5989) · 5f1c9cca
      unknown authored
      
      mysql-test/r/view.result:
        fixed default behaviour of WITH CHECK OPTIONS according to standard
      sql/sql_yacc.yy:
        fixed default behaviour of WITH CHECK OPTIONS according to standard
      5f1c9cca
    • unknown's avatar
      Allow inheriting check options if view have not WHERE clause (BUG#5988) · 2c8aa3bb
      unknown authored
      
      mysql-test/r/view.result:
        test of cascaded check option for whiew without WHERE clause
      mysql-test/t/view.test:
        test of cascaded check option for whiew without WHERE clause
      sql/table.cc:
        Allow inheriting check options if view have not WHERE clause
      2c8aa3bb
    • unknown's avatar
      fixed printing of substring_index (BUG#5911) · 55f12a29
      unknown authored
      
      mysql-test/r/func_str.result:
        fixed printing of substring_index
      mysql-test/r/view.result:
        test of substring_index with view
      mysql-test/t/view.test:
        test of substring_index with view
      sql/item_strfunc.h:
        fixed printing of substring_index
      55f12a29
  6. 20 Oct, 2004 9 commits
  7. 19 Oct, 2004 3 commits
    • unknown's avatar
      Merge for post-merge fixes for Item_equal patch. · a9da1869
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      mysql-test/r/range.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/t/range.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/item.h:
        Manual merge
      sql/sql_select.cc:
        Manual merge
      a9da1869
    • unknown's avatar
      table.h, sql_select.h: · fcab6583
      unknown authored
        Added the code processing on expressions for applying
        multiple equalities.
      sql_select.cc:
        Post-merge fixes for Item_equal patch.
        Added the code processing on expressions for applying
        multiple equalities.
      Many files:
        Post-merge fixes for Item_equal patch.
      item_cmpfunc.cc:
        Post-merge fixes for Item_equal patch.
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      item.h, item.cc:
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      
      
      mysql-test/r/func_test.result:
        Post-merge fixes for Item_equal patch.
      mysql-test/r/index_merge.result:
        Post-merge fixes for Item_equal patch.
      mysql-test/r/join_nested.result:
        Post-merge fixes for Item_equal patch.
      mysql-test/r/range.result:
        Post-merge fixes for Item_equal patch.
      sql/item.cc:
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      sql/item.h:
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      sql/item_cmpfunc.cc:
        Post-merge fixes for Item_equal patch.
        Fixed a problem when an equality field=const cannot be applied to
        the predicate P(field,c) for constant propagation as a conversion
        of field is needed.
      sql/opt_range.cc:
        Post-merge fixes for Item_equal patch.
      sql/sql_select.cc:
        Post-merge fixes for Item_equal patch.
        Added the code processing on expressions for applying
        multiple equalities.
      sql/sql_select.h:
        Added the code processing on expressions for applying
        multiple equalities.
      sql/table.h:
        Added the code processing on expressions for applying
        multiple equalities.
      fcab6583
    • unknown's avatar
      decimal to/from bin, and utility functions · b86a19bc
      unknown authored
      
      strings/Makefile.am:
        cleanup
      b86a19bc
  8. 18 Oct, 2004 3 commits
    • unknown's avatar
      compatibility fix · c5ded716
      unknown authored
      test results corrected
      
      
      mysql-test/r/range.result:
        test results corrected
      mysql-test/t/range.test:
        test results corrected
      sql/opt_range.cc:
        compatibility fix
      c5ded716
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0/ · d953b148
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0
      
      
      BitKeeper/etc/ignore:
        auto-union
      d953b148
    • unknown's avatar
      arbitrary precision decimal numbers · d36af6f0
      unknown authored
      
      strings/llstr.c:
        small optimization
      BitKeeper/etc/ignore:
        Added strings/test_decimal to the ignore list
      d36af6f0
  9. 16 Oct, 2004 1 commit
    • unknown's avatar
      texi2html: · 0a69b06e
      unknown authored
        Change parsing of @image argument.
      
      
      Docs/Support/texi2html:
        Change parsing of @image argument.
      0a69b06e
  10. 14 Oct, 2004 1 commit
    • unknown's avatar
      Implemented the stored procedure data access characteristics: · f7635ca5
      unknown authored
      NO SQL
      CONTAINS SQL (default)
      READS SQL DATA
      MODIFIES SQL DATA
      
      These are needed as hints for the replication.
      (Before this, we did have the default in the mysql.proc table, but no support in the parser.)
      
      
      mysql-test/r/sp.result:
        Modified test cases for new data access characteristics.
      mysql-test/t/sp.test:
        Modified test cases for new data access characteristics.
      scripts/mysql_create_system_tables.sh:
        We now support all the SP data access characteristics (not just CONTAINS SQL).
      scripts/mysql_fix_privilege_tables.sql:
        We now support all the SP data access characteristics (not just CONTAINS SQL).
      sql/lex.h:
        New tokens for SP data access characteristics.
      sql/sp.cc:
        Store, print and support alter of data access characteristics.
      sql/sp_head.cc:
        Added SP_ prefix to some symbols.
      sql/sql_lex.h:
        Added SP_ prefix to some symbols, and added SP data access enum.
      sql/sql_yacc.yy:
        Parse SP data access characteristics.
        (And allow "alter ... language sql", mostly as a formality, it was accidently
         put in the wrong clause before.)
      f7635ca5
  11. 13 Oct, 2004 1 commit