- 25 Jun, 2010 1 commit
-
-
Vasil Dimov authored
-
- 24 Jun, 2010 1 commit
-
-
Jimmy Yang authored
-
- 23 Jun, 2010 2 commits
-
-
Jimmy Yang authored
to 5.1 plugin codeline. rb://378, approved by Marko
-
Jimmy Yang authored
out NULL type columns, and return without creating the table. rb://378 approved by Marko
-
- 22 Jun, 2010 5 commits
-
-
Vasil Dimov authored
-
Vasil Dimov authored
-
Vasil Dimov authored
when renaming tables Allocate the table name using ut_malloc() instead of table->heap because the latter cannot be freed. Adjust dict_sys->size calculations all over the code. Change dict_table_t::name from const char* to char* because we need to ut_malloc()/ut_free() it. Reviewed by: Inaam, Marko, Heikki (rb://384) Approved by: Heikki (rb://384)
-
Marko Mäkelä authored
-
Marko Mäkelä authored
ha_innobase::index_read(), ha_innobase::records_in_range(): Check that the index is useable before invoking row_sel_convert_mysql_key_to_innobase(). This fix is based on a suggestion by Yasufumi Kinoshita.
-
- 21 Jun, 2010 2 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
dict_check_tablespaces_and_store_max_id(): Initialize max_space_id and fil_system->max_assigned_id from DICT_HDR_MAX_SPACE_ID. fil_space_create(): Suppress the warning unless !recv_recovery_on (do not complain while applying the redo log).
-
- 18 Jun, 2010 3 commits
-
-
Vasil Dimov authored
-
Vasil Dimov authored
1.0.9 has been released with MySQL 5.1.48.
-
Jimmy Yang authored
rb://290, approved by Sunny
-
- 17 Jun, 2010 2 commits
-
-
Jimmy Yang authored
-
Jimmy Yang authored
account for each merge run's start offset, so correct offsets are paired up for multiple merge runs. rb://377 approved by Marko
-
- 15 Jun, 2010 1 commit
-
-
Jimmy Yang authored
-
- 14 Jun, 2010 2 commits
-
-
Vasil Dimov authored
-
Vasil Dimov authored
(innodb_mysql.result needs to be adjusted after this commit)
-
- 10 Jun, 2010 4 commits
-
-
Inaam Rana authored
-
Inaam Rana authored
-
Inaam Rana authored
-
Marko Mäkelä authored
-
- 09 Jun, 2010 2 commits
-
-
Sergey Glukhov authored
(InnoDB plugin branch) mysql-test/suite/innodb_plugin/r/innodb_mysql.result: test case mysql-test/suite/innodb_plugin/t/innodb_mysql.test: test case storage/innodb_plugin/row/row0sel.c: init null bytes with default values as they might be left uninitialized in some cases and these uninited bytes might be copied into mysql record buffer that leads to valgrind warnings on next use of the buffer.
-
Sergey Glukhov authored
Valgrind warning happpens because of uninitialized null bytes. In row_sel_push_cache_row_for_mysql() function we fill fetch cache with necessary field values, row_sel_store_mysql_rec() is called for this and leaves null bytes untouched. Later row_sel_pop_cached_row_for_mysql() rewrites table record buffer with uninited null bytes. We can see the problem from the test case: At 'SELECT...' we call row_sel_push...->row_sel_store...->row_sel_pop_cached... chain which rewrites table->record[0] buffer with uninitialized null bytes. When we call 'UPDATE...' statement, compare_record uses this buffer and valgrind warning occurs. The fix is to init null bytes with default values. mysql-test/suite/innodb/r/innodb_mysql.result: test case mysql-test/suite/innodb/t/innodb_mysql.test: test case mysql-test/t/ps_3innodb.test: enable valgrind testing storage/innobase/row/row0sel.c: init null bytes with default values as they might be left uninitialized in some cases and these uninited bytes might be copied into mysql record buffer that leads to valgrind warnings on next use of the buffer.
-
- 08 Jun, 2010 4 commits
-
-
Inaam Rana authored
this before.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
for InnoDB plugin dict_load_table(): Pass the correct tablespace flags to fil_open_single_table_tablespace(). For ROW_FORMAT=COMPACT and REDUNDANT, the tablespace flags are 0. The table flags would be 0 or DICT_TF_COMPACT.
-
Marko Mäkelä authored
-
- 03 Jun, 2010 6 commits
-
-
unknown authored
-
Jimmy Yang authored
introduced in bug fix #53592, since dict_table_t can sufficiently unique identify the the table.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 02 Jun, 2010 5 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
In semi-consistent read, only unlock freshly locked non-matching records. lock_rec_lock_fast(): Return LOCK_REC_SUCCESS, LOCK_REC_SUCCESS_CREATED, or LOCK_REC_FAIL instead of TRUE/FALSE. enum db_err: Add DB_SUCCESS_LOCKED_REC for indicating a successful operation where a record lock was created. lock_sec_rec_read_check_and_lock(), lock_clust_rec_read_check_and_lock(), lock_rec_enqueue_waiting(), lock_rec_lock_slow(), lock_rec_lock(), row_ins_set_shared_rec_lock(), row_ins_set_exclusive_rec_lock(), sel_set_rec_lock(), row_sel_get_clust_rec_for_mysql(): Return DB_SUCCESS_LOCKED_REC if a new record lock was created. Adjust callers. row_unlock_for_mysql(): Correct the function documentation. row_prebuilt_t::new_rec_locks: Correct the documentation.
-
Marko Mäkelä authored
In semi-consistent read, only unlock freshly locked non-matching records. Define DB_SUCCESS_LOCKED_REC for indicating a successful operation where a record lock was created. lock_rec_lock_fast(): Return LOCK_REC_SUCCESS, LOCK_REC_SUCCESS_CREATED, or LOCK_REC_FAIL instead of TRUE/FALSE. lock_sec_rec_read_check_and_lock(), lock_clust_rec_read_check_and_lock(), lock_rec_enqueue_waiting(), lock_rec_lock_slow(), lock_rec_lock(), row_ins_set_shared_rec_lock(), row_ins_set_exclusive_rec_lock(), sel_set_rec_lock(), row_sel_get_clust_rec_for_mysql(): Return DB_SUCCESS_LOCKED_REC if a new record lock was created. Adjust callers. row_unlock_for_mysql(): Correct the function documentation. row_prebuilt_t::new_rec_locks: Correct the documentation.
-
Marko Mäkelä authored
-
Georgi Kodinov authored
-