1. 30 May, 2007 5 commits
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/bk-trees/mysql-5.0-opt · 937d5f89
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/olap.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/analyse.result:
        Manual merge
      mysql-test/r/sp.result:
        Manual merge
      sql/item_timefunc.cc:
        Manual merge
      937d5f89
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · d9426a89
      unknown authored
      into  dl145s.mysql.com:/users/mhansson/mysql/autopush/my51-bug28250
      
      
      sql/item_func.cc:
        Auto merged
      d9426a89
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 98b5043a
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28492-5.0-opt
      
      
      mysql-test/r/sp.result:
        Auto merged
      98b5043a
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 5462e46b
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28605-5.0-opt
      
      
      5462e46b
    • unknown's avatar
      Bug #28492: subselect returns LONG in >5.0.24a and LONGLONG in <=5.0.24a · 4e9cef54
      unknown authored
      Integer values with 10 digits may or may not fit into an int column 
      (e.g. 2147483647 vs 6147483647).
      Thus when creating a temp table column for such an int we must
      use bigint instead.
      Fixed to use bigint.
      Also subsituted a "magic number" with a named constant.
      
      
      mysql-test/r/analyse.result:
        Bug #28492: Adjusted the results after having fixed the bug
      mysql-test/r/metadata.result:
        Bug #28492: test case
      mysql-test/r/olap.result:
        Bug #28492: Adjusted the results after having fixed the bug
      mysql-test/r/sp.result:
        Bug #28492: Adjusted the results after having fixed the bug
      mysql-test/r/view.result:
        Bug #28492: Adjusted the results after having fixed the bug
      mysql-test/t/metadata.test:
        Bug #28492: test case
      sql/field.h:
        Bug #28492: Replaced a magic number with a constant
      sql/sql_select.cc:
        Bug #28492: Treat integers with 10 and more digits as 
        bigint.
      4e9cef54
  2. 29 May, 2007 7 commits
    • unknown's avatar
      Bug#28450: The Item_date_add_interval in select list may fail the field · d393c9e6
      unknown authored
      type assertion.
      
      The bug was introduced by the patch for bug #16377.
      The "+ INTERVAL" (Item_date_add_interval) function detects its result type
      by the type of its first argument. But in some cases it returns STRING
      as the result type. This happens when, for example, the first argument is a 
      DATE represented as string. All this makes the get_datetime_value()
      function misinterpret such result and return wrong DATE/DATETIME value.
      To avoid such cases in the fix for #16377 the code that detects correct result
      field type on the first execution was added to the
      Item_date_add_interval::get_date() function. Due to this the result
      field type of the Item_date_add_interval item stored by the send_fields()
      function differs from item's result field type at the moment when
      the item is actually sent. It causes an assertion failure.
      
      Now the get_datetime_value() detects that the DATE value is returned by
      some item not only by checking the result field type but also by comparing
      the returned value with the 100000000L constant - any DATE value should be
      less than this value.
      Removed result field type adjusting code from the
      Item_date_add_interval::get_date() function.
      
      
      sql/item_cmpfunc.cc:
        Bug#28450: The Item_date_add_interval in select list may fail the field 
        type assertion.
        Now the get_datetime_value() detects that the DATE value is returned by
        some item not only by checking the result field type but also by comparing
        the returned value with the 100000000L constant - any DATE value should be
        less than this value.
      mysql-test/r/func_date_add.result:
        Added a test case for the bug#28450: The Item_date_add_interval in select list may fail the field
        type assertion.
      sql/item_timefunc.cc:
        Bug#28450: The Item_date_add_interval in select list may fail the field 
        type assertion.
        Removed result field type adjusting code from the
        Item_date_add_interval::get_date() function.
      mysql-test/t/func_date_add.test:
        Added a test case for the bug#28450: The Item_date_add_interval in select list may fail the field
        type assertion.
      d393c9e6
    • unknown's avatar
      Added comment for ha_statistics::records · 54c88bca
      unknown authored
      54c88bca
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · e8ba126c
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/join_cache_explain-5.1-opt
      
      
      e8ba126c
    • unknown's avatar
      Bug #27531: 5.1 part of the fix · aff34a8c
      unknown authored
      - Renamed "Using join cache" to "Using join buffer".
      - "Using join buffer" is now printed on the last
        table that "reads" from the join buffer cache.
      
      
      mysql-test/r/archive_gis.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/compress.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/ctype_utf8.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/derived.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/distinct.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/func_group.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/func_group_innodb.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/gis.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/greedy_optimizer.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/group_by.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/group_min_max.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/index_merge_myisam.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/information_schema.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/innodb_gis.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/innodb_mysql.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/join.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/join_nested.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/key_diff.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/myisam.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/ndb_condition_pushdown.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/ndb_gis.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/range.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/row.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/select.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/ssl.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/ssl_compress.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/subselect.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/subselect3.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/union.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      mysql-test/r/view.result:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      sql/sql_select.cc:
        Bug #27531: renamed "Using join cache" to "Using join buffer"
        and moved to the last table in the batch.
      aff34a8c
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 95d4ece0
      unknown authored
      into  dl145s.mysql.com:/users/mhansson/mysql/autopush/my51-bug23856
      
      
      sql/field.h:
        Auto merged
      95d4ece0
    • unknown's avatar
      Bug #28605: SHOW CREATE VIEW with views using stored_procedures no · 9e06efb4
      unknown authored
       longer showing SP names.
      SHOW CREATE VIEW uses Item::print() methods to reconstruct the 
      statement text from the parse tree.
      The print() method for stored procedure calls needs allocate 
      space to print the function's quoted name.
      It was incorrectly calculating the length of the buffer needed 
      (was too short).
      Fixed to reflect the actual space needed.
      
      
      mysql-test/r/sp.result:
        Bug #28605: test case
      mysql-test/t/sp.test:
        Bug #28605: test case
      sql/item_func.cc:
        Bug #28605: fixed the string length calculation
      9e06efb4
    • unknown's avatar
      Merge dl145s.mysql.com:/users/mhansson/mysql/push/bug28250/my50-bug28250 · 77824461
      unknown authored
      into  dl145s.mysql.com:/users/mhansson/mysql/push/bug28250/my51-bug28250
      
      
      mysql-test/t/cast.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      77824461
  3. 28 May, 2007 3 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · fbaad80e
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.1-opt
      
      
      client/mysqldump.c:
        Auto merged
      mysql-test/r/mysqldump.result:
        Auto merged
      mysql-test/r/ps_2myisam.result:
        Auto merged
      mysql-test/r/ps_3innodb.result:
        Auto merged
      mysql-test/r/ps_4heap.result:
        Auto merged
      mysql-test/r/ps_5merge.result:
        Auto merged
      mysql-test/r/ps_7ndb.result:
        Auto merged
      sql/field.h:
        Auto merged
      BitKeeper/deleted/.del-ps_6bdb.result:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/my_decimal.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      fbaad80e
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · 7c5aa30f
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.1-opt
      
      
      BitKeeper/deleted/.del-ps_6bdb.result:
        Auto merged
      client/mysqldump.c:
        Auto merged
      mysql-test/r/mysqldump.result:
        Auto merged
      mysql-test/r/ps_2myisam.result:
        Auto merged
      mysql-test/r/ps_3innodb.result:
        Auto merged
      mysql-test/r/ps_4heap.result:
        Auto merged
      mysql-test/r/ps_5merge.result:
        Auto merged
      mysql-test/r/ps_7ndb.result:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/my_decimal.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      7c5aa30f
    • unknown's avatar
      Post-merge fix. · d7a90fa1
      unknown authored
      d7a90fa1
  4. 27 May, 2007 3 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.0 · 11dd353e
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/mysql-5.0-opt
      
      
      client/mysqldump.c:
        Auto merged
      mysql-test/r/mysqldump.result:
        Auto merged
      mysql-test/r/ps_2myisam.result:
        Auto merged
      mysql-test/r/ps_3innodb.result:
        Auto merged
      mysql-test/r/ps_4heap.result:
        Auto merged
      mysql-test/r/ps_5merge.result:
        Auto merged
      mysql-test/r/ps_6bdb.result:
        Auto merged
      mysql-test/r/ps_7ndb.result:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/my_decimal.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      11dd353e
    • unknown's avatar
      view.result, mysqldump.result: · 1e40d325
      unknown authored
        Merge with 5.0-opt.
      
      
      mysql-test/r/view.result:
        Merge with 5.0-opt.
      mysql-test/r/mysqldump.result:
        Merge with 5.0-opt.
      1e40d325
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/mysql-5.0-opt · 4f9d9845
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/mysql-5.1-opt
      
      
      client/mysqldump.c:
        Auto merged
      mysql-test/r/join_outer.result:
        Auto merged
      mysql-test/r/kill.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/join_outer.test:
        Auto merged
      mysql-test/t/kill.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      mysql-test/r/mysqldump.result:
        Merge with 5.0-opt
      mysql-test/t/mysqldump.test:
        Merge with 5.0-opt
      mysql-test/t/view.test:
        Merge with 5.0-opt
      sql/sql_select.cc:
        Merge with 5.0-opt
      4f9d9845
  5. 26 May, 2007 3 commits
    • unknown's avatar
      Avoided warnings on Windows. · 5f99cf96
      unknown authored
      5f99cf96
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · faf03194
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug28571
      
      
      faf03194
    • unknown's avatar
      Fixed bug #28571. Outer join queries with ON conditions over · 90484de3
      unknown authored
      constant outer tables did not return null complemented
      rows when conditions were evaluated to FALSE.
      Wrong results were returned because the conditions over constant
      outer tables, when being pushed down, were erroneously enclosed 
      into the guard function used for WHERE conditions.
      
      
      mysql-test/r/join_outer.result:
        Added a test case for bug #28571.
      mysql-test/t/join_outer.test:
        Added a test case for bug #28571.
      sql/sql_select.cc:
        Fixed bug #28571. Outer join queries with ON conditions over
        constant outer tables did not return null complemented
        rows when conditions were evaluated to FALSE.
        Wrong results were returned because the conditions over constant
        outer tables, when being pushed down, were erroneously enclosed 
        into the guard function used for WHERE conditions.
        The problem is fixed in the function make_join_select. Now the
        conditions over constant tables from ON expressions are pushed
        down after the conditions from WHERE has been pushed down.
      90484de3
  6. 25 May, 2007 3 commits
    • unknown's avatar
      field.h: · 5a5c256f
      unknown authored
        Warnings elimination.
      
      
      sql/field.h:
        Warnings elimination.
      5a5c256f
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · a2051ec5
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/mysql-5.0-opt
      
      
      a2051ec5
    • unknown's avatar
      Fixed bug #28522: · c326457d
      unknown authored
      sometimes `mysqldump --hex-blob' overruned output buffer by '\0' byte.
      
      The dump_table() function has been fixed to reserve 1 byte more for the
      last '\0' byte of dumped string.
      
      
      client/mysqldump.c:
        Fixed bug #28522.
        The dump_table() function has been fixed to reserve 1 byte more for the
        last '\0' byte of dumped string.
      mysql-test/t/mysqldump.test:
        Updated test case for bug #28522.
      mysql-test/r/mysqldump.result:
        Updated test case for bug #28522.
      c326457d
  7. 24 May, 2007 11 commits
  8. 23 May, 2007 5 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c57d6f72
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/27563-bug-5.0-opt-mysql
      
      
      sql/item_func.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      c57d6f72
    • unknown's avatar
      Bug#27563: Stored functions and triggers wasn't throwing an error when killed. · 1734b4e9
      unknown authored
      If a stored function or a trigger was killed it had aborted but no error
      was thrown. This allows the caller statement to continue without a notice.
      This may lead to a wrong data being inserted/updated to/deleted as in such
      cases the correct result of a stored function isn't guaranteed. In the case
      of triggers it allows the caller statement to ignore kill signal and to
      waste time because of re-evaluation of triggers that always will fail
      because thd->killed flag is still on.
      
      Now the Item_func_sp::execute() and the sp_head::execute_trigger() functions
      check whether a function or a trigger were killed during execution and
      throws an appropriate error if so.
      Now the fill_record() function stops filling record if an error was reported
      through thd->net.report_error.
      
      
      sql/item_func.cc:
        Bug#27563: Stored functions and triggers wasn't throwing an error when killed.
        Now the Item_func_sp::execute() function checks whether a trigger was killed
        during execution and throws an appropriate error if so.
      sql/sp_head.cc:
        Bug#27563: Stored functions and triggers wasn't throwing an error when killed.
        Now the sp_head::execute_trigger() function checks whether a function was
        killed during execution and throws an appropriate error if so.
      sql/sql_base.cc:
        Bug#27563: Stored functions and triggers wasn't throwing an error when killed.
        Now the fill_record() function stops filling record if an error was reported
        through thd->net.report_error.
      mysql-test/r/kill.result:
        Added a test case for the bug#27563: Stored functions and triggers wasn't
        throwing an error when killed.
      mysql-test/t/kill.test:
        Added a test case for the bug#27563: Stored functions and triggers wasn't
        throwing an error when killed.
      1734b4e9
    • unknown's avatar
      Bug #28250: Run-Time Check Failure #3 - The variable 'value' is · 8998080a
      unknown authored
      being used without being def
      
      Inside method Item_func_unsigned::val_int, the variable value 
      can be returned without being initialized when the CAST argument
      is of type DECIMAL and has a NULL value. This gives a run-time 
      error when building debug binaries using Visual C++ 2005.
      
      Solution: Initialize value to 0
      
      
      mysql-test/t/cast.test:
        bug#28250: There is no need for an extra test case, but we
        recognize that this one catches the bug.
      sql/item_func.cc:
        bug#28250: initialization of value.
      8998080a
    • unknown's avatar
      sql_table.cc: · 2d6544b4
      unknown authored
        After merge fix.
      
      
      sql/sql_table.cc:
        After merge fix.
      2d6544b4
    • unknown's avatar
      Merge dl145s.mysql.com:/users/mhansson/mysql/push/bug23856/my50-bug23856 · 0d318aa8
      unknown authored
      into  dl145s.mysql.com:/users/mhansson/mysql/push/bug23856/my51-bug23856
      
      
      sql/field.h:
        Auto merged
      0d318aa8