- 11 Oct, 2018 1 commit
-
-
Marko Mäkelä authored
-
- 10 Oct, 2018 2 commits
-
-
Sergei Petrunia authored
The test needs to be run with rocksdb_flush_log_at_trx_commit=1, otherwise the changes do not survive a crash.
-
Marko Mäkelä authored
Ensure that no redo log checkpoint occurs in a critical section of a recovery test.
-
- 09 Oct, 2018 1 commit
-
-
Sergei Petrunia authored
Make the testcase stable
-
- 08 Oct, 2018 2 commits
-
-
Thirunarayanan Balathandayuthapani authored
table for purge thread Problem: ======= Purge tries to fetch mdl lock for the whole table even though it tries to open one of the partition. But table name length was wrongly set to indicate the partition name too. Solution: ======== - Table name length should identify the table name only not the partition name.
-
Igor Babaev authored
derived table / view by equality Now rows of a materialized derived table are always put into a temporary table before join operation. If BNLH is used to join this table with the result of a partial join then both operands of the join are actually put into main memory. In most cases this is not efficient. We could avoid this by sending the rows of the derived table directly to the join operation. However this kind of data flow is not supported yet. Fixed by not allowing usage of hash join algorithm to join a materialized derived table if it's joined by an equality predicate of the form f=e where f is a field of the derived table.
-
- 06 Oct, 2018 1 commit
-
-
Marko Mäkelä authored
-
- 05 Oct, 2018 9 commits
-
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
-
Vladislav Vaintroub authored
Amend previous patch, so it works in all cases (also for "change user" command, and for RESET CONNECTION in 10.3)
-
Thirunarayanan Balathandayuthapani authored
-
Michael Widenius authored
-
Michael Widenius authored
This warning come from a copy() operation of type: memcpy(ptr, ptr+A, B), which is safe but produces a warning when run with valgrind. To avoid the warning, I added copy_or_move() method which uses memmove() instead of memcpy(). In 10.3 the change in item_strfunc::Item_func_concat() has to be mirroed in Item_func_concat_oracle() to avoid future valgrind warnings.
-
Marko Mäkelä authored
-
Thirunarayanan Balathandayuthapani authored
-
Thirunarayanan Balathandayuthapani authored
This is a regression caused by commit 73af8af0 (MDEV-15325 Incomplete validation of missing tablespace during recovery). If the recv_sys->addr_hash hash table ran out of memory, we would have to do crash recovery in multiple passes. If some tablespaces were missing, after the MDEV-15325 fix we would rescan the remaining redo log. But, we could incorrectly reset the "rescan" flag. Because of this, we would fail to apply some of the oldest redo log records to the data files. (The recv_sys->addr_hash would only contain records from the latest redo log scan batch.) Fix: After checking for missing tablespaces, reset the flag rescan=true, so that all redo log records will be re-read and applied.
-
- 03 Oct, 2018 2 commits
-
-
Vladislav Vaintroub authored
Output API function name, exception name, exception text
-
Vladislav Vaintroub authored
-
- 01 Oct, 2018 1 commit
-
-
Thirunarayanan Balathandayuthapani authored
|| node->vcol_info.is_used()' failed - Purge thread can acquire mdl lock while initializing the mysql template. Set the vcol_info information before acquiring mdl lock. - Purge thread doesn't need to use the virtual column info even though it is requested. In that case, reset the virtual column info.
-
- 27 Sep, 2018 1 commit
-
-
Eugene Kosov authored
rw_lock_x_lock_wait_func(): remove duplicated logic added in incorrect merge Affected counters are affected by InnoDB monitor. But they aren't stable and thus can not be realiably tested.
-
- 26 Sep, 2018 1 commit
-
-
Marko Mäkelä authored
Some global function definitions were orphaned by a bug fix in MySQL 5.7.14 more than 2 years ago. Remove them. https://github.com/mysql/mysql-server/commit/5ed18d823c4fad30b75ab4b68c7327c1b95821d3
-
- 25 Sep, 2018 2 commits
-
-
Marko Mäkelä authored
Implement undo tablespace truncation via normal redo logging. Implement TRUNCATE TABLE as a combination of RENAME to #sql-ib name, CREATE, and DROP.
-
Daniel Bartholomew authored
-
- 24 Sep, 2018 4 commits
-
-
Elena Stepanova authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 23 Sep, 2018 6 commits
-
-
Sergei Golubchik authored
storage/rocksdb/rdb_datadic.cc: In member function 'int myrocks::Rdb_key_def::unpack_integer(myrocks::Rdb_field_packing*, Field*, uchar*, myrocks::Rdb_string_reader*, myrocks::Rdb_string_reader*) const' storage/rocksdb/rdb_datadic.cc:1781:1: internal compiler error: Segmentation fault } on ppc64le, ubuntu bionic gcc 7.3.0 and debian stretch gcc 6.3.0 The error happens with -ftree-loop-vectorize when trying to vectorize a particular loop (see Rdb_key_def::unpack_integer()) Compiler gets confused by __attribute__((optimize("O0")) that comes from ha_rocksdb_proto.h. The intention of this __attribute__ was to prevent function from being inlined (see ha_rocksdb.cc). Let's use a more specific attribute that prevents inlining but does not confuse loop vectorizer.
-
Sergei Golubchik authored
-
Jan Lindström authored
-
Sergei Petrunia authored
An error in "group commit with MariaDB's binlog" code: we would flush the WAL even when the transaction did not do any writes (and so the logic in myrocks::Rdb_transaction::commit caused it to rollback).
-
Jan Lindström authored
-
Jan Lindström authored
Reset query cache after every test case and add wait after load infile.
-
- 22 Sep, 2018 2 commits
-
-
Sergei Golubchik authored
to guarantee that it's destroyed when plugin deinit is called, not after
-
Sergei Golubchik authored
-
- 21 Sep, 2018 5 commits
-
-
Sergei Golubchik authored
Use RedHat-recommended /var/lib/rpm-state/mariadb/ for restart flag. This also fixes SUSE where /var/lib/rpm-state doesn't necessarily exist.
-
Sergei Golubchik authored
cover ALTER TABLE
-
Sergei Golubchik authored
MDEV-16792 Assertion `m_status == DA_ERROR' failed in Diagnostics_area::sql_errno or wrong result upon SHOW TABLE STATUS after adding partition under ANSI_QUOTES if opening a table fails with a syntax error, the error shouldn't be suppressed completely as if it didn't happen at all.
-
Alexander Barkov authored
-
Alexander Barkov authored
-