1. 23 Oct, 2007 2 commits
    • unknown's avatar
      Merge mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-bug30695 · 94254a3f
      unknown authored
      into  mattiasj-laptop.(none):/home/mattiasj/clones/mysql-5.1-bug30878
      
      
      mysql-test/r/partition.result:
        SCCS merged
      mysql-test/t/partition.test:
        SCCS merged
      94254a3f
    • unknown's avatar
      Bug #30695: An apostrophe ' in the comment of the ADD PARTITION · b8583cd5
      unknown authored
        causes the Server to crash.
      
      Accessing partitioned table with an apostrophe in partition options
      like DATA DIRECTORY, INDEX DIRECTORY or COMMENT causes server crash.
      
      Partition options were saved in .frm file without escaping.
      When accessing such table it is not possible to properly restore
      partition information.
      Crashed because there was no check for partition info parser failure.
      
      Fixed by escaping quoted text in the partition info when writing it to
      the frm-file and added a check that it was able to parse the partition
      info before using it 
      
      NOTE: If the comment is written by an earlier version of the server,
      the corrupted frm-file is not fixed, but left corrupted, you have to
      manually drop the table and recreate it.
      
      
      mysql-test/r/partition.result:
        bug #30695: An apostrophe ' in the comment of the ADD PARTITION causes
        the Server to crash.
         testresult
      mysql-test/t/partition.test:
        bug #30695: An apostrophe ' in the comment of the ADD PARTITION causes
        the Server to crash.
          testcase
      sql/sql_partition.cc:
        Bug #30695: An apostrophe ' in the comment of the ADD PARTITION causes
          the Server to crash.
        
          Crashes when there is an non escaped apostrophe in the partition options
        
          fixed by escaping quoted text before writing to the frm-file
      sql/table.cc:
        Bug #30695 An apostrophe ' in the comment of the ADD PARTITION
          causes the Server to crash
        
        problem was using a null poiter without check -> crash.
        
        added a check that the previus call succeded
      b8583cd5
  2. 17 Oct, 2007 1 commit
    • unknown's avatar
      Bug #30878: Crashing when alter an auto_increment non partitioned · 597caca7
      unknown authored
        table to partitioned
      
      Problem:
      Crashed because usage of an uninitialised mutex when auto_incrementing
        a partitioned temporary table
      
      Fix:
      Only locking (using the mutex) if not temporary table.
      
      
      mysql-test/r/partition.result:
        Bug #30878: Crashing when alter an auto_increment non partitioned
          table to partitioned
        test result
      mysql-test/t/partition.test:
        Bug #30878: Crashing when alter an auto_increment non partitioned
          table to partitioned
        testcase
      sql/ha_partition.cc:
        Bug #30878: Crashing when alter an auto_increment non partitioned
          table to partitioned
        
        If the table is a temporary table, the table_share->mutex is not
          initialised.
        
        Checking if not temporary table, then OK to lock (else no need
          to lock)
      597caca7
  3. 10 Oct, 2007 5 commits
  4. 09 Oct, 2007 3 commits
  5. 05 Oct, 2007 2 commits
  6. 04 Oct, 2007 8 commits
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/mysql-5.1-engines · 6b35867f
      unknown authored
      into  xiphis.org:/anubis/antony/work/p1-bug31382.1.merge-5.1
      
      6b35867f
    • unknown's avatar
      Bug#31382 · e8a23842
      unknown authored
        "Disabled plugin is provoking Valgrind error"
        If there are any auto-alloced string plug-in options, memory is
        allocated during the call for handle_options(). We must free this
        memory if we are not installing the plug-in.
      
      
      include/my_getopt.h:
        bug31382
          new function: my_cleanup_options()
      mysys/my_getopt.c:
        bug31382
          new function: my_cleanup_options(), fini_one_value()
          alter init_variables() to take an extra option.
          forward declare init_one_value() and fini_one_value()
      sql/sql_plugin.cc:
        bug31382
          after calling handle_options(), make sure to call my_cleanup_options()
          if we are not installing the plug-in.
      e8a23842
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · 0f769793
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      storage/ndb/test/ndbapi/testScanFilter.cpp:
        Auto merged
      0f769793
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 711be53b
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      711be53b
    • unknown's avatar
      Bug #30484: Partitions: crash with self-referencing trigger · 25eb54da
      unknown authored
      Two cases in ha_partition::extra() was missing
      (HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH)
      which only is currently used by NDB (which not uses ha_partition)
      
      
      mysql-test/r/partition.result:
        Added result for test of Bug #30484
      mysql-test/t/partition.test:
        Added test for Bug #30484
      sql/ha_partition.cc:
        Added HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH
        in ha_partition::extra to do nothing
        (Only currently used in NDB, which is not dependent of ha_partition)
      25eb54da
    • unknown's avatar
      Merge production.mysql.com:/usersnfs/jperkin/bk/build/5.0 · 3fb8f160
      unknown authored
      into  production.mysql.com:/usersnfs/jperkin/bk/build/5.1
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      scripts/mysql_install_db.sh:
        Auto merged
      3fb8f160
    • unknown's avatar
      Merge production.mysql.com:/usersnfs/jperkin/bk/build/5.0 · 270011cb
      unknown authored
      into  production.mysql.com:/usersnfs/jperkin/bk/bug-27692/5.0
      
      270011cb
    • unknown's avatar
      Restore creation of test databases and the anonymous user which · 4d1a88e8
      unknown authored
      were accidentally removed during a previous rototill of this
      code.  Fixes bug#27692.
        
      While it can be argued we should strive to provide a 'secure by
      default' installation, this happens to be the setup currently
      documented in the manual as the default, so defer changes that
      improve security out of the box to a co-ordinated effort later
      on.
        
      For now, make a note about the test databases and anonymous user
      in mysql_install_db and recommend that mysql_secure_installation
      be ran for users wishing to remove these defaults.
      
      [..re-commit of previously lost change..]
      
      
      scripts/mysql_system_tables_data.sql:
        Add anonymous accounts.
      scripts/mysql_install_db.sh:
        Point users at the mysql_secure_installation script.
      mysql-test/mysql-test-run.pl:
        Add a comment where removing anonymous users.
      4d1a88e8
  7. 02 Oct, 2007 1 commit
    • unknown's avatar
      testScanFilter.cpp: · c47eab5e
      unknown authored
         Updated variable size arrays to use vector like Jonas did for 5.1 so that my build would not break
      
      
      ndb/test/ndbapi/testScanFilter.cpp:
         Updated variable size arrays to use vector like Jonas did for 5.1 so that my build would not break
      c47eab5e
  8. 01 Oct, 2007 6 commits
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 1b0701e4
      unknown authored
      into  mysql.com:/home/kent/bk/make-install/mysql-5.1-build
      
      1b0701e4
    • unknown's avatar
      make_binary_distribution.sh: · 2f295f62
      unknown authored
        Added special handling of "mysql_install_db" and "mysql.server" scripts,
        find executables relative to the current directory.
      
      
      scripts/make_binary_distribution.sh:
        Added special handling of "mysql_install_db" and "mysql.server" scripts,
        find executables relative to the current directory.
      2f295f62
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · 8f9743d6
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      configure.in:
        5.0 version change does not affect 5.1 - "use local".
      8f9743d6
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 1b96170f
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      1b96170f
    • unknown's avatar
      Fix bug#31150 "Test case does not cleanup": · a7e3f053
      unknown authored
      Add the cleanup by dropping the database 'track' in test "rpl_bug31076".
      
      
      mysql-test/suite/rpl/r/rpl_bug31076.result:
        Fix bug#31150 "Test case does not cleanup":
        Drop the database 'track' which was newly created for this test.
      mysql-test/suite/rpl/t/rpl_bug31076.test:
        Fix bug#31150 "Test case does not cleanup":
        Drop the database 'track' which was newly created for this test.
      a7e3f053
    • unknown's avatar
      Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.1-engines · 2308c12a
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG30583/mysql-5.1-engines
      
      
      sql/ha_partition.cc:
        Auto merged
      2308c12a
  9. 29 Sep, 2007 4 commits
  10. 28 Sep, 2007 7 commits
  11. 27 Sep, 2007 1 commit