1. 23 Aug, 2017 23 commits
    • Michael Widenius's avatar
      Affected rows for a SP now includes affected rows for all statements · 94bbe8ad
      Michael Widenius authored
      The old behavior of returning the affected rows for the last statement
      in a stored procedure was more an accident than design. Having the number
      of affected rows for all sub statements is more useful and will not change
      just because on changes the order of statements in the stored procedure.
      94bbe8ad
    • Monty's avatar
      Added missing ; after WSREP_TO_ISOLATION_BEGIN · 4be15fe0
      Monty authored
      - Changed also a few ;; to ;
      4be15fe0
    • Monty's avatar
      New option for slow logging (log_slow_disable_statements) · 21518ab2
      Monty authored
      This fixes MDEV-7742 and MDEV-8305 (Allow user to specify if stored
      procedures should be logged in the slow and general log)
      
      New functionality:
      - Added new variables log_slow_disable_statements and log_disable_statements
        that can be used to disable logging of certain queries to slow and
        general log. Currently supported options are 'admin', 'call', 'slave'
        and 'sp'.
        Defaults are as before. Only 'sp' (stored procedure statements) is
        disabled for  slow and general_log.
      - Slow log to files now includes the following new information:
        - When logging stored procedure statements the name of stored
          procedure is logged.
        - Number of created tmp_tables, tmp_disk_tables and the space used
          by temporary tables.
      - When logging 'call', the logged status now contains the sum of all
        included statements.  Before only 'time' was correct.
      - Added filsort_priority_queue as an option for log_slow_filter (this
        variable existed before, but was not exposed)
      - Added support for BIT types in my_getopt()
      
      Mapped some old variables to bitmaps (old variables can still be used)
      - Variable 'log_queries_not_using_indexes' is mapped to
        log_slow_filter='not_using_index'
      - Variable 'log_slow_slave_statements' is mapped to
        log_slow_disabled_statements='slave'
      - Variable 'log_slow_admin_statements' is mapped to
        log_slow_disabled_statements='admin'
      - All the above variables are changed to session variables from global
        variables
      
      Other things:
      - Simplified LOGGER::log_command. We don't need to check for super if
        OPTION_LOG_OFF is set as this flag can only be set if one is a super
        user.
      - Removed some setting of enable_slow_log as it's guaranteed to be set by
        mysql_parse()
      - mysql_admin_table() now sets thd->enable_slow_log
      - Added prepare_logs_for_admin_command() to reset thd->enable_slow_log if
        needed.
      - Added new functions to store, restore and add slow query status
      - Added new functions to store and restore query start time
      - Reorganized Sub_statement_state according to types
      - Added code in dispatch_command() to ensure that
        thd->reset_for_next_command() is always called for a query.
      - Added thd->last_sql_command to simplify checking of what was the type
        of the last command. Needed when logging to slow log as lex->sql_command
        may have changed before slow logging is called.
      - Moved QPLAN_TMP_... to where status for tmp tables are updated
      - Added new THD variable, affected_rows, to be able to correctly log
        number of affected rows to slow log.
      21518ab2
    • Monty's avatar
      Added DBUG_ASSERT_AS_PRINTF compile flag · 536215e3
      Monty authored
      If compiling a non DBUG binary with
      -DDBUG_ASSERT_AS_PRINTF asserts will be
      changed to printf + stack trace (of stack
      trace are enabled).
      
      - Changed #ifndef DBUG_OFF to
        #ifdef DBUG_ASSERT_EXISTS
        for those DBUG_OFF that was just used to enable
        assert
      - Assert checking that could greatly impact
        performance where changed to DBUG_ASSERT_SLOW which
        is not affected by DBUG_ASSERT_AS_PRINTF
      - Added one extra option to my_print_stacktrace() to
        get more silent in case of stack trace printing as
        part of assert.
      536215e3
    • Monty's avatar
      Fixed sequence.gtid · 52a1e4d6
      Monty authored
      52a1e4d6
    • Michael Widenius's avatar
      Fixed some compiler warnings · 9e1cc831
      Michael Widenius authored
      9e1cc831
    • Michael Widenius's avatar
      Safety fix: lock binlog_end_pos before calling signal_update · f71bed08
      Michael Widenius authored
      The mutex is needed to ensure that sql thread should not not miss the error
      signal.
      f71bed08
    • Michael Widenius's avatar
      Lots of small cleanups · 458d5ed8
      Michael Widenius authored
      - Simplified use_trans_cache() to return at once if is_transactional is set
      - Indentation and spelling errors fixed
      - Don't call signal_update() if update_binlog_end_pos() is called as the
        function already calls signal_update()
      - Removed not used function wait_for_update_bin_log(), which would cause
        errors if ever used.
      - Simplified handler::clone() by always allocating 'ref' in ha_open(). To do
        this I added an optional MEM_ROOT argument to ha_open() to be used when
        allocating 'ref'
      - Changed arguments to get_system_var() from LEX_CSTRING to LEX_CSTRING*
      - Added THD as argument to create_select_for_variable(). Changed also char*
        argument to LEX_CSTRING to avoid strlen() call.
      - Change calls to append() to use LEX_CSTRING
      458d5ed8
    • Michael Widenius's avatar
      Print thread_id instead of pthread_self to error log · a70f7aad
      Michael Widenius authored
      - Now we have same thread_id in general log, slow long and error log
        instead of a long meaningless thread number that may even change for
        one user.
      - Align error and slow log header with output
      - Extend thread_id with one number to handle nice printing up to ten
        million connections
      a70f7aad
    • Michael Widenius's avatar
    • Michael Widenius's avatar
      Simplify test if we can use table in query cache · 8bfda2f0
      Michael Widenius authored
      - Added TABLE_SHARE->not_usable_by_query_cache
      - Moved TABLE->no_replicate to TABLE_SHARE->no_replicate as it's same for
        all TABLE instances
      - Renamed TABLE_SHARE->cached_row_logging_check to can_do_row_logging
      8bfda2f0
    • Michael Widenius's avatar
      Added sql_alloc.h · 1ed605e4
      Michael Widenius authored
      - Moved declaration of Sql_alloc from Sql_list.h as they are independent
        structures.
      1ed605e4
    • Sergei Golubchik's avatar
      Don't include my_global.h in "pure" plugins · 82860235
      Sergei Golubchik authored
      this partially reverts 6e56ebbb498
      82860235
    • Sergei Golubchik's avatar
      Fix compilation warnings in plugins · a6e215f2
      Sergei Golubchik authored
      * update cracklib_password_check to match the new prototype
      * cannot use __attribute__((format)) for my_snprintf, because
        we support format extensions that the compiler doesn't know about.
      a6e215f2
    • Sergei Golubchik's avatar
      Fix compilation errors · d5a6bae7
      Sergei Golubchik authored
      d5a6bae7
    • Michael Widenius's avatar
      Enusure that my_global.h is included first · 4aaa38d2
      Michael Widenius authored
      - Added sql/mariadb.h file that should be included first by files in sql
        directory, if sql_plugin.h is not used (sql_plugin.h adds SHOW variables
        that must be done before my_global.h is included)
      - Removed a lot of include my_global.h from include files
      - Removed include's of some files that my_global.h automatically includes
      - Removed duplicated include's of my_sys.h
      - Replaced include my_config.h with my_global.h
      4aaa38d2
    • Michael Widenius's avatar
      Added copyright message to some files · b0da8897
      Michael Widenius authored
      b0da8897
    • Monty's avatar
      Use microsecond_interval_timer() instead of my_time() in replicaiton · b77bb43f
      Monty authored
      - Use microsecond_interval_timer() to calculate time for applying row events.
        (Faster execution)
      - Removed return value for set_row_stmt_start_timestamp()
        as it was never used.
      b77bb43f
    • Monty's avatar
      Cleaned up output from thr_print_locks · 44676ed5
      Monty authored
      44676ed5
    • Sergei Golubchik's avatar
      Compile mariabackup with its own copy of net_serv.cc · 4040a17e
      Sergei Golubchik authored
      Don't use the server's version, that expects a valid THD.
      Modify net_serv.cc not not use any THD if MYSQL_SERVER isn't defined.
      
      This reverts commit aaddac5c.
      4040a17e
    • Sergei Golubchik's avatar
      fix 64-bit tests too · 7a5eb003
      Sergei Golubchik authored
      7a5eb003
    • Sergei Golubchik's avatar
      32-bit fixes · 4246fe80
      Sergei Golubchik authored
      4246fe80
    • Vladislav Vaintroub's avatar
      fix compile errors · aaddac5c
      Vladislav Vaintroub authored
      aaddac5c
  2. 22 Aug, 2017 3 commits
  3. 20 Aug, 2017 2 commits
  4. 19 Aug, 2017 1 commit
    • Igor Babaev's avatar
      This patch complements the patch for mdev-10855. · d7b45e01
      Igor Babaev authored
      It allows to push conditions into derived with window functions not
      only in the cases when the window specifications of these window
      functions use the same partition, but also in the cases when the window
      functions use partitions that share only some fields. In these
      cases only the conditions over the common fields are pushed.
      d7b45e01
  5. 18 Aug, 2017 2 commits
  6. 17 Aug, 2017 2 commits
  7. 16 Aug, 2017 3 commits
    • Marko Mäkelä's avatar
      Silence a -Wimplicit-fallthrough warning · ff3cf749
      Marko Mäkelä authored
      ff3cf749
    • Marko Mäkelä's avatar
      Work around MDEV-13542 Crashing on a corrupted page is unhelpful · 92f9be49
      Marko Mäkelä authored
      With MDEV-12288 and MDEV-13536, the InnoDB purge threads will access
      pages more often, causing all sorts of debug assertion failures in
      the B-tree code.
      
      Work around this problem by amending the corruption tests with
      --innodb-purge-rseg-truncate-frequency=1 --skip-innodb-fast-shutdown
      so that everything will be purged before the server
      is restarted to deal with the corruption.
      92f9be49
    • Marko Mäkelä's avatar
      MDEV-13536 DB_TRX_ID is not actually being reset when the history is removed · f4b379d6
      Marko Mäkelä authored
      This should have been part of MDEV-12288.
      
      trx_undo_t::del_marks: Remove.
      Purge needs to process all undo log records in order to
      reset the DB_TRX_ID. Before MDEV-12288, it sufficed to only delete
      the purgeable delete-marked records, and it ignore other undo log.
      
      trx_rseg_t::needs_purge: Renamed from trx_rseg_t::last_del_marks.
      Indicates whether a rollback segment needs to be processed by purge.
      
      TRX_UNDO_NEEDS_PURGE: Renamed from TRX_UNDO_DEL_MARKS.
      Indicates whether a rollback segment needs to be processed by purge.
      This will be 1 until trx_purge_free_segment() has been invoked.
      
      row_purge_record_func(): Set the is_insert flag for TRX_UNDO_INSERT_REC,
      so that the DB_ROLL_PTR will match in row_purge_reset_trx_id().
      
      trx_purge_fetch_next_rec(): Add a comment about row_purge_record_func()
      going to set the is_insert flag.
      
      trx_purge_read_undo_rec(): Always attempt to read the undo log record.
      
      trx_purge_get_next_rec(): Do not skip any undo log records.
      Even when no clustered index record is going to be removed,
      we may want to reset some DB_TRX_ID,DB_ROLL_PTR.
      
      trx_undo_rec_get_cmpl_info(), trx_undo_rec_get_extern_storage(): Remove.
      
      trx_purge_add_undo_to_history(): Set the TRX_UNDO_NEEDS_PURGE flag
      so that the resetting will work on undo logs that were originally
      created before MDEV-12288 (MariaDB 10.3.1).
      
      trx_undo_roll_ptr_is_insert(), trx_purge_free_segment(): Cleanup
      (should be no functional change).
      f4b379d6
  8. 15 Aug, 2017 4 commits