1. 09 Oct, 2009 16 commits
    • Magne Mahre's avatar
      Bug #31031 ALTER TABLE regression in 5.0 · 95b32ae2
      Magne Mahre authored
      An ALTER TABLE statement which added a column and added
      a non-partial index on it failed with:
                  
      "ERROR 1089 (HY000): Incorrect sub part key; the used
      key part isn't a string, the used length is longer than
      the key part, or the storage engine doesn't support unique
      sub keys"
                  
      In a check introduced to fix an earlier bug (no. 26794),
      to allow for indices on spatial type columns, the
      test expression was flawed (a logical OR was used instead
      of a logical AND), which led to this regression.
                  
      The code in question does a sanity check on the key, and
      the flawed code mistakenly classified any index created
      in the way specified above as a partial index.  Since
      many data types does not allow partial indices, the
      statement would fail.
      95b32ae2
    • Magne Mahre's avatar
      Bug #33831 mysql_real_connect() connects again if · 4432a0ce
      Magne Mahre authored
                 given an already connected MYSQL handle
      
      mysql_real_connect() did not check whether the MYSQL connection
      handler was already connected and connected again even if so. 
      Now a CR_ALREADY_CONNECTED error is returned.
      4432a0ce
    • Alexander Nozdrin's avatar
      975adc7f
    • Alexander Nozdrin's avatar
      Merge from mysql-next-mr. · 71563ed5
      Alexander Nozdrin authored
      71563ed5
    • Jon Olav Hauglid's avatar
      Bug #25863 No database selected error, but documentation · a7a161fa
      Jon Olav Hauglid authored
                 says * for global allowed
      
      The current behaviour of 'GRANT *' was changed as a part of the fix
      for Bug#19022, Bug#17199 and Bug#18444. To avoid regression, we keep
      the current behavior and update the documentation. 
      Test case added to grant.test.
      a7a161fa
    • Alexander Nozdrin's avatar
      Pull from mysql-next-mr. · e99f6ee9
      Alexander Nozdrin authored
      e99f6ee9
    • Alexander Nozdrin's avatar
      Pull from mysql-next-mr. · abaf5c3d
      Alexander Nozdrin authored
      abaf5c3d
    • Konstantin Osipov's avatar
      Backport the following revision from 6.0: · 956c8776
      Konstantin Osipov authored
      ```-------------------------------------------------------
      revno: 2476.657.210
      committer: kostja@bodhi.(none)
      timestamp: Tue 2007-12-04 18:27:44 +0300
      message:
        Fix a potential linking error with libmysql and libmysqld on Windows:
        remove declarations of removed functions (Bug#31952)
      ```
      
      -------------------------------------------------------
      
      
      libmysql/libmysql.def:
        Remove declarations of removed functions (Bug#31952)
      libmysqld/libmysqld.def:
        Remove declarations of removed functions (Bug#31952)
      956c8776
    • Alexander Nozdrin's avatar
      Merge from mysql-trunk. · 477e59f2
      Alexander Nozdrin authored
      477e59f2
    • Alexander Nozdrin's avatar
      Change the version tag (to 5.5.0). · 5041ac75
      Alexander Nozdrin authored
      5041ac75
    • Konstantin Osipov's avatar
      Backport to 5.4 the following changesets: · a9d4ba84
      Konstantin Osipov authored
      revno: 2476.785.24
      committer: kostja@bodhi.(none)
      timestamp: Tue 2007-10-16 20:19:00 +0400
      message:
        Reflect a rename of a member in the client ABI (a compatible change).
      ----------------------------------------------------------
      revno: 2476.423.26
      committer: kostja@bodhi.(none)
      timestamp: Tue 2007-10-16 20:12:37 +0400
      message:
        Update the client ABI to reflect member rename
        (this is a backward-compatible change).
      ----------------------------------------------------------
      revno: 2476.785.22
      committer: kostja@bodhi.(none)
      timestamp: Tue 2007-10-16 19:37:25 +0400
      message:
        Remove some remains of support of 3.22 protocol. This was in fact dead code,
        since the option to talk 3.22 protocol was removed in 4.1 and there
        is no other protocol negotiation mechanism besides this option.
      
      include/mysql.h.pp:
        Update ABI.
      include/mysql_com.h:
        Remove an unused 3.22 protocol member.
      sql/field.cc:
        Remove an unused 3.22 protocol check.
      sql/mysqld.cc:
        Remove an unused 3.22 protocol check.
      sql/net_serv.cc:
        Remove an unused 3.22 protocol variable initialization.
      sql/protocol.cc:
        Remove an unused 3.22 protocol check.
      a9d4ba84
    • Alexander Nozdrin's avatar
      Merge from mysql-next-mr. · 1de5b86c
      Alexander Nozdrin authored
      1de5b86c
    • Dmitry Lenev's avatar
      Fix for bug #44738 "fill_schema_table_from_frm() opens tables without · 510318ad
      Dmitry Lenev authored
      lowercasing table name".
      
      In lower_case_table_names > 0 mode some queries to I_S left entries
      with incorrect key in table definition cache. This wasted memory and
      caused some of the further queries to I_S to produce stale results
      in cases when table definition was changed by a DDL statement.
      Also in combination with similar problem in CREATE TABLE (which also
      has peeked into table definition cache using non-normalized key) this
      issue led to to spurious ER_TABLE_EXISTS_ERROR errors when one tried
      to create a table with the same name as a previously existing but
      dropped table (assuming that table name contained characters in upper
      case).
      
      This problem occured due to fact that fill_schema_table_from_frm()
      was not properly normalizing (lowercasing) database and table names
      which it used for lookups in table definition cache.
      
      This fix adds proper normalization to this function. It also solves
      similar problem in CREATE TABLE's code by ensuring that it uses
      properly normalized version of table name when it peeks into table
      definition cache instead of non-normalized one.
      
      mysql-test/r/lowercase_table2.result:
        Added test for #44738 "fill_schema_table_from_frm() opens tables
        without lowercasing table name".
      mysql-test/t/lowercase_table2.test:
        Added test for #44738 "fill_schema_table_from_frm() opens tables
        without lowercasing table name".
      sql/sql_show.cc:
        Normalize database and table name before using them for looking
        up entry in table definition cache.
      sql/sql_table.cc:
        Ensure that CREATE TABLE uses properly normalized version of table
        name when it peeks into table definition cache.
      510318ad
    • Alexander Nozdrin's avatar
      Merge from mysql-trunk. · 08759f58
      Alexander Nozdrin authored
      08759f58
    • Alexander Nozdrin's avatar
      Fix default.cof. · b61aec18
      Alexander Nozdrin authored
      b61aec18
    • Alexander Nozdrin's avatar
      Merge from mysql-trunk-bugfixing. · f558b85e
      Alexander Nozdrin authored
      f558b85e
  2. 08 Oct, 2009 4 commits
  3. 07 Oct, 2009 5 commits
    • Alexander Nozdrin's avatar
      A backport of a patch for Bug#35297. · 951c11c8
      Alexander Nozdrin authored
      Original revision in mysql-6.0-codebase is:
      
      revno: 2617.31.14
      committer: Konstantin Osipov <kostja@sun.com>
      branch nick: mysql-6.0-runtime
      timestamp: Sat 2009-03-28 11:42:55 +0300
      message:
        Bug#35297 SHOW CREATE EVENT does not show the DEFINER:
        update test result after a merge from now.
      951c11c8
    • Alexander Nozdrin's avatar
      A backport a patch of Bug#34828. · 62fa62af
      Alexander Nozdrin authored
      Original revision is from mysql-6.0-codebase:
      
      revno: 2617.23.13
      committer: Alexander Nozdrin <alik@sun.com>
      branch nick: 6.0-rt-bug34828
      timestamp: Tue 2009-02-24 14:25:46 +0300
      message:
        A patch for Bug#34828: OF is taken as OFF and a value of 0
        is set for variable SQL_notes.
        
        The problem was that partial match was allowed for keywords.
        
        A fix is to disable partial match and require full match.
      62fa62af
    • Alexander Nozdrin's avatar
      A backport of patch for Bug#26704. · 67227ef1
      Alexander Nozdrin authored
      Original revision is from mysql-6.0-codebase:
      
      revno: 2630.3.1
      committer: Alexander Nozdrin <alik@mysql.com>
      branch nick: 6.0-rt-bug26704
      timestamp: Thu 2008-05-29 21:04:06 +0400
      message:
        A fix for Bug#26704: Failing DROP DATABASE brings
        mysql-client out of sync.
      
        The problem was that we changed current database w/o caring
        whether it was dropped successfully or not.
      
        The fix is not to change current database if we failed to drop it.
      67227ef1
    • Alexander Nozdrin's avatar
      Merge from mysql-trunk-bugfixing. · 11cb4d66
      Alexander Nozdrin authored
      11cb4d66
    • Alexander Nozdrin's avatar
      503b1087
  4. 05 Oct, 2009 2 commits
  5. 03 Oct, 2009 3 commits
  6. 02 Oct, 2009 4 commits
  7. 01 Oct, 2009 5 commits
  8. 30 Sep, 2009 1 commit