An error occurred fetching the project authors.
  1. 26 Oct, 2009 1 commit
    • Vladislav Vaintroub's avatar
      Bug #48317 cannot build innodb as static library. · fc7f9316
      Vladislav Vaintroub authored
      The problem here is that the latest innodb push contains
      both MYSQL_STORAGE_ENGINE(INNOBASE) and MYSQL_STORAGE_ENGINE(INNOBASE)
      in the same CMakeLists.txt, to make the resulting library
      ha_innodb.dll, instead of ha_innobase.dll.
      
      Using multiple MYSQL_STORAGE_ENGINE within the same  CMakeLists.txt
      conflicts with the fix for the bug Bug #47795 "CMake, storage engine
      name different from directory name". Top-level CMakeLists.txt now 
      parses storage engine's  CMakeLists.txt to extract engines name from 
      MYSQL_STORAGE_ENGINE().
      
      For innodb, it concludes that there is not storage engine named
      INNOBASE, hence WITH_INNOBASE_STORAGE_ENGINE has no effect.
      
      The fix is to use SET_TARGET_PROPERTIES(... PROPERTIES OUTPUT_NAME ...),
      instead of renaming the engine to have plugins named ha_innodb.dll.
      fc7f9316
  2. 20 Oct, 2009 2 commits
  3. 16 Oct, 2009 1 commit
  4. 30 Sep, 2009 1 commit
    • Vladislav Vaintroub's avatar
      Backport http://lists.mysql.com/commits/57778 · 146a86b3
      Vladislav Vaintroub authored
      2677 Vladislav Vaintroub	2008-11-04
      CMakeLists.txt files cleanup
      - remove SAFEMALLOC and SAFE_MUTEX definitions that were 
      present in *each* CMakeLists.txt. Instead, put them into top level 
      CMakeLists.txt, but disable on Windows, because
      a) SAFEMALLOC does not add any functionality that is not already
      present in Debug C runtime ( and 2 safe malloc one on top of the other 
      only unnecessarily slows down the server) 
            
      b)SAFE_MUTEX does not work on Windows  and have been
      explicitely  disabled on Windows with #undef previously.  Fortunately,
      ntdll does  pretty good  job identifying l problems with 
      CRITICAL_SECTIONs.
      DebugBreak()s on using uninited critical section, unlocking unowned 
      critical section)
            
      -Also, remove occationally used -D_DEBUG (added by compiler 
      anyway)
      
      
      sql/udf_example.c:
        use unixish end of line
      146a86b3
  5. 07 Aug, 2009 3 commits
    • Guilhem Bichot's avatar
      small cmake fix for Windows build · 5e98bffa
      Guilhem Bichot authored
      storage/innobase/CMakeLists.txt:
        ${WIN64} fails if variable is undefined
      5e98bffa
    • Guilhem Bichot's avatar
      Fixes to tests and their results, to account for differences between InnoDB... · 60dead9c
      Guilhem Bichot authored
      Fixes to tests and their results, to account for differences between InnoDB 1.0.4 and the old builtin.
      All committed result differences have either been verified by me or copied from Oracle's provided
      results (storage/innodb_plugin/mysql-test/*.result, storage/innodb_plugin/mysql-test/patches).
      
      mysql-test/r/information_schema.result:
        queries changed a bit
      mysql-test/r/information_schema_db.result:
        queries changed a bit
      mysql-test/r/innodb-autoinc.result:
        importing piece from storage/innodb_plugin/mysql-test/innodb-autoinc.result
      mysql-test/r/innodb.result:
        result close to storage/innodb_plugin/innodb.result, except 4095 pages instead of 8191, which makes
        sense as Summit runs with a buffer pool of 64M, whereas the mentioned result file was made with
        a buffer pool of 128M.
      mysql-test/r/mysqlshow.result:
        InnoDB I_S tables have arrived
      mysql-test/suite/funcs_1/r/is_columns_is.result:
        queries changed a bit
      mysql-test/suite/funcs_1/r/is_columns_is_embedded.result:
        queries changed a bit
      mysql-test/suite/funcs_1/r/is_tables_is.result:
        queries changed a bit
      mysql-test/suite/funcs_1/t/is_columns_is.test:
        making I_S queries ignore InnoDB I_S tables
      mysql-test/suite/funcs_1/t/is_columns_is_embedded.test:
        making I_S queries ignore InnoDB I_S tables
      mysql-test/suite/funcs_1/t/is_tables_is.test:
        making I_S queries ignore InnoDB I_S tables
      mysql-test/suite/innodb/r/innodb-zip.result:
        result update
      mysql-test/suite/innodb/t/innodb-zip.test:
        439, as size of prefix key, throws error with certain system zlib (ubuntu
        "intrepid") but not with zlib bundled with MySQL, because zlib's
        compressBound() are different (and used by InnoDB's page_zip_empty_size()).
      mysql-test/suite/sys_vars/r/innodb_file_per_table_basic.result:
        result update
      mysql-test/suite/sys_vars/r/innodb_lock_wait_timeout_basic.result:
        result update
      mysql-test/suite/sys_vars/r/innodb_sync_spin_loops_basic_32.result:
        result update (default value is 30 in the plugin, 20 in the builtin)
      mysql-test/suite/sys_vars/r/innodb_sync_spin_loops_basic_64.result:
        result update (default value is 30 in the plugin, 20 in the builtin)
      mysql-test/suite/sys_vars/r/table_definition_cache_basic.result:
        result update (default value is 400 in Summit)
      mysql-test/suite/sys_vars/t/innodb_file_per_table_basic.test:
        variable is writable in the plugin (patch from Oracle)
      mysql-test/suite/sys_vars/t/innodb_lock_wait_timeout_basic.test:
        variable is per-session in the plugin (patch from Oracle)
      mysql-test/t/information_schema.test:
        making I_S queries ignore InnoDB I_S tables
      mysql-test/t/information_schema_db.test:
        making I_S queries ignore InnoDB I_S tables
      mysql-test/t/innodb-autoinc.test:
        importing piece from storage/innodb_plugin/mysql-test/innodb-autoinc.test
      mysql-test/t/innodb.test:
        importing most of storage/innodb_plugin/t/innodb.test. Most replace_result were not needed (no path printed), some where (for --embedded).
      mysql-test/t/mysqlshow.test:
        output of test now depends on InnoDB or not InnoDB. As there is no way to make mysqlshow
        produce a single output in those two cases (no way to make it exclude InnoDB I_S
        tables), let the test depend on InnoDB, it isn't a very selective condition, and the
        test is simple enough.
      storage/innobase/CMakeLists.txt:
        thanks Vlad for the noticing () vs {}
      60dead9c
    • Guilhem Bichot's avatar
      Renamed storage/innodb_plugin to storage/innobase, so that 1) it's the same · 7f2dd157
      Guilhem Bichot authored
      layout as we always had in trees containing only the builtin
      2) win\configure.js WITH_INNOBASE_STORAGE_ENGINE still works.
      
      storage/innobase/CMakeLists.txt:
        fix to new directory name (and like 5.1)
      storage/innobase/Makefile.am:
        fix to new directory name (and like 5.1)
      storage/innobase/handler/ha_innodb.cc:
        fix to new directory name (and like 5.1)
      storage/innobase/plug.in:
        fix to new directory name (and like 5.1)
      7f2dd157
  6. 30 Jul, 2009 1 commit
  7. 10 Jun, 2009 1 commit
    • Vladislav Vaintroub's avatar
      Backport WL#3653 to 5.1 to enable bundled innodb plugin. · dd86e2cd
      Vladislav Vaintroub authored
      Remove custom DLL loader code from innodb plugin code, use 
      symbols exported from mysqld.
      
      
      storage/innodb_plugin/handler/ha_innodb.cc:
        Remove a Win32 workaround for current_thd.
        The original  problem that innodb plugin used
        value of TLS variable across DLL boundaries is 
        solved in MySQL server (current_thd is a function
        not TLS variable now)
      storage/innodb_plugin/handler/handler0alter.cc:
        Remove custom delay loader
      storage/innodb_plugin/handler/handler0vars.h:
        Remove custom delay loader
      storage/innodb_plugin/handler/i_s.cc:
        Remove custom delay loader
      storage/innodb_plugin/handler/win_delay_loader.cc:
        Remove custom delay loader
      storage/innodb_plugin/plug.in:
        Remove commented out MYSQL_PLUGIN_STATIC, 
        CMake would not parse that correctly
      dd86e2cd
  8. 27 May, 2009 1 commit