1. 24 Aug, 2004 4 commits
    • unknown's avatar
      Fixed UNION support in view creation (BUG#4664) · 964955b1
      unknown authored
      
      mysql-test/r/view.result:
        added removing of table t2
        test of view built over union
      mysql-test/t/view.test:
        added removing of table t2
        test of view built over union
      sql/sql_view.cc:
        Fixed UNION support in view creation
      964955b1
    • unknown's avatar
      items for functions which is converted to constants internally to support its... · c688b7b8
      unknown authored
      items for functions which is converted to constants internally to support its correct printing added (BUG#4663)
      
      
      mysql-test/r/view.result:
        test of functions in VIEW which is converted to constants internally
      mysql-test/t/view.test:
        test of functions in VIEW which is converted to constants internally
      sql/item.h:
        items for functions which is converted to constants internally to support its correct printing
      sql/item_create.cc:
        items for functions which is converted to constants internally to support its correct printing
      c688b7b8
    • unknown's avatar
      sending right error message where VIEW is not expected (BUG#4606) · 46a0c8a7
      unknown authored
      
      mysql-test/r/view.result:
        using VIEW where table is required
      mysql-test/t/view.test:
        using VIEW where table is required
      sql/sql_base.cc:
        sending right error message where VIEW is not expected
      sql/sql_view.h:
        frm_type_enum moved to table.h becuae used in TABLE_LIST
      sql/table.h:
        frm_type_enum moved to table.h becuae used in TABLE_LIST
      46a0c8a7
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 2f16033f
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-5.0
      
      
      2f16033f
  2. 23 Aug, 2004 3 commits
    • unknown's avatar
      innodb.result, innodb.test: · 07a1c31a
      unknown authored
        Fix mysql-test failure in the 5.0 tree on Aug 23: label seems to be a reserved word in 5.0, and we to use it a s a column name we must but it inside backticks
      
      
      mysql-test/t/innodb.test:
        Fix mysql-test failure in the 5.0 tree on Aug 23: label seems to be a reserved word in 5.0, and we to use it a s a column name we must but it inside backticks
      mysql-test/r/innodb.result:
        Fix mysql-test failure in the 5.0 tree on Aug 23: label seems to be a reserved word in 5.0, and we to use it a s a column name we must but it inside backticks
      07a1c31a
    • unknown's avatar
      fixed LIMIT clause printing (BUG#4839) · 248d7108
      unknown authored
      
      mysql-test/r/view.result:
        EXISTS with UNION VIEW creation test
      mysql-test/t/view.test:
        EXISTS with UNION VIEW creation test
      sql/sql_lex.cc:
        fixed LIMIT clause printing
      248d7108
    • unknown's avatar
      fixed error processing of prepare in VIEW creation (BUG#4801) · 9ca63e55
      unknown authored
      
      mysql-test/r/view.result:
        test of error processing found in preparation phase
      mysql-test/t/view.test:
        test of error processing found in preparation phase
      sql/sql_view.cc:
        fixed error processing of prepare
      9ca63e55
  3. 19 Aug, 2004 1 commit
  4. 17 Aug, 2004 2 commits
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · d90c1ae6
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0-merge
      
      
      d90c1ae6
    • unknown's avatar
      WL#2002: Implement stored procedure GOTO. · 9b5a6f72
      unknown authored
      Mostly done, it works, but the temporary LABEL syntax still to be fixed.
      
      
      mysql-test/r/sp-error.result:
        New test case for WL#2002 (GOTO).
      mysql-test/r/sp.result:
        New test case for WL#2002 (GOTO).
        (Also corrected another test)
      mysql-test/t/sp-error.test:
        New test case for WL#2002 (GOTO).
      mysql-test/t/sp.test:
        New test case for WL#2002 (GOTO).
        (Also corrected another test)
      sql/lex.h:
        New symbol GOTO.
        Also a temporary symbol LABEL, which hopefully will go away soon.
      sql/sp_head.cc:
        Fixed backpatching to cope with free GOTO labels an hpop and cpop instructions.
        Also optimized away pointless jump instructions.
      sql/sp_head.h:
        Fixed backpatching to cope with free GOTO labels an hpop and cpop instructions.
        We now sometimes generate hpop/cpop 0 instructions but the optimizer removes them.
      sql/sp_pcontext.cc:
        Added free GOTO labels, and support for coping with jumps out of blocks
        with handlers or cursors.
      sql/sp_pcontext.h:
        Added free GOTO labels, and support for coping with jumps out of blocks
        with handlers or cursors.
      sql/sql_yacc.yy:
        Added GOTO and LABEL, and adjusted backpatching accordingly. Also fixed LEAVE
        out of blocks. The LABEL syntax will go away soon, hopefully.
      9b5a6f72
  5. 16 Aug, 2004 4 commits
  6. 15 Aug, 2004 1 commit
  7. 13 Aug, 2004 4 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 603f0d96
      unknown authored
      into brandersnatch.localdomain:/home/dlenev/src/mysql-5.0
      
      
      603f0d96
    • unknown's avatar
      Made sp.test more repeatable. · 5e0f3401
      unknown authored
      5e0f3401
    • unknown's avatar
      join_nested.test, join_nested.result: · f0ac45bc
      unknown authored
        Added a case for bug #4976 when one of the inner tables is empty.
      select.result, join.result:
        Reversed the previous change of the erronious fix for bug #4976.
      sql_select.cc:
        The previous fix for bug 4976 was reversed as it
        erroniously converted an outer join into an innner join
        when on_expression does not refer to outer tables.
        This is not valid if inner tables return an empty set.
        Setting dependency on outer tables was added for the above cases.
        To fix the crash in the test case of bug #4976  
        a guard was added that blocks running the crashing code for
        nested outer joins.
      
      
      sql/sql_select.cc:
        The previous fix for bug 4976 was reversed as it
        erroniously converted an outer join into an innner join
        when on_expression does not refer to outer tables.
        This is not valid if inner tables return an empty set.
        Setting dependency on outer tables was added.
        The crash of the test case for bug #4976 was fixed
        adding a guard that blocks running the code for
        nested outer joins.
      mysql-test/r/join.result:
        Reversed the previous change of the erronious fix for bug #4976.
      mysql-test/r/select.result:
        Reversed the previous change of the erronious fix for bug #4976.
      mysql-test/r/join_nested.result:
        Added a case for bug #4976 when one of the inner tables is empty.
      mysql-test/t/join_nested.test:
        Added a case for bug #4976 when one of the inner tables is empty.
      f0ac45bc
    • unknown's avatar
      Fixed another bug#4984-type problem. This probably isn't the last fix for this bug. · 6ae4094a
      unknown authored
      
      sql/opt_range.cc:
        Fix for bug#4984
      6ae4094a
  8. 11 Aug, 2004 3 commits
    • unknown's avatar
      Fix and testcase for BUG#4984 · dde591f2
      unknown authored
       The crash is eliminated but still it is weird/inefficent that ROR-intersection is used when performing updates in empty table.
      
      
      mysql-test/r/index_merge_ror_cpk.result:
        Fix and testcase for BUG#4984
      mysql-test/t/index_merge_ror_cpk.test:
        Fix and testcase for BUG#4984
      sql/opt_range.cc:
        Don't call index_end() for CPK quick select inside of a ROR-intersection.
      sql/opt_range.h:
        Fix and testcase for BUG#4984
      dde591f2
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 4aa20acc
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-1
      
      
      4aa20acc
    • unknown's avatar
      join.result, select.result: · a2a94818
      unknown authored
        Fixed bug #4976.
      join_nested.result, join_nested.test:
        Added a test case for bug #4976.
      sql_select.cc:
        Applied conversion from an outer join to an inner join 
        when the on expression does not depend on the outer table.
        It fixed bug #4976.
      
      
      sql/sql_select.cc:
        Applied conversion from an outer join to an inner join 
        when the on expression does not depend on the outer table.
        It fixed bug #4976.
      mysql-test/t/join_nested.test:
        Added a case test for bug #4976.
      mysql-test/r/join_nested.result:
        Added a case test for bug #4976.
      mysql-test/r/select.result:
        Fixed bug #4976.
      mysql-test/r/join.result:
        Fixed bug #4976.
      a2a94818
  9. 10 Aug, 2004 2 commits
    • unknown's avatar
      view.result: · 3c016ef7
      unknown authored
        Update test results.
      
      
      mysql-test/r/view.result:
        Update test results.
      3c016ef7
    • unknown's avatar
      errmsg.txt: · de78ba87
      unknown authored
        fix error message
      
      
      sql/share/czech/errmsg.txt:
        fix error message
      sql/share/danish/errmsg.txt:
        fix error message
      sql/share/dutch/errmsg.txt:
        fix error message
      sql/share/english/errmsg.txt:
        fix error message
      sql/share/estonian/errmsg.txt:
        fix error message
      sql/share/french/errmsg.txt:
        fix error message
      sql/share/german/errmsg.txt:
        fix error message
      sql/share/greek/errmsg.txt:
        fix error message
      sql/share/hungarian/errmsg.txt:
        fix error message
      sql/share/italian/errmsg.txt:
        fix error message
      sql/share/japanese/errmsg.txt:
        fix error message
      sql/share/korean/errmsg.txt:
        fix error message
      sql/share/norwegian-ny/errmsg.txt:
        fix error message
      sql/share/norwegian/errmsg.txt:
        fix error message
      sql/share/polish/errmsg.txt:
        fix error message
      sql/share/portuguese/errmsg.txt:
        fix error message
      sql/share/romanian/errmsg.txt:
        fix error message
      sql/share/serbian/errmsg.txt:
        fix error message
      sql/share/slovak/errmsg.txt:
        fix error message
      sql/share/spanish/errmsg.txt:
        fix error message
      sql/share/swedish/errmsg.txt:
        fix error message
      de78ba87
  10. 09 Aug, 2004 1 commit
    • unknown's avatar
      mysqld.cc: · e077f175
      unknown authored
        Typos/grammar.
      
      
      sql/mysqld.cc:
        Typos/grammar.
      e077f175
  11. 06 Aug, 2004 6 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 578b0f57
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-1
      
      
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      578b0f57
    • unknown's avatar
      join_nested.result, join_nested.test: · 3478d656
      unknown authored
        Added a test case for bug #4922.
      sql_select.cc:
        Blocked an optimization performed by join_read_const_table when
        applied to an inner table of a nested outer join.
        It was done to fix bug #4922.
      sql_yacc.yy:
        Fixed a typo bug in the rule for join_table.
      
      
      sql/sql_yacc.yy:
        Fixed a typo bug in the rule for join_table.
      sql/sql_select.cc:
        Blocked an optimization performed by join_read_const_table when
        applied to an inner table of a nested outer join.
        It was done to fix bug #4922.
      mysql-test/t/join_nested.test:
        Added a test case for bug #4922.
      mysql-test/r/join_nested.result:
        Added a test case for bug #4922.
      3478d656
    • unknown's avatar
      Fixed BUG#4934: Caching issue with stored procedures. · 98f85188
      unknown authored
        ...and added new test file, sp-threads, for multiple connection tests
        (apart from the security tests that are in sp-security).
      
      
      sql/sp.cc:
        When removing an SP, invalidate the caches even if the
        removing thread doesn't have one.
      98f85188
    • unknown's avatar
      Removed an SP test case that's not repeatable over different builds/platforms. · 8602f545
      unknown authored
      
      mysql-test/r/sp.result:
        Removed a test case that's not repeatable over different builds/platforms.
      mysql-test/t/sp.test:
        Removed a test case that's not repeatable over different builds/platforms.
      8602f545
    • unknown's avatar
      Fixed BUG#4904: Stored procedure crash if continue handler for HY000 errors. · ba7c7439
      unknown authored
        The description is not entirerly correct. The issue was follow-up errors
        where the first error is not caught - in which case it's often a system
        error with errcode < 1000 (which are mapped by default to 'HY000'). In this
        case the error state is different from what was assumed in the execution
        loop.
      
      
      mysql-test/r/sp.result:
        New test case for BUG#4902.
      mysql-test/t/sp.test:
        New test case for BUG#4902.
      sql/sp_head.cc:
        Don't test the net.report_error flag in the execution loop. (Don't know
        why this was done in the first place, as it seems to serve no purpose.)
      ba7c7439
    • unknown's avatar
      Fixed BUG#4902: Stored procedure with SHOW WARNINGS leads to packet error, · 177ef90b
      unknown authored
        and tried to do it properly this time, digging out all show commands that
        need the multi results flag set.
      
      
      mysql-test/r/sp.result:
        New test case for BUG#4902, with lots of other show commands as well.
      mysql-test/t/sp.test:
        New test case for BUG#4902, with lots of other show commands as well.
      sql/sp_head.cc:
        The check for possible multiple result commands was becomming unwieldly,
        so we moved it to a separate function, and added loads of new command codes
        to the test.
      sql/sp_head.h:
        The check for possible multiple result commands was becomming unwieldly,
        so we moved it to a separate function.
      sql/sql_yacc.yy:
        The check for possible multiple result commands was becomming unwieldly,
        so we moved it to a separate function.
      177ef90b
  12. 04 Aug, 2004 2 commits
  13. 03 Aug, 2004 6 commits
    • unknown's avatar
      Followup3: operator new and operator delete are defined in mysys. · bd5c6aca
      unknown authored
      The fix makes client_test.cc compile with embedded library.
      
      
      bd5c6aca
    • unknown's avatar
      Followup2 (new commands are supported in prepared statements): test files · cb4b2257
      unknown authored
      should've been fixed as well.
      
      
      mysql-test/include/ps_modify.inc:
        Followup2 (new commands are supported in prepared statements):
        - no more error is expected here
      mysql-test/t/ps_1general.test:
        Followup2 (new commands are supported in prepared statements): 
        - no more error expected here
      cb4b2257
    • unknown's avatar
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · a5debaea
      unknown authored
      into mysql.com:/home/kostja/mysql/mysql-5.0-sap-new
      
      
      sql/sp.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      a5debaea
    • unknown's avatar
      Port of cursors to be pushed into 5.0 tree: · eaf34dd8
      unknown authored
      - client side part is simple and may be considered stable
      - server side part now just joggles with THD state to save execution
        state and has no additional locking wisdom.
        Lot's of it are to be rewritten.
      
      
      include/mysql.h:
        Cursor patch to push into the main tree, client library part (considered 
        stable):
        - new statement attribute STMT_ATTR_CURSOR_TYPE
        - MYSQL_STMT::flags to store statement cursor type
        - MYSQL_STMT::server_status to store server status (i. e. if the server
        was able to open a cursor for this query).
      include/mysql_com.h:
        Cursor patch to push into the main tree, client library part (considered 
        stable):
        - new COMmand, COM_FETCH, to fetch K rows from read-only cursor.
          By design should support scrollable cursors as well.
        - a few new server statuses:
          SERVER_STATUS_CURSOR_EXISTS is sent by server in reply to COM_EXECUTE,
          when cursor was successfully opened for this query
          SERVER_STATUS_LAST_ROW_SENT is sent along with the last row to prevent one
          more round trip just for finding out that all rows were fetched from 
          this cursor (this is server mem savier also).
        - and finally, all possible values of STMT_ATTR_CURSOR_TYPE, 
          while now we support only CURSORT_TYPE_NO_CURSOR and 
          CURSOR_TYPE_READ_ONLY
      libmysql/libmysql.c:
        Cursor patch to push into the main tree, client library part (considered 
        stable):
        - simple additions to mysql_stmt_fetch implementation to read data 
          from an opened cursor: we can read up to iteration count rows per
          one request; read rows are buffered in the same way as rows of
          mysql_stmt_store_result.
        - now send stmt->flags to server to let him now if we wish to have 
          a cursor for this statement.
        - support for setting/getting statement cursor type.
      libmysqld/examples/Makefile.am:
        Testing cursors was originally implemented in C++. Now when these tests
        go into client_test, it's time to convert it to C++ as well.
      libmysqld/lib_sql.cc:
        - cleanup: send_fields flags are now named.
      sql/ha_innodb.cc:
        - cleanup: send_fields flags are now named.
      sql/mysql_priv.h:
        - cursors support: declaration for server-side handler of COM_FETCH
      sql/protocol.cc:
        - cleanup: send_fields flags are now named.
        - we can't anymore assert that field_types[field_pos] is sensible:
          if we have COM_EXCUTE(stmt1), COM_EXECUTE(stmt2), COM_FETCH(stmt1)
          field_types[field_pos] will point to fields of stmt2.
      sql/protocol.h:
        - cleanup: send_fields flag_s_ are now named.
      sql/protocol_cursor.cc:
        - cleanup: send_fields flags are now named.
      sql/repl_failsafe.cc:
        - cleanup: send_fields flags are now named.
      sql/slave.cc:
        - cleanup: send_fields flags are now named.
      sql/sp.cc:
        - cleanup: send_fields flags are now named.
      sql/sp_head.cc:
        - cleanup: send_fields flags are now named.
      sql/sql_acl.cc:
        - cleanup: send_fields flags are now named.
      sql/sql_class.cc:
        - cleanup: send_fields flags are now named.
      sql/sql_class.h:
        - cleanup: send_fields flags are now named.
      sql/sql_error.cc:
        - cleanup: send_fields flags are now named.
      sql/sql_handler.cc:
        - cleanup: send_fields flags are now named.
      sql/sql_help.cc:
        - cleanup: send_fields flags are now named.
      sql/sql_parse.cc:
        Server side support for cursors:
        - handle COM_FETCH
        - enforce assumption that whenever we free thd->free_list, 
          we reset it to zero. This way it's much easier to handle free_list
          in prepared statements implementation.
      sql/sql_prepare.cc:
        Server side support for cursors:
        - implementation of mysql_stmt_fetch (fetch some rows from open cursor).
        - management of cursors memory is quite tricky now.
        - execute_stmt can't be reused anymore in mysql_stmt_execute and 
          mysql_sql_stmt_execute
      sql/sql_repl.cc:
        - cleanup: send_fields flags are now named.
      sql/sql_select.cc:
        Server side support for cursors:
        - implementation of Cursor::open, Cursor::fetch (buggy when it comes to
          non-equi joins), cursor cleanups.
        - -4 -3 -0 constants indicating return value of sub_select and end_send are
          to be renamed to something more readable:
          it turned out to be not so simple, so it should come with the other patch.
      sql/sql_select.h:
        Server side support for cursors:
        - declaration of Cursor class.
        - JOIN::fetch_limit contains runtime value of rows fetched via cursor.
      sql/sql_show.cc:
        - cleanup: send_fields flags are now named.
      sql/sql_table.cc:
        - cleanup: send_fields flags are now named.
      sql/sql_union.cc:
        - if there was a cursor, don't cleanup unit: we'll need it to fetch
          the rest of the rows.
      tests/Makefile.am:
        Now client_test is in C++.
      tests/client_test.cc:
        A few elementary tests for cursors.
      BitKeeper/etc/ignore:
        Added libmysqld/examples/client_test.cc to the ignore list
      eaf34dd8
    • unknown's avatar
      - bumped up version number in configure.in to 5.0.2-alpha, now that · efec1293
      unknown authored
         5.0.1 is out
       - tagged ChangeSet@1.1698 as "mysql-5.0.1"
      
      
      configure.in:
         - bumped up version number in configure.in to 5.0.2-alpha, now that
           5.0.1 is out
      efec1293
  14. 02 Aug, 2004 1 commit
    • unknown's avatar
      WL#2001: Optimize stored procedure code. · 81aad353
      unknown authored
      Added a simple optimizer that shortcuts jumps and skip unused instructions.
      
      
      sql/sp.cc:
        Optimize the code after parsing.
      sql/sp_head.cc:
        Added a simple optimizer that shortcuts jumps and skip unused instructions.
      sql/sp_head.h:
        Added a simple optimizer that shortcuts jumps and skip unused instructions.
      81aad353