1. 05 Apr, 2024 11 commits
  2. 04 Apr, 2024 1 commit
    • sjaakola's avatar
      MDEV-33749 hyphen in table name can cause galera certification failures · 2fcf2ec2
      sjaakola authored
      Fix in this commit handles foreign key value appending into write set
      so that db and table names are converted from the filepath format
      to tablename format. This is compatible with key values appended from
      elsewhere in the code base
      
      There is a mtr test galera.galera_table_with_hyphen for regression testing
      
      Reviewer: monty@mariadb.com
      2fcf2ec2
  3. 02 Apr, 2024 1 commit
  4. 29 Mar, 2024 1 commit
    • Alexander Barkov's avatar
      MDEV-33788 HEX(COLUMN_CREATE(.. AS CHAR ...)) fails with --view-protocol · 29bb321f
      Alexander Barkov authored
      Item_func_dyncol_create::print_arguments() printed only CHARSET clause
      without COLLATE.
      
      Therefore,
      
      HEX(column_create(1,'1212' AS CHAR CHARACTER SET utf8mb3 COLLATE utf8mb3_bin))
      
      inside a VIEW changed to just:
      
      HEX(column_create(1,'1212' AS CHAR CHARACTER SET utf8mb3))
      
      which changed the collation ID seen in the HEX output.
      
      Note, the collation ID inside column_create() is not really much important.
      (It's only important what the character set is).
      And for COLLATE, the more important thing is what's later written
      in the AS clause of COLUMN_GET:
      
      SELECT
         COLUMN_GET(
          column_create(1,'1212' AS CHAR CHARACTER SET utf8mb3 COLLATE utf8mb3_bin)
          column_nr AS type  -- this type is more important
         );
      
      Still, let's add the COLLATE clause into the COLUMN_CREATE() print output,
      although it's not important for now for anything else than just the HEX output.
      At least to make VIEW work in a more predictable way with HEX(COLUMN_CREATE()).
      
      Also, in the future we can start using somehow the collation ID written inside
      COLUMN_CREATE(), for example by making the `AS type` clause optional in
      COLUMN_GET():
        COLUMN_GET(dyncol_blob, column_nr [AS type]);
      instead of:
        COLUMN_GET(dyncol_blob, column_nr AS type);
      
      SQL Server compatibility layer may need this for
      the SQL_Variant data type support.
      29bb321f
  5. 28 Mar, 2024 3 commits
    • Dmitry Shulga's avatar
      MDEV-33768: Memory leak found in the test main.constraints run with... · e1876e7f
      Dmitry Shulga authored
      MDEV-33768: Memory leak found in the test main.constraints run with --ps-protocol against a server built with the option -DWITH_PROTECT_STATEMENT_MEMROOT
      
      The discovered memory leak was introduced by the commit
        762bf7a0
          (MDEV-22602 Disable UPDATE CASCADE for SQL constraints)
      
      The reason why a memory leaked on running the test main.constraints
      is that a statement arena was used for allocation a memory
      for storing a constraint name. A constraint name is an entity having
      temporary nature by its design so runtime arena should be used for its
      allocation.
      e1876e7f
    • Dmitry Shulga's avatar
      MDEV-33767: Memory leaks found in some tests run with --ps-protocol against a... · f44e41db
      Dmitry Shulga authored
      MDEV-33767: Memory leaks found in some tests run with --ps-protocol against a server built with the option -DWITH_PROTECT_STATEMENT_MEMROOT
      
      Found memory leaks were introduced by the commit
        a896bebf
        MDEV-18844 Implement EXCEPT ALL and INTERSECT ALL operations
      and caused by using a statement arena instead a runtime arena for
      allocation of objects having temporary life span by their nature.
      Aforementioned memory leaks were produced by running queries
      that typically use select with intersect, union or table values
      constructors.
      
      To fix these memory leaks use the runtime arena for allocation
      of Item_field objects used by set operations.
      
      Additionally, OOM handling added on allocation of aforementioned
      Item_field objects.
      f44e41db
    • Daniel Black's avatar
      MDEV-33044 Loading time zones does not work with alter_algorithm INPLACE (postfix) · 9f1019ba
      Daniel Black authored
      Test case doesn't work on embedded builds.
      9f1019ba
  6. 27 Mar, 2024 17 commits
  7. 25 Mar, 2024 2 commits
  8. 22 Mar, 2024 2 commits
  9. 19 Mar, 2024 1 commit
  10. 18 Mar, 2024 1 commit