- 16 Mar, 2020 5 commits
-
-
Vladislav Vaintroub authored
It did not work, eventhough the default for Windows was changed to 1 for the corresponding system variable. This be because test_flags was zeroed mysql_init_variables. The patch fixes this glitch.
-
Marko Mäkelä authored
mi_records_in_range(): Because HA_POS_ERROR cannot be accurately represented in double (it will be off by one), add an explicit cast to silence the warning.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 14 Mar, 2020 1 commit
-
-
Sergei Golubchik authored
-
- 13 Mar, 2020 10 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
myrg_open(): Reduce the scope of the variable 'end' and simplify the code. For some reason, I got no warning for this code in the 10.2 branch, only 10.3 or later. The ENGINE=MERGE is covered by the tests main.merge, main.merge_debug, and main.merge-big.
-
Sujatha authored
Problem: ======= When we upgrade from "mysql" to "mariadb" if slave is using repositories as tables their data is completely ignored and no warning is issued in error log. Fix: === "mysql_upgrade" test should check for the presence of data in "mysql.slave_master_info" and "mysql.slave_relay_log_info" tables. When tables have some data the upgrade script should report a warning which hints users that the data in repository tables will be ignored.
-
Marko Mäkelä authored
_ma_fetch_keypage(): Correct an assertion that used to always hold. Thanks to clang -Wint-in-bool-context for flagging this. double_to_datetime_with_warn(): Suppress -Wimplicit-int-float-conversion by adding a cast. LONGLONG_MAX converted to double will actually be LONGLONG_MAX+1.
-
Marko Mäkelä authored
All tablespace metadata is buffered in fil_system. There is a LRU mechanism, but that only controls the opening and closing of fil_node_t::handle. It is much more efficient and less error-prone to access data file names by looking up the fil_space_t object rather than by essentially joining each row with an access to SYS_DATAFILES via the InnoDB internal SQL parser. dict_get_first_path(): Declare static. The function may only be needed when loading or updating the data dictionary. Also, change a condition in order to avoid a bogus GCC 10 -Wstringop-overflow warning for mem_strdupl() about len==ULINT_UNDEFINED. i_s_sys_tablespaces_fill_table(): Do not access other InnoDB internal dictionary tables than SYS_TABLESPACES.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
This fixes GCC 10.0.1 -Wstringop-truncation and some typos.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 12 Mar, 2020 2 commits
-
-
Eugene Kosov authored
-
Jan Lindström authored
-
- 11 Mar, 2020 10 commits
-
-
Monty authored
-
Eugene Kosov authored
actually, page_zip_verify_checksum() generally allows all-zeroes checksums because our CRC32 checksum is something like crc_1 ^ crc_2 ^ crc_3 Also, all zeroes page is considered correct. As a side effect fix nasty reinterpret_cast<> UB Also, since c0f47a4a innodb_checksum_algorithm=full_crc32 exists which computes CRC32 in one go (without bitwise arithmetic)
-
Oleksandr Byelkin authored
-
Eugene Kosov authored
-
Oleksandr Byelkin authored
-
Marko Mäkelä authored
Also, remove some trailing white space and add missing static qualifier to free_annotate_event().
-
Oleksandr Byelkin authored
-
Sergei Petrunia authored
It was: implicit conversion from 'ha_rows' (aka 'unsigned long long') to 'double' changes value from 18446744073709551615 to 18446744073709551616 Follow what JOIN::get_examined_rows() does for similar code.
-
Jan Lindström authored
-
Aleksey Midenkov authored
Parser: uninitialized Lex->create_last_non_select_table under mysql_unpack_partition() fix. Tested with main, parts suites.
-
- 10 Mar, 2020 5 commits
-
-
Marko Mäkelä authored
-
Eugene Kosov authored
-
Marko Mäkelä authored
Re-enable main.mysql_client_test on all builders, because at the moment we do not run any --big-test on buildbot due to resource constraints. A number of tests were declared big in commit eeee1832 in an attempt to save resources on buildbot.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 09 Mar, 2020 6 commits
-
-
Monty authored
-
Monty authored
The default keyread_time() was optimized for blocks and not suitable for HEAP. The effect was the HEAP prefered table scans over ranges for btree indexes. Fixed also get_sweep_read_cost() for HEAP tables.
-
Monty authored
- Move testing of my_writer to inline functions to avoid calls - Made more functions inline. Especially thd->thread_started() is now very optimized! - Moved Opt_trace_stmt classe to opt_trace_context.h to get critical functions inline
-
Monty authored
- Added unlikely() to optimize for not having optimizer trace enabled - Made THD::trace_started() inline - Added 'if (trace_enabled())' around some potentially expensive code (not many found) - Added ASSERT's to ensure we don't call expensive optimizer trace calls if optimizer trace is not enabled - Added length to Json_writer functions to speed up buffer writes when optimizer trace is enabled. - Changed LEX_CSTRING argument handling to not send full struct to writer function on_add_str() functions now trusts length arguments
-
Marko Mäkelä authored
Stop masking the Data_free values, because innodb_file_per_table=1 is the default. Also, do mask Update_time after updating tables, even though for some reason it does appear to matter.
-
Jan Lindström authored
Change events only on Galera environment where idea is that event is enabled only on one node of the cluster and nodes are identified by server_id.
-
- 08 Mar, 2020 1 commit
-
-
Vicențiu Ciorbaru authored
-