1. 21 Aug, 2007 3 commits
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug30269/my51-bug30269 · 982b2195
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      982b2195
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug30269/my50-bug30269 · 68560de6
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug30269/my51-bug30269
      
      
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      68560de6
    • unknown's avatar
      Bug#30269 Query cache eats memory · a5423e18
      unknown authored
      Although the query cache doesn't support retrieval of statements containing
      column level access control, it was still possible to cache such statements
      thus wasting memory.
        
      This patch extends the access control check on the target tables to avoid
      caching a statement with column level restrictions. 
      
      Views are excepted and can be cached but only retrieved by super user account.
      
      
      mysql-test/t/query_cache_with_views.test:
        Rename: mysql-test/t/view_query_cache.test -> mysql-test/t/query_cache_with_views.test
      mysql-test/r/query_cache_with_views.result:
        Rename: mysql-test/r/view_query_cache.result -> mysql-test/r/query_cache_with_views.result
      mysql-test/r/query_cache.result:
        Modified test case to allow caching of views
      mysql-test/t/query_cache.test:
        Modified test case to allow caching of views
      sql/sql_cache.cc:
        Allow caching of views
      a5423e18
  2. 17 Aug, 2007 5 commits
    • unknown's avatar
      Merge kpettersson@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · d1a11a8c
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      d1a11a8c
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug30269/my51-bug30269 · fd8b2c93
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_cache.h:
        Auto merged
      fd8b2c93
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug30269/my50-bug30269 · 392f5589
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug30269/my51-bug30269
      
      
      mysql-test/r/query_cache.result:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_cache.h:
        Auto merged
      mysql-test/t/query_cache.test:
        Manual merge
      392f5589
    • unknown's avatar
      Bug #30269 Query cache eats memory · 28233c1f
      unknown authored
      Although the query cache doesn't support retrieval of statements containing
      column level access control, it was still possible to cache such statements
      thus wasting memory.
      
      This patch extends the access control check on the target tables to avoid
      caching a statement with column level restrictions. 
      
      
      mysql-test/r/query_cache.result:
        Added test
      mysql-test/t/query_cache.test:
        Added test
      sql/sql_cache.cc:
        The function check_table_access leaves the artifact
        grant.want_privileges= 1, if a statement refers to tables with column level
        privileges. To avoid the statement from being stored into the query cache,
        it is enough to check this flag and set 'safe_to_cache_query' to zero.
      sql/sql_cache.h:
        - Removed 'static' attribute or class methods
        - Added THD parameter to process_and_count_tables
      28233c1f
    • unknown's avatar
      Bug#25856 (HANDLER table OPEN in one connection lock DROP TABLE in another one) · f0c26a97
      unknown authored
      mysql_ha_open calls mysql_ha_close on the error path (unsupported) to close the (opened) table before inserting it into the tables hash list handler_tables_hash) but mysql_ha_close only closes tables which are on the hash list, causing the table to be left open and locked.
      
      This change moves the table close logic into a separate function that is always called on the error path of mysql_ha_open or on a normal handler close (mysql_ha_close).
      
      
      mysql-test/r/lock_multi.result:
        Bug#25856 test result
      mysql-test/t/lock_multi.test:
        Bug#25856 test case
      sql/sql_handler.cc:
        Move the table close logic into a separate function that is always called on the error path of mysql_ha_open or on a normal handler close.
      f0c26a97
  3. 16 Aug, 2007 5 commits
  4. 15 Aug, 2007 6 commits
    • unknown's avatar
      Add replication group (comments). · 4e39f736
      unknown authored
      4e39f736
    • unknown's avatar
      Provide initial module structure to Doxygen. · a0305d90
      unknown authored
      
      sql/event_data_objects.cc:
        Add module comments.
      sql/event_data_objects.h:
        Add module comments.
      sql/event_db_repository.cc:
        Add module comments.
      sql/event_db_repository.h:
        Add module comments.
      sql/event_queue.cc:
        Add module comments.
      sql/event_queue.h:
        Add module comments.
      sql/event_scheduler.cc:
        Add module comments.
      sql/event_scheduler.h:
        Add module comments.
      sql/events.cc:
        Add module comments.
      sql/events.h:
        Add module comments.
      sql/lock.cc:
        Add module comments.
      sql/sp_head.h:
        Add module comments.
      sql/sql_base.cc:
        Add module comments.
      sql/sql_lex.h:
        Add module comments.
      sql/sql_parse.cc:
        Add module comments.
      sql/sql_select.cc:
        Add module comments.
      sql/sql_yacc.yy:
        Add module comments.
      a0305d90
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 4a081468
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      4a081468
    • unknown's avatar
      Fix doxygen warnings. · 58b1146d
      unknown authored
      
      client/mysqldump.c:
        Fix doxygen warnings
      mysys/test_charset.c:
        Fix doxygen warnings
      sql/event_db_repository.cc:
        Fix doxygen warnings
      sql/events.cc:
        Fix doxygen warnings
      sql/events.h:
        Fix doxygen warnings
      sql/item_create.cc:
        Fix doxygen warnings, style.
      sql/item_create.h:
        Fix coding style.
      sql/item_subselect.cc:
        Fix doxygen warnings
      sql/lock.cc:
        Fix doxygen warnings
      sql/sp.cc:
        Fix doxygen warnings
      sql/sp_head.h:
        Fix doxygen warnings
      sql/sql_analyse.cc:
        Fix doxygen warnings
      sql/sql_analyse.h:
        Fix doxygen warnings
      sql/sql_base.cc:
        Fix doxygen warnings
      sql/sql_db.cc:
        Fix doxygen warnings
      sql/sql_lex.cc:
        Fix doxygen warnings
      sql/sql_lex.h:
        Fix doxygen warnings
      sql/sql_parse.cc:
        Fix doxygen warnings
      sql/sql_plugin.cc:
        Fix doxygen warnings
      sql/sql_prepare.cc:
        Fix doxygen warnings
      sql/sql_show.cc:
        Fix doxygen warnings
      sql/sql_trigger.cc:
        Fix doxygen warnings
      sql/sql_update.cc:
        Fix doxygen warnings
      sql/table.h:
        Fix doxygen warnings
      58b1146d
    • unknown's avatar
      Merge malff@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 373dac37
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.1-cleanup
      
      373dac37
    • unknown's avatar
      2f96e98f
  5. 11 Aug, 2007 2 commits
    • unknown's avatar
      Merge bodhi.(none):/opt/local/work/mysql-5.1-target-5.1.22 · 47dc9aeb
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      47dc9aeb
    • unknown's avatar
      A fix for Bug#29049 lock_multi fails in rare case. · 1db30e13
      unknown authored
      The patch changes the test case only.
      The fix is to replace all 'sleep's with wait_condition. This makes
      the test deterministic and also ~300 times faster.
      
      
      mysql-test/r/lock_multi.result:
        Update result.
      mysql-test/t/lock_multi.test:
        A fix for Bug#29049 lock_multi fails in rare case.
        Replace all 'sleep's with wait_condition. This makes
        the test deterministic and also ~300 times faster.
      1db30e13
  6. 10 Aug, 2007 2 commits
  7. 09 Aug, 2007 1 commit
    • unknown's avatar
      Bug#25930 (CREATE TABLE x SELECT ... parses columns wrong when ran with · 40c3c0f4
      unknown authored
                 ANSI_QUOTES mode)
      
      This patch contains a test case only, showing that the bug has been fixed.
      
      The issue was related to parsing <"blah">, where the lexical analyser
      would not properly delimit the start and end of the token.
      
      Properly making the token boundaries has been fixed in sql_lex.cc
      with the patch for bug 25411 : see the Lex_input_stream class.
      
      
      mysql-test/r/parser.result:
        Test case for Bug#25930, which was fixed by Bug#25411
      mysql-test/t/parser.test:
        Test case for Bug#25930, which was fixed by Bug#25411
      40c3c0f4
  8. 08 Aug, 2007 5 commits
  9. 06 Aug, 2007 10 commits
  10. 05 Aug, 2007 1 commit