1. 27 Feb, 2008 1 commit
  2. 24 Feb, 2008 1 commit
  3. 22 Feb, 2008 1 commit
    • unknown's avatar
      BUG#13861 - START SLAVE UNTIL may stop 1 evnt too late if · f16fcb1a
      unknown authored
                  log-slave-updates and circul repl
      
      Slave SQL thread may execute one extra event when there are events
      skipped by slave I/O thread (e.g. originated by the same server).
      Whereas it was requested not to do so by the UNTIL condition.
      
      This happens because we compare with the end position of previously
      executed event. This is fine when there are no skipped by slave I/O
      thread events, as end position of previous event equals to start
      position of to be executed event. Otherwise this position equals to
      start position of skipped event.
      
      This is fixed by:
      - reading the event to be executed before checking if the until condition
        is satisfied.
      - comparing the start position of the event to be executed. Since we do
        not have the start position available, we compute it by subtracting
        event length from end position (which is available).
      - if there are no events on the event queue at the slave sql starting
        time, that meet until condition, we stop immediately, as in this
        case we do not want to wait for next event.
      
      
      mysql-test/r/rpl_dual_pos_advance.result:
        A test case for BUG#13861.
      mysql-test/t/rpl_dual_pos_advance.test:
        A test case for BUG#13861.
      sql/log_event.cc:
        Store length of event. This is needed for further calculation of
        the beginning of event.
      sql/slave.cc:
        Slave SQL thread may execute one extra event when there are events
        skipped by slave I/O thread (e.g. originated by the same server).
        Whereas it was requested not to do so by the UNTIL condition.
        
        This happens because we compare with the end position of previously
        executed event. This is fine when there are no skipped by slave I/O
        thread events, as end position of previous event equals to start
        position of to be executed event. Otherwise this position equals to
        start position of skipped event.
        
        This is fixed by:
        - reading the event to be executed before checking if the until condition
          is satisfied.
        - comparing the start position of the event to be executed. Since we do
          not have the start position available, we compute it by subtracting
          event length from end position (which is available).
        - if there are no events on the event queue at the slave sql starting
          time, that meet until condition, we stop immediately, as in this
          case we do not want to wait for next event.
      sql/slave.h:
        Added master_log_pos parametr to is_until_satisfied().
      mysql-test/t/rpl_dual_pos_advance-slave.opt:
        New BitKeeper file ``mysql-test/t/rpl_dual_pos_advance-slave.opt''
      f16fcb1a
  4. 21 Feb, 2008 1 commit
  5. 19 Feb, 2008 1 commit
    • unknown's avatar
      BUG#34289 - Incorrect NAME_CONST substitution in stored procedures · 4181bf0b
      unknown authored
                  breaks replication
      
      NAME_CONST() didn't replicate constant character set and collation
      correctly.
      
      With this fix NAME_CONST() inherits collation from the value argument.
      
      
      mysql-test/r/func_misc.result:
        A test case for BUG#34289.
      mysql-test/t/func_misc.test:
        A test case for BUG#34289.
      sql/item.cc:
        Inherit collation from value argument.
      4181bf0b
  6. 15 Feb, 2008 2 commits
  7. 14 Feb, 2008 4 commits
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · 266be9ab
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      266be9ab
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · f4d85e6d
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      f4d85e6d
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · 07a37f3b
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      07a37f3b
    • unknown's avatar
      BUG#33946 - Join on Federated tables with Unique index gives error 1430 · b0dde216
      unknown authored
                  from storage engine
      
      Federated may crash a server, return wrong result set, return
      "ERROR 1030 (HY000): Got error 1430 from storage engine" message
      when local (engine=federated) table has a key against nullable
      column.
      
      The problem was wrong implementation of function that creates
      WHERE clause for remote query from key.
      
      
      mysql-test/r/federated.result:
        A test case for BUG#33946.
      mysql-test/t/federated.test:
        A test case for BUG#33946.
      sql/ha_federated.cc:
        Fixed that federated adds " IS NULL " condition to a remote query,
        whereas "IS NOT NULL" requested by original query.
        
        Fixed that federated didn't check for end of key buffer, didn't
        setup key buffer pointer and remaining lenght of key buffer,
        didn't add " AND " between conditions in case original query
        has IS [NOT] NULL condition against nullable column.
        
        Fixed that federated wrongly shifts key buffer pointer by extra
        one byte when key part may be null (was: store_length + 1,
        now: store_length).
      b0dde216
  8. 12 Feb, 2008 2 commits
    • unknown's avatar
      Fix for bug #33758: Got query result when using ORDER BY ASC, but · 36a050d6
      unknown authored
      empty result when using DESC
      
      Problem: fetching MyISAM keys we copy a key block pointer to the end of the key buffer.
      However, we don't take into account the pointer length calculatig the buffer size,
      that may leads to memory overwriting and in turn to unpredictable results.
      
      Fix: increase key buffer size by length of the key block pointer.
      
      Note: no simple test case.
      
      
      myisam/mi_open.c:
        Fix for bug #33758: Got query result when using ORDER BY ASC, but 
        empty result when using DESC
          - increase possible maximum key length by size of the key block pointer,
            as it's copied into the key buffer in the get_key() MyISAM functions.
      36a050d6
    • unknown's avatar
      Merge poseidon.ndb.mysql.com:/home/tomas/mysql-5.0-rpl-merge · eb820aad
      unknown authored
      into  poseidon.ndb.mysql.com:/home/tomas/mysql-5.0-ndb-merge
      
      eb820aad
  9. 11 Feb, 2008 4 commits
  10. 08 Feb, 2008 2 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 955f1885
      unknown authored
      into  dipika.(none):/opt/local/work/mysql-5.0-runtime
      
      955f1885
    • unknown's avatar
      Bug#33798 prepared statements improperly handle large unsigned ints · cea021da
      unknown authored
      The unsignedness of large integer user variables was not being
      properly preserved when feeded to prepared statements. This was
      happening because the unsigned flags wasn't being updated when
      converting the user variable is converted to a parameter.
      
      The solution is to copy the unsigned flag when converting the
      user variable to a parameter and take the unsigned flag into
      account when converting the integer to a string.
      
      
      mysql-test/r/binlog.result:
        Add test case result for Bug#33798
      mysql-test/r/ps.result:
        Add test case result for Bug#33798
      mysql-test/t/binlog.test:
        Add test case for Bug#33798
      mysql-test/t/ps.test:
        Add test case for Bug#33798
      sql/item.cc:
        Take the unsigned flag into account when converting the
        user variable.
      cea021da
  11. 07 Feb, 2008 2 commits
  12. 06 Feb, 2008 4 commits
  13. 05 Feb, 2008 1 commit
    • unknown's avatar
      Bug #34305 show slave status handling segfaults when slave io is about · 89e828b4
      unknown authored
          to leave
      
      The artifact was caused by
      a flaw in concurrent accessing the slave's io thd by
      the io itself and a handling show slave status thread.
      Namely, show_master_info did not acquire mi->run_lock mutex that is
      specified for mi->io_thd member.
      
      Fixed with deploying the mutex locking and unlocking. The mutex is kept
      short time and without interleaving with mi->data_lock mutex.
      
      Todo: to report and fix an issue with 
          sys_var_slave_skip_counter::{methods} 
      seem to acquire incorrectly
           active_mi->rli.run_lock
      instead of the specified
           active_mi->rli.data_lock
      
      A test case is difficult to compose, so rpl_packet should continue serving
      as the indicator.
      
      
      sql/slave.cc:
        implementing a TODO left at 4.1 time:
        mending access to mi->io_thd with the specified mutex;
      sql/slave.h:
        adding a member name to the list of that run_lock guards.
      89e828b4
  14. 04 Feb, 2008 4 commits
    • unknown's avatar
      ndb - some warnings, debug errors · 69f41d63
      unknown authored
      
      ndb/src/common/debugger/SignalLoggerManager.cpp:
        some warnings, debug errors
      ndb/src/common/debugger/signaldata/ScanTab.cpp:
        some warnings, debug errors
      ndb/src/kernel/vm/pc.hpp:
        some warnings, debug errors
      69f41d63
    • unknown's avatar
      Updating result file. · 9c81e797
      unknown authored
      
      mysql-test/r/rpl_user.result:
        Result change.
      9c81e797
    • unknown's avatar
      Fixes to make rpl_user test pass in pushbuild. · 42b9a0f1
      unknown authored
      
      mysql-test/t/rpl_user.test:
        Removing redundant reset master and deleting users from master
        and slave without using binary log.
      42b9a0f1
    • unknown's avatar
      bug#34169 - fix pthread_t abuse · 066da030
      unknown authored
      
      ndb/src/ndbapi/Ndb.cpp:
        fix pthread_t abuse
      ndb/test/ndbapi/testOIBasic.cpp:
        fix pthread_t abuse
      066da030
  15. 01 Feb, 2008 6 commits
  16. 31 Jan, 2008 4 commits
    • unknown's avatar
      ndb - bug#34107 - ndb api test case · 48d88798
      unknown authored
      
      ndb/test/ndbapi/testInterpreter.cpp:
        bug#34107 testInterpreter test case
      ndb/test/run-test/daily-basic-tests.txt:
        bug#34107 testInterpreter test case
      48d88798
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0 · fc72d468
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl-merge
      
      
      include/my_sys.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      fc72d468
    • unknown's avatar
      BUG#22989 - START SLAVE causes Error on COM_REGISTER_SLAVE: 1105 · d857e163
      unknown authored
                  'Wrong parameters to functi
      
      START SLAVE reports vague error when it fails to register on master:
      "Wrong parameters to function register_slave".
      
      If master failed to register slave because of too long
      'report-host'/'report-user'/'report-password', return better error
      messages:
      "Failed to register slave: too long 'report-host'"
      "Failed to register slave: too long 'report-user'"
      "Failed to register slave; too long 'report-password'"
      
      No test case for this fix.
      
      
      sql/repl_failsafe.cc:
        Report descriptive error when master fails to register slave.
      d857e163
    • unknown's avatar
      Merge sama.ndb.mysql.com:/export/space/pekka/ndb/version/my50-ndb · 699acec1
      unknown authored
      into  sama.ndb.mysql.com:/export/space/pekka/ndb/version/my50-bug34107
      
      699acec1