1. 26 Mar, 2008 5 commits
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-ateam · 98daf3fe
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/federated.result:
        Auto merged
      mysql-test/t/federated.test:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      storage/federated/ha_federated.cc:
        Auto merged
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Manual merge
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        Manual merge
      98daf3fe
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · a68cb126
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/ctype_big5.result:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_gb2312.result:
        Auto merged
      mysql-test/r/ctype_gbk.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_ctype_cp932.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/slave.cc:
        Auto merged
      mysql-test/r/federated.result:
        Manual merge from 5.0
      mysql-test/t/federated.test:
        Manual merge from 5.0
      storage/federated/ha_federated.cc:
        Manual merge from 5.0
      a68cb126
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · 375fae43
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/ctype_big5.result:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_gb2312.result:
        Auto merged
      mysql-test/r/ctype_gbk.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_row_ctype_cp932.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_ctype_cp932.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/rpl_rli.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        SCCS merged
      375fae43
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · 768d675a
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      768d675a
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · 8f24dc76
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/ctype_big5.result:
        Auto merged
      mysql-test/r/ctype_cp932.result:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_gb2312.result:
        Auto merged
      mysql-test/r/ctype_gbk.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/slave.cc:
        Auto merged
      8f24dc76
  2. 25 Mar, 2008 6 commits
    • unknown's avatar
      Bug#35559 - plugin_load.test creates warnings · df6c8c43
      unknown authored
      plugin_load.test created lines in the warnings files and made
      pushbuild cells yellow. Some pushbuild systems are configured
      so that they don't build the ha_example plugin. Trying to load
      them creates error messages in the error log. These were copied
      to the warnings file.
      
      Fixed by ignoring expected error messages for non-existent
      ha_example.
      
      
      mysql-test/lib/mtr_report.pl:
        Bug#35559 - plugin_load.test creates warnings
        Ignore expected error messages for non-existent ha_example.
      df6c8c43
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG35509/mysql-5.0-engines · cbdd79b0
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG34768/mysql-5.1-engines
      
      
      mysql-test/t/federated.test:
        Auto merged
      storage/federated/ha_federated.cc:
        Use local.
      cbdd79b0
    • unknown's avatar
      Eliminating compiler warnings. · 0f075800
      unknown authored
      
      sql/set_var.h:
        Changing order of initializer list for sys_var class constructor to
        eliminate compiler warning.
      mysql-test/suite/binlog/combinations:
        New BitKeeper file ``mysql-test/suite/binlog/combinations''
      0f075800
    • unknown's avatar
      BUG#34789 - drop server/create server leaks memory ! · 417e051b
      unknown authored
      BUG#34790 - 'create server' doesn't handle out of memory scenario
                  well enough
      
      This is an addition to fixes for these bugs, which makes gcov
      happy.
      
      
      mysql-test/r/federated.result:
        CREATE SERVER is only tested by federated_server.test, which requires
        big-test option. Added dummy test case to make gcov happy.
      mysql-test/t/federated.test:
        CREATE SERVER is only tested by federated_server.test, which requires
        big-test option. Added dummy test case to make gcov happy.
      sql/sql_parse.cc:
        Make gcov happy.
      417e051b
    • unknown's avatar
      BUG#34768 - nondeterministic INSERT using LIMIT logged in stmt mode · e616870a
      unknown authored
                  if binlog_format=mixed
      
      Addition to fix for BUG#34768: fixed test case failures discovered
      by pushbuild.
      
      
      mysql-test/suite/binlog/r/binlog_stm_ps.result:
        Fixed binlog_stm_ps failure when binlog format is statement:
        - this test case makes sence only if binlog format is statement,
          thus execute it only in this mode;
        - added a warning that insert ... select ... limit is not safe
          to execute in statement mode.
      mysql-test/suite/binlog/t/binlog_stm_ps.test:
        Fixed binlog_stm_ps failure when binlog format is statement:
        - this test case makes sence only if binlog format is statement,
          thus execute it only in this mode;
        - added a warning that insert ... select ... limit is not safe
          to execute in statement mode.
      mysql-test/suite/rpl/t/rpl_optimize.test:
        rpl_optimize test may be executed in various binlog format modes.
        In statement mode delete ... limit issues a warning, in mixed and
        row modes it does not.
        
        Fixed a test case so it is still possible to execute it in all binlog
        format modes by ignoring delete ... limit warnings.
      mysql-test/suite/rpl/t/rpl_user_variables.test:
        rpl_user_variables test may be executed in various binlog format modes.
        In statement mode insert ... select ... limit issues a warning,
        in mixed and row modes it does not.
        
        Fixed a test case so it is still possible to execute it in all binlog
        format modes by ignoring insert ... select ... limit warnings.
      e616870a
    • unknown's avatar
      BUG#35509 - Federated leaks memory when connecting to · 62c8302b
      unknown authored
                  localhost/default port
      
      When creating federated table that points to unspecified host or
      localhost on unspecified port or port is 0, small memory leak occurs.
      
      This happens because we make a copy of unix socket path, which is
      never freed.
      
      With this fix we do not make a copy of unix socket path, instead
      share->socket points to MYSQL_UNIX_ADDR constant directly.
      
      This fix is covered by a test case for BUG34788.
      
      Affects 5.0 only.
      
      
      mysql-test/t/federated.test:
        A test case for BUG#35509.
      sql/ha_federated.cc:
        When creating federated table we call parse_url() to check if connect
        string is correct. parse_url() may make a copy of unix socket path if
        port is not specified or 0 and host is not specified or 'localhost'.
        This copy is never freed.
        
        As there is no need to make a copy of unix socket path, let
        share->socket point to MYSQL_UNIX_ADDR directly.
      62c8302b
  3. 21 Mar, 2008 4 commits
  4. 20 Mar, 2008 8 commits
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.1-engines · b04607d3
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG34768/mysql-5.1-engines
      
      
      sql/sql_insert.cc:
        Auto merged
      b04607d3
    • unknown's avatar
      BUG#34788 - malformed federated connection url is not handled · 6c599276
      unknown authored
                  correctly - crashes server !
      
      Creating federated table with connect string containing empty
      (zero-length) host name and port is evaluated as 0 (port is
      incorrect, omitted or 0) crashes server.
      
      This happens because federated calls strcmp() with NULL pointer.
      
      Fixed by avoiding strcmp() call if hostname is set to NULL.
      
      
      mysql-test/r/federated.result:
        A test case for BUG#34788.
      mysql-test/t/federated.test:
        A test case for BUG#34788.
      sql/ha_federated.cc:
        Fixed that parse_url() may call strcmp() with NULL pointer.
      6c599276
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-ateam · ec8e154e
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/partition_not_windows.result:
        Auto merged
      mysql-test/r/partition_symlink.result:
        Auto merged
      mysql-test/r/symlink.result:
        Auto merged
      mysql-test/suite/parts/r/partition_basic_innodb.result:
        Auto merged
      mysql-test/suite/parts/r/partition_basic_myisam.result:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/partition_info.cc:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/t/partition_symlink.test:
        Manual merge
      mysql-test/t/symlink.test:
        Manual merge
      sql/sql_parse.cc:
        Manual merge
      ec8e154e
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 56419e3a
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      configure.in:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      56419e3a
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · acb93f9d
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      acb93f9d
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-4.1-axmrg · f2715573
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      configure.in:
        Manual merge
      f2715573
    • unknown's avatar
      BUG#34789 - drop server/create server leaks memory ! · 9de6bbe9
      unknown authored
      When CREATE SERVER is issued, it allocates memory on memory root
      to store cached server structure. When DROP SERVER is issued,
      it doesn't release this memory, as it is impossible with the
      memory root.
      
      We use the same allocation strategy for plugins and acl. The problem
      here that there was no way (except for the server restart) to force
      'servers' code to release this memory.
      
      With this fix it is possible to release unused server cache memory
      by FLUSH PRIVILEGES.
      
      No test case for this fix.
      
      
      sql/sql_parse.cc:
        Reload servers table on FLUSH PRIVILEGES.
      sql/sql_servers.cc:
        Instead of just marking memory blocks as unused, release memory
        used by servers cache and initialize new memory root.
        
        This is needed for FLUSH PRIVILEGES to release unused memory
        blocks.
      9de6bbe9
    • unknown's avatar
      BUG#34790 - 'create server' doesn't handle out of memory scenario · e023ad1a
      unknown authored
                  well enough
      
      CREATE SERVER may cause server crash if there is not enough memory
      to execute this operation.
      
      Fixed that create_server() and prepare_server_struct_for_insert()
      didn't check return value of functions that allocate memory.
      
      As this is out of memory issue fix, not test case available.
      
      
      sql/sql_servers.cc:
        Fixed that create_server() and prepare_server_struct_for_insert()
        didn't check return value of functions that allocate memory.
      e023ad1a
  5. 18 Mar, 2008 3 commits
    • unknown's avatar
      BUG#34768 - nondeterministic INSERT using LIMIT logged in stmt mode if · 5d36e601
      unknown authored
                  binlog_format=mixed
      
      Statement-based replication of DELETE ... LIMIT, UPDATE ... LIMIT,
      INSERT ... SELECT ... LIMIT is not safe as order of rows is not
      defined.
      
      With this fix, we issue a warning that this statement is not safe to
      replicate in statement mode, or go to row-based mode in mixed mode.
      
      Note that we may consider a statement as safe if ORDER BY primary_key
      is present. However it may confuse users to see very similiar statements
      replicated differently.
      
      Note 2: regular UPDATE statement (w/o LIMIT) is unsafe as well, but
      this patch doesn't address this issue. See comment from Kristian
      posted 18 Mar 10:55.
      
      
      mysql-test/suite/binlog/r/binlog_stm_ps.result:
        Updated a test case according to fix for BUG#34768:
        INSERT ... SELECT ... LIMIT is now replicated in row mode.
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        A test case for BUG#34768.
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        A test case for BUG#34768.
      sql/sql_delete.cc:
        Statement-based replication of DELETE ... LIMIT is not safe as order of
        rows is not defined, so in mixed mode we go to row-based.
      sql/sql_insert.cc:
        Statement-based replication of INSERT ... SELECT ... LIMIT is not safe
        as order of rows is not defined, so in mixed mode we go to row-based.
      sql/sql_update.cc:
        Statement-based replication of UPDATE ... LIMIT is not safe as order of
        rows is not defined, so in mixed mode we go to row-based.
      5d36e601
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/cov/mysql-5.0-engines · 34be4016
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/cov/mysql-5.1-engines
      
      
      sql/log_event.cc:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      34be4016
    • unknown's avatar
      Make gcov happy. · bfd4b3ce
      unknown authored
      bfd4b3ce
  6. 17 Mar, 2008 4 commits
    • unknown's avatar
      Raise version number after cloning 4.1.24 · dcb028e1
      unknown authored
      dcb028e1
    • unknown's avatar
      Bug#35306: partition_basic_symlink test failures · 4827ddc2
      unknown authored
      Have changed the DATA/INDEX dir to not be a database dir.
      (and made some changes for better result files.)
      
      
      mysql-test/suite/parts/inc/partition_basic_symlink.inc:
        Bug#35306: partition_basic_symlink test failures
        
        after bug 32167 it is not allowed with DATA/INDEX DIR in any database
        directory.
        
        remade the inc-files to make better use of each other (less duplicate tests)
      mysql-test/suite/parts/inc/partition_directory.inc:
        Removed disable/enable_query_log for better result files
      mysql-test/suite/parts/inc/partition_layout_check1.inc:
        changed DATA/INDEX DIR
      mysql-test/suite/parts/inc/partition_layout_check2.inc:
        added check with_directories
      mysql-test/suite/parts/inc/partition_methods1.inc:
        Removed disable/enable_query_log for better result files
      mysql-test/suite/parts/inc/partition_methods2.inc:
        Removed disable/enable_query_log for better result files
        Added with_directories for testing of DATA/INDEX DIR
      mysql-test/suite/parts/r/partition_basic_innodb.result:
        Updated test result due to test case changes
      mysql-test/suite/parts/r/partition_basic_myisam.result:
        Updated test result due to test case changes
      mysql-test/suite/parts/r/partition_basic_symlink_innodb.result:
        Updated test result due to test case changes
      mysql-test/suite/parts/r/partition_basic_symlink_myisam.result:
        Updated test result due to test case changes
      mysql-test/suite/parts/t/disabled.def:
        Bug#35306: parts.partition_basic_symlink test failures
        Enable the test again since the have been fixed
      mysql-test/suite/parts/t/partition_basic_innodb.test:
        Added check for table files.
      mysql-test/suite/parts/t/partition_basic_myisam.test:
        removing dependency of symlink
        (test exists now in parts.partition_basic_symlink_myisam)
      mysql-test/suite/parts/t/partition_basic_symlink_innodb.test:
        Bug#35306: partition_basic_symlink test failures
        
        Removed old test (since DATA/INDEX DIRECTORY is not supported in InnoDB)
        and replaced it with a simple test that altering a partitioned innodb
        with DATA/INDEX DIR to MyISAM, would use the DATA/INDEX DIR.
      4827ddc2
    • unknown's avatar
      Bug#35305: partition_symlink test failures · fdabb761
      unknown authored
      Updated the test due to bug 32167
      
      Corrected spelling of error message
      
      
      mysql-test/r/partition_not_windows.result:
        Updated test result due to test case changes and corrected spelling error
      mysql-test/r/partition_symlink.result:
        Bug#35305: partition_symlink test failure
        
        Updated test result due to test case changes
      mysql-test/r/symlink.result:
        Updated test result due to test case changes and corrected spelling error
      mysql-test/t/disabled.def:
        Bug#35305: partition_symlink test failure
        
        Enable the test after it has been fixed
      mysql-test/t/partition_not_windows.test:
        Removed disable/enable_query_log for better result files
      mysql-test/t/partition_symlink.test:
        Bug#35305: partition_symlink test failure
        
        Changes due to bug 32167
      mysql-test/t/symlink.test:
        using replace_result instead of disable_query_log
      sql/partition_info.cc:
        corrected spelling
      sql/sql_parse.cc:
        corrected spelling
      fdabb761
    • unknown's avatar
      Valgrind warnings found after bug#32943 and after merge from -main · f09fc126
      unknown authored
      into -engines tree.
      
      hander::table_share was not updated after changing table->s.
      
      
      sql/ha_partition.cc:
        Valgrind warning after merge -main -> -engines, after bug#32943
        
        change_table_ptr can happen in a middle of
        alter table rename/drop/... partition
        
        the newly created partitions must get the updated table_share too.
      sql/sql_base.cc:
        Bug#32943 was missing a call to change_table_ptr, this was found by valgrind
        after a merge from -main to -engines.
      f09fc126
  7. 16 Mar, 2008 1 commit
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-ateam · e33a591a
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      configure.in:
        Auto merged
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/r/merge.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/r/partition.result:
        Auto merged
      mysql-test/r/partition_not_windows.result:
        Auto merged
      mysql-test/r/partition_symlink.result:
        Auto merged
      mysql-test/r/symlink.result:
        Auto merged
      mysql-test/suite/parts/inc/partition_basic.inc:
        Auto merged
      mysql-test/suite/parts/r/partition_basic_innodb.result:
        Auto merged
      mysql-test/suite/parts/r/partition_basic_myisam.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_row_create_table.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      mysql-test/t/merge.test:
        Auto merged
      mysql-test/t/partition.test:
        Auto merged
      mysql-test/t/symlink.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/partition_info.cc:
        Auto merged
      sql/partition_info.h:
        Auto merged
      sql/rpl_rli.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/myisammrg/ha_myisammrg.cc:
        Auto merged
      mysql-test/t/partition_symlink.test:
        Manual merge
      e33a591a
  8. 15 Mar, 2008 5 commits
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 69476af8
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      69476af8
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · e119b8c6
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      e119b8c6
    • unknown's avatar
      make pushbuild green · eef61457
      unknown authored
      
      mysql-test/t/disabled.def:
        make pushbuild green, entry added to wrong disabled.def file.
      eef61457
    • unknown's avatar
      make pushbuild green · fe227c80
      unknown authored
      fe227c80
    • unknown's avatar
      fix results after merge · 4a206fcd
      unknown authored
      
      mysql-test/r/partition_not_windows.result:
        fix results from merge
      mysql-test/t/disabled.def:
        disable test partition_symlink
      4a206fcd
  9. 14 Mar, 2008 4 commits