1. 19 Jul, 2007 1 commit
  2. 18 Jul, 2007 1 commit
    • unknown's avatar
      Bug#26909: Specified key was too long; max key length is 255 bytes \ · 8b8b430b
      unknown authored
      	when creating table
      
      Federated tables had an artificially low maximum of key length, 
      because the handler failed to implement a method to return it and 
      the default value is taked from the prototype handler.
      
      Now, implement that method and return the maximum possible key
      length, which is that of InnoDB.
      
      
      mysql-test/r/federated.result:
        Verify that unique keys may be longer than 255 characters.
      mysql-test/t/federated.test:
        Verify that unique keys may be longer than 255 characters.
      sql/ha_federated.h:
        Implement the virtual method that tells the max size of parts to 
        make a key.
        
        Backport the length defined in 5.1.
      8b8b430b
  3. 09 Jul, 2007 2 commits
  4. 05 Jul, 2007 2 commits
    • unknown's avatar
      Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored · 32c6341e
      unknown authored
      Problem: logging queries not using indexes we check a special flag which 
      is set only at the server startup and is not changing with a corresponding
      server variable together.
      
      Fix: check the variable value instead of the flag.
      
      
      
      mysql-test/r/show_check.result:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - test result.
      mysql-test/t/show_check.test:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - test case.
      sql/mysqld.cc:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - SPECIAL_LOG_QUERIES_NOT_USING_INDEXES is not used anymore.
      sql/sql_parse.cc:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - check opt_log_queries_not_using_indexes instead of 
            SPECIAL_LOG_QUERIES_NOT_USING_INDEXES flag.
      sql/unireg.h:
        Fix for bug #28808: log_queries_not_using_indexes variable dynamic change is ignored
          - SPECIAL_LOG_QUERIES_NOT_USING_INDEXES is not used anymore.
      32c6341e
    • unknown's avatar
      Fix for bug #29420: crash with show and purge binlogs · 0d8f353b
      unknown authored
      Problem: in case of failed 'show binlog events...' we don't inform that 
      the log is not in use anymore. That may confuse following 'purge logs...'
      command as it takes into account logs in use.
      
      Fix: always notify that the log is not in use anymore.
      
      
      mysql-test/r/rpl_rotate_logs.result:
        Fix for bug #29420: crash with show and purge binlogs
          - test result.
      mysql-test/t/rpl_rotate_logs.test:
        Fix for bug #29420: crash with show and purge binlogs
          - test case.
      sql/sql_repl.cc:
        Fix for bug #29420: crash with show and purge binlogs
          - always zero thd->current_linfo at the end of the mysql_show_binlog_events().
      0d8f353b
  5. 04 Jul, 2007 5 commits
  6. 03 Jul, 2007 3 commits
  7. 02 Jul, 2007 8 commits
  8. 01 Jul, 2007 2 commits
  9. 30 Jun, 2007 3 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · 8dcd5fca
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/type_enum.result:
        Auto merged
      mysql-test/t/type_enum.test:
        Auto merged
      sql/field_conv.cc:
        SCCS merged
      8dcd5fca
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 0b0cef48
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/22540/50-22540
      
      
      0b0cef48
    • unknown's avatar
      Bug#22540: Incorrect value in column End_log_pos of SHOW BINLOG EVENTS using InnoDB · 59ab2d46
      unknown authored
      previous correction didn't. make sure "tail" is fixed up
      when filling cache several times; rework formulae.
      
      
      mysql-test/r/binlog.result:
        Bug#22540: Incorrect value in column End_log_pos of SHOW BINLOG EVENTS using InnoDB
        
        show that fix for absolute end_log_pos in binlog also
        works when cache is read several times and headers are
        split across that boundary
      mysql-test/t/binlog.test:
        Bug#22540: Incorrect value in column End_log_pos of SHOW BINLOG EVENTS using InnoDB
        
        show that fix for absolute end_log_pos in binlog also
        works when cache is read several times and headers are
        split across that boundary
      59ab2d46
  10. 29 Jun, 2007 12 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29205 · a89259fa
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      a89259fa
    • unknown's avatar
      Fixed bug #29205. · db397d16
      unknown authored
      When a UNION statement forced conversion of an UTF8
      charset value to a binary charset value, the byte
      length of the result values was truncated to the
      CHAR_LENGTH of the original UTF8 value.
      
      
      sql/item.cc:
        Fixed bug #29205.
        The calculation of data length was modified in
        the Item_type_holder::join_types method to take into
        account possible conversion of a multibyte charset
        value to a binary charset value, when each
        multibyte character is converted into a sequence
        of bytes (not to a single byte of binary charset).
      mysql-test/t/ctype_utf8.test:
        Updated test case for bug #29205.
      mysql-test/r/ctype_utf8.result:
        Updated test case for bug #29205.
      db397d16
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 6a00ce71
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29261-bug-5.0-opt-mysql
      
      
      6a00ce71
    • unknown's avatar
      Bug#29261: Sort order of the collation wasn't used when comparing trailing · 4772a012
      unknown authored
      spaces.
      
      When the my_strnncollsp_simple function compares two strings and one is a prefix
      of another then this function compares characters in the rest of longer key
      with the space character to find whether the longer key is greater or less.
      But the sort order of the collation isn't used in this comparison. This may
      lead to a wrong comparison result, wrongly created index or wrong order of the
      result set of a query with the ORDER BY clause.
      
      Now the my_strnncollsp_simple function uses collation sort order to compare
      the characters in the rest of longer key with the space character.
      
      
      mysql-test/t/ctype_collate.test:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      mysql-test/r/ctype_collate.result:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      strings/ctype-simple.c:
        Bug#29261: Sort order of the collation wasn't used when comparing trailing
        spaces.
        Now the my_strnncollsp_simple function uses collation sort order to compare
        the characters in the rest of longer key with the space character.
      4772a012
    • unknown's avatar
      Update result files. · f10d930b
      unknown authored
      
      mysql-test/r/ps_6bdb.result:
        Update result file.
      mysql-test/r/ps_7ndb.result:
        Update result file.
      f10d930b
    • unknown's avatar
      Follow up to the patch for the BUG#10491. · 54c3809d
      unknown authored
      
      mysql-test/r/ps_1general.result:
        Update result file.
      mysql-test/r/ps_2myisam.result:
        Update result file.
      mysql-test/r/ps_3innodb.result:
        Update result file.
      mysql-test/r/ps_4heap.result:
        Update result file.
      mysql-test/r/ps_5merge.result:
        Update result file.
      tests/mysql_client_test.c:
        Fix test -- after field changing character set to utf8 in the server,
        length should be calculated differently.
      54c3809d
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-maint · f30a53a0
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.0-maint
      
      
      f30a53a0
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/bug28356/my50-bug28356 · c8dde6df
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/t/sp.test:
        Auto merged
      c8dde6df
    • unknown's avatar
      Bug#28356 Exec'ing "diff" from "mysqltest" loses the output, no information available · 0870afe3
      unknown authored
       - Use SQL for diffing master and slave
      
      
      mysql-test/r/rpl_misc_functions.result:
        Dump t1 on slave and load it back into temporary table on master
        to allow comapre with SQL
      mysql-test/t/rpl_misc_functions.test:
        Dump t1 on slave and load it back into temporary table on master
        to allow comapre with SQL
      0870afe3
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 33eb22a3
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27333-gcov-5.0-opt
      
      
      33eb22a3
    • unknown's avatar
      Bug#27333: subquery grouped for aggregate of outer · c2e961cf
      unknown authored
      query / no aggregate of subquery
       The optimizer counts the aggregate functions that 
       appear as top level expressions (in all_fields) in 
       the current subquery. Later it makes a list of these
       that it uses to actually execute the aggregates in
       end_send_group().
       That count is used in several places as a flag whether
       there are aggregates functions.
       While collecting the above info it must not consider
       aggregates that are not aggregated in the current 
       context. It must treat them as normal expressions 
       instead. Not doing that leads to incorrect data about
       the query, e.g. running a query that actually has no
       aggregate functions as if it has some (and hence is
       expected to return only one row).
       Fixed by ignoring the aggregates that are not aggregated
       in the current context. 
       One other smaller omission discovered and fixed in the 
       process : the place of aggregation was not calculated for
       user defined functions. Fixed by calling 
       Item_sum::init_sum_func_check() and 
       Item_sum::check_sum_func() as it's done for the rest of 
       the aggregate functions.
      
      
      mysql-test/r/subselect.result:
        Bug #27333: test case
      mysql-test/t/subselect.test:
        Bug #27333: test case
      sql/item_subselect.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.h:
        Bug#27333: calculate the place of 
         aggregation for user defined functions.
      sql/sql_select.cc:
        Bug#27333: When counting the aggregated functions
         and collecting a list of them we must not consider
         the aggregates that are not aggregated in the local
         context as "local" : i.e. we must treat them as 
         normal functions and not add them to the aggregate
         functions list.
      sql/sql_select.h:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      c2e961cf
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 73023608
      unknown authored
      into  mysql.com:/home/hf/work/29247/my50-29247
      
      
      sql-common/client.c:
        Auto merged
      73023608
  11. 28 Jun, 2007 1 commit
    • unknown's avatar
      Fix for BUG#10491: Server returns data as charset binary · 925c33db
      unknown authored
      SHOW CREATE TABLE or SELECT FROM I_S.
      
      Actually, the bug discovers two problems:
        - the original query is not preserved properly. This is the problem
          of BUG#16291;
        - the resultset of SHOW CREATE TABLE statement is binary.
      
      This patch fixes the second problem for the 5.0.
      
      Both problems will be fixed in 5.1.
      
      
      mysql-test/r/show_check.result:
        Update result file.
      mysql-test/t/show_check.test:
        Provide test case for BUG#10491.
      sql/item.h:
        Use utf8_general_ci instead of binary collation by default,
        because for views and base tables utf8 is the character set
        in which their definition is stored. For system constants
        it's the default character set, and for other objects
        (routines, triggers), no character set is stored, and
        therefore no character set is known, so returning utf8
        is just as good as any non-binary character set.
        This latter problem is fixed in 5.1 by 16291. In 5.1
        we will return the "real" character set.
      925c33db