1. 14 Apr, 2004 1 commit
  2. 12 Apr, 2004 1 commit
    • unknown's avatar
      Added missing return statement · fc67a828
      unknown authored
      
      sql/sql_delete.cc:
        Added missing return
      sql/sql_lex.cc:
        Comment fixes
      sql/sql_parse.cc:
        Comment fixes
      fc67a828
  3. 11 Apr, 2004 2 commits
  4. 09 Apr, 2004 7 commits
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 91e2f80b
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-ps3-4.1
      
      
      sql/set_var.cc:
        Auto merged
      91e2f80b
    • unknown's avatar
      after review PS fixes · 77330300
      unknown authored
      
      sql/item_cmpfunc.cc:
        merged in one if
      sql/mysql_priv.h:
        removed unused paremeter of check_one_table_access
        declaration of new function for SP share code
      sql/set_var.cc:
        function descriotion added
        unneeded parantses removed
      sql/sql_acl.cc:
        new parameter to limit number of checked tables for check_grant
      sql/sql_acl.h:
        new parameter to limit number of checked tables for check_grant
      sql/sql_delete.cc:
        preparation moved in separate function
      sql/sql_insert.cc:
        preparation moved in separate function
      sql/sql_lex.cc:
        comment style fixed
        unneeded assignment removed
      sql/sql_parse.cc:
        new parameter to limit number of checked tables for check_grant
        table list manipulation removed (because of above)
        new precheck function
      sql/sql_prepare.cc:
        function rewrited to shere code with sql_prepare.cc
        flow control fixed
      sql/sql_show.cc:
        new parameter to limit number of checked tables for check_grant
      sql/sql_update.cc:
        preparation moved in separate function
      sql/table.h:
        flag renamed
      77330300
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1/ · 951b0362
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.1
      
      951b0362
    • unknown's avatar
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · a810fcad
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-ps3-4.1
      
      a810fcad
    • unknown's avatar
      complex join example for test suite · 103c1544
      unknown authored
      103c1544
    • unknown's avatar
      Fixed problems noticed with last build · a502beda
      unknown authored
      
      mysql-test/r/lowercase_table2.result:
        Fixed typo
      mysql-test/r/repair.result:
        Portability fix (For OpenBSD)
      mysql-test/t/repair.test:
        Portability fix (For OpenBSD)
      mysys/my_thr_init.c:
        Fixed crasch with some tests on OpenBSD.
      sql/field.cc:
        Don't truncate big values (Caused a core dump on Linux-Alpha for big values)
      sql/log.cc:
        More DBUG
      a502beda
  5. 08 Apr, 2004 7 commits
    • unknown's avatar
      merge · 97198d71
      unknown authored
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      97198d71
    • unknown's avatar
      fixed subquery in the FROM clause with parameter (BUG#3020) · 66487416
      unknown authored
      
      sql/sql_derived.cc:
        do not execute subqueries in the FROM clause in PS preparation
      tests/client_test.c:
        test of subquery in FROM clause with parameter
      66487416
    • unknown's avatar
      always call start_bulk_insert, clarify this behaviour in comment block · dc6e0478
      unknown authored
      change 10 to a #define'd constant
      
      
      myisam/myisamdef.h:
        use a constant with a difficult-to-type name instead of two-digit number :)
      sql/ha_myisam.cc:
        use a constant with a difficult-to-type name instead of two-digit number :)
      sql/sql_insert.cc:
        always call start_bulk_insert (it performs all checks itself)
        removed spurious semicolon at the end of the "if" :)
        added a clarifying comment
      dc6e0478
    • unknown's avatar
      Don't enable HA_EXTRA_WRITE_CACHE if too few rows · 66434e70
      unknown authored
      Revert main parts of patch for online index builds. Should be done differently
      Added support for %lx in my_snprintf()
      
      
      sql/ha_myisam.cc:
        Don't enable HA_EXTRA_WRITE_CACHE if too few rows
      sql/handler.h:
        Indentaion fix
      sql/mysql_priv.h:
        Removed real_alter_table, mysql_add_column and mysql_drop_column
      sql/sql_class.cc:
        After merge fix
      sql/sql_insert.cc:
        Don't user bulk_insert if only one row (common case)
      sql/sql_parse.cc:
        Added mysql_create_index() and mysql_drop_index() as these are only wrappers for mysql_alter_table()
      sql/sql_table.cc:
        Revert main parts of patch for online index builds
        Changed back to use tabs to make merges possible between trees
      sql/unireg.cc:
        Added comments and minor cleanup
      strings/my_vsnprintf.c:
        Added support for %lx.
        Proper long support
      66434e70
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 5229431d
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      5229431d
    • unknown's avatar
      Moved reading of ranges from opt_range.cc to handler.cc · 031e7872
      unknown authored
      This gives the handler more optimization possiblities and is needed for NDB cluster
      Fixed not-initialized memory error detected by valgrind
      
      
      mysql-test/mysql-test-run.sh:
        Fixed address to manual page
      mysql-test/r/gis-rtree.result:
        Added test to show fatal error in GIS
      mysql-test/r/grant.result:
        New tests
      mysql-test/t/gis-rtree.test:
        New tests
      mysql-test/t/grant.test:
        New tests
      sql/handler.cc:
        Moved reading of ranges from opt_range.cc to handler.cc
        This gives the handler more optimization possiblities and is needed for NDB cluster
      sql/handler.h:
        Moved reading of ranges from opt_range.cc to handler.cc
        T
      sql/opt_range.cc:
        Moved reading of ranges from opt_range.cc to handler.cc
        Simplified GIS get_next() handling
        Indentation cleanups
      sql/opt_range.h:
        Removed not needed cmp_next()
        Added new QUICK_SELECT method for GIS keys to make code for normal keys easier and faster
      sql/sql_select.cc:
        Fixed wrong handling of usable-keys in test_if_skip_sort_order (not fatal, just a warning from valgrind)
        Added DBUG
        Cleaned up comments
      031e7872
    • unknown's avatar
      field->store resuts passing is fixed for REAL and INT for Item_param (BUG3223) · b1444485
      unknown authored
      
      sql/item.cc:
        field->store resuts passing is fixed for REAL and INT
      tests/client_test.c:
        removed debugging commnet
        fixed type casting
        test for BUG#3223
      b1444485
  6. 07 Apr, 2004 18 commits
    • unknown's avatar
      Cleanup/optimizations of structures and key usage to make it easier to move... · 076ec3c0
      unknown authored
      Cleanup/optimizations of structures and key usage to make it easier to move key-range-search to handler
      
      
      sql/field.cc:
        Use 'HA_KEY_BLOB_LENGTH' instead of '2' for 'packed-length'
        Changed 'get_key_image' and 'set_key_image' to take length data part of key (without length-store bytes). This makes the interface easier to use from opt_range.cc
      sql/field.h:
        Indentation fix
      sql/opt_range.cc:
        Changed KEY_PART to use KEY_PART_INFO->store_length (which includes null-byte if needed)
        This makes some functions easier and allowed us to easier use the new get_key_image/set_key_image interfaces
        Simple loop optimization.
      sql/opt_range.h:
        Changed part_length -> store_length and added length to KEY_PART.
        This make this structure more like KEY_PART_INFO
        Added 'sorted' to QUICK_SELECT for NDB
      sql/sql_class.cc:
        Fixed compiler warning
      sql/sql_select.cc:
        Set 'quick->sorted' if keys should be sorted (for NDB)
      sql/table.cc:
        GEOMETRY KEYS doesn't have length prefix in keys
      076ec3c0
    • unknown's avatar
      merge · fca942ff
      unknown authored
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      fca942ff
    • unknown's avatar
      new error for unsupported command in PS · 9802b134
      unknown authored
      fixed IN subselect with basic constant left expression
      SQLCOM_CREATE_TABLE, SQLCOM_UPDATE_MULTI, SQLCOM_REPLACE_SELECT, SQLCOM_INSERT_SELECT, QLCOM_DELETE_MULTI fixed to be compatible with PS (BUG#3398, BUG#3406)
      fixed multiupdate privelege check (BUG#3408)
      fixed multiupdate tables check (BUG#3411)
      unchecked commands now is rejected by PS protocol to avoid serever crash
      fixed cleunup procedure to be compatible sith DO/SET (BUG#3393)
      
      
      include/mysqld_error.h:
        new error for unsupported command in PS
      mysql-test/r/multi_update.result:
        test sutes (BUG#3408, BUG#3411)
      mysql-test/t/multi_update.test:
        test sutes (BUG#3408, BUG#3411)
      sql/item_cmpfunc.cc:
        fixed IN subselect with basic constant left expression
      sql/mysql_priv.h:
        some function frop sql_parse.h become public
      sql/set_var.cc:
        check for SET command via PS
      sql/set_var.h:
        check for SET command via PS
      sql/share/czech/errmsg.txt:
        new error for unsupported command in PS
      sql/share/danish/errmsg.txt:
        new error for unsupported command in PS
      sql/share/dutch/errmsg.txt:
        new error for unsupported command in PS
      sql/share/english/errmsg.txt:
        new error for unsupported command in PS
      sql/share/estonian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/french/errmsg.txt:
        new error for unsupported command in PS
      sql/share/german/errmsg.txt:
        new error for unsupported command in PS
      sql/share/greek/errmsg.txt:
        new error for unsupported command in PS
      sql/share/hungarian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/italian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/japanese/errmsg.txt:
        new error for unsupported command in PS
      sql/share/korean/errmsg.txt:
        new error for unsupported command in PS
      sql/share/norwegian-ny/errmsg.txt:
        new error for unsupported command in PS
      sql/share/norwegian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/polish/errmsg.txt:
        new error for unsupported command in PS
      sql/share/portuguese/errmsg.txt:
        new error for unsupported command in PS
      sql/share/romanian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/russian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/serbian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/slovak/errmsg.txt:
        new error for unsupported command in PS
      sql/share/spanish/errmsg.txt:
        new error for unsupported command in PS
      sql/share/swedish/errmsg.txt:
        new error for unsupported command in PS
      sql/share/ukrainian/errmsg.txt:
        new error for unsupported command in PS
      sql/sql_lex.cc:
        first table unlincking procedures for CREATE command
      sql/sql_lex.h:
        first table unlincking procedures for CREATE command
      sql/sql_parse.cc:
        used function to exclude first table from list
        SQLCOM_CREATE_TABLE, SQLCOM_UPDATE_MULTI, SQLCOM_REPLACE_SELECT, SQLCOM_INSERT_SELECT, QLCOM_DELETE_MULTI fixed to be compatible with PS (BUG#3398, BUG#3406)
        fixed multiupdate privelege check (BUG#3408)
        fixed multiupdate tables check (BUG#3411)
      sql/sql_prepare.cc:
        fixed a lot of commands to be compatible with PS
        unchecked commands now is rejected to avoid serever crash
      sql/sql_select.cc:
        allow empty result for PS preparing
      sql/sql_union.cc:
        fixed cleunup procedure to be compatible sith DO/SET (BUG#3393)
      sql/sql_update.cc:
        fixed update to use correct tables lists (BUG#3408)
      sql/table.h:
        flag to support multi update tables check (BUG#3408)
      tests/client_test.c:
        removed unsupported tables
        fixed show table test
        added new tests
      9802b134
    • unknown's avatar
      escaping all molty-statement macro · a93249cb
      unknown authored
      a93249cb
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1/ · 4eab9b34
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.1
      
      4eab9b34
    • unknown's avatar
      75e208ee
    • unknown's avatar
      Fixed previous security patch. mysqld_safe will use the given --log=file, · 5cce281a
      unknown authored
      or if not given, it will try to use the one in datadir, if possible, otherwise
      log file will be disabled.
      
      5cce281a
    • unknown's avatar
      merged · ffcd2459
      unknown authored
      
      sql/handler.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      ffcd2459
    • unknown's avatar
      merged · 3c2d3735
      unknown authored
      
      sql/field.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/protocol.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      3c2d3735
    • unknown's avatar
      Fix for Hand-Merge · c74cea81
      unknown authored
      c74cea81
    • unknown's avatar
      post-review fixes · a9a5517a
      unknown authored
      HA_EXTRA_WRITE_CACHE now part of start_bulk_insert()
      test cleanups
      
      
      BitKeeper/deleted/.del-repair_part2-master.sh~f44a8c15d6c36585:
        Delete: mysql-test/t/repair_part2-master.sh
      BitKeeper/deleted/.del-repair_part2.test~c20f60783b04d001:
        Delete: mysql-test/t/repair_part2.test
      BitKeeper/deleted/.del-repair_part2.result~72ca166fb248b566:
        Delete: mysql-test/r/repair_part2.result
      mysql-test/r/myisam.result:
        updated
      mysql-test/t/lowercase_table2.test:
        typo fixed
      mysql-test/r/repair.result:
        single repair.test from repair_part[12].test
      mysql-test/t/lowercase_table3.test:
        typo fixed
      mysql-test/t/lowercase_table_qcache.test:
        newline added
      mysql-test/t/myisam.test:
        updated
      mysql-test/t/repair.test:
        single repair.test from repair_part[12].test
      sql/field.cc:
        reverted
      sql/field.h:
        style fix
      sql/ha_myisam.cc:
        add HA_EXTRA_WRITE_CACHE to start_bulk_insert
      sql/sql_insert.cc:
        add HA_EXTRA_WRITE_CACHE to start_bulk_insert
      sql/sql_load.cc:
        add HA_EXTRA_WRITE_CACHE to start_bulk_insert
      sql/sql_table.cc:
        add HA_EXTRA_WRITE_CACHE to start_bulk_insert
      a9a5517a
    • unknown's avatar
      Hand-resolved auto merge · 397b0b80
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      sql/handler.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/unireg.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_table.cc:
        Hand-merged
      sql/sql_yacc.yy:
        Hand-merged
      397b0b80
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · 01bcc6ed
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-ps3-4.1
      
      
      mysql-test/r/union.result:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      01bcc6ed
    • unknown's avatar
      Merge eagle.mysql.r18.ru:/home/vva/work/mysql.orig/clear/mysql-4.1 · 08797f59
      unknown authored
      into eagle.mysql.r18.ru:/home/vva/work/BUG_3342/mysql-4.1
      
      
      sql/sql_parse.cc:
        Auto merged
      08797f59
    • unknown's avatar
      ignore: · c0b9ce7b
      unknown authored
        added install
      
      
      BitKeeper/etc/ignore:
        added install
      c0b9ce7b
    • unknown's avatar
      Worklog#1563 - Support of on-line CREATE/DROP INDEX. · 29309415
      unknown authored
      Corrected minor problems of the preceding changeset 1.1705.
      
      
      sql/sql_table.cc:
        Worklog#1563 - Support of on-line CREATE/DROP INDEX.
        Replaced all tabs by a proper number of spaces. In the diff list this looks unaligned sometimes.
        Changed all sprintf to snprintf and checked the return value.
        Fixed key_count<= 0. key_count is unsigned.
        Removed an obsolete comment.
      29309415
    • unknown's avatar
      after review changes · 56507195
      unknown authored
      
      sql/log_event.cc:
        non_cachable_table flag changed to cacheable_table
      sql/repl_failsafe.cc:
        non_cachable_table flag changed to cacheable_table
      sql/slave.cc:
        non_cachable_table flag changed to cacheable_table
      sql/sql_acl.cc:
        non_cachable_table flag changed to cacheable_table
      sql/sql_base.cc:
        non_cachable_table flag changed to cacheable_table
      sql/sql_cache.cc:
        non_cachable_table flag changed to cacheable_table
      sql/sql_help.cc:
        non_cachable_table flag changed to cacheable_table
      sql/sql_insert.cc:
        non_cachable_table flag changed to cacheable_table
      sql/sql_parse.cc:
        non_cachable_table flag changed to cacheable_table
      sql/sql_prepare.cc:
        renamed DEBUG tag
      sql/table.h:
        non_cachable_table flag changed to cacheable_table
      56507195
    • unknown's avatar
      Portability fixes · ef79036c
      unknown authored
      Fixed problems with group_concat() and HAVING
      Updated crash-me values
      
      
      sql-bench/limits/mysql-4.0.cfg:
        Rename: sql-bench/limits/mysql.cfg -> sql-bench/limits/mysql-4.0.cfg
      include/my_global.h:
        Safety fix
      libmysqld/Makefile.am:
        Portability fix (For AIX 64 bit)
      mysql-test/r/func_gconcat.result:
        More tests
      mysql-test/t/func_gconcat.test:
        More tests
      sql/field.cc:
        Cleanups
      sql/init.cc:
        moved thread_stack_min to right place
      sql/item_sum.cc:
        Fixed problems with group_concat() and HAVING
        Removed some not needed variables
      sql/item_sum.h:
        Fixed problems with group_concat() and HAVING
        Removed some not needed variables
      sql/mysqld.cc:
        Moved thread_stack_min to right place to handle case where we didn't get as much stack space as we asked for
      sql/sql_parse.cc:
        More debugging
      sql/sql_select.cc:
        Cleanup
      sql/sql_yacc.yy:
        Fixed handling of Item_group_concat() in having. (Arguments should not be handled as refs)
      ef79036c
  7. 06 Apr, 2004 4 commits
    • unknown's avatar
      ::reset(), HA_FAST_KEY_READ, disable_indexes(), enable_indexes(),... · 6ca2c764
      unknown authored
      ::reset(), HA_FAST_KEY_READ, disable_indexes(), enable_indexes(), start_bulk_insert(), end_bulk_insert()
      Field::val_str simplification, comment
      
      
      include/my_base.h:
        typos fixed
      mysql-test/r/myisam.result:
        alter table enable/disable keys
      mysql-test/t/help.test:
        cleanup
      mysql-test/t/myisam.test:
        alter table enable/disable keys
      sql/field.cc:
        Field::val_str() simplification
      sql/field.h:
        Field::val_str() simplification and comment
      sql/field_conv.cc:
        Field::val_str() simplification
      sql/ha_berkeley.cc:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_berkeley.h:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_heap.cc:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_heap.h:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_innodb.cc:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_innodb.h:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_isam.cc:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_isam.h:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_isammrg.cc:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_isammrg.h:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_myisam.cc:
        ::reset(), HA_FAST_KEY_READ, disable_indexes(), enable_indexes(), start_bulk_insert(), end_bulk_insert()
      sql/ha_myisam.h:
        ::reset(), HA_FAST_KEY_READ, disable_indexes(), enable_indexes(), start_bulk_insert(), end_bulk_insert()
      sql/ha_myisammrg.cc:
        ::reset(), HA_FAST_KEY_READ
      sql/ha_myisammrg.h:
        ::reset(), HA_FAST_KEY_READ
      sql/handler.h:
        ::reset(), HA_FAST_KEY_READ, disable_indexes(), enable_indexes(), start_bulk_insert(), end_bulk_insert()
      sql/item.cc:
        Field::val_str() simplification
      sql/item_sum.cc:
        Field::val_str() simplification
      sql/key.cc:
        Field::val_str() simplification
      sql/opt_range.cc:
        Field::val_str() simplification
      sql/protocol.cc:
        Field::val_str() simplification
      sql/records.cc:
        HA_FAST_KEY_READ
      sql/sql_acl.cc:
        Field::val_str() simplification
      sql/sql_base.cc:
        ::reset
      sql/sql_insert.cc:
        ::reset(), start_bulk_insert(), end_bulk_insert()
      sql/sql_load.cc:
        start_bulk_insert(), end_bulk_insert()
      sql/sql_show.cc:
        Field::val_str() simplification
      sql/sql_table.cc:
        disable_indexes(), enable_indexes(), start_bulk_insert(), end_bulk_insert()
      sql/table.cc:
        Field::val_str() simplification
      6ca2c764
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · fa3fe20a
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      fa3fe20a
    • unknown's avatar
      fixed · 6f021f42
      unknown authored
      bug #3342 "SHOW CREATE DATABASE seems to require DROP privilege"
      (now it require only SELECT privilege on database)
      
      
      mysql-test/r/show_check.result:
        added test for 
        bug #3342 "SHOW CREATE DATABASE seems to require DROP privilege"
      mysql-test/t/show_check.test:
        added test for 
        bug #3342 "SHOW CREATE DATABASE seems to require DROP privilege"
      6f021f42
    • unknown's avatar
      Fixed charsetnr sent to the client · 2b2d0dda
      unknown authored
      2b2d0dda