1. 21 May, 2011 1 commit
    • Igor Babaev's avatar
      Fixed 3 valgrind bugs. · 9a5b2c1e
      Igor Babaev authored
      Two of them (in the function make_join_statistics and in the function
      sort_and_filter_keyuse) were due to bad merges while the third bug was
      triggered by uninitialized values of the field JOIN_TAB::preread_init_done.
      
      Fixed a compiler warning in mysql_priv.h.
      
      Commented out some queries from the funcs_1 suite returning wrong
      errors due to bugs concerning updatable views (see bugs 784297 and
      784303).
      
      Adjusted some results for the test cases with derived tables from
      different suites. 
      9a5b2c1e
  2. 20 May, 2011 12 commits
  3. 19 May, 2011 12 commits
  4. 18 May, 2011 11 commits
    • unknown's avatar
      automatic merge · da94d3b8
      unknown authored
      da94d3b8
    • Michael Widenius's avatar
      Original idea from Zardosht Kasheff to add HA_CLUSTERED_INDEX · 0dbfd00e
      Michael Widenius authored
      - Added a lot of code comments
      - Updated get_best_ror_intersec() to prefer index scan on not clustered keys before clustered keys.
      - Use HA_CLUSTERED_INDEX to define if one should use HA_MRR_INDEX_ONLY
      - For test of using index or filesort to resolve ORDER BY, use HA_CLUSTERED_INDEX flag instead of primary_key_is_clustered()
      - Use HA_TABLE_SCAN_ON_INDEX instead of primary_key_is_clustered() to decide if ALTER TABLE ... ORDER BY will have any effect.
      
      sql/ha_partition.h:
        Added comment with warning for code unsafe to use with multiple storage engines at the same time
      sql/handler.h:
        Added HA_CLUSTERED_INDEX.
        Documented primary_key_is_clustered()
      sql/opt_range.cc:
        Added code comments
        Updated get_best_ror_intersec() to ignore clustered keys.
        Optimized away cpk_scan_used and one instance of current_thd (Simpler code)
        Use HA_CLUSTERED_INDEX to define if one should use HA_MRR_INDEX_ONLY
      sql/sql_select.cc:
        Changed comment to #ifdef
        For test of using index or filesort to resolve ORDER BY, use HA_CLUSTERED_INDEX flag instead of primary_key_is_clustered()
        (Change is smaller than what it looks beause of indentation change)
      sql/sql_table.cc:
        Use HA_TABLE_SCAN_ON_INDEX instead of primary_key_is_clustered() to decide if ALTER TABLE ... ORDER BY will have any effect.
      storage/innobase/handler/ha_innodb.h:
        Added support for HA_CLUSTERED_INDEX
      storage/innodb_plugin/handler/ha_innodb.cc:
        Added support for HA_CLUSTERED_INDEX
      storage/xtradb/handler/ha_innodb.cc:
        Added support for HA_CLUSTERED_INDEX
      0dbfd00e
    • unknown's avatar
      automerge · 2fec2309
      unknown authored
      2fec2309
    • unknown's avatar
      Rewritten patch of percona - switching query cache on and off, removing comments. · 220c3bb4
      unknown authored
      client/mysqltest.cc:
        Column names.
      mysql-test/r/grant_cache_no_prot.result:
        fix of text.
      mysql-test/r/grant_cache_ps_prot.result:
        Fix of test.
      mysql-test/r/query_cache.result:
        Switching on and off query cache.
      mysql-test/t/query_cache.test:
        Switching on and off query cache.
      mysys/charset.c:
        Fix of parser.
      sql/handler.cc:
        thd added to parameters.
      sql/log_event.cc:
        thd added to parameters.
      sql/log_event_old.cc:
        thd added to parameters.
      sql/mysql_priv.h:
        Fixed functions definitions.
      sql/mysqld.cc:
        Comments stripping.
      sql/set_var.cc:
        Switching on and off query cache.
      sql/set_var.h:
        Switching on and off query cache.
      sql/share/errmsg.txt:
        New errors.
      sql/sql_cache.cc:
        Switching query cache on and off, removing comments.
      sql/sql_cache.h:
        thd added to parameters.
      sql/sql_class.h:
        Comments stripping.
      sql/sql_db.cc:
        thd added to parameters.
      sql/sql_lex.cc:
        lex fixed.
      sql/sql_parse.cc:
        thd added to parameters.
      220c3bb4
    • unknown's avatar
      fb92a2ff
    • unknown's avatar
      automerge · f6c5c36b
      unknown authored
      f6c5c36b
    • unknown's avatar
      automerge · 6848ebb0
      unknown authored
      6848ebb0
    • unknown's avatar
      Fix mysqltest printing of include stack. · 8a747fff
      unknown authored
      The printing of include stack in the error case in mysqltest omitted the
      bottom of the stack (the line number in original test case file), and instead
      printed the top of the stack twice. Fix to print each element on the stack
      once and only once.
      8a747fff
    • Michael Widenius's avatar
      Added HA_ERR_DISK_FULL handler error · 3418a7b7
      Michael Widenius authored
      Original code by Zardosht Kasheff
      
      sql/handler.cc:
        Added HA_ERR_DISK_FULL and ENOSPC (for handler that uses normal errno).
        This sets 'fatal_error' to ensure that the error is logged to err file (which hopefully is on another disk...)
      3418a7b7
    • Vladislav Vaintroub's avatar
      Fix compile warning. · cb8d6e3f
      Vladislav Vaintroub authored
      cb8d6e3f
    • Igor Babaev's avatar
      Fixed LP bug #784281. · 78794f32
      Igor Babaev authored
      When a view is merged into a select all the depended_from fields
      pointing to the select of the view should have been corrected to
      point to the select where the view is used. It was not done yet.
      This could lead to wrong results returned by queries such as
      one from the test case for bug 33389.
      Correction of outer references required walking through all items
      of the proccesed qurery. To avoid this the following solution was
      implemented.
      Each select now contains a pointer to the select it is merged into
      (if there is any). Such pointers allow to get the corrected value
      of depended_from on the fly. The function Item_ident::get_depended_from
      was introduced for this purpose.
      78794f32
  5. 17 May, 2011 2 commits
    • Michael Widenius's avatar
      Removed some alias warnings · 4f289957
      Michael Widenius authored
      Fixed alias bug when compiling with gcc 4.2.4 that caused subselect.test to fail
      
      sql/item.cc:
        Removed alias warnings by changing type from char * to const char*
      sql/item.h:
        Removed alias warnings by changing type from char * to const char*
      sql/item_subselect.cc:
        Fixed alias bug when compiling with gcc 4.2.4 that caused subselect.test to fail
      sql/sql_string.h:
        Removed alias warnings by changing type from char * to const char*
      storage/heap/hp_test2.c:
        Removed SAFEMALLOC to get rid of compiler error
        Fixed test case as we can't anymore use heap_rlast() on a HASH key entry.
      4f289957
    • Igor Babaev's avatar
      Merged the code of MWL#106 into 5.3 · c8611b6e
      Igor Babaev authored
      Resolved all conflicts, bad merges and fixed a few minor bugs in the code.
      Commented out the queries from multi_update, view, subselect_sj, func_str,
      derived_view, view_grant that failed either with crashes in ps-protocol or
      with wrong results.
      The failures are clear indications of some bugs in the code and these bugs
      are to be fixed.
      c8611b6e
  6. 16 May, 2011 2 commits