- 18 Jul, 2017 4 commits
-
-
Sergei Golubchik authored
-
Oleksandr Byelkin authored
MDEV-11240: Server crashes in check_view_single_update or Assertion `derived->table' failed in mysql_derived_merge_for_insert Move table pointer for single table view (even if it is view over other view) to make the access universal.
-
Alexey Botchkov authored
Set name_length properly in Item_idnet constructors.
-
Daniel Black authored
end_io_call uses uninitialized values from the new_data_cache As such we the buffer 0 and check this before calling end_io_cache on it. Thanks Sergey Vojtovich for the review and for this solution. Found by Coverity (ref 972481).
-
- 17 Jul, 2017 2 commits
-
-
Elena Stepanova authored
-
Alexander Barkov authored
A few tests assumes that the CYCLE timer is always available, which is not true on some platforms (e.g. ARM). Fixing the tests not to reply on the CYCLE availability.
-
- 15 Jul, 2017 3 commits
-
-
Sergei Golubchik authored
in ab785bfe
-
Daniel Black authored
Coverity report this as: CID 971840 (#1 of 1): Operands don't affect result (CONSTANT_EXPRESSION_RESULT) result_independent_of_operands: 4 | (flags & 1) is always true regardless of the values of its operands. This occurs as the logical first operand of "?:". The C order of precidence has | of higher precidence than ?:. The intenting implies an | of the 3 terms. Adjust to intented meaning.
-
Sergei Golubchik authored
Avoid using STDERR_FILENO. The server uses freopen(stderr), so stderr can be on any file descriptor.
-
- 14 Jul, 2017 1 commit
-
-
Daniel Black authored
field_names[x][y] is a pointer client/mysql.cc: In function 'void build_completion_hash(bool, bool)': client/mysql.cc:2855:37: error: invalid conversion from 'char' to 'char*' [-fpermissive] field_names[i][num_fields*2]= '\0'; Signed-off-by: Daniel Black <daniel.black@au.ibm.com>
-
- 13 Jul, 2017 1 commit
-
-
Sergei Golubchik authored
Same MDEV, second bug. Merge buffer must fit at least MERGEBUFF2 (that is, 15) key values. Because merge_index() can merge that many buffers, and merge_many_buff() leaves that many buffers unmerged.
-
- 12 Jul, 2017 7 commits
-
-
Sergei Golubchik authored
use the correct value for the merge_buffer size, max_in_memory_size is too small and merge_walk() fails. also: remove a cast.
-
Sergei Golubchik authored
already fixed by be55bbc2 just add a test case
-
Sergei Golubchik authored
only compare field references with an alias (from the SELECT clause) when this reference doesn't specify an explicit table name part.
-
Sergei Golubchik authored
remove unused variable
-
Sergei Golubchik authored
already fixed by a7ed4644. just add a test case,
-
Sergei Golubchik authored
upper->item can be NULL if we're referring to an aggregate function
-
Sergei Golubchik authored
Item_in_subselect::pushed_cond_guards[] array is allocated only when left_expr->maybe_null. And it is used (for row expressions) when left_expr->element_index(i)->maybe_null. For left_expr being a multi-column subquery, its maybe_null is always false when the subquery doesn't use tables (see Item_singlerow_subselect::fix_length_and_dec() and subselect_single_select_engine::fix_length_and_dec()), otherwise it's always true. But row elements can be NULL regardless, so let's always allocate pushed_cond_guards for multi-column subqueries, no matter whether its maybe_null was forced to true or false.
-
- 06 Jul, 2017 1 commit
-
-
Sergei Golubchik authored
-
- 05 Jul, 2017 1 commit
-
-
Oleksandr Byelkin authored
MDEV-10146: Wrong result (or questionable result and behavior) with aggregate function in uncorrelated SELECT subquery When outer reference resolved in a VIEW it still should mark aggregate function resolving border.
-
- 04 Jul, 2017 1 commit
-
-
Daniel Black authored
Found by Coverity (id 971843). Signed-off-by: Daniel Black <daniel.black@au.ibm.com>
-
- 03 Jul, 2017 6 commits
-
-
Daniel Black authored
make_lock_and_pin didn't release the lock so we should. Found by Coverity (id 972095).
-
Daniel Black authored
Release the lock for the error path. Found by Coverity (id 972093).
-
Daniel Black authored
translog_stop_writing doesn't release a lock (though does to a DBUG_ASSERT). Better to just release the lock. Found by Coverity id 972092
-
Daniel Black authored
Found by Coverity scan - id 92087
-
Daniel Black authored
max_data_file_size is overwritten in next statement so this assignment didn't ever get used. Found by Coverity (ID 1409644)
-
Daniel Black authored
CID 971836 (#1 of 1): Same on both sides (CONSTANT_EXPRESSION_RESULT) pointless_expression: The expression val != end && val != end does not accomplish anything because it evaluates to either of its identical operands, val != end.
-
- 29 Jun, 2017 1 commit
-
-
Sergei Golubchik authored
-
- 27 Jun, 2017 2 commits
-
-
Sergei Golubchik authored
cover ANSI_QUOTES and NO_BACKSLASH_ESCAPES in mysqltest
-
Sergei Golubchik authored
don't do backslash escapes inside backticks
-
- 19 Jun, 2017 1 commit
-
-
Sergei Golubchik authored
-
- 18 Jun, 2017 3 commits
-
-
Sergei Golubchik authored
-
Daniel Black authored
This has been implemented in for cmake-3.6 to match distro version of what the filename should look like. Thanks to Domen Vranka for the suggestion.
-
Sergei Golubchik authored
regex didn't replace lines that were split by 16K chunk reads.
-
- 14 Jun, 2017 4 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
MDEV-13063 Server crashes in intern_plugin_lock or assertion `plugin_ptr->ref_count == 1' fails in plugin_init if a forced plugin is disabled (for any reason, e.g. invalid command-line option) - it's an error
-
Sergei Golubchik authored
-
- 08 Jun, 2017 1 commit
-
-
Igor Babaev authored
This is actually a legacy bug: SQL_SELECT::test_quick_select() was called with SQL_SELECT::head not set. It looks like that this problem can be reproduced only on queries with ORDER BY that use IN predicates converted to semi-joins.
-
- 07 Jun, 2017 1 commit
-
-
Igor Babaev authored
This patch corrects the fix for bug mdev-7599. When the min/max optimization of the function opt_sum_query() optimizes away all tables of a subquery it should not ever be rolled back.
-