1. 07 Nov, 2007 1 commit
    • unknown's avatar
      Bug #20748: Configuration files should not be read more than once · 9a7ca70e
      unknown authored
      A user could not override system-wide settings in their ~/.my.cnf,
      because the DEFAULT_SYSCONFDIR was being searched last.  Also, in
      some configurations (especially when the --sysconfdir compile-time
      option is set to /etc or /etc/mysql), the system-wide my.cnf file
      was read multiple times, causing confusion and potential problems.
      
      Rearrange default directories to conform to the manual and logic.
      Move --sysconfdir=<path> (DEFAULT_SYSCONFDIR) from the last default
      directory to the middle of the list.  $HOME/.my.cnf should be last,
      so the user is able to override the system-wide settings.
      
      Change init_default_directories() to remove duplicates from the
      list.
      
      
      include/my_sys.h:
        Add array_append_string_unique(), from mf_arr_appstr.c
      libmysql/Makefile.shared:
        Add new mf_arr_appstr.lo object
      mysys/CMakeLists.txt:
        Add new mf_arr_appstr.c source.
      mysys/Makefile.am:
        Add new mf_arr_appstr.c source.
      mysys/default.c:
        Change order in which defaults files are added to default_directories,
        in order to conform to the manual (and to common sense).  This fixes
        a particularly bad problem on Unix, where ~/.my.cnf was read before
        /usr/local/etc/my.cnf.
        
        Also, don't add duplicate entries; move the existing entry to the
        end of the list instead.
        
        
        Here is a comparison of the order of defaults files, BEFORE and AFTER
        this patch.
        
        On Windows:
        
        BEFORE:  C:\, GetWindowsDirectory(), GetSystemWindowsDirectory(),
                 $MYSQL_HOME, defaults-extra-file, INSTALLDIR
        
        AFTER:  GetSystemWindowsDirectory(), GetWindowsDirectory(), C:\,
                INSTALLDIR, $MYSQL_HOME, defaults-extra-file
        
        GetSystemWindowsDirectory() is moved before GetWindowsDirectory() because
        the former is shared by all Terminal Services users, while the latter is
        private for each user.
        
        
        On Netware (no change):
        
        BEFORE:  sys:/etc/, $MYSQL_HOME, defaults-extra-file
        
        AFTER:  sys:/etc, $MYSQL_HOME, defaults-extra-file
        
        
        On OS/2:
        
        BEFORE:  $ETC, /etc, $MYSQL_HOME, defaults-extra-file
        
        AFTER:  /etc, $ETC, $MYSQL_HOME, defaults-extra-file
        
        
        On everything else (general Unix):
        
        BEFORE:  /etc, $MYSQL_HOME, defaults-extra-file, ~/, --sysconfdir
        
        AFTER:  /etc/, --sysconfdir, $MYSQL_HOME, defaults-extra-file, ~/
        
        The BEFORE code added --sysconfdir on all systems, but only the
        Unix build system actually defined a value for it.
      mysys/mf_arr_appstr.c:
        BitKeeper file /home/tsmith/m/bk/build/50-b20748/mysys/mf_arr_appstr.c
      9a7ca70e
  2. 15 Oct, 2007 1 commit
  3. 08 Oct, 2007 1 commit
  4. 04 Oct, 2007 3 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 711be53b
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      711be53b
    • unknown's avatar
      Merge production.mysql.com:/usersnfs/jperkin/bk/build/5.0 · 270011cb
      unknown authored
      into  production.mysql.com:/usersnfs/jperkin/bk/bug-27692/5.0
      
      270011cb
    • unknown's avatar
      Restore creation of test databases and the anonymous user which · 4d1a88e8
      unknown authored
      were accidentally removed during a previous rototill of this
      code.  Fixes bug#27692.
        
      While it can be argued we should strive to provide a 'secure by
      default' installation, this happens to be the setup currently
      documented in the manual as the default, so defer changes that
      improve security out of the box to a co-ordinated effort later
      on.
        
      For now, make a note about the test databases and anonymous user
      in mysql_install_db and recommend that mysql_secure_installation
      be ran for users wishing to remove these defaults.
      
      [..re-commit of previously lost change..]
      
      
      scripts/mysql_system_tables_data.sql:
        Add anonymous accounts.
      scripts/mysql_install_db.sh:
        Point users at the mysql_secure_installation script.
      mysql-test/mysql-test-run.pl:
        Add a comment where removing anonymous users.
      4d1a88e8
  5. 02 Oct, 2007 1 commit
    • unknown's avatar
      testScanFilter.cpp: · c47eab5e
      unknown authored
         Updated variable size arrays to use vector like Jonas did for 5.1 so that my build would not break
      
      
      ndb/test/ndbapi/testScanFilter.cpp:
         Updated variable size arrays to use vector like Jonas did for 5.1 so that my build would not break
      c47eab5e
  6. 01 Oct, 2007 1 commit
  7. 27 Sep, 2007 2 commits
  8. 26 Sep, 2007 1 commit
  9. 25 Sep, 2007 1 commit
  10. 22 Sep, 2007 1 commit
  11. 20 Sep, 2007 2 commits
    • unknown's avatar
      result fix · bf3d46a8
      unknown authored
      bf3d46a8
    • unknown's avatar
      Bug#27747 database metadata doesn't return sufficient column default info · b7734724
      unknown authored
      added get_field_default_value() function which obtains default value from the field
      (used in store_create_info() & get_schema_column_record() functions)
      
      
      mysql-test/r/alter_table.result:
        result fix
      mysql-test/r/create.result:
        result fix
      mysql-test/r/ctype_collate.result:
        result fix
      mysql-test/r/ctype_recoding.result:
        result fix
      mysql-test/r/default.result:
        result fix
      mysql-test/r/gis.result:
        result fix
      mysql-test/r/grant.result:
        result fix
      mysql-test/r/information_schema.result:
        result fix
      mysql-test/r/key.result:
        result fix
      mysql-test/r/mysql.result:
        result fix
      mysql-test/r/ps_1general.result:
        result fix
      mysql-test/r/show_check.result:
        result fix
      mysql-test/r/sp.result:
        result fix
      mysql-test/r/type_enum.result:
        result fix
      mysql-test/r/type_ranges.result:
        result fix
      mysql-test/t/information_schema.test:
        test case
      b7734724
  12. 19 Sep, 2007 1 commit
  13. 15 Sep, 2007 1 commit
    • unknown's avatar
      select.test: · 6bcc6c25
      unknown authored
        Post-fix for bug#27695.
      
      
      mysql-test/t/select.test:
        Post-fix for bug#27695.
      6bcc6c25
  14. 14 Sep, 2007 13 commits
  15. 13 Sep, 2007 5 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · 31132dc9
      unknown authored
      into  trift2.:/MySQL/M50/tmp-5.0
      
      31132dc9
    • unknown's avatar
      Fixed bug #27695. · ede3c722
      unknown authored
      Declaring an all space column name in the SELECT FROM DUAL or in a view
      leads to misleading warning message:
      "Leading spaces are removed from name ' '".
      
      The Item::set_name method has been modified to raise warnings like
      "Name ' ' has become ''" in case of the truncation of an all
      space identifier to an empty string identifier instead of the
      "Leading spaces are removed from name ' '" warning message.
      
      
      sql/item.cc:
        Fixed bug #27695.
        The Item::set_name method has been modified to raise warnings like
        "Name ' ' has become ''" in case of the truncation of an all
        space identifier to an empty string identifier instead of the
        "Leading spaces are removed from name ' '" warning message.
      sql/share/errmsg.txt:
        Fixed bug #27695.
      mysql-test/t/select.test:
        Added test case for bug #27695.
      mysql-test/r/select.result:
        Added test case for bug #27695.
      ede3c722
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb · 7082c70e
      unknown authored
      into  mysql.com:/windows/Linux_space/MySQL/mysql-5.0-ndb
      
      7082c70e
    • unknown's avatar
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e7bfb500
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      e7bfb500
  16. 12 Sep, 2007 5 commits