1. 17 Feb, 2023 1 commit
  2. 16 Feb, 2023 1 commit
  3. 15 Feb, 2023 5 commits
    • Sergei Petrunia's avatar
      MDEV-30218: Incorrect optimization for rowid_filtering, correction · 2e687279
      Sergei Petrunia authored
      Final corrections:
      - Remove incorrect tracing, "rowid_filter_skipped"
      - Put the worst_seeks sanity check back
      2e687279
    • Igor Babaev's avatar
      MDEV-30218 Incorrect optimization for rowid_filtering · d1a46c68
      Igor Babaev authored
      Correction over the last patch for this MDEV.
      d1a46c68
    • Haidong Ji's avatar
      MDEV-29091: Correct event_name in PFS for wait caused by FOR UPDATE · 03c9a4ef
      Haidong Ji authored
      When one session SELECT ... FOR UPDATE and holds the lock, subsequent
      sessions that SELECT ... FOR UPDATE will wait to get the lock.
      Currently, that event is labeled as `wait/io/table/sql/handler`, which
      is incorrect. Instead, it should have been
      `wait/lock/table/sql/handler`.
      
      Two factors contribute to this bug:
      1. Instrumentation interface and the heavy usage of `TABLE_IO_WAIT` in
         `sql/handler.cc` file. See interface [^1] for better understanding;
      2. The balancing act [^2] of doing instrumentation aggregration _AND_
         having good performance. For example, EVENTS_WAITS_SUMMARY... is
         aggregated using EVENTS_WAITS_CURRENT. Aggregration needs to be based
         on the same wait class, and the code was overly aggressive in label a
         LOCK operation as an IO operation in this case.
      
      The proposed fix is pretty simple, but understanding the bug took a
      while. Hence the footnotes below.  For future improvement and
      refactoring, we may want to consider renaming `TABLE_IO_WAIT` and making
      it less coarse and more targeted.
      
      Note that newly added test case, events_waits_current_MDEV-29091,
      initially didn't pass Buildbot CI for embedded build tests.  Further
      research showed that other impacted tests all included not_embedded.inc.
      This oversight was fixed later.
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license.  I am contributing on behalf of my employer Amazon Web
      Services, Inc.
      
      [^1]: To understand `performance_schema` instrumentation interface, I
      found this URL is the most helpful:
      https://dev.mysql.com/doc/dev/mysql-server/latest/PAGE_PFS_PSI.html
      [^2]: The best place to understand instrumentation projection,
      composition, and aggregration is through the source file. Although I
      prefer reading Doxygen produced html file, but for whatever reason, the
      rendering is not ideal. Here is link to 10.6's pfs.cc:
      https://github.com/MariaDB/server/blob/10.6/storage/perfschema/pfs.cc
      03c9a4ef
    • Daniel Black's avatar
      MDEV-30630 locale: Chinese error messages for ZH_CN · fab16653
      Daniel Black authored
      MDEV-28227 added the error messages in simplified characters.
      Lets use these for those running a zh_CN profile.
      
      From Haidong Ji in the MDEV, Taiwan/Hong Kong (zh_TW/zh_HK)
      would expect traditional characters so this is left for when
      we have these.
      fab16653
    • Robin Newhouse's avatar
      Backport GitLab CI to earlier branches · 60f96b58
      Robin Newhouse authored
      Add .gitlab-ci.yml file to earliest supported branch to enable
      automated building and testing for all MariaDB major branches.
      
      For 10.4 we use the bundled SSL to build MariaDB when the platform
      does not have OpenSSL 1.1 available. This requires the installation of
      gnutls-devel as a dependency of MariaDB Connector/C.
      OpenSSL 3.0 support was backported to MariaDB 10.5
      (see https://github.com/MariaDB/server/pull/2036, f0fa40ef, 8a9c1e9c)
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license. I am contributing on behalf of my employer
      Amazon Web Services, Inc.
      60f96b58
  4. 14 Feb, 2023 3 commits
  5. 10 Feb, 2023 1 commit
  6. 09 Feb, 2023 5 commits
    • Brandon Nesterenko's avatar
      MDEV-30608: rpl.rpl_delayed_parallel_slave_sbm sometimes fails with... · eecd4f14
      Brandon Nesterenko authored
      MDEV-30608: rpl.rpl_delayed_parallel_slave_sbm sometimes fails with Seconds_Behind_Master should not have used second transaction timestamp
      
      One of the constraints added in the MDEV-29639 patch, is that only
      the first event after idling should update last_master_timestamp;
      and as long as the replica has more events to execute, the variable
      should not be updated. The corresponding test,
      rpl_delayed_parallel_slave_sbm.test, aims to verify this; however,
      if the IO thread takes too long to queue events, the SQL thread can
      appear to catch up too fast.
      
      This fix ensures that the relay log has been fully written before
      executing the events.
      
      Note that the underlying cause of this test failure needs to be
      addressed as a bug-fix, this is a temporary fix to stop test
      failures. To track work on the bug-fix for the underlying issue,
      please see MDEV-30619.
      eecd4f14
    • Igor Babaev's avatar
      MDEV-30586 DELETE with aggregation in subquery of WHERE returns bogus error · c6376842
      Igor Babaev authored
      The parser code for single-table DELETE missed the call of the function
      LEX::check_main_unit_semantics(). As a result the the field nested level
      of SELECT_LEX structures remained set 0 for all non-top level selects.
      This could lead to different kind of problems. In particular this did not
      allow to determine properly the selects where set functions had to be
      aggregated when they were used in inner subqueries.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      c6376842
    • Vicențiu Ciorbaru's avatar
      Apply clang-tidy to remove empty constructors / destructors · 08c85202
      Vicențiu Ciorbaru authored
      This patch is the result of running
      run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' .
      
      Code style changes have been done on top. The result of this change
      leads to the following improvements:
      
      1. Binary size reduction.
      * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by
        ~400kb.
      * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb.
      
      2. Compiler can better understand the intent of the code, thus it leads
         to more optimization possibilities. Additionally it enabled detecting
         unused variables that had an empty default constructor but not marked
         so explicitly.
      
         Particular change required following this patch in sql/opt_range.cc
      
         result_keys, an unused template class Bitmap now correctly issues
         unused variable warnings.
      
         Setting Bitmap template class constructor to default allows the compiler
         to identify that there are no side-effects when instantiating the class.
         Previously the compiler could not issue the warning as it assumed Bitmap
         class (being a template) would not be performing a NO-OP for its default
         constructor. This prevented the "unused variable warning".
      08c85202
    • Vladislav Vaintroub's avatar
      MDEV-30624 HeidiSQL 12.3 · 8dab6614
      Vladislav Vaintroub authored
      8dab6614
    • Vladislav Vaintroub's avatar
  7. 08 Feb, 2023 2 commits
  8. 07 Feb, 2023 3 commits
    • Daniel Black's avatar
      MDEV-30554 RockDB libatomic linking on riscv64 · 17423c6c
      Daniel Black authored
      The existing storage/rocksdb/CMakeCache.txt defined
      ATOMIC_EXTRA_LIBS when atomics where required. This was
      determined by the toplevel configure.cmake test
      (HAVE_GCC_C11_ATOMICS_WITH_LIBATOMIC).
      
      As build_rocksdb.cmake is included after ATOMIC_EXTRA_LIBS
      was set, we just need to use it. As such no riscv64
      specific macro is needed in build_rocksdb.cmake.
      
      As highlighted by Gianfranco Costamagna (@LocutusOfBorg)
      in #2472 overwriting SYSTEM_LIBS was problematic.
      This is corrected in case in future SYSTEM_LIBS is changed
      elsewhere.
      
      Closes #2472.
      17423c6c
    • Daniel Black's avatar
      MDEV-30492 Crash when use mariabackup.exe with config 'innodb_flush_method=async_unbuffered' · ecc93c98
      Daniel Black authored
      Normalize innodb_flush_method, the same as the service, before
      attempting to print it.
      ecc93c98
    • Daniel Black's avatar
      MDEV-30558: ER_KILL_{,QUERY_}DENIED_ERROR - normalize id type · 762fe015
      Daniel Black authored
      The error string from ER_KILL_QUERY_DENIED_ERROR took a different
      type to ER_KILL_DENIED_ERROR for the thread id. This shows
      up in differences on 32 big endian arches like powerpc (Deb notation).
      
      Normalize the passing of the THD->id to its real type of my_thread_id,
      and cast to (long long) on output. As such normalize the
      ER_KILL_QUERY_DENIED_ERROR to that convention too.
      
      Note for upwards merge, convert the type to %lld on new translations
      of ER_KILL_QUERY_DENIED_ERROR.
      762fe015
  9. 06 Feb, 2023 3 commits
  10. 03 Feb, 2023 2 commits
  11. 30 Jan, 2023 2 commits
  12. 28 Jan, 2023 3 commits
  13. 27 Jan, 2023 1 commit
  14. 25 Jan, 2023 2 commits
    • Daniel Black's avatar
      CREDITS: re-instate Tencent Cloud · 765291d6
      Daniel Black authored
      This was an accidential deletion looking at an outdated list.
      765291d6
    • Yuchen Pei's avatar
      MDEV-30370 Fixing spider hang when server aborts · 284810b3
      Yuchen Pei authored
      This is Kentoku's patch for MDEV-22979 (e6e41f04 + 22a00977),
      which fixes 30370.
      
      It changes the wait to a timed wait for the first sts thread, which
      waits on server start to execute the init queries for spider. It also
      flips the flag init_command to false when the sts thread is being
      freed. With these changes the sts thread can check the flag regularly
      and abort the init_queries when it finds out the init_command is
      false. This avoids the deadlock that causes the problem in MDEV-30370.
      
      It also fixes MDEV-22979 for 10.4, but not 10.5. I have not tested
      higher versions for MDEV-22979.
      
      A test has also been done on MDEV-29904 to avoid regression, given
      MDEV-27233 is a similar problem and its patch caused the
      regression. The test passes for 10.4-11.0.
      
      However, this adhoc test only works consistently when placed in the
      main testsuite. We should not place spider tests in the main suite, so
      we do not include it in this commit. A patch for MDEV-27912 should fix
      this problem and allow a proper test for MDEV-29904. See comments in
      the jira ticket MDEV-30370/29904 for the adhoc testcase used for this
      commit.
      284810b3
  15. 24 Jan, 2023 6 commits
    • Vladislav Vaintroub's avatar
      MDEV-30457 Windows, signtool error "No file digest algorithm specified." · 2279ddda
      Vladislav Vaintroub authored
      Add /fd parameter. It is now mandatory for the recent versions of
      signtool
      2279ddda
    • Andrei's avatar
      MDEV-30323 Some DDLs like ANALYZE can complete on parallel slave out of order · 7fe93244
      Andrei authored
      ANALYZE was observed to race over a preceding in binlog order DML
      in updating the binlog and slave gtid states.
      
      Tagging ANALYZE and other admin class commands in binlog by the fixes
      of MDEV-17515 left a flaw allowing such race leading to
      the gtid mode out-of-order error.
      This is fixed now to observe by ADMIN commands the ordered access to
      the slave gtid status variables and binlog.
      7fe93244
    • Andrei's avatar
      MDEV-30010 Slave (additional info): Commit failed due to failure of an earlier... · 3aa04c0d
      Andrei authored
      MDEV-30010 Slave (additional info): Commit failed due to failure of an earlier commit on which this one depends Error_code: 1964
      
      This commit merely adds is a Read-Committed version MDEV-30225 test
      solely to prove the RC isolation yields ROW binlog format as it is
      supposed to per docs.
      3aa04c0d
    • Igor Babaev's avatar
      MDEV-30081 Crash with splitting from constant mergeable derived table · f513d715
      Igor Babaev authored
      This bug manifested itself in very rare situations when splitting
      optimization was applied to a materialized derived table with group clause
      by key over a constant meargeable derived table that was in inner part of
      an outer join. In this case the used tables for the key to access the
      split table incorrectly was evaluated to a not empty table map.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      f513d715
    • Brandon Nesterenko's avatar
      MDEV-29639: Seconds_Behind_Master is incorrect for Delayed, Parallel Replicas · d69e8357
      Brandon Nesterenko authored
      Problem
      ========
      On a parallel, delayed replica, Seconds_Behind_Master will not be
      calculated until after MASTER_DELAY seconds have passed and the
      event has finished executing, resulting in potentially very large
      values of Seconds_Behind_Master (which could be much larger than the
      MASTER_DELAY parameter) for the entire duration the event is
      delayed. This contradicts the documented MASTER_DELAY behavior,
      which specifies how many seconds to withhold replicated events from
      execution.
      
      Solution
      ========
      After a parallel replica idles, the first event after idling should
      immediately update last_master_timestamp with the time that it began
      execution on the primary.
      
      Reviewed By
      ===========
      Andrei Elkin <andrei.elkin@mariadb.com>
      d69e8357
    • Sergei Petrunia's avatar
      2ed598ea