1. 17 Jul, 2005 3 commits
    • unknown's avatar
      Merge pgalbraith@bk-internal.mysql.com:/home/bk/mysql-5.0 · 9b1b56df
      unknown authored
      into  krsna.patg.net:/home/patg/mysql-5.0
      
      9b1b56df
    • unknown's avatar
      Federated Storage Engine, bug 9925 "Federated query processor (step 2 or step 3) not using logic in · 6743f0ee
      unknown authored
      WHERE statement"
      
      
      sql/ha_federated.cc:
        Changes per Jimw's review. 
        
        notes about some suggestions:
        
        1. Tried to replace my_sprintf with strxmov, but had problems. Couldn't 
           get the test suite to run at all, and could not find any particular
           error. Since this is something that is not critical, I'll leave it
           as is for now.
        2. I would like to use my_error to create all of my error messages, but 
           cannot figure out how to get it to take more than one argument to be
           passed to the error message (I tried this once but had errors, and 
           cannot find an example of how to get it to work despite seeing messages
           with obviously more than one arg
        3. Replaced all string building from literals to defined SQL string pieces
           such as "SELECT ", "FROM " ...
        4. Format fixes, spacing fixes completed
        5. Removed records_in_range records calculation functionality
      sql/ha_federated.h:
        Formatting changes, new defines for SQL query string tokens
      sql/share/errmsg.txt:
        changed 'SRC' to 'SOURCE' per Jimw's review
      6743f0ee
    • unknown's avatar
      func_in.result, func_in.test: · 653d467c
      unknown authored
        Fixed bug #11885.
      sql_select.cc:
        Fixed bug #11885.
        Predicates of the forms 'a IN (v)' 'a NOT IN (v)' now
        is replaced by 'a=v' and 'a<>v' at the parsing stage.
      sql_yacc.yy:
        Fixed bug #11885.
        Predicates of the forms 'a IN (v)' 'a NOT IN (v)' now 
        is replaced by 'a=v' and 'a<>v' at the parsing stage.
      
      
      sql/sql_yacc.yy:
        Fixed bug #11885.
        Predicates of the forms 'a IN (v)' 'a NOT IN (v) now 
        is replaced by 'a=v' and 'a<>v' at the parsing stage.
      sql/sql_select.cc:
        Fixed bug #11885.
        Predicates of the forms 'a IN (v)' 'a NOT IN (v) now
        is replaced by 'a=v' and 'a<>v' at the parsing stage.
      mysql-test/t/func_in.test:
        Fixed bug #11885.
      mysql-test/r/func_in.result:
        Fixed bug #11885.
      653d467c
  2. 16 Jul, 2005 10 commits
    • unknown's avatar
      opt_range.cc: · 4c52fb2e
      unknown authored
        Fixed bug #11853.
        Corrected the code of the range optimization for
        NOT IN and NOT BETWEEN.
      range.test, range.result:
        Fixed bug #11853.
      
      
      mysql-test/t/range.test:
        Fixed bug #11853.
      sql/opt_range.cc:
        Fixed bug #11853.
        Corrected the code of the range optimization for
        NOT IN and NOT BETWEEN.
      4c52fb2e
    • unknown's avatar
      After-merge fixes (4.1 -> 5.0). · 64efb147
      unknown authored
      
      mysql-test/r/sp.result:
        Test results fixed: rewritten test for Bug#6129
      mysql-test/r/view.result:
        Push a change to the result file from Sanja's patch.
      mysql-test/t/sp.test:
        Rewrite the test for Bug#6129 (now that stored procedures don't
        evaluate system variables at parse, the test produced different results).
        The old test failed with 1 in the second invocation (the old
        result was wrong).
      sql/item_func.cc:
        After-merge fix.
      sql/item_func.h:
        After-merge fix.
      sql/mysql_priv.h:
        After-merge fix.
      sql/mysqld.cc:
        Rollback the patch for Bug#7403 (it breaks the test suite).
      64efb147
    • unknown's avatar
      Merge mysql.com:/opt/local/work/mysql-4.1-root · f4c249a6
      unknown authored
      into  mysql.com:/media/sda1/mysql/mysql-5.0-merge
      
      
      mysql-test/r/select.result:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/ps.result:
        Manual merge (again).
      mysql-test/t/ps.test:
        Manual merge (again).
      mysql-test/t/select.test:
        Manual merge (again).
      sql/item_func.cc:
        Manual merge (again).
      sql/item_func.h:
        Manual merge (again).
      sql/set_var.h:
        Manual merge (again).
      f4c249a6
    • unknown's avatar
      cs fixes · 3d5ff216
      unknown authored
      3d5ff216
    • unknown's avatar
      Merge grichter@bk-internal.mysql.com:/home/bk/mysql-5.0 · 174a7b90
      unknown authored
      into lmy002.wdf.sap.corp:/home/georg/work/mysql-5.0
      
      
      tests/mysql_client_test.c:
        Auto merged
      174a7b90
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 01a1456f
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug6-5.0
      
      01a1456f
    • unknown's avatar
      Restore previous used client charset in mysql_reconnect · e61a8c99
      unknown authored
      Moved mysql_set_character_set function to client.c
      Changed function prototype for mysql_set_character_set (as suggested
      by Konstantin)
      
      
      include/mysql.h:
        Changed function prototype
      libmysql/libmysql.c:
        moved mysql_set_character_set to client.c
      sql-common/client.c:
        moved mysql_set_character_set to client.c
      e61a8c99
    • unknown's avatar
      Merge baker@bk-internal.mysql.com:/home/bk/mysql-5.0 · 3c773e21
      unknown authored
      into  zim.(none):/home/brian/mysql/foo-5.0
      
      3c773e21
    • unknown's avatar
      Added federated to max base test. · 6d0e645a
      unknown authored
      
      BUILD/SETUP.sh:
        Added federated to base_max tests.
      6d0e645a
    • unknown's avatar
      This is the same patch as 1.1937, with small variable declaration changes, memory · 11536781
      unknown authored
      deallocation cleanup
      
      
      mysql-test/r/federated.result:
        new test results
      mysql-test/t/federated.test:
        New tests, and added explains per Timour's suggestion. This will keep
                track of whether changes have been made to the optimiser that might affect
                Federated.
                Also changed the error codes to federated error codes in the error tests
      sql/ha_federated.cc:
        1. Not using MAX_REMOTE_SIZE, so removed
                 2. Changed all defines that were IO_SIZE to FEDERATED_QUERY_BUFFER_SIZE
                 3. Now using Federated Error Codes
                 4. Implemented ::info (gets valid 'records' number)
                 5. Implemented ::read_range_first - now uses indexes in range operations
                 6. Better allocation in get_share
                 7. Cleaned up memory bug in get_share
                 8. Better initial query "SELECT * FROM t1 WHERE 1=0" for check_foreign_data_src
                 9. emit_key_part_name and emit_key_part_element for read_range_first to not
                    have redundancy
                 10. Made sure all 'append's pass length, and use append("") to ensure proper
                     null termination of strings being built.
                 11. Better message creation. If ER_QUERY_ON_FOREIGN_DATA_SRC, I also pass
                     the actual error code and message from the foreign data src.
                 12. Cleaned up how the result set and share->scheme is freed.
      sql/share/errmsg.txt:
        New Federated error messages that are more tailored to the type of information
        we want to see when federated has an error.
      mysql-test/include/federated.inc:
        New bitkeeper file, include file for separating setup from main test suite
      mysql-test/include/federated_cleanup.inc:
        New BitKeeper file ``mysql-test/include/federated_cleanup.inc''
      sql/ha_federated.h:
        Added comments where needed, one was already commented about
      11536781
  3. 15 Jul, 2005 27 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · dc4e24ad
      unknown authored
      into  mysql.com:/opt/local/work/mysql-4.1-root
      
      dc4e24ad
    • unknown's avatar
      Merge rburnett@bk-internal.mysql.com:/home/bk/mysql-4.1 · 44dd2bca
      unknown authored
      into  linux.site:/home/reggie/bk/bug7403
      
      44dd2bca
    • unknown's avatar
      A fix and a test case for Bug#9359 "Prepared statements take snapshot · 0b9cb876
      unknown authored
       of system vars at PREPARE time": implement a special Item
      to handle system variables. This item substitutes itself with 
      a basic constant containing variable value at fix_fields.
      
      
      mysql-test/r/ps.result:
        - test results fixed (Bug#9359).
      mysql-test/t/ps.test:
        - add a test case for Bug#9359 "Prepared statements take snapshot
         of system vars at PREPARE time"
      sql/item_func.cc:
        - implement Item_func_get_system_var: we should not evaluate system
        variables in the parser, but instead should create an item which 
        is evaluated to a constant at execute.
        - remove an unused function
      sql/item_func.h:
        Add a new item, Item_func_get_system_var
      sql/mysql_priv.h:
        Move necessary declarations to make set_var.h objects visible in 
        item_func.h
      sql/set_var.cc:
        - we should not print to network from get_system_var: if it's called
        from prepared statement prepare, we get packets out of order when using
        the binary protocol. Instead report the error to be sent to the user later.
        This is a backport from 5.0.
      sql/set_var.h:
        - declaration of enum_var_type moved to mysql_priv.h
      0b9cb876
    • unknown's avatar
      Fix bug#11482 4.1.12 produces different resultset for a complex query · 653e2989
      unknown authored
        than in previous 4.1.x
      
      Wrongly applied optimization were adding NOT NULL constraint which results in
      rejecting valid rows and reduced result set.
      
      The problem was that add_notnull_conds() while checking subquery were adding
      NOT NULL constraint to left joined table, to which, normally, optimization 
      don't have to be applied.
      
      
      sql/sql_select.cc:
        Fix bug #11482 Wrongly applied optimization was erroneously rejecting valid rows
        Constraint were added to optimization appliance test.
      mysql-test/t/select.test:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      mysql-test/r/select.result:
        Test case for bug #11482  Wrongly applied optimization was erroneously rejecting valid rows
      653e2989
    • unknown's avatar
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · 026903bf
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-bug6-5.0
      
      
      BitKeeper/etc/config:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/sp-security.result:
        merge
      mysql-test/r/view.result:
        merge
      mysql-test/t/sp-security.test:
        merge
      mysql-test/t/view.test:
        merge
      sql/item_cmpfunc.cc:
        merge
      sql/sql_class.h:
        merge
      026903bf
    • unknown's avatar
      stop evaluation constant functions in WHERE (BUG#4663) · 03f1ae0b
      unknown authored
      correct value of CURRENT_USER() in SP with "security definer" (BUG#7291)
      
      
      BitKeeper/etc/config:
        switch off open logging
      mysql-test/r/sp-security.result:
        correct value from current_user() in function run from "security definer"
      mysql-test/r/view.result:
        evaluation constant functions in WHERE (BUG#4663)
      mysql-test/t/sp-security.test:
        correct value from current_user() in function run from "security definer"
      mysql-test/t/view.test:
        evaluation constant functions in WHERE (BUG#4663)
      sql/item.cc:
        Item_static_string_func creation if it is need
      sql/item.h:
        support of Item_static_string_func creation
      sql/item_cmpfunc.cc:
        do not evaluate items during view creation
      sql/item_create.cc:
        create Item_func_user
      sql/item_strfunc.cc:
        Item_func_sysconst in case of converting value still have to correctly print itself
        => use Item_static_string_func instead of Item_string
            Item_func_user return USER() or CURRENT_USER()
      sql/item_strfunc.h:
        support of correct charset conversion procedure in Item_func_sysconst
      sql/sql_class.h:
        new method
      sql/sql_yacc.yy:
        Item_func_user now support both USER() and CURRENT_USER(), so we have to pass parametr what it is
      03f1ae0b
    • unknown's avatar
      Merge linux.site:/home/reggie/bk/bug7403 · 1feeb0b2
      unknown authored
      into  linux.site:/home/reggie/bk/mysql-5.0
      
      
      sql/mysqld.cc:
        merging in changes from 4.1
      1feeb0b2
    • unknown's avatar
      Removed dead options, fixed pentium script to no longer ask for isam (its not included in 5.0). · d4f6c052
      unknown authored
      
      BUILD/SETUP.sh:
        Removed dead options, added blackhole option
      BUILD/compile-pentium-debug-max-no-embedded:
        Updated option to remove unused option
      d4f6c052
    • unknown's avatar
      Post-review fix: Made test bug9538 test robust. · e588c7e3
      unknown authored
      
      mysql-test/r/sp.result:
        Made test bug9538 test robust.
      mysql-test/t/sp.test:
        Made test bug9538 test robust.
      e588c7e3
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 650f5a36
      unknown authored
      into  mysql.com:/home/pem/work/mysql-5.0
      
      650f5a36
    • unknown's avatar
      9c2b24b6
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 373d471a
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0
      
      
      tests/mysql_client_test.c:
        Auto merged
      373d471a
    • unknown's avatar
      Fixed BUG#9538: SProc: Creation fails if we try to SET system variable · 4c4a78b7
      unknown authored
                        using @@var_name in proc
        Made sure we don't lose the tokenizer state when swapping lex in during SET
        parsing.
      
      
      mysql-test/r/sp.result:
        New test case for BUG#9538.
      mysql-test/t/sp.test:
        New test case for BUG#9538.
      sql/sp_head.cc:
        Keep lex->next_state when swapping lex during SP parsing (for SET mainly),
        otherwise the tokenizer gets confused.
      4c4a78b7
    • unknown's avatar
      Made .c files compile with a C compiler. · c60f877b
      unknown authored
      
      ndb/src/common/portlib/NdbMutex.c:
        Turned into C code.
      ndb/src/common/portlib/NdbThread.c:
        Turned into C code.
      c60f877b
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · cc82195a
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0
      
      
      tests/mysql_client_test.c:
        Auto merged
      cc82195a
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 148de25d
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0
      
      148de25d
    • unknown's avatar
      minor fix for restoring the previous characterset in · 21e8bfc2
      unknown authored
      test_client_character_set
      
      
      tests/mysql_client_test.c:
        minor fix for restoring the previous characterset.
      21e8bfc2
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 5536725d
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-5.0
      
      5536725d
    • unknown's avatar
      Merge grichter@bk-internal.mysql.com:/home/bk/mysql-5.0 · af80b7a2
      unknown authored
      into lmy002.wdf.sap.corp:/home/georg/work/mysql-5.0
      
      af80b7a2
    • unknown's avatar
      Fix for bug #11037. · 58f2023c
      unknown authored
      When all rows are fetched subsequent calls to mysql_stmt_fetch return
      now MYSQL_NO_DATA instead of errorcode 1.
      
      
      libmysql/libmysql.c:
        fix for bug#11037
      tests/mysql_client_test.c:
        added new testcase for bug #11037
      58f2023c
    • unknown's avatar
      Merge rburnett@bk-internal.mysql.com:/home/bk/mysql-4.1 · fca5a3ca
      unknown authored
      into  linux.site:/home/reggie/bk/bug7403
      
      fca5a3ca
    • unknown's avatar
      Merge tulin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 6f3929e3
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-new
      
      
      tests/mysql_client_test.c:
        Auto merged
      6f3929e3
    • unknown's avatar
      Merge · 58cf4607
      unknown authored
      
      mysql-test/t/ctype_utf8.test:
        Auto merged
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        Auto merged
      ndb/src/common/transporter/Transporter.hpp:
        Auto merged
      ndb/src/common/transporter/TransporterRegistry.cpp:
        Auto merged
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      support-files/mysql.spec.sh:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      ndb/include/transporter/TransporterRegistry.hpp:
        SCCS merged
      ndb/src/common/transporter/Transporter.cpp:
        SCCS merged
      58cf4607
    • unknown's avatar
      minor type fixes to prev patch · 2360600e
      unknown authored
      2360600e
    • unknown's avatar
      Merge poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-release · e7c4937e
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-new
      
      
      mysql-test/t/ctype_utf8.test:
        Auto merged
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        Auto merged
      ndb/src/common/transporter/TransporterRegistry.cpp:
        Auto merged
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Auto merged
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        Auto merged
      ndb/src/mgmsrv/Services.cpp:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      e7c4937e
    • unknown's avatar
      Merge mysqldev@production.mysql.com:my/mysql-4.1-release · 701d93a4
      unknown authored
      into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1-release
      
      701d93a4