1. 26 Mar, 2008 12 commits
    • unknown's avatar
      Post-merge fix. · 9bd13302
      unknown authored
      Query cache does now work with concurrent_insert=0. See
      Bug 33756 - query cache with concurrent_insert=0 appears broken
      
      9bd13302
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 192fe25b
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      192fe25b
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · 8b8c0762
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/t/query_cache.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      mysql-test/r/query_cache.result:
        SCCS merged
      8b8c0762
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · 20cf640c
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      20cf640c
    • unknown's avatar
      Post-merge fix · 285de696
      unknown authored
      285de696
    • unknown's avatar
      Dummy change to force PushBuild. · 3cf73f27
      unknown authored
      3cf73f27
    • unknown's avatar
      Dummy change to force PushBuild. · 0b86a282
      unknown authored
      0b86a282
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-ateam · 98daf3fe
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/federated.result:
        Auto merged
      mysql-test/t/federated.test:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      storage/federated/ha_federated.cc:
        Auto merged
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        Manual merge
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        Manual merge
      98daf3fe
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · a68cb126
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/ctype_big5.result:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_gb2312.result:
        Auto merged
      mysql-test/r/ctype_gbk.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_ctype_cp932.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/slave.cc:
        Auto merged
      mysql-test/r/federated.result:
        Manual merge from 5.0
      mysql-test/t/federated.test:
        Manual merge from 5.0
      storage/federated/ha_federated.cc:
        Manual merge from 5.0
      a68cb126
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-amain · 375fae43
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/ctype_big5.result:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_gb2312.result:
        Auto merged
      mysql-test/r/ctype_gbk.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_row_ctype_cp932.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_stm_ctype_cp932.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/rpl_rli.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        SCCS merged
      375fae43
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · 768d675a
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      768d675a
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-amain · 8f24dc76
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      mysql-test/r/ctype_big5.result:
        Auto merged
      mysql-test/r/ctype_cp932.result:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_gb2312.result:
        Auto merged
      mysql-test/r/ctype_gbk.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      sql/slave.cc:
        Auto merged
      8f24dc76
  2. 25 Mar, 2008 11 commits
    • unknown's avatar
      Bug#35559 - plugin_load.test creates warnings · df6c8c43
      unknown authored
      plugin_load.test created lines in the warnings files and made
      pushbuild cells yellow. Some pushbuild systems are configured
      so that they don't build the ha_example plugin. Trying to load
      them creates error messages in the error log. These were copied
      to the warnings file.
      
      Fixed by ignoring expected error messages for non-existent
      ha_example.
      
      
      mysql-test/lib/mtr_report.pl:
        Bug#35559 - plugin_load.test creates warnings
        Ignore expected error messages for non-existent ha_example.
      df6c8c43
    • unknown's avatar
      Merge quad.opbmk:/mnt/raid/alik/MySQL/devel/5.1 · d17a0dec
      unknown authored
      into  quad.opbmk:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
      
      d17a0dec
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG35509/mysql-5.0-engines · cbdd79b0
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG34768/mysql-5.1-engines
      
      
      mysql-test/t/federated.test:
        Auto merged
      storage/federated/ha_federated.cc:
        Use local.
      cbdd79b0
    • unknown's avatar
      Eliminating compiler warnings. · 0f075800
      unknown authored
      
      sql/set_var.h:
        Changing order of initializer list for sys_var class constructor to
        eliminate compiler warning.
      mysql-test/suite/binlog/combinations:
        New BitKeeper file ``mysql-test/suite/binlog/combinations''
      0f075800
    • unknown's avatar
      BUG#34789 - drop server/create server leaks memory ! · 417e051b
      unknown authored
      BUG#34790 - 'create server' doesn't handle out of memory scenario
                  well enough
      
      This is an addition to fixes for these bugs, which makes gcov
      happy.
      
      
      mysql-test/r/federated.result:
        CREATE SERVER is only tested by federated_server.test, which requires
        big-test option. Added dummy test case to make gcov happy.
      mysql-test/t/federated.test:
        CREATE SERVER is only tested by federated_server.test, which requires
        big-test option. Added dummy test case to make gcov happy.
      sql/sql_parse.cc:
        Make gcov happy.
      417e051b
    • unknown's avatar
      BUG#34768 - nondeterministic INSERT using LIMIT logged in stmt mode · e616870a
      unknown authored
                  if binlog_format=mixed
      
      Addition to fix for BUG#34768: fixed test case failures discovered
      by pushbuild.
      
      
      mysql-test/suite/binlog/r/binlog_stm_ps.result:
        Fixed binlog_stm_ps failure when binlog format is statement:
        - this test case makes sence only if binlog format is statement,
          thus execute it only in this mode;
        - added a warning that insert ... select ... limit is not safe
          to execute in statement mode.
      mysql-test/suite/binlog/t/binlog_stm_ps.test:
        Fixed binlog_stm_ps failure when binlog format is statement:
        - this test case makes sence only if binlog format is statement,
          thus execute it only in this mode;
        - added a warning that insert ... select ... limit is not safe
          to execute in statement mode.
      mysql-test/suite/rpl/t/rpl_optimize.test:
        rpl_optimize test may be executed in various binlog format modes.
        In statement mode delete ... limit issues a warning, in mixed and
        row modes it does not.
        
        Fixed a test case so it is still possible to execute it in all binlog
        format modes by ignoring delete ... limit warnings.
      mysql-test/suite/rpl/t/rpl_user_variables.test:
        rpl_user_variables test may be executed in various binlog format modes.
        In statement mode insert ... select ... limit issues a warning,
        in mixed and row modes it does not.
        
        Fixed a test case so it is still possible to execute it in all binlog
        format modes by ignoring insert ... select ... limit warnings.
      e616870a
    • unknown's avatar
      Merge quad.opbmk:/mnt/raid/alik/MySQL/devel/5.0-rt · 5aa0c70e
      unknown authored
      into  quad.opbmk:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
      
      
      sql/sql_delete.cc:
        Auto merged
      5aa0c70e
    • unknown's avatar
      Merge quad.opbmk:/mnt/raid/alik/MySQL/devel/5.1 · 45256456
      unknown authored
      into  quad.opbmk:/mnt/raid/alik/MySQL/devel/5.1-rt-merged
      
      
      sql/sql_delete.cc:
        Auto merged
      45256456
    • unknown's avatar
      Merge quad.opbmk:/mnt/raid/alik/MySQL/devel/5.0 · 04cf5127
      unknown authored
      into  quad.opbmk:/mnt/raid/alik/MySQL/devel/5.0-rt-merged
      
      
      sql/sql_delete.cc:
        Auto merged
      04cf5127
    • unknown's avatar
      BUG#35509 - Federated leaks memory when connecting to · 62c8302b
      unknown authored
                  localhost/default port
      
      When creating federated table that points to unspecified host or
      localhost on unspecified port or port is 0, small memory leak occurs.
      
      This happens because we make a copy of unix socket path, which is
      never freed.
      
      With this fix we do not make a copy of unix socket path, instead
      share->socket points to MYSQL_UNIX_ADDR constant directly.
      
      This fix is covered by a test case for BUG34788.
      
      Affects 5.0 only.
      
      
      mysql-test/t/federated.test:
        A test case for BUG#35509.
      sql/ha_federated.cc:
        When creating federated table we call parse_url() to check if connect
        string is correct. parse_url() may make a copy of unix socket path if
        port is not specified or 0 and host is not specified or 'localhost'.
        This copy is never freed.
        
        As there is no need to make a copy of unix socket path, let
        share->socket point to MYSQL_UNIX_ADDR directly.
      62c8302b
    • unknown's avatar
      Patch for bug 28386 enabled table logging for all tests in · f7337580
      unknown authored
      mysql_client_test causing a severe slowdown and increase
      in memory usage, especially for test cases with long queries.
      
      The solution is to enable the general log only in tests that
      actually need the general log and disable it during the
      execution of all other tests.
      
      
      tests/mysql_client_test.c:
        Selectively enable and disable the general log.
      f7337580
  3. 22 Mar, 2008 2 commits
    • unknown's avatar
      Fix for Bug#34274: Invalid handling of 'DEFAULT 0' · ff79c7ac
      unknown authored
      for YEAR data type.
      
      The problem was that for some unknown reason 0 was not allowed
      as a default value for YEAR data type. That was coded before BK.
      However the Manual does not say a word about such a limitation.
      Also, it looks inconsistent with other data types.
      
      The fix is to allow 0 as a default value.
      
      
      mysql-test/r/create.result:
        Update result file.
      mysql-test/t/create.test:
        Add a test case for Bug#34274: Invalid handling of 'DEFAULT 0'
        for YEAR data type.
      sql/unireg.cc:
        Allow 0 as a default value for YEAR data type.
      ff79c7ac
    • unknown's avatar
      Fix result files (Bug#21854). · 4e728320
      unknown authored
      
      mysql-test/r/information_schema_db.result:
        Update result file.
      mysql-test/r/sp-security.result:
        Update result file.
      mysql-test/r/trigger_notembedded.result:
        Update result file.
      mysql-test/r/view_grant.result:
        Update result file.
      4e728320
  4. 21 Mar, 2008 6 commits
  5. 20 Mar, 2008 9 commits
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.1-engines · b04607d3
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG34768/mysql-5.1-engines
      
      
      sql/sql_insert.cc:
        Auto merged
      b04607d3
    • unknown's avatar
      BUG#34788 - malformed federated connection url is not handled · 6c599276
      unknown authored
                  correctly - crashes server !
      
      Creating federated table with connect string containing empty
      (zero-length) host name and port is evaluated as 0 (port is
      incorrect, omitted or 0) crashes server.
      
      This happens because federated calls strcmp() with NULL pointer.
      
      Fixed by avoiding strcmp() call if hostname is set to NULL.
      
      
      mysql-test/r/federated.result:
        A test case for BUG#34788.
      mysql-test/t/federated.test:
        A test case for BUG#34788.
      sql/ha_federated.cc:
        Fixed that parse_url() may call strcmp() with NULL pointer.
      6c599276
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.1-ateam · ec8e154e
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      mysql-test/r/partition_not_windows.result:
        Auto merged
      mysql-test/r/partition_symlink.result:
        Auto merged
      mysql-test/r/symlink.result:
        Auto merged
      mysql-test/suite/parts/r/partition_basic_innodb.result:
        Auto merged
      mysql-test/suite/parts/r/partition_basic_myisam.result:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/partition_info.cc:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/t/partition_symlink.test:
        Manual merge
      mysql-test/t/symlink.test:
        Manual merge
      sql/sql_parse.cc:
        Manual merge
      ec8e154e
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-axmrg · 56419e3a
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.1-axmrg
      
      
      configure.in:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      56419e3a
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-5.0-ateam · acb93f9d
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      acb93f9d
    • unknown's avatar
      Merge stella.local:/home2/mydev/mysql-4.1-axmrg · f2715573
      unknown authored
      into  stella.local:/home2/mydev/mysql-5.0-axmrg
      
      
      configure.in:
        Manual merge
      f2715573
    • unknown's avatar
      A test case for Bug#29958: Weird message on DROP DATABASE · 762cbd16
      unknown authored
      if mysql.proc does not exist.
      
      
      mysql-test/r/drop.result:
        Update result file.
      mysql-test/t/drop.test:
        Add a test case for Bug#29958: Weird message on DROP DATABASE
        if mysql.proc does not exist.
      762cbd16
    • unknown's avatar
      BUG#34789 - drop server/create server leaks memory ! · 9de6bbe9
      unknown authored
      When CREATE SERVER is issued, it allocates memory on memory root
      to store cached server structure. When DROP SERVER is issued,
      it doesn't release this memory, as it is impossible with the
      memory root.
      
      We use the same allocation strategy for plugins and acl. The problem
      here that there was no way (except for the server restart) to force
      'servers' code to release this memory.
      
      With this fix it is possible to release unused server cache memory
      by FLUSH PRIVILEGES.
      
      No test case for this fix.
      
      
      sql/sql_parse.cc:
        Reload servers table on FLUSH PRIVILEGES.
      sql/sql_servers.cc:
        Instead of just marking memory blocks as unused, release memory
        used by servers cache and initialize new memory root.
        
        This is needed for FLUSH PRIVILEGES to release unused memory
        blocks.
      9de6bbe9
    • unknown's avatar
      BUG#34790 - 'create server' doesn't handle out of memory scenario · e023ad1a
      unknown authored
                  well enough
      
      CREATE SERVER may cause server crash if there is not enough memory
      to execute this operation.
      
      Fixed that create_server() and prepare_server_struct_for_insert()
      didn't check return value of functions that allocate memory.
      
      As this is out of memory issue fix, not test case available.
      
      
      sql/sql_servers.cc:
        Fixed that create_server() and prepare_server_struct_for_insert()
        didn't check return value of functions that allocate memory.
      e023ad1a